Passed
Push — master ( 936202...c84ff9 )
by Andreas
09:27
created
lib/org/openpsa/projects/style/show-frontpage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('ongoing') . "\">{$task_count['ongoing']}</span></td>\n";
69 69
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('on_hold') . "\">{$task_count['on_hold']}</span></td>\n";
70 70
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('closed') . "\">{$task_count['closed']}</span></td>\n";
71
-            echo "        <td class=\"numeric\"> " ;
71
+            echo "        <td class=\"numeric\"> ";
72 72
             echo "            <span title=\"" . $data['l10n']->get('reported') . "\">" . round($hours['reportedHours'], 2) . "</span>";
73 73
             if ($hours['plannedHours'] > 0) {
74 74
                 echo          " / <span title=\"" . $data['l10n']->get('planned hours') . "\">" . round($hours['plannedHours'], 2) . "</span>";
Please login to merge, or discard this patch.
lib/midcom/admin/folder/management.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
             }
51 51
 
52 52
             // Skip components beginning with midcom or midgard
53
-            if (   preg_match('/^(midcom|midgard)\./', $manifest->name)
53
+            if (preg_match('/^(midcom|midgard)\./', $manifest->name)
54 54
                 && $manifest->name != 'midcom.helper.search') {
55 55
                 continue;
56 56
             }
Please login to merge, or discard this patch.
lib/org/openpsa/sales/style/show-deliverable.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 $state = $data['deliverable']->get_state();
4 4
 $formatter = $data['l10n']->get_formatter();
5 5
 $per_unit = $data['l10n']->get('per unit');
6
-if (   $data['product']
6
+if ($data['product']
7 7
     && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) {
8 8
     $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option);
9 9
 }
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 	    </div>
116 116
      <?php
117 117
     $tabs = [];
118
-    if (   $data['invoices_url']
118
+    if ($data['invoices_url']
119 119
         && $data['deliverable']->invoiced > 0) {
120 120
         $tabs[] = [
121 121
             'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/",
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
         ];
124 124
     }
125 125
 
126
-    if (   $data['projects_url']
126
+    if ($data['projects_url']
127 127
         && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED
128 128
         && $data['product']
129 129
         && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) {
Please login to merge, or discard this patch.
lib/net/nemein/redirector/viewer.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@
 block discarded – undo
19 19
     public function _on_initialize()
20 20
     {
21 21
         // Match /
22
-        if (   $this->_config->get('redirection_type') === null
23
-            || (   $this->_topic->can_do('net.nemein.redirector:noredirect')
22
+        if ($this->_config->get('redirection_type') === null
23
+            || ($this->_topic->can_do('net.nemein.redirector:noredirect')
24 24
                 && !$this->_config->get('admin_redirection'))) {
25 25
             $this->_request_switch['redirect'] = [
26 26
                 'handler' => [net_nemein_redirector_handler_tinyurl::class, 'list'],
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/conflictmanager.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
         }
126 126
         // TODO: Shared tasks need a separate check (different member object)
127 127
 
128
-        if (   !empty($this->busy_members)
128
+        if (!empty($this->busy_members)
129 129
             || !empty($this->busy_resources)) {
130 130
             //Unresolved conflicts (note return value is for conflicts not lack of them)
131 131
             midcom::get()->auth->drop_sudo();
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
         }
189 189
 
190 190
         if (array_key_exists($member->event, $modified_events)) {
191
-            $event =& $modified_events[$member->event];
191
+            $event = & $modified_events[$member->event];
192 192
             $set_as_modified = false;
193 193
         } else {
194 194
             try {
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
         }
203 203
         debug_add("overlap found in event {$event->title} (#{$event->id})");
204 204
 
205
-        if (   $event->tentative
205
+        if ($event->tentative
206 206
             && $rob_tentative) {
207 207
             debug_add('event is tentative, robbing resources');
208 208
             $event->resources = array_diff_key($event->resources, $this->_event->resources);
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
         }
230 230
         debug_add("overlap found in event {$event->title} (#{$event->id})");
231 231
 
232
-        if (   $event->tentative
232
+        if ($event->tentative
233 233
             && $rob_tentative) {
234 234
             debug_add('event is tentative, robbing participants');
235 235
             $event->participants = array_diff_key($event->participants, $this->_event->participants);
Please login to merge, or discard this patch.
lib/org/openpsa/notifications/main.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
 
103 103
         // If user has preference for this message, we use that
104 104
         $personal_preferences = $recipient->list_parameters('org.openpsa.notifications');
105
-        if (   !empty($personal_preferences)
105
+        if (!empty($personal_preferences)
106 106
             && array_key_exists("{$component}:{$action}", $personal_preferences)) {
107 107
             return $personal_preferences[$action];
108 108
         }
Please login to merge, or discard this patch.
lib/org/openpsa/projects/project.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -249,7 +249,7 @@
 block discarded – undo
249 249
             $new_status = $this->_find_status($this->_status_map[$this->status_type], $status_types);
250 250
         }
251 251
 
252
-        if (   $new_status !== null
252
+        if ($new_status !== null
253 253
             && $this->status != $new_status) {
254 254
             $this->status = $new_status;
255 255
             $update_required = true;
Please login to merge, or discard this patch.
lib/midcom/connection.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -261,7 +261,7 @@
 block discarded – undo
261 261
             if ($part === '') {
262 262
                 continue;
263 263
             }
264
-            if (    midcom::get()->config->get('theme')
264
+            if (midcom::get()->config->get('theme')
265 265
                  && !$args_started
266 266
                  && self::check_page_exists($part)) {
267 267
                 $page_style .= '/' . $part;
Please login to merge, or discard this patch.
lib/midcom/admin/help/style/midcom_admin_help_mgdschemas.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
 
16 16
         foreach ($properties as $propname => $val) {
17 17
             $description = preg_replace('/ *\n */', "\n", $val['value']);
18
-            if (   $val['link']
18
+            if ($val['link']
19 19
                 && $linked_component = midcom::get()->dbclassloader->get_component_for_class($val['link_name'])) {
20 20
                 $proplink = $data['router']->generate('help', ['component' => $linked_component, 'help_id' => 'mgdschemas']);
21 21
                 $proplink = "<a href='{$proplink}#{$val['link_name']}' title='{$linked_component}/{$val['link_name']}::{$val['link_target']}'>{$val['link_name']}:{$val['link_target']}</a>";
Please login to merge, or discard this patch.