flack / openpsa

lib/midgard/admin/asgard/handler/object/manage.php

Braces +2 added lines, -1 removed lines

@@ -61,7 +61,8 @@
     {
         try {
             $this->_object = midcom::get()->dbfactory->get_object_by_guid($guid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             if (midcom_connection::get_error() == MGD_ERR_OBJECT_DELETED) {
                 $relocate = $this->router->generate('object_deleted', ['guid' => $guid]);
                 midcom::get()->relocate($relocate);

Spacing +2 added lines, -2 removed lines

@@ -223,10 +223,10 @@
             $new_type_reflector = midcom_helper_reflector::get($new_type);
             $link_properties = $new_type_reflector->get_link_properties();
             foreach ($link_properties as $property => $link) {
-                if (   ($link['class'] && midcom_helper_reflector::is_same_class($link['class'], $this->_object->__mgdschema_class_name__))
+                if (($link['class'] && midcom_helper_reflector::is_same_class($link['class'], $this->_object->__mgdschema_class_name__))
                     || $link['type'] == MGD_TYPE_GUID) {
                     $defaults[$property] = $this->_object->{$link['target']};
-                } elseif (   $property == $parent_property
+                } elseif ($property == $parent_property
                           && midcom_helper_reflector::is_same_class($new_type, $this->_object->__mgdschema_class_name__)) {
                     $defaults[$property] = $this->_object->$parent_property;
                 }

lib/org/openpsa/directmarketing/viewer.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
      */
     private function _populate_node_toolbar()
     {
-        if (   $this->_topic->can_do('midgard:update')
+        if ($this->_topic->can_do('midgard:update')
             && $this->_topic->can_do('midcom:component_config')) {
             $workflow = $this->get_workflow('datamanager');
             $this->_node_toolbar->add_item($workflow->get_button($this->router->generate('config'), [

lib/org/openpsa/contacts/handler/frontpage.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
         }
         $this->_view_toolbar->add_items($buttons);
 
-        if (   $this->_topic->can_do('midgard:update')
+        if ($this->_topic->can_do('midgard:update')
             && $this->_topic->can_do('midcom:component_config')) {
             $this->_node_toolbar->add_item($workflow->get_button($this->router->generate('config'), [
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),

lib/org/openpsa/invoices/handler/list.php

Spacing +1 added lines, -1 removed lines

@@ -171,7 +171,7 @@
     {
         $this->prepare_toolbar(false);
 
-        if (   $this->_topic->can_do('midgard:update')
+        if ($this->_topic->can_do('midgard:update')
             && $this->_topic->can_do('midcom:component_config')) {
             $workflow = $this->get_workflow('datamanager');
             $this->_node_toolbar->add_item($workflow->get_button($this->router->generate('config'), [

Braces +6 added lines, -3 removed lines

@@ -87,7 +87,8 @@ 
                 $customer = org_openpsa_contacts_group_dba::get_cached($invoice->customer);
                 $entry['customer'] = "<a href=\"{$this->router->generate('list_customer_all', ['guid' => $customer->guid])}\">" . $customer->get_label() . "</a>";
                 $entry['index_customer'] = $customer->get_label();
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 $entry['customer'] = '';
                 $entry['index_customer'] = '';
             }
@@ -101,7 +102,8 @@ 
                 $entry['contact'] = "<a href=\"{$this->router->generate('list_customer_all', ['guid' => $contact->guid])}\">" . $contact->get_label() . "</a>";
                 $entry['contact'] = $contact_widget->show_inline();
                 $entry['index_contact'] = $contact->get_label();
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 $entry['contact'] = '';
                 $entry['index_contact'] = '';
             }
@@ -248,7 +250,8 @@ 
     {
         try {
             $this->_customer = new org_openpsa_contacts_group_dba($guid);
-        } catch (midcom_error) {
+        }
+        catch (midcom_error) {
             $this->_customer = new org_openpsa_contacts_person_dba($guid);
         }
         $data['customer'] = $this->_customer;

lib/org/openpsa/projects/handler/task/view.php

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
             MIDCOM_TOOLBAR_ACCESSKEY => 'e',
         ]);
 
-        if (   $this->task->reportedHours == 0
+        if ($this->task->reportedHours == 0
             && $this->task->can_do('midgard:delete')) {
             $delete_workflow = $this->get_workflow('delete', ['object' => $this->task]);
             $buttons[] = $delete_workflow->get_button($this->router->generate('task_delete', ['guid' => $this->task->guid]));

Braces +2 added lines, -1 removed lines

@@ -109,7 +109,8 @@
                         MIDCOM_TOOLBAR_GLYPHICON => 'money',
                     ];
                 }
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
             }
         }
 

lib/org/openpsa/projects/handler/task/list.php

Spacing +1 added lines, -1 removed lines

@@ -169,7 +169,7 @@
             case 'proposed':
                 $html = $this->render_status($task->manager, "from %s");
                 $task->get_members();
-                if (   $task->can_do('midgard:update')
+                if ($task->can_do('midgard:update')
                     && isset($task->resources[midcom_connection::get_user()])) {
                     $html .= '<form method="post" action="' . $this->router->generate('workflow', ['guid' => $task->guid]) . '">';
                     //TODO: If we need all resources to accept task hide tools when we have accepted and replace with "pending acceptance from..."

Braces +4 added lines, -2 removed lines

@@ -255,7 +255,8 @@ 
             $url = $this->router->generate('project', ['guid' => $project->guid]);
             $ret['project'] = '<a href="' . $url . '">' . $project->title . '</a>';
             $ret['index_project'] = $project->title;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
 
@@ -267,7 +268,8 @@ 
                 $customer_url = "{$contacts_url}group/{$customer->guid}/";
                 $ret['customer'] = "<a href='{$customer_url}' title='{$customer->official}'>{$customer->get_label()}</a>";
                 $ret['index_customer'] = $customer->name;
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 $ret['customer'] = '';
                 $ret['index_customer'] = '';
             }

lib/org/openpsa/invoices/handler/scheduled.php

Braces +4 added lines, -2 removed lines

@@ -61,7 +61,8 @@ 
         try {
             $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($at_entry->arguments['deliverable']);
             $salesproject = org_openpsa_sales_salesproject_dba::get_cached($deliverable->salesproject);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return $invoice;
         }
@@ -103,7 +104,8 @@ 
                     $invoice[$fieldname] = '<a href="' . $sales_url . 'list/customer/' . $object->guid . '/">' . $invoice[$fieldname] . '</a>';
                 }
                 $invoice['index_' . $fieldname] = $object->get_label();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/midcom/core/privilege.php

Indentation -1 removed lines

@@ -37,7 +37,6 @@
                 - 1: MIDCOM_PRIVILEGE_ALLOW
                 - 2: MIDCOM_PRIVILEGE_DENY
                 - 3: MIDCOM_PRIVILEGE_INHERIT
-
  * @property string $guid
  * @package midcom
  */

Spacing +5 added lines, -5 removed lines

@@ -75,7 +75,7 @@ 
      * The Default constructor creates an empty privilege, if you specify
      * another privilege object in the constructor, a copy is constructed.
      */
-    public function __construct(midcom_core_privilege_db|array|string $src = null)
+    public function __construct(midcom_core_privilege_db | array | string $src = null)
     {
         if (is_array($src)) {
             // Store given values to our privilege array
@@ -210,7 +210,7 @@ 
      * - Any midcom_core_user or midcom_core_group object or subtype thereof.
      * - Any string identifier which can be resolved using midcom_services_auth::get_assignee().
      */
-    public function set_assignee(midcom_core_group|midcom_core_user|string $assignee) : bool
+    public function set_assignee(midcom_core_group | midcom_core_user | string $assignee) : bool
     {
         if (is_string($assignee)) {
             if ($this->is_magic_assignee($assignee)) {
@@ -266,12 +266,12 @@ 
             }
         }
 
-        if (   !$this->is_magic_assignee()
+        if (!$this->is_magic_assignee()
             && !$this->get_assignee()) {
             debug_add("The assignee identifier '{$this->assignee}' is invalid.", MIDCOM_LOG_INFO);
             return false;
         }
-        if (   $this->assignee == 'OWNER'
+        if ($this->assignee == 'OWNER'
             && $this->privilegename == 'midgard:owner') {
             debug_add("Tried to assign midgard:owner to the OWNER magic assignee, this is invalid.", MIDCOM_LOG_INFO);
             return false;
@@ -283,7 +283,7 @@ 
                 MIDCOM_LOG_INFO);
             return false;
         }
-        if (   !$object->can_do('midgard:update')
+        if (!$object->can_do('midgard:update')
             || !$object->can_do('midgard:privileges')) {
             debug_add("Insufficient privileges on the content object with the GUID '{$this->__guid}', midgard:update and midgard:privileges required.",
                 MIDCOM_LOG_INFO);

Braces +2 added lines, -1 removed lines

@@ -112,7 +112,8 @@
         if ($this->__cached_object === null) {
             try {
                 $this->__cached_object = midcom::get()->dbfactory->get_object_by_guid($this->objectguid);
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 return null;
             }
         }

src/midcom/datamanager/extension/subscriber/purifySubscriber.php

Spacing +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
 
     public function purify_content(FormEvent $event)
     {
-        if (   isset($this->config['Cache']['SerializerPath'])
+        if (isset($this->config['Cache']['SerializerPath'])
             && !file_exists($this->config['Cache']['SerializerPath'])) {
             mkdir($this->config['Cache']['SerializerPath']);
         }
@@ -54,7 +54,7 @@ 
 
         // Load custom element/attribute definitions
         $definitions = $this->get_from_global_config('html_purify_HTMLDefinition');
-        if (   !empty($definitions)
+        if (!empty($definitions)
             && $def = $purifier_config->maybeGetRawHTMLDefinition()) {
             if (!empty($definitions['addAttribute'])) {
                 foreach (array_filter((array) $definitions['addAttribute'], 'is_array') as $attrdef) {

Braces +2 added lines, -1 removed lines

@@ -72,7 +72,8 @@
         $data = $event->getData();
         try {
             $data = $purifier->purify($data);
-        } catch (\Exception $e) {
+        }
+        catch (\Exception $e) {
             debug_add("HTML Purifier failed: " . $e->getMessage(), MIDCOM_LOG_WARN);
         }
         $event->setData($data);