Passed
Push — master ( 936202...c84ff9 )
by Andreas
09:27
created
lib/org/openpsa/sales/style/show-salesproject-grid.php 1 patch
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -31,7 +31,8 @@  discard block
 block discarded – undo
31 31
                 if ($data['contacts_url']) {
32 32
                     $row['customer'] = "<a href=\"{$data['contacts_url']}group/{$customer->guid}/\">{$label}</a>";
33 33
                 }
34
-            } catch (midcom_error $e) {
34
+            }
35
+            catch (midcom_error $e) {
35 36
                 $e->log();
36 37
             }
37 38
         }
@@ -44,7 +45,8 @@  discard block
 block discarded – undo
44 45
             $contact_widget = org_openpsa_widgets_contact::get($salesproject->customerContact);
45 46
             $row['index_customerContact'] = $customer->get_label();
46 47
             $row['customerContact'] = $contact_widget->show_inline();
47
-        } catch (midcom_error $e) {
48
+        }
49
+        catch (midcom_error $e) {
48 50
             $e->log();
49 51
         }
50 52
     }
@@ -56,7 +58,8 @@  discard block
 block discarded – undo
56 58
         $owner_widget = org_openpsa_widgets_contact::get($salesproject->owner);
57 59
         $row['index_owner'] = $owner->rname;
58 60
         $row['owner'] = $owner_widget->show_inline();
59
-    } catch (midcom_error) {
61
+    }
62
+    catch (midcom_error) {
60 63
         $row['index_owner'] = '';
61 64
         $row['owner'] = '';
62 65
     }
Please login to merge, or discard this patch.
lib/org/openpsa/sales/midcom/interfaces.php 1 patch
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -31,7 +31,8 @@  discard block
 block discarded – undo
31 31
             try {
32 32
                 $agreement = new org_openpsa_sales_salesproject_deliverable_dba($agreement);
33 33
                 $agreement->update_units();
34
-            } catch (midcom_error $e) {
34
+            }
35
+            catch (midcom_error $e) {
35 36
                 $e->log();
36 37
             }
37 38
         }
@@ -49,7 +50,8 @@  discard block
 block discarded – undo
49 50
 
50 51
         try {
51 52
             $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($args['deliverable']);
52
-        } catch (midcom_error $e) {
53
+        }
54
+        catch (midcom_error $e) {
53 55
             $handler->print_error("Deliverable {$args['deliverable']} not found: " . $e->getMessage());
54 56
             return false;
55 57
         }
@@ -69,7 +71,8 @@  discard block
 block discarded – undo
69 71
         }
70 72
         try {
71 73
             $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($args['deliverable']);
72
-        } catch (midcom_error) {
74
+        }
75
+        catch (midcom_error) {
73 76
             $handler->print_error('no deliverable with passed GUID: ' . $args['deliverable'] . ', aborting');
74 77
             return false;
75 78
         }
@@ -77,7 +80,8 @@  discard block
 block discarded – undo
77 80
         //get the owner of the salesproject the deliverable belongs to
78 81
         try {
79 82
             $project = new org_openpsa_sales_salesproject_dba($deliverable->salesproject);
80
-        } catch (midcom_error $e) {
83
+        }
84
+        catch (midcom_error $e) {
81 85
             $handler->print_error('Failed to load salesproject: ' . $e->getMessage());
82 86
             return false;
83 87
         }
Please login to merge, or discard this patch.
lib/org/openpsa/sales/handler/edit.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -54,7 +54,8 @@  discard block
 block discarded – undo
54 54
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];
55 55
 
56 56
                 $defaults['customer'] = $customer->id;
57
-            } catch (midcom_error) {
57
+            }
58
+            catch (midcom_error) {
58 59
                 $customer = new org_openpsa_contacts_person_dba($guid);
59 60
                 $defaults['customerContact'] = $customer->id;
60 61
                 $field['type_config']['options'] = $this->list_groups([$customer->id => true]);
@@ -126,7 +127,8 @@  discard block
 block discarded – undo
126 127
             try {
127 128
                 $company = new org_openpsa_contacts_group_dba($company_id);
128 129
                 $ret[$company->id] = $company->get_label();
129
-            } catch (midcom_error $e) {
130
+            }
131
+            catch (midcom_error $e) {
130 132
                 $e->log();
131 133
             }
132 134
         }
Please login to merge, or discard this patch.
lib/org/openpsa/sales/handler/list.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,8 @@
 block discarded – undo
95 95
         try {
96 96
             $this->_request_data['customer'] = new org_openpsa_contacts_group_dba($guid);
97 97
             $qb->add_constraint('customer', '=', $this->_request_data['customer']->id);
98
-        } catch (midcom_error) {
98
+        }
99
+        catch (midcom_error) {
99 100
             $this->_request_data['customer'] = new org_openpsa_contacts_person_dba($guid);
100 101
             $qb->add_constraint('customerContact', '=', $this->_request_data['customer']->id);
101 102
         }
Please login to merge, or discard this patch.
lib/org/openpsa/sales/handler/deliverable/view.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,8 @@
 block discarded – undo
45 45
         }
46 46
         try {
47 47
             $this->_request_data['product'] = org_openpsa_products_product_dba::get_cached($this->_deliverable->product);
48
-        } catch (midcom_error) {
48
+        }
49
+        catch (midcom_error) {
49 50
             $this->_request_data['product'] = false;
50 51
         }
51 52
     }
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/event/member.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -141,7 +141,8 @@
 block discarded – undo
141 141
                 debug_add('person #' . $person->id . 'has no email address, aborting');
142 142
                 return null;
143 143
             }
144
-        } catch (midcom_error) {
144
+        }
145
+        catch (midcom_error) {
145 146
             return null;
146 147
         }
147 148
 
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/event/resource.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,8 @@
 block discarded – undo
43 43
         }
44 44
         try {
45 45
             $resource = org_openpsa_calendar_resource_dba::get_cached($this->resource);
46
-        } catch (midcom_error) {
46
+        }
47
+        catch (midcom_error) {
47 48
             debug_add("Cannot fetch resource #{$this->resource} returning false", MIDCOM_LOG_INFO);
48 49
             return false;
49 50
         }
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/conflictmanager.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -142,7 +142,8 @@  discard block
 block discarded – undo
142 142
             try {
143 143
                 $event = new org_openpsa_calendar_event_dba($member->event);
144 144
                 $set_as_modified = true;
145
-            } catch (midcom_error) {
145
+            }
146
+            catch (midcom_error) {
146 147
                 debug_add("event_resource #{$member->id} links to bogus event #{$member->event}, skipping and removing", MIDCOM_LOG_WARN);
147 148
                 $member->delete();
148 149
                 return;
@@ -170,7 +171,8 @@  discard block
 block discarded – undo
170 171
 
171 172
         try {
172 173
             $event = new org_openpsa_calendar_event_dba($member->eid);
173
-        } catch (midcom_error) {
174
+        }
175
+        catch (midcom_error) {
174 176
             debug_add("eventmember #{$member->id} links to bogus event #{$member->eid}, skipping and removing", MIDCOM_LOG_WARN);
175 177
             $member->delete();
176 178
             return;
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/invoice/item.php 1 patch
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -72,7 +72,8 @@  discard block
 block discarded – undo
72 72
             try {
73 73
                 $task = org_openpsa_projects_task_dba::get_cached($this->task);
74 74
                 $url = $projects_url . 'task/' . $task->guid . '/';
75
-            } catch (midcom_error) {
75
+            }
76
+            catch (midcom_error) {
76 77
             }
77 78
         }
78 79
         if (   $url == ''
@@ -80,7 +81,8 @@  discard block
 block discarded – undo
80 81
             try {
81 82
                 $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($this->deliverable);
82 83
                 $url = $sales_url . 'deliverable/' . $deliverable->guid . '/';
83
-            } catch (midcom_error) {
84
+            }
85
+            catch (midcom_error) {
84 86
             }
85 87
         }
86 88
         if ($url != '') {
@@ -102,7 +104,8 @@  discard block
 block discarded – undo
102 104
                     $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($this->deliverable);
103 105
                     self::update_deliverable($deliverable);
104 106
                 }
105
-            } catch (midcom_error $e) {
107
+            }
108
+            catch (midcom_error $e) {
106 109
                 $e->log();
107 110
             }
108 111
         }
Please login to merge, or discard this patch.