Passed
Push — master ( e155c6...a0a06d )
by Andreas
10:43
created
lib/midgard/admin/asgard/schemadb.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 
65 65
     protected function add_string_field(string $key, string $type)
66 66
     {
67
-        if (   $key == 'component'
67
+        if ($key == 'component'
68 68
             && $type == midcom_db_topic::class) {
69 69
             $this->_add_component_dropdown($key);
70 70
             return;
@@ -134,12 +134,12 @@  discard block
 block discarded – undo
134 134
         parent::add_longtext_field($key);
135 135
 
136 136
         // Check the user preference and configuration
137
-        if (   in_array($key, ['content', 'description'])
137
+        if (in_array($key, ['content', 'description'])
138 138
             && midgard_admin_asgard_plugin::get_preference('tinymce_enabled')) {
139 139
             $this->schema['fields'][$key]['widget'] = 'tinymce';
140 140
         }
141 141
 
142
-        if (   in_array($key, ['value', 'code'])
142
+        if (in_array($key, ['value', 'code'])
143 143
             && midgard_admin_asgard_plugin::get_preference('codemirror_enabled')) {
144 144
             $this->schema['fields'][$key]['widget'] = 'codemirror';
145 145
         }
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
         if ($score1 > $score2) {
258 258
             return 1;
259 259
         }
260
-        if (   $score1 < 3
260
+        if ($score1 < 3
261 261
             || $score1 > 6) {
262 262
             return strnatcmp($first, $second);
263 263
         }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/component/configuration.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
     {
278 278
         $success = true;
279 279
         foreach ($this->_request_data['config']->_global as $global_key => $global_value) {
280
-            if (   isset($config[$global_key])
280
+            if (isset($config[$global_key])
281 281
                 && $config[$global_key] != $global_value) {
282 282
                 continue;
283 283
                 // Skip the ones we will set next
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
         }
291 291
 
292 292
         foreach ($config as $key => $value) {
293
-            if (   is_array($value)
293
+            if (is_array($value)
294 294
                 || is_object($value)) {
295 295
                 /**
296 296
                  * See http://trac.midgard-project.org/ticket/1442
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/schemadb/config.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,11 +61,11 @@
 block discarded – undo
61 61
                 $fields[$key] = $this->detect_schema($key, $value);
62 62
             }
63 63
 
64
-            if (   !isset($this->config->_local[$key])
64
+            if (!isset($this->config->_local[$key])
65 65
                 || $this->config->_local[$key] == $this->config->_global[$key]) {
66 66
                 // No local configuration setting, note to user that this is the global value
67 67
                 $fields[$key]['title'] = $schema->get_l10n()->get($fields[$key]['title']);
68
-                $fields[$key]['title'] .= " <span class=\"global\">(" . midcom::get()->i18n->get_string('global value', 'midgard.admin.asgard') .")</span>";
68
+                $fields[$key]['title'] .= " <span class=\"global\">(" . midcom::get()->i18n->get_string('global value', 'midgard.admin.asgard') . ")</span>";
69 69
             }
70 70
         }
71 71
 
Please login to merge, or discard this patch.
lib/midcom/admin/help/help.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -179,9 +179,9 @@  discard block
 block discarded – undo
179 179
         $files = [];
180 180
         $pattern = $component_dir . '*.{' . $this->_i18n->get_current_language() . ',' . $this->_i18n->get_fallback_language() . '}.txt';
181 181
 
182
-        foreach (glob($pattern, GLOB_NOSORT|GLOB_BRACE) as $path) {
182
+        foreach (glob($pattern, GLOB_NOSORT | GLOB_BRACE) as $path) {
183 183
             $entry = basename($path);
184
-            if (   str_starts_with($entry, 'index')
184
+            if (str_starts_with($entry, 'index')
185 185
                 || str_starts_with($entry, 'handler')
186 186
                 || str_starts_with($entry, 'urlmethod')) {
187 187
                 // Ignore dotfiles, handlers & index.lang.txt
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
         $data = [];
233 233
 
234 234
         $exec_path = midcom::get()->componentloader->path_to_snippetpath($component) . '/exec/';
235
-        if (   !is_dir($exec_path)
235
+        if (!is_dir($exec_path)
236 236
             || !is_readable($exec_path)) {
237 237
             // Directory not accessible, skip loading it
238 238
             return $data;
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/event.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
         }
142 142
 
143 143
         //Check up
144
-        if (   !$this->up
144
+        if (!$this->up
145 145
             && $this->title != '__org_openpsa_calendar') {
146 146
             $root_event = org_openpsa_calendar_interface::find_root_event();
147 147
             $this->up = $root_event->id;
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 
167 167
     private function _check_timerange() : bool
168 168
     {
169
-        if (   !$this->start
169
+        if (!$this->start
170 170
             || !$this->end) {
171 171
             debug_add('Event must have start and end timestamps');
172 172
             midcom_connection::set_error(MGD_ERR_RANGE);
Please login to merge, or discard this patch.
lib/net/nemein/wiki/handler/view.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -202,9 +202,9 @@
 block discarded – undo
202 202
         $toc .= "\n<ol class=\"midcom_helper_toc_formatter level_{$current_list_level}\">\n";
203 203
         foreach ($headings[4] as $key => $heading) {
204 204
             $anchor = 'heading-' . md5($heading);
205
-            $tag_level =& $headings[3][$key];
206
-            $heading_code =& $headings[0][$key];
207
-            $heading_tag =& $headings[2][$key];
205
+            $tag_level = & $headings[3][$key];
206
+            $heading_code = & $headings[0][$key];
207
+            $heading_tag = & $headings[2][$key];
208 208
             $heading_new_code = "<a id='{$anchor}'></a>{$heading_code}";
209 209
             $content = str_replace($heading_code, $heading_new_code, $content);
210 210
             if ($current_tag_level === false) {
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/handler/message/send.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
     {
115 115
         $nap = new midcom_helper_nav();
116 116
         $node = $nap->get_node($nap->get_current_node());
117
-        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid .'/';
117
+        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid . '/';
118 118
         $this->batch_url_base_full = $node[MIDCOM_NAV_RELATIVEURL] . 'message/send_bg/' . $data['message']->guid . '/';
119 119
         debug_add("compose_url: {$compose_url}");
120 120
         debug_add("batch_url base: {$this->batch_url_base_full}");
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/object/manage.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -223,10 +223,10 @@
 block discarded – undo
223 223
             $new_type_reflector = midcom_helper_reflector::get($new_type);
224 224
             $link_properties = $new_type_reflector->get_link_properties();
225 225
             foreach ($link_properties as $property => $link) {
226
-                if (   ($link['class'] && midcom_helper_reflector::is_same_class($link['class'], $this->_object->__mgdschema_class_name__))
226
+                if (($link['class'] && midcom_helper_reflector::is_same_class($link['class'], $this->_object->__mgdschema_class_name__))
227 227
                     || $link['type'] == MGD_TYPE_GUID) {
228 228
                     $defaults[$property] = $this->_object->{$link['target']};
229
-                } elseif (   $property == $parent_property
229
+                } elseif ($property == $parent_property
230 230
                           && midcom_helper_reflector::is_same_class($new_type, $this->_object->__mgdschema_class_name__)) {
231 231
                     $defaults[$property] = $this->_object->$parent_property;
232 232
                 }
Please login to merge, or discard this patch.
lib/midcom/services/auth/main.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -221,7 +221,7 @@
 block discarded – undo
221 221
             return true;
222 222
         }
223 223
         if ($user === null) {
224
-            $user =& $this->user;
224
+            $user = & $this->user;
225 225
         }
226 226
 
227 227
         if ($user == 'EVERYONE') {
Please login to merge, or discard this patch.