@@ -30,7 +30,7 @@ discard block |
||
| 30 | 30 | <?php |
| 31 | 31 | foreach ($type_choices as $value => $label) { |
| 32 | 32 | $selected = ''; |
| 33 | - if ( isset($data['type_filter']) |
|
| 33 | + if (isset($data['type_filter']) |
|
| 34 | 34 | && $data['type_filter'] == $value) { |
| 35 | 35 | $selected = ' selected="selected"'; |
| 36 | 36 | } |
@@ -45,7 +45,7 @@ discard block |
||
| 45 | 45 | <?php |
| 46 | 46 | foreach ($revised_after_choices as $value => $label) { |
| 47 | 47 | $selected = ''; |
| 48 | - if ( isset($data['revised_after']) |
|
| 48 | + if (isset($data['revised_after']) |
|
| 49 | 49 | && $data['revised_after'] == date('Y-m-d', $value)) { |
| 50 | 50 | $selected = ' selected="selected"'; |
| 51 | 51 | } |
@@ -18,7 +18,7 @@ |
||
| 18 | 18 | public function initialize(midcom_baseclasses_components_viewer $master, Router $router) |
| 19 | 19 | { |
| 20 | 20 | $this->router = $router; |
| 21 | - $this->_request_data =& $master->_request_data; |
|
| 21 | + $this->_request_data = & $master->_request_data; |
|
| 22 | 22 | $this->_topic = $master->_topic; |
| 23 | 23 | $this->_request_data['l10n'] = $this->_l10n; |
| 24 | 24 | |
@@ -138,7 +138,8 @@ |
||
| 138 | 138 | try { |
| 139 | 139 | $parent = new org_openpsa_projects_project($task->project); |
| 140 | 140 | $options['success_url'] = $this->router->generate('project', ['guid' => $parent->guid]); |
| 141 | - } catch (midcom_error $e) { |
|
| 141 | + } |
|
| 142 | + catch (midcom_error $e) { |
|
| 142 | 143 | $e->log(); |
| 143 | 144 | } |
| 144 | 145 | |
@@ -64,7 +64,7 @@ discard block |
||
| 64 | 64 | return new midcom_response_relocate($this->router->generate('task_view', ['guid' => $guid])); |
| 65 | 65 | } |
| 66 | 66 | |
| 67 | - if ( $request->request->has('save') |
|
| 67 | + if ($request->request->has('save') |
|
| 68 | 68 | && $prospects = $request->request->get('org_openpsa_projects_prospects')) { |
| 69 | 69 | $qb = org_openpsa_projects_task_resource_dba::new_query_builder(); |
| 70 | 70 | $qb->add_constraint('guid', 'IN', array_keys($prospects)); |
@@ -95,7 +95,7 @@ discard block |
||
| 95 | 95 | // create relatedto |
| 96 | 96 | org_openpsa_relatedto_plugin::create($event, 'org.openpsa.calendar', $this->_task, 'org.openpsa.projects'); |
| 97 | 97 | } |
| 98 | - if ( $update_prospect |
|
| 98 | + if ($update_prospect |
|
| 99 | 99 | && !$prospect->update()) { |
| 100 | 100 | debug_add('Failed to update prospect: ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR); |
| 101 | 101 | } |
@@ -36,7 +36,8 @@ discard block |
||
| 36 | 36 | // Add person to campaign |
| 37 | 37 | try { |
| 38 | 38 | $campaign = new org_openpsa_directmarketing_campaign_dba($add_to); |
| 39 | - } catch (midcom_error $e) { |
|
| 39 | + } |
|
| 40 | + catch (midcom_error $e) { |
|
| 40 | 41 | // FIXME: More informative error message |
| 41 | 42 | $this->notify('Failed adding person %s to campaign %s', $add_to, 'error'); |
| 42 | 43 | return; |
@@ -86,7 +87,8 @@ discard block |
||
| 86 | 87 | try { |
| 87 | 88 | $campaigns[$membership->campaign] = new org_openpsa_directmarketing_campaign_dba($membership->campaign); |
| 88 | 89 | $campaign_membership_map[$membership->campaign] = $membership; |
| 89 | - } catch (midcom_error $e) { |
|
| 90 | + } |
|
| 91 | + catch (midcom_error $e) { |
|
| 90 | 92 | debug_add('Failed to load campaign ' . $membership->campaign . ', reason: ' . $e->getMessage()); |
| 91 | 93 | } |
| 92 | 94 | } |
@@ -48,7 +48,8 @@ discard block |
||
| 48 | 48 | // We're creating invoice for chosen customer |
| 49 | 49 | try { |
| 50 | 50 | $this->customer = new org_openpsa_contacts_group_dba($company); |
| 51 | - } catch (midcom_error $e) { |
|
| 51 | + } |
|
| 52 | + catch (midcom_error $e) { |
|
| 52 | 53 | $contact = new org_openpsa_contacts_person_dba($company); |
| 53 | 54 | $this->contact_id = $contact->id; |
| 54 | 55 | } |
@@ -155,7 +156,8 @@ discard block |
||
| 155 | 156 | if (!empty($this->invoice->customer)) { |
| 156 | 157 | try { |
| 157 | 158 | $this->customer = org_openpsa_contacts_group_dba::get_cached($this->invoice->customer); |
| 158 | - } catch (midcom_error $e) { |
|
| 159 | + } |
|
| 160 | + catch (midcom_error $e) { |
|
| 159 | 161 | $customer_field['hidden'] = true; |
| 160 | 162 | $e->log(); |
| 161 | 163 | } |
@@ -141,8 +141,8 @@ |
||
| 141 | 141 | $schema->get_field('paid')['hidden'] = empty($this->invoice->paid); |
| 142 | 142 | |
| 143 | 143 | $contact = $this->invoice->customerContact ?: $this->contact_id; |
| 144 | - $customer_field =& $schema->get_field('customer'); |
|
| 145 | - $contact_field =& $schema->get_field('customerContact'); |
|
| 144 | + $customer_field = & $schema->get_field('customer'); |
|
| 145 | + $contact_field = & $schema->get_field('customerContact'); |
|
| 146 | 146 | |
| 147 | 147 | if (!empty($contact)) { |
| 148 | 148 | $customer_field['type_config']['options'] = $this->get_customers_for_contact($contact); |
@@ -89,7 +89,8 @@ |
||
| 89 | 89 | } elseif ((int) $group > 0) { |
| 90 | 90 | try { |
| 91 | 91 | $this->parent = new org_openpsa_products_product_group_dba((int) $group); |
| 92 | - } catch (midcom_error $e) { |
|
| 92 | + } |
|
| 93 | + catch (midcom_error $e) { |
|
| 93 | 94 | $e->log(); |
| 94 | 95 | } |
| 95 | 96 | } |
@@ -33,7 +33,7 @@ |
||
| 33 | 33 | midcom::get()->auth->require_valid_user(); |
| 34 | 34 | midcom::get()->skip_page_style = true; |
| 35 | 35 | |
| 36 | - $this->add_stylesheet(MIDCOM_STATIC_URL ."/midcom.helper.imagepopup/styling.css", 'screen'); |
|
| 36 | + $this->add_stylesheet(MIDCOM_STATIC_URL . "/midcom.helper.imagepopup/styling.css", 'screen'); |
|
| 37 | 37 | |
| 38 | 38 | $data['filetype'] = $filetype; |
| 39 | 39 | $data['object'] = null; |
@@ -100,7 +100,8 @@ |
||
| 100 | 100 | try { |
| 101 | 101 | $task = org_openpsa_projects_task_dba::get_cached($hour_report->task); |
| 102 | 102 | $options['success_url'] = $this->router->generate('list_hours_task', ['guid' => $task->guid]); |
| 103 | - } catch (midcom_error $e) { |
|
| 103 | + } |
|
| 104 | + catch (midcom_error $e) { |
|
| 104 | 105 | $e->log(); |
| 105 | 106 | } |
| 106 | 107 | return $this->get_workflow('delete', $options)->run($request); |