flack / openpsa

lib/midcom/helper/toolbar/view.php

Spacing +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
             ]);
         }
 
-        if (   midcom::get()->config->get('midcom_services_rcs_enable')
+        if (midcom::get()->config->get('midcom_services_rcs_enable')
             && $object->can_do('midgard:update')
             && $object->_use_rcs) {
             $buttons[] = [
@@ -84,7 +84,7 @@ 
             }
 
             $icon = 'stock-icons/16x16/page-' . $icontype . '.png';
-            if (   !midcom::get()->config->get('show_hidden_objects')
+            if (!midcom::get()->config->get('show_hidden_objects')
                 && !$object->metadata->is_visible()) {
                 // Take scheduling into account
                 $icon = 'stock-icons/16x16/page-' . $icontype . '-notpublished.png';

lib/org/openpsa/reports/handler/projects/report.php

Braces +2 added lines, -1 removed lines

@@ -123,7 +123,8 @@
             $row = [];
             try {
                 $row['person'] = org_openpsa_contacts_person_dba::get_cached($hour->person);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
                 continue;
             }

Spacing +4 added lines, -4 removed lines

@@ -47,12 +47,12 @@ 
         $qb_hr = org_openpsa_expenses_hour_report_dba::new_query_builder();
         $qb_hr->add_constraint('date', '<=', (int) $query_data['end']);
         $qb_hr->add_constraint('date', '>=', (int) $query_data['start']);
-        if (   array_key_exists('invoiceable_filter', $query_data)
+        if (array_key_exists('invoiceable_filter', $query_data)
             && $query_data['invoiceable_filter'] != -1) {
             $qb_hr->add_constraint('invoiceable', '=', (bool) $query_data['invoiceable_filter']);
         }
 
-        if (   array_key_exists('invoiced_filter', $query_data)
+        if (array_key_exists('invoiced_filter', $query_data)
             && $query_data['invoiced_filter'] != -1) {
             if ((int) $query_data['invoiced_filter']) {
                 debug_add('invoiced_filter parsed as ONLY, adding constraint');
@@ -71,7 +71,7 @@ 
             $tasks = $this->_expand_task($query_data['task']);
             $qb_hr->add_constraint('task', 'IN', $tasks);
         }
-        if (   array_key_exists('hour_type_filter', $query_data)
+        if (array_key_exists('hour_type_filter', $query_data)
             && $query_data['hour_type_filter'] != 'builtin:all') {
             $qb_hr->add_constraint('reportType', '=', $query_data['hour_type_filter']);
         }
@@ -140,7 +140,7 @@ 
 
     private function add_to_group(array $new_row, string $matching, string $sort, string $title)
     {
-        $rows =& $this->_request_data['report']['rows'];
+        $rows = & $this->_request_data['report']['rows'];
         if (array_key_exists($matching, $rows)) {
             $rows[$matching]['rows'][] = $new_row;
             $rows[$matching]['total_hours'] += $new_row['hour']->hours;

lib/org/openpsa/directmarketing/sender.php

Braces +4 added lines, -2 removed lines

@@ -222,7 +222,8 @@ 
             $this->_backend->send($person, $member, $token, $subject, $content, $from);
             self::$_messages_sent++;
             $status = org_openpsa_directmarketing_campaign_messagereceipt_dba::SENT;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $status = org_openpsa_directmarketing_campaign_messagereceipt_dba::FAILURE;
             if (!$this->test_mode) {
                 $params[] = [
@@ -279,7 +280,8 @@ 
     {
         try {
             $person = org_openpsa_contacts_person_dba::get_cached($member->person);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             debug_add("Person #{$member->person} deleted or missing, removing member (member #{$member->id})");
             $member->orgOpenpsaObtype = org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED;
             $member->delete();

Spacing +3 added lines, -3 removed lines

@@ -75,7 +75,7 @@ 
         $this->from = $from;
         $this->subject = $subject;
 
-        if (   $message->orgOpenpsaObtype != org_openpsa_directmarketing_campaign_message_dba::EMAIL_TEXT
+        if ($message->orgOpenpsaObtype != org_openpsa_directmarketing_campaign_message_dba::EMAIL_TEXT
             && $message->orgOpenpsaObtype != org_openpsa_directmarketing_campaign_message_dba::EMAIL_HTML) {
             throw new midcom_error('unsupported message type');
         }
@@ -219,7 +219,7 @@ 
         $token .= midcom_helper_misc::random_string($this->token_size - 1, 'abcdefghijklmnopqrstuvwxyz0123456789');
 
         //If token is not free or (very, very unlikely) matches our dummy token, recurse.
-        if (   $token === 'dummy'
+        if ($token === 'dummy'
             || !org_openpsa_directmarketing_campaign_messagereceipt_dba::token_is_free($token)) {
             return $this->_create_token();
         }
@@ -240,7 +240,7 @@ 
             return null;
         }
         $type = $this->_backend->get_type();
-        if (   $person->get_parameter('org.openpsa.directmarketing', "send_all_denied")
+        if ($person->get_parameter('org.openpsa.directmarketing', "send_all_denied")
             || $person->get_parameter('org.openpsa.directmarketing', "send_{$type}_denied")) {
             debug_add("Sending {$type} messages to person {$person->rname} is denied, unsubscribing member (member #{$member->id})");
             $member->orgOpenpsaObtype = org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED;

src/midcom/datamanager/datamanager.php

Braces +1 added lines, -2 removed lines

@@ -210,8 +210,7 @@
     {
         $ret = [];
 
-        foreach ($this->storage as $field => $value)
-        {
+        foreach ($this->storage as $field => $value) {
             $ret[$field] = $value->get_value();
             $config = $this->schema->get_field($field);
             if (!empty($config['type_config']['allow_multiple'])) {

Spacing +3 added lines, -3 removed lines

@@ -57,7 +57,7 @@ 
 
     public function set_storage(midcom_core_dbaobject $storage = null, string $schemaname = null) : self
     {
-        if (   $schemaname === null
+        if ($schemaname === null
             && !empty($storage->id)) {
             $schemaname = $storage->get_parameter('midcom.helper.datamanager2', 'schema_name');
         }
@@ -147,7 +147,7 @@ 
             $this->form = null;
         }
 
-        if (   $this->form === null
+        if ($this->form === null
             || ($name && $this->form->getName() != $name)) {
             $this->build_form($this->get_builder($name));
         }
@@ -235,7 +235,7 @@ 
     {
         $ret = true;
         foreach ($this->storage as $field) {
-            if (   $field instanceof recreateable
+            if ($field instanceof recreateable
                 && !$field->recreate()) {
                 $ret = false;
             }

lib/org/openpsa/contacts/handler/group/create.php

Spacing +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
 
         $this->_group = new org_openpsa_contacts_group_dba();
 
-        if (   $this->_type == 'organization'
+        if ($this->_type == 'organization'
             && $this->_parent_group) {
             $this->_group->owner = $this->_parent_group->id;
         } else {

lib/org/openpsa/documents/handler/directory/create.php

Spacing +1 added lines, -1 removed lines

@@ -50,6 +50,6 @@
         $indexer = new org_openpsa_documents_midcom_indexer($this->_topic);
         $indexer->index($controller->get_datamanager());
 
-        return $controller->get_datamanager()->get_storage()->get_value()->name. "/";
+        return $controller->get_datamanager()->get_storage()->get_value()->name . "/";
     }
 }

src/midcom/datamanager/storage/dbanode.php

Braces +2 added lines, -1 removed lines

@@ -30,7 +30,8 @@
         $this->config = $config;
     }
 
-    protected function cast($value) {
+    protected function cast($value)
+    {
         if ($this->config['type'] == 'number' && !is_numeric($value)) {
             $value = (float) $value;
         }

lib/net/nemein/wiki/midcom/interfaces.php

Braces +2 added lines, -1 removed lines

@@ -30,7 +30,8 @@
             foreach ($result as $wikipage) {
                 try {
                     $datamanager->set_storage($wikipage);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $e->log(MIDCOM_LOG_WARN);
                     continue;
                 }

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
 
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
     {
-        if (   $object instanceof midcom_db_article
+        if ($object instanceof midcom_db_article
             && $topic->id == $object->topic) {
             if ($object->name == 'index') {
                 return '';

lib/net/nehmer/blog/handler/archive.php

Braces +2 added lines, -1 removed lines

@@ -409,7 +409,8 @@
             foreach ($this->_articles as $article_counter => $article) {
                 try {
                     $data['datamanager']->set_storage($article);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $e->log();
                     continue;
                 }

Spacing +4 added lines, -4 removed lines

@@ -131,8 +131,8 @@ 
         $year_data = [];
         $first_post = $this->_compute_welcome_first_post();
         $this->_request_data['first_post'] = $first_post;
-        $this->_request_data['total_count'] =& $total_count;
-        $this->_request_data['year_data'] =& $year_data;
+        $this->_request_data['total_count'] = & $total_count;
+        $this->_request_data['year_data'] = & $year_data;
         if (!$first_post) {
             return;
         }
@@ -261,7 +261,7 @@ 
         switch ($handler_id) {
             case 'archive-year-category':
                 $category = trim(strip_tags($args[1]));
-                if (   $data['datamanager']->get_schema('default')->has_field('categories')
+                if ($data['datamanager']->get_schema('default')->has_field('categories')
                     && !$data['datamanager']->get_schema('default')->get_field('categories')['type_config']['allow_multiple']) {
                     $qb->add_constraint('extra1', '=', $category);
                 } else {
@@ -345,7 +345,7 @@ 
             throw new midcom_error_notfound("The year '{$year}' is not valid.");
         }
 
-        if (   $month < 1
+        if ($month < 1
             || $month > 12) {
             throw new midcom_error_notfound("The month {$month} is not valid.");
         }