flack / openpsa

lib/midcom/admin/folder/handler/order.php

Braces +2 added lines, -1 removed lines

@@ -69,7 +69,8 @@
         // Use the DB Factory to resolve the class and to get the object
         try {
             $object = midcom::get()->dbfactory->get_object_by_guid($identifier);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             // This is probably a pseudo leaf, store the score to the current node
             $this->_topic->set_parameter('midcom.helper.nav.score', $identifier, $score);
             return true;

Spacing +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
         }
 
         // Approve if possible
-        if (   $approval_status
+        if ($approval_status
             && $object->can_do('midcom:approve')) {
             $object->metadata->approve();
         }

lib/midcom/db/topic.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     public function _on_loaded()
     {
         // if we are missing the component, use the nullcomponent.
-        if (   !$this->component
+        if (!$this->component
             || !array_key_exists($this->component, midcom::get()->componentloader->manifests)) {
             debug_add("Topic {$this->id} has no component assigned to it, using 'midcom.core.nullcomponent'.",
             MIDCOM_LOG_INFO);

lib/midcom/services/cache/module/nap.php

Braces +2 added lines, -1 removed lines

@@ -132,7 +132,8 @@
                       && $nodeobject = $nav->get_node($node->id)) {
                 $napobject = $nav->get_leaf($nodeobject[MIDCOM_NAV_ID] . '-' . $object->id);
             }
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
         return $napobject;

Spacing +7 added lines, -7 removed lines

@@ -77,7 +77,7 @@ 
             // Get parent from DB and compare to catch moves
             if ($parent = $napobject[MIDCOM_NAV_OBJECT]->get_parent()) {
                 $parent_entry_from_object = $this->get_guid($parent->guid);
-                if (    $parent_entry_from_object
+                if ($parent_entry_from_object
                      && $parent_entry_from_object[MIDCOM_NAV_ID] != $cached_node_id) {
                     $this->_cache->delete($this->_prefix . '-' . $parent_entry_from_object[MIDCOM_NAV_ID] . '-leaves');
                 }
@@ -92,7 +92,7 @@ 
             $parent_id = $napobject[MIDCOM_NAV_NODEID];
             $parent_entry = $this->get_node($parent_id);
 
-            if (   $parent_entry
+            if ($parent_entry
                 && array_key_exists(MIDCOM_NAV_SUBNODES, $parent_entry)) {
                 unset($parent_entry[MIDCOM_NAV_SUBNODES]);
                 $this->put_node($parent_id, $parent_entry);
@@ -102,7 +102,7 @@ 
             if ($parent = $napobject[MIDCOM_NAV_OBJECT]->get_parent()) {
                 $parent_entry_from_object = $this->get_guid($parent->guid);
 
-                if (    !empty($parent_entry_from_object[MIDCOM_NAV_ID])
+                if (!empty($parent_entry_from_object[MIDCOM_NAV_ID])
                      && !empty($parent_entry[MIDCOM_NAV_ID])
                      && $parent_entry_from_object[MIDCOM_NAV_ID] != $parent_entry[MIDCOM_NAV_ID]) {
                     unset($parent_entry_from_object[MIDCOM_NAV_SUBNODES]);
@@ -128,7 +128,7 @@ 
             $nav = new midcom_helper_nav;
             if ($object instanceof midcom_db_topic) {
                 $napobject = $nav->get_node($object->id);
-            } elseif (   ($node = $nav->find_closest_topic($object))
+            } elseif (($node = $nav->find_closest_topic($object))
                       && $nodeobject = $nav->get_node($node->id)) {
                 $napobject = $nav->get_leaf($nodeobject[MIDCOM_NAV_ID] . '-' . $object->id);
             }
@@ -153,7 +153,7 @@ 
         }
         $lang_id = midcom::get()->i18n->get_current_language();
         $result = $this->_cache->fetch("{$this->_prefix}-{$key}");
-        if (   !is_array($result)
+        if (!is_array($result)
             || !isset($result[$lang_id])) {
             return false;
         }
@@ -177,7 +177,7 @@ 
 
         $lang_id = midcom::get()->i18n->get_current_language();
         $result = $this->_cache->fetch("{$this->_prefix}-{$key}");
-        if (   !is_array($result)
+        if (!is_array($result)
             || !isset($result[$lang_id])) {
             return false;
         }
@@ -244,7 +244,7 @@ 
 
         $lang_id = midcom::get()->i18n->get_current_language();
         $result = $this->_cache->fetch("{$this->_prefix}-{$guid}");
-        if (   !is_array($result)
+        if (!is_array($result)
             || !isset($result[$lang_id])) {
             return false;
         }

lib/midcom/services/permalinks/main.php

Braces +2 added lines, -1 removed lines

@@ -72,7 +72,8 @@
 
         try {
             $object = midcom::get()->dbfactory->get_object_by_guid($guid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             debug_add("Failed to resolve the GUID {$guid}, this is most probably an access denied error.", MIDCOM_LOG_ERROR);
             debug_add('Last MidCOM error string: ' . $e->getMessage());
             return null;

Spacing +1 added lines, -1 removed lines

@@ -93,7 +93,7 @@
         if ($object instanceof midcom_db_attachment) {
             // Faster linking to attachments
             $parent = $object->get_parent();
-            if (   is_a($parent, midcom_db_topic::class)
+            if (is_a($parent, midcom_db_topic::class)
                 && $nav->is_node_in_tree($parent->id, $nav->get_root_node())) {
                 $napobj = $nav->get_node($parent->id);
                 return $napobj[MIDCOM_NAV_FULLURL] . $object->name;

lib/midcom/services/indexer/document/midcom.php

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
      */
     public function members_to_fields()
     {
-        if (   empty($this->topic_guid)
+        if (empty($this->topic_guid)
             || empty($this->topic_url)
             || empty($this->component)) {
             //if one of those is missing, we override all three to ensure consistency

lib/midcom/config/test.php

Indentation +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
             $this->add('Setting: upload_max_filesize', self::OK, ini_get('upload_max_filesize'));
         } else {
             $this->add('Setting: upload_max_filesize',
-                             self::WARNING, "To make bulk uploads (for exampe in the Image Gallery) useful, you should increase the Upload limit to something above 50 MB. (Current setting: {$upload_limit})");
+                                self::WARNING, "To make bulk uploads (for exampe in the Image Gallery) useful, you should increase the Upload limit to something above 50 MB. (Current setting: {$upload_limit})");
         }
 
         $post_limit = $this->ini_get_filesize('post_max_size');

Braces +2 added lines, -1 removed lines

@@ -74,7 +74,8 @@
                 $config = new midcom_services_rcs_config($config);
                 $config->test_rcs_config();
                 $this->add("MidCOM RCS", self::OK);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $this->add("MidCOM RCS", self::ERROR, $e->getMessage());
             }
         } else {

lib/midcom/core/context.php

Braces +2 added lines, -1 removed lines

@@ -181,7 +181,8 @@
         } else {
             try {
                 $root_node = midcom_db_topic::get_cached($guid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 if ($e instanceof midcom_error_forbidden) {
                     throw $e;
                 }

Spacing +2 added lines, -2 removed lines

@@ -148,7 +148,7 @@ 
             return false;
         }
 
-        if (   $key === MIDCOM_CONTEXT_ROOTTOPIC
+        if ($key === MIDCOM_CONTEXT_ROOTTOPIC
             && $this->_data[$key] === null) {
             $this->_initialize_root_topic();
         }
@@ -274,7 +274,7 @@ 
      */
     public function set_custom_key($key, &$value)
     {
-        $this->_data[MIDCOM_CONTEXT_CUSTOMDATA][$key] =& $value;
+        $this->_data[MIDCOM_CONTEXT_CUSTOMDATA][$key] = & $value;
     }
 
     public function show()

lib/midgard/admin/asgard/toolbar.php

Braces +2 added lines, -1 removed lines

@@ -117,7 +117,8 @@
                                 }
                                 break;
                         }
-                    } catch (midcom_error $e) {
+                    }
+                    catch (midcom_error $e) {
                         $e->log();
                     }
                 }

Spacing +3 added lines, -3 removed lines

@@ -144,7 +144,7 @@ 
             ];
         }
 
-        if (   midcom::get()->config->get('midcom_services_rcs_enable')
+        if (midcom::get()->config->get('midcom_services_rcs_enable')
             && $object->can_do('midgard:update')
             && $object->_use_rcs) {
             $buttons[] = [
@@ -205,7 +205,7 @@ 
     private function get_toolbar_update_items($object)
     {
         $buttons = [];
-        if (   is_a($object, midcom_db_topic::class)
+        if (is_a($object, midcom_db_topic::class)
             && $object->component
             && $object->can_do('midcom:component_config')) {
             $buttons[] = [
@@ -243,7 +243,7 @@ 
             MIDCOM_TOOLBAR_ENABLED => $object->can_do('midgard:privileges'),
         ];
 
-        if (   midcom::get()->componentloader->is_installed('midcom.helper.replicator')
+        if (midcom::get()->componentloader->is_installed('midcom.helper.replicator')
             && midcom::get()->auth->admin) {
             $buttons[] = [
                 MIDCOM_TOOLBAR_URL => "__mfa/asgard_midcom.helper.replicator/object/{$object->guid}/",

lib/midgard/admin/user/handler/list.php

Braces +2 added lines, -1 removed lines

@@ -217,7 +217,8 @@
 
         try {
             $account = new midcom_core_account($person);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             midcom::get()->uimessages->add($this->_l10n->get('midgard.admin.user'), sprintf($this->_l10n->get('failed to get the user with id %s'), $person->id), 'error');
             return;
         }