flack / openpsa

lib/midcom/admin/folder/handler/approvals.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
      */
     public function _handler_approval(Request $request, $handler_id)
     {
-        if (   !$request->request->has('guid')
+        if (!$request->request->has('guid')
             || !$request->request->has('return_to')) {
             throw new midcom_error('Cannot process approval request, request is incomplete.');
         }

lib/midcom/helper/imagepopup/handler/list.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
         midcom::get()->auth->require_valid_user();
         midcom::get()->skip_page_style = true;
 
-        $this->add_stylesheet(MIDCOM_STATIC_URL ."/midcom.helper.imagepopup/styling.css", 'screen');
+        $this->add_stylesheet(MIDCOM_STATIC_URL . "/midcom.helper.imagepopup/styling.css", 'screen');
 
         $data['filetype'] = $filetype;
         $data['object'] = null;

lib/midcom/services/rcs/handler.php

Spacing +5 added lines, -5 removed lines

@@ -48,7 +48,7 @@ 
     {
         $this->object = midcom::get()->dbfactory->get_object_by_guid($guid);
 
-        if (   !midcom::get()->config->get('midcom_services_rcs_enable')
+        if (!midcom::get()->config->get('midcom_services_rcs_enable')
             || !$this->object->_use_rcs) {
             throw new midcom_error_notfound("Revision control not supported for " . get_class($this->object) . ".");
         }
@@ -216,8 +216,8 @@ 
     public function _handler_history($handler_id, array $args)
     {
         // Check if the comparison request is valid
-        if (    !empty($_GET['first']) && !empty($_GET['last'])
-            && $_GET['first']  !== $_GET['last']) {
+        if (!empty($_GET['first']) && !empty($_GET['last'])
+            && $_GET['first'] !== $_GET['last']) {
             return new midcom_response_relocate($this->url_prefix . "diff/{$args[0]}/{$_GET['first']}/{$_GET['last']}/");
         }
 
@@ -252,7 +252,7 @@ 
     {
         $this->load_object($args[0]);
 
-        if (   !$this->backend->version_exists($args[1])
+        if (!$this->backend->version_exists($args[1])
             || !$this->backend->version_exists($args[2])) {
             throw new midcom_error_notfound("One of the revisions {$args[1]} or {$args[2]} does not exist.");
         }
@@ -323,7 +323,7 @@ 
         $this->object->require_do('midgard:update');
         // TODO: set another privilege for restoring?
 
-        if (   $this->backend->version_exists($args[1])
+        if ($this->backend->version_exists($args[1])
             && $this->backend->restore_to_revision($args[1])) {
             midcom::get()->uimessages->add($this->_l10n->get('midcom.admin.rcs'), sprintf($this->_l10n->get('restore to version %s successful'), $args[1]));
             return new midcom_response_relocate($this->get_object_url());

lib/org/openpsa/relatedto/handler/journal/entry.php

Spacing +2 added lines, -2 removed lines

@@ -44,7 +44,7 @@ 
     public function _handler_create(Request $request, $guid)
     {
         $this->_current_object = midcom::get()->dbfactory->get_object_by_guid($guid);
-        $entry= new org_openpsa_relatedto_journal_entry_dba();
+        $entry = new org_openpsa_relatedto_journal_entry_dba();
         $entry->linkGuid = $this->_current_object->guid;
 
         midcom::get()->head->set_pagetitle($this->_l10n->get('add journal entry'));
@@ -68,7 +68,7 @@ 
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
         if ($entry->can_do('midgard:delete')) {
             $delete = $this->get_workflow('delete', ['object' => $entry]);
-            $url = $this->router->generate('journal_entry_delete', ['guid' => $guid ]);
+            $url = $this->router->generate('journal_entry_delete', ['guid' => $guid]);
             $workflow->add_dialog_button($delete, $url);
         }
         return $workflow->run($request);

lib/org/openpsa/user/handler/person/account.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
         $response = $workflow->run($request);
 
-        if (   $workflow->get_state() == 'save'
+        if ($workflow->get_state() == 'save'
             && $this->create_account($this->person, $data["controller"]->get_form_values())) {
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), sprintf($this->_l10n->get('person %s created'), $this->person->name));
         }
@@ -148,7 +148,7 @@ 
         $accounthelper = new org_openpsa_user_accounthelper($this->person);
 
         // Update account
-        if (   !$accounthelper->set_account($controller->get_form_values()["username"], $password)
+        if (!$accounthelper->set_account($controller->get_form_values()["username"], $password)
             && midcom_connection::get_error() != MGD_ERR_OK) {
             // Failure, give a message
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get("failed to update the user account, reason") . ': ' . midcom_connection::get_error_string(), 'error');

lib/org/openpsa/directmarketing/handler/message/send.php

Spacing +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
     {
         $nap = new midcom_helper_nav();
         $node = $nap->get_node($nap->get_current_node());
-        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid .'/';
+        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid . '/';
         $data['batch_url_base_full'] = $node[MIDCOM_NAV_RELATIVEURL] . 'message/send_bg/' . $data['message']->guid . '/';
         debug_add("compose_url: {$compose_url}");
         debug_add("batch_url base: {$data['batch_url_base_full']}");

lib/org/openpsa/expenses/handler/hours/admin.php

Braces +2 added lines, -1 removed lines

@@ -100,7 +100,8 @@
         try {
             $task = org_openpsa_projects_task_dba::get_cached($hour_report->task);
             $options['success_url'] = $this->router->generate('list_hours_task', ['guid' => $task->guid]);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
         return $this->get_workflow('delete', $options)->run($request);

src/midcom/datamanager/controller.php

Spacing +3 added lines, -3 removed lines

@@ -70,13 +70,13 @@ 
             }
         } elseif (!$this->form->isSubmitted()) {
             $this->form->handleRequest($request);
-            if (   $this->form->isSubmitted()
+            if ($this->form->isSubmitted()
                 && $button = $this->form->getClickedButton()) {
                 $operation = $button->getConfig()->getOption('operation');
             }
         }
 
-        if (   in_array($operation, [self::SAVE, self::NEXT])
+        if (in_array($operation, [self::SAVE, self::NEXT])
             && !$this->form->isValid()) {
             $operation = self::EDIT;
         }
@@ -159,7 +159,7 @@ 
                 if ($storage->get_last_operation() === self::SAVE) {
                     // Get GUIDs and such for new-created dependent objects
                     $this->dm->set_storage($storage->get_value(), $this->dm->get_schema()->get_name());
-                } elseif (   !$this->form->isValid()
+                } elseif (!$this->form->isValid()
                           && $storage->move_uploaded_files() > 0) {
                     $form = $this->dm->get_form($this->form->getName(), true);
                     $this->copy_errors($this->form, $form);

lib/midcom/services/indexer/document/attachment.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
 
     private function process_attachment()
     {
-        if (   !isset($this->attachment->metadata)
+        if (!isset($this->attachment->metadata)
             || !is_object($this->attachment->metadata)) {
             return;
         }