flack / openpsa

lib/midcom/style/dm2_config_recreate.php

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
         continue;
     }
 
-    if (   !$object->can_do('midgard:update')
+    if (!$object->can_do('midgard:update')
         || !$object->can_do('midgard:attachments')) {
         echo sprintf(midcom::get()->i18n->get_string('not recreating object %s %s, reason %s', 'midcom'), $type, $object->guid, 'Insufficient privileges') . "\n";
         continue;

lib/org/openpsa/calendar/event.php

Spacing +3 added lines, -3 removed lines

@@ -93,7 +93,7 @@ 
 
     public function get_parent_guid_uncached()
     {
-        if (   $this->up
+        if ($this->up
             || $this->title != '__org_openpsa_calendar') {
             $root_event = org_openpsa_calendar_interface::find_root_event();
             if ($this->id != $root_event->id) {
@@ -153,7 +153,7 @@ 
         }
 
         //Check up
-        if (   !$this->up
+        if (!$this->up
             && $this->title != '__org_openpsa_calendar') {
             $root_event = org_openpsa_calendar_interface::find_root_event();
             $this->up = $root_event->id;
@@ -178,7 +178,7 @@ 
 
     private function _check_timerange()
     {
-        if (   !$this->start
+        if (!$this->start
             || !$this->end) {
             debug_add('Event must have start and end timestamps');
             midcom_connection::set_error(MGD_ERR_RANGE);

lib/midgard/admin/asgard/style/midgard_admin_asgard_welcome.php

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
                     <?php
                     foreach ($type_choices as $value => $label) {
                         $selected = '';
-                        if (   isset($data['type_filter'])
+                        if (isset($data['type_filter'])
                             && $data['type_filter'] == $value) {
                             $selected = ' selected="selected"';
                         }
@@ -45,7 +45,7 @@ 
                     <?php
                     foreach ($revised_after_choices as $value => $label) {
                         $selected = '';
-                        if (   isset($data['revised_after'])
+                        if (isset($data['revised_after'])
                             && $data['revised_after'] == date('Y-m-d', $value)) {
                             $selected = ' selected="selected"';
                         }

lib/midcom/baseclasses/components/plugin.php

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
     public function initialize(midcom_baseclasses_components_viewer $master, Router $router)
     {
         $this->router = $router;
-        $this->_request_data =& $master->_request_data;
+        $this->_request_data = & $master->_request_data;
         $this->_topic = $master->_topic;
         $this->_request_data['l10n'] = $this->_l10n;
 

lib/net/nehmer/comments/handler/view.php

Spacing +11 added lines, -11 removed lines

@@ -98,8 +98,8 @@ 
         if (!$this->_schemadb) {
             $this->_schemadb = schemadb::from_path($this->_config->get('schemadb'));
 
-            if (   $this->_config->get('use_captcha')
-                || (   !midcom::get()->auth->user
+            if ($this->_config->get('use_captcha')
+                || (!midcom::get()->auth->user
                     && $this->_config->get('use_captcha_if_anonymous'))) {
                 $fields = $this->_schemadb->get('comment')->get('fields');
                 $fields['captcha'] = [
@@ -112,9 +112,9 @@ 
                 $this->_schemadb->get('comment')->set('fields', $fields);
             }
 
-            if (   $this->_config->get('ratings_enable')
+            if ($this->_config->get('ratings_enable')
                 && $this->_schemadb->get('comment')->has_field('rating')) {
-                $field =& $this->_schemadb->get('comment')->get_field('rating');
+                $field = & $this->_schemadb->get('comment')->get_field('rating');
                 $field['hidden'] = false;
             }
         }
@@ -189,7 +189,7 @@ 
             $this->_comments = $this->_comments->execute();
         }
 
-        if (   midcom::get()->auth->user
+        if (midcom::get()->auth->user
             || $this->_config->get('allow_anonymous')) {
             $this->_init_post_controller($request);
             $this->_process_post($request);
@@ -217,7 +217,7 @@ 
      */
     private function _process_post(Request $request)
     {
-        if (   !midcom::get()->auth->user
+        if (!midcom::get()->auth->user
             && !midcom::get()->auth->request_sudo('net.nehmer.comments')) {
             throw new midcom_error('We were anonymous but could not acquire SUDO privileges, aborting');
         }
@@ -227,7 +227,7 @@ 
                 // Check against comment spam
                 $this->_new_comment->check_spam($this->_config);
                 $formdata = $this->_post_controller->get_form_values();
-                if (   $formdata['subscribe']
+                if ($formdata['subscribe']
                     && midcom::get()->auth->user) {
                     // User wants to subscribe to receive notifications about this comments thread
 
@@ -264,7 +264,7 @@ 
      */
     private function _get_last_modified()
     {
-        return array_reduce($this->_comments, function ($carry, net_nehmer_comments_comment $item) {
+        return array_reduce($this->_comments, function($carry, net_nehmer_comments_comment $item) {
             return max($item->metadata->revised, $carry);
         }, 0);
     }
@@ -286,8 +286,8 @@ 
                 $data['comment_toolbar'] = $this->populate_post_toolbar($comment);
                 midcom_show_style('comments-item');
 
-                if (   midcom::get()->auth->admin
-                    || (   midcom::get()->auth->user
+                if (midcom::get()->auth->admin
+                    || (midcom::get()->auth->user
                         && $comment->can_do('midgard:delete'))) {
                     midcom_show_style('comments-admintoolbar');
                 }
@@ -297,7 +297,7 @@ 
             midcom_show_style('comments-nonefound');
         }
 
-        if (   midcom::get()->auth->user
+        if (midcom::get()->auth->user
             || $this->_config->get('allow_anonymous')) {
             midcom_show_style('post-comment');
         } else {

lib/net/nehmer/comments/handler/admin.php

Spacing +1 added lines, -1 removed lines

@@ -118,7 +118,7 @@
      */
     public function _handler_moderate_ajax(Request $request, $status, array &$data)
     {
-        if (   !$request->request->has('action')
+        if (!$request->request->has('action')
             || !$request->request->has('guid')) {
             throw new midcom_error_notfound('Incomplete POST data');
         }

lib/org/openpsa/sales/handler/deliverable/add.php

Spacing +4 added lines, -4 removed lines

@@ -51,13 +51,13 @@ 
 
         if ($this->_product->delivery == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
             $schema = 'subscription';
-            $field =& $schemadb->get('subscription')->get_field('start');
+            $field = & $schemadb->get('subscription')->get_field('start');
             $field['type_config']['min_date'] = strftime('%Y-%m-%d');
         } else {
-            $end =& $schemadb->get('default')->get_field('end');
+            $end = & $schemadb->get('default')->get_field('end');
             $end['type_config']['min_date'] = strftime('%Y-%m-%d');
             if ($this->_product->costType == "%") {
-                $costPerUnit =& $schemadb->get('default')->get_field('costPerUnit');
+                $costPerUnit = & $schemadb->get('default')->get_field('costPerUnit');
                 $costPerUnit['title'] = $this->_l10n->get("cost per unit (percentage)");
             }
         }
@@ -95,7 +95,7 @@ 
      */
     public function _handler_add(Request $request, $guid, array &$data)
     {
-        if (   !$request->request->has('product')
+        if (!$request->request->has('product')
             && !$request->request->has('org_openpsa_sales')) {
             throw new midcom_error('No product specified, aborting.');
         }

lib/org/openpsa/sales/handler/edit.php

Spacing +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
         $this->_salesproject->require_do('midgard:update');
 
         $schemadb = schemadb::from_path($this->_config->get('schemadb_salesproject'));
-        $field =& $schemadb->get('default')->get_field('customer');
+        $field = & $schemadb->get('default')->get_field('customer');
         $field['type_config']['options'] = org_openpsa_helpers_list::task_groups($this->_salesproject);
         $dm = new datamanager($schemadb);
         $dm->set_storage($this->_salesproject);
@@ -59,7 +59,7 @@ 
         $schemadb = schemadb::from_path($this->_config->get('schemadb_salesproject'));
 
         if (!empty($guid)) {
-            $field =& $schemadb->get('default')->get_field('customer');
+            $field = & $schemadb->get('default')->get_field('customer');
             try {
                 $customer = new org_openpsa_contacts_group_dba($guid);
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];

Braces +2 added lines, -1 removed lines

@@ -65,7 +65,8 @@
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];
 
                 $defaults['customer'] = $customer->id;
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $customer = new org_openpsa_contacts_person_dba($guid);
                 $defaults['customerContact'] = $customer->id;
                 $field['type_config']['options'] = org_openpsa_helpers_list::task_groups(new org_openpsa_sales_salesproject_dba, 'id', [$customer->id => true]);

lib/org/openpsa/slideshow/handler/edit.php

Spacing +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
         $images = $qb->execute();
         $failed = 0;
         foreach ($images as $image) {
-            if (   !$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
+            if (!$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
                 || !$image->generate_image('image', $this->_config->get('image_filter'))) {
                 $failed++;
             }
@@ -249,7 +249,7 @@ 
         $attachment->title = $_POST['title'];
         $attachment->mimetype = $file['type'];
         $attachment->parentguid = $image->guid;
-        if (   !$attachment->create()
+        if (!$attachment->create()
             || !$attachment->copy_from_file($file['tmp_name'])) {
             throw new midcom_error('Failed to create attachment: ' . midcom_connection::get_error_string());
         }

Braces +2 added lines, -1 removed lines

@@ -134,7 +134,8 @@
         try {
             $this->$function($request->request);
             $this->_response->success = true;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $this->_response->success = false;
             $this->_response->error = $e->getMessage();
         }