flack / openpsa

lib/org/openpsa/reports/style/projects_report-basic-header.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
                         <th><?php echo $data['l10n']->get('type'); ?></th>
 <?php
         }   ?>
-<?php   if (   array_key_exists('invoiceable_filter', $query_data)) {
+<?php   if (array_key_exists('invoiceable_filter', $query_data)) {
             ?>
                         <th><?php echo midcom::get()->i18n->get_string('invoiceable', 'org.openpsa.projects'); ?></th>
 <?php

lib/org/openpsa/sales/handler/deliverable/admin.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
         $at_entries = $mc->get_related_objects();
 
         if (empty($at_entries)) {
-            if (   (   $this->_deliverable->continuous
+            if (($this->_deliverable->continuous
                     || $this->_deliverable->end > time())
                 && $this->_deliverable->state == org_openpsa_sales_salesproject_deliverable_dba::STATE_STARTED) {
                 $schema->get_field('next_cycle')['hidden'] = false;

lib/org/openpsa/contacts/person.php

Spacing +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
 
     public function __construct($identifier = null)
     {
-        if (   midcom::get()->config->get('person_class') != 'midgard_person'
+        if (midcom::get()->config->get('person_class') != 'midgard_person'
             && midcom::get()->config->get('person_class') != 'openpsa_person') {
             $this->__mgdschema_class_name__ = midcom::get()->config->get('person_class');
         }
@@ -52,7 +52,7 @@ 
 
     public function __set($name, $value)
     {
-        if (   $name == 'homepage'
+        if ($name == 'homepage'
             && !empty($value)
             && $value != $this->homepage) {
             $this->_register_prober = true;

lib/midgard/admin/asgard/navigation.php

Spacing +17 added lines, -17 removed lines

@@ -45,7 +45,7 @@ 
 
         $this->_object = $object;
         $this->get_object_path();
-        $this->_request_data =& $request_data;
+        $this->_request_data = & $request_data;
 
         $this->root_types = midcom_helper_reflector_tree::get_root_classes();
 
@@ -59,7 +59,7 @@ 
             // we go through the path bottom up and show the first root type we find
             foreach (array_reverse($this->_object_path) as $node) {
                 foreach ($this->root_types as $root_type) {
-                    if (    is_a($node, $root_type)
+                    if (is_a($node, $root_type)
                         || midcom_helper_reflector::is_same_class($root_type, $node->__midcom_class_name__)) {
                         $this->expanded_root_types[] = $root_type;
                         break;
@@ -99,7 +99,7 @@ 
 
     protected function _is_collapsed($type, $total)
     {
-        return (   $total > $this->_config->get('max_navigation_entries')
+        return ($total > $this->_config->get('max_navigation_entries')
                 && empty($_GET['show_all_' . $type]));
     }
 
@@ -115,7 +115,7 @@ 
         foreach ($ref->get_child_classes() as $class) {
             $qb = $ref->_child_objects_type_qb($class, $object, false);
 
-            if (   !$qb
+            if (!$qb
                 || !($count = $qb->count_unchecked())) {
                 continue;
             }
@@ -163,7 +163,7 @@ 
     {
         $qb = $ref->_root_objects_qb(false);
 
-        if (   !$qb
+        if (!$qb
             || !($total = $qb->count_unchecked())) {
             return;
         }
@@ -198,7 +198,7 @@ 
     {
         $ref = midcom_helper_reflector::get($type);
         if (!empty($this->_object_path[$level])) {
-            if (   $this->_object_path[$level]->__mgdschema_class_name__ == $type
+            if ($this->_object_path[$level]->__mgdschema_class_name__ == $type
                 && !array_key_exists($this->_object_path[$level]->guid, $this->shown_objects)) {
                 $label = htmlspecialchars($ref->get_object_label($this->_object_path[$level]));
                 $this->_draw_element($this->_object_path[$level], $label, $level);
@@ -233,7 +233,7 @@ 
         $label = html_entity_decode($label);
 
         echo "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/{$mode}/{$object->guid}/\" title=\"GUID: {$object->guid}, ID: {$object->id}\">{$icon}{$label}</a>\n";
-        if (   $selected
+        if ($selected
             || $autoexpand) {
             $this->_list_child_elements($object, $level + 1);
         }
@@ -253,7 +253,7 @@ 
                 continue;
             }
 
-            if (   method_exists($class, 'navigation')
+            if (method_exists($class, 'navigation')
                 && ($this->_request_data['plugin_name'] == "asgard_{$component}")) {
                 $this->_request_data['expanded'] = true;
                 midcom_show_style('midgard_admin_asgard_navigation_section_header');
@@ -287,13 +287,13 @@ 
         if ($this->_is_selected($object)) {
             $css_class .= ' selected';
         }
-        if (   is_object($this->_object)
-            && (   $object->guid == $this->_object->guid
-                || (   is_a($this->_object, midcom_db_parameter::class)
+        if (is_object($this->_object)
+            && ($object->guid == $this->_object->guid
+                || (is_a($this->_object, midcom_db_parameter::class)
                     && $object->guid == $this->_object->parentguid))) {
             $css_class .= ' current';
         }
-        if ( !$object->can_do('midgard:update')) {
+        if (!$object->can_do('midgard:update')) {
             $css_class .= ' readonly';
         }
     }
@@ -309,7 +309,7 @@ 
         $types = [];
 
         // Get the types that might have special display conditions
-        if (   $this->_config->get('midgard_types')
+        if ($this->_config->get('midgard_types')
             && preg_match_all('/\|([a-z0-9\.\-_]+)/', $this->_config->get('midgard_types'), $regs)) {
             $types = $regs[1];
         }
@@ -317,7 +317,7 @@ 
         // Override with user selected
         // @TODO: Should this just include to the configuration selection, although it would break the consistency
         // of other similar preference sets, which simply override the global settings?
-        if (   midgard_admin_asgard_plugin::get_preference('midgard_types')
+        if (midgard_admin_asgard_plugin::get_preference('midgard_types')
             && preg_match_all('/\|([a-z0-9\.\-_]+)/', midgard_admin_asgard_plugin::get_preference('midgard_types'), $regs)) {
             $types = $regs[1];
         }
@@ -349,7 +349,7 @@ 
         $label_mapping = [];
         foreach ($types as $root_type) {
             // If the regular expression has been set, check which types should be shown
-            if (   $regexp !== '//'
+            if ($regexp !== '//'
                 && (boolean) preg_match($regexp, $root_type) == $exclude) {
                 continue;
             }
@@ -384,7 +384,7 @@ 
          * click if nothing is expanded
          */
         $types_shown = false;
-        if (    !empty($expanded_types)
+        if (!empty($expanded_types)
              && midgard_admin_asgard_plugin::get_preference('navigation_type') === 'dropdown') {
             $this->_draw_select_navigation();
             $types_shown = true;
@@ -423,7 +423,7 @@ 
             echo "    <li class=\"mgdschema-type\">";
 
             $dbaclass = midcom::get()->dbclassloader->get_midcom_class_name_for_mgdschema_object($type);
-            if (   $dbaclass
+            if ($dbaclass
                 && class_exists($dbaclass)) {
                 $object = new $dbaclass;
             } else {

lib/midcom/helper/reflector/copy.php

Spacing +3 added lines, -3 removed lines

@@ -278,7 +278,7 @@ 
         }
 
         // Override requested root object properties
-        if (   !empty($this->target->guid)
+        if (!empty($this->target->guid)
             && $target->guid === $this->target->guid) {
             foreach ($this->root_object_values as $name => $value) {
                 $target->$name = $value;
@@ -320,7 +320,7 @@ 
             return false;
         }
 
-        if (   !$this->_copy_data('parameters', $source, $target)
+        if (!$this->_copy_data('parameters', $source, $target)
             || !$this->_copy_data('metadata', $source, $target)
             || !$this->_copy_data('attachments', $source, $target)
             || !$this->_copy_data('privileges', $source, $target)) {
@@ -342,7 +342,7 @@ 
     {
         if ($this->$type) {
             $method = 'copy_' . $type;
-            if (   !$this->$method($source, $target)
+            if (!$this->$method($source, $target)
                 && $this->halt_on_errors) {
                 $this->errors[] = $this->_l10n->get('failed to copy ' . $type);
                 return false;

src/midcom/workflow/delete.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
             ])
             ->setRequired('object')
             ->setAllowedTypes('object', midcom_core_dbaobject::class)
-            ->setNormalizer('label', function ($options, $value) {
+            ->setNormalizer('label', function($options, $value) {
                 if ($value === null) {
                     return midcom_helper_reflector::get_object_title($options['object']);
                 }

src/midcom/datamanager/extension/transformer/imageTransformer.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
         }
         $result = [];
 
-        if (   !empty($array['file'])
+        if (!empty($array['file'])
             || !empty($array['identifier']) && substr($array['identifier'], 0, 8) === 'tmpfile-') {
             $result['file'] = parent::reverseTransform($array);
         } elseif (!empty($array['objects'])) {

src/midcom/datamanager/extension/transformer/attachmentTransformer.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
             return null;
         }
 
-        if (! $input instanceof midcom_db_attachment) {
+        if (!$input instanceof midcom_db_attachment) {
             throw new UnexpectedTypeException($input, midcom_db_attachment::class);
         }
 

src/midcom/datamanager/schema.php

Spacing +4 added lines, -4 removed lines

@@ -160,7 +160,7 @@ 
             'customdata' => []
         ], $config));
 
-        $normalize_widget = function (Options $options, $value) {
+        $normalize_widget = function(Options $options, $value) {
             if ($value == 'text') {
                 if (!empty($options['widget_config']['hideinput'])) {
                     return PasswordType::class;
@@ -185,7 +185,7 @@ 
             return $value;
         };
 
-        $normalize_storage = function (Options $options, $value) use ($name) {
+        $normalize_storage = function(Options $options, $value) use ($name) {
             $default = [
                 'location' => 'parameter',
                 'domain' => 'midcom.helper.datamanager2',
@@ -227,7 +227,7 @@ 
             return $value;
         };
 
-        $normalize_validation = function (Options $options, $value) {
+        $normalize_validation = function(Options $options, $value) {
             $validation = [];
 
             foreach ((array) $value as $key => $rule) {
@@ -239,7 +239,7 @@ 
                     $rule = ['type' => $rule];
                 } elseif (!array_key_exists('type', $rule)) {
                     throw new midcom_error("Missing validation rule type for rule {$key} on field {$options['name']}, this is a required option.");
-                } elseif (   $rule['type'] == 'compare'
+                } elseif ($rule['type'] == 'compare'
                           && !array_key_exists('compare_with', $rule)) {
                     throw new midcom_error("Missing compare_with option for compare type rule {$key} on field {$options['name']}, this is a required option.");
                 }