flack / openpsa

lib/midcom/helper/nav/backend.php

Spacing +3 added lines, -3 removed lines

@@ -270,7 +270,7 @@ 
         if (!array_key_exists($id, self::$_nodes)) {
             $node = new midcom_helper_nav_node($this, $topic);
 
-            if (    !$node->is_object_visible()
+            if (!$node->is_object_visible()
                 || !$node->is_readable_by($this->_user_id)) {
                 return MIDCOM_ERRFORBIDDEN;
             }
@@ -306,7 +306,7 @@ 
             });
             foreach ($leaves as $id => $leaf) {
                 $this->_leaves[$id] = $leaf;
-                $this->_loaded_leaves[$node->id][$id] =& $this->_leaves[$id];
+                $this->_loaded_leaves[$node->id][$id] = & $this->_leaves[$id];
             }
         }
     }
@@ -386,7 +386,7 @@ 
                 continue;
             }
 
-            if (   !$show_noentry
+            if (!$show_noentry
                 && self::$_nodes[$id]->noentry) {
                 // Hide "noentry" items
                 continue;

lib/org/openpsa/sales/handler/offer.php

Spacing +1 added lines, -1 removed lines

@@ -108,7 +108,7 @@
         $this->load_pdf_builder();
 
         $schemadb = schemadb::from_path($this->_config->get('schemadb_pdf'));
-        $field =& $schemadb->get_first()->get_field('deliverables');
+        $field = & $schemadb->get_first()->get_field('deliverables');
         $field['type_config']['constraints'][] = [
             'field' => 'salesproject',
             'op' => '=',

lib/org/openpsa/invoices/handler/scheduled.php

Braces +4 added lines, -2 removed lines

@@ -61,7 +61,8 @@ 
         try {
             $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($at_entry->arguments['deliverable']);
             $salesproject = org_openpsa_sales_salesproject_dba::get_cached($deliverable->salesproject);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return $invoice;
         }
@@ -103,7 +104,8 @@ 
                     $invoice[$fieldname] = '<a href="' . $sales_url . 'list/customer/' . $object->guid . '/">' . $invoice[$fieldname] . '</a>';
                 }
                 $invoice['index_' . $fieldname] = $object->get_label();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/midcom/helper/reflector/main.php

Braces +4 added lines, -2 removed lines

@@ -229,7 +229,8 @@ 
         if ($object instanceof mgdobject) {
             try {
                 $obj = midcom::get()->dbfactory->convert_midgard_to_midcom($object);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 return false;
             }
         } else {
@@ -658,7 +659,8 @@ 
         if (!isset(self::$_cache['name'][$key])) {
             try {
                 self::$_cache['name'][$key] = self::get($object)->get_name_property_nonstatic($object);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add('Could not get reflector instance for class ' . $key . ': ' . $e->getMessage(), MIDCOM_LOG_ERROR);
                 self::$_cache['name'][$key] = null;
             }

Spacing +7 added lines, -7 removed lines

@@ -405,7 +405,7 @@ 
 
         $label_prop = $this->get_label_property();
 
-        if (    is_string($label_prop)
+        if (is_string($label_prop)
              && $label_prop != 'guid'
              && $this->_mgd_reflector->property_exists($label_prop)) {
             $search_properties[$label_prop] = true;
@@ -466,7 +466,7 @@ 
                 continue;
             }
 
-            if (   !$ref->is_link($property)
+            if (!$ref->is_link($property)
                 && $ref->get_midgard_type($property) != MGD_TYPE_GUID) {
                 continue;
             }
@@ -530,7 +530,7 @@ 
                 return $schema_type;
             }
         }
-        if (   isset($extends[$schema_type])
+        if (isset($extends[$schema_type])
             && class_exists($extends[$schema_type])) {
             return $extends[$schema_type];
         }
@@ -583,7 +583,7 @@ 
         // Check for decorators first
         if (!empty($class_instance->__mgdschema_class_name__)) {
             $parent_class = $class_instance->__mgdschema_class_name__;
-            if (   !empty($class_instance->__object)
+            if (!empty($class_instance->__object)
                 && !$class_instance->__object instanceof $class_instance->__mgdschema_class_name__) {
                 $parent_class = get_class($class_instance->__object);
                 debug_add('mgdschema object class ' . $parent_class . ' is not an instance of ' . $class_instance->__mgdschema_class_name__, MIDCOM_LOG_INFO);
@@ -618,7 +618,7 @@ 
         $name_exceptions = $this->_config->get('name_exceptions');
         foreach ($name_exceptions as $class => $property) {
             if (midcom::get()->dbfactory->is_a($object, $class)) {
-                if (   $property !== false
+                if ($property !== false
                     && !$this->_mgd_reflector->property_exists($property)) {
                     debug_add("Matched class '{$key}' to '{$class}' via is_a but property '{$property}' does not exist", MIDCOM_LOG_ERROR);
                     self::$_cache['name'][$key] = false;
@@ -674,7 +674,7 @@ 
         if ($title_property === null) {
             $title_property = self::get_title_property($object);
         }
-        if (   empty($title_property)
+        if (empty($title_property)
             || !self::get($object)->property_exists($title_property)) {
             // Could not resolve valid property
             return false;
@@ -721,7 +721,7 @@ 
 
         foreach ($title_exceptions as $class => $property) {
             if (midcom::get()->dbfactory->is_a($object, $class)) {
-                if (   $property !== false
+                if ($property !== false
                     && !$this->_mgd_reflector->property_exists($property)) {
                     debug_add("Matched class '{$key}' to '{$class}' via is_a but property '{$property}' does not exist", MIDCOM_LOG_ERROR);
                     self::$_cache['title'][$key] = false;

src/midcom/grid/grid.php

Spacing +4 added lines, -4 removed lines

@@ -109,7 +109,7 @@ 
         if (file_exists(MIDCOM_STATIC_ROOT . $jqgrid_path . 'i18n/grid.locale-' . $language . '.js')) {
             $lang = $language;
         }
-        $head->add_jsfile(MIDCOM_STATIC_URL . $jqgrid_path . 'i18n/grid.locale-'. $lang . '.js');
+        $head->add_jsfile(MIDCOM_STATIC_URL . $jqgrid_path . 'i18n/grid.locale-' . $lang . '.js');
         $head->add_jsfile(MIDCOM_STATIC_URL . $jqgrid_path . 'jquery.jqgrid.min.js');
 
         \org_openpsa_widgets_ui::add_head_elements();
@@ -165,7 +165,7 @@ 
     public function set_option($key, $value, $autoquote_string = true)
     {
         $this->_raw_options[$key] = $value;
-        if (   $autoquote_string
+        if ($autoquote_string
             && is_string($value)) {
             $value = '"' . str_replace('"', '\\"', $value) . '"';
         } elseif ($value === true) {
@@ -198,7 +198,7 @@ 
     public function set_select_column($name, $label, $options, array $selectdata)
     {
         $selectstring = implode(';', array_map(
-            function ($key, $value) {
+            function($key, $value) {
                 return $key . ':' . $value;
             },
             array_keys($selectdata),
@@ -249,7 +249,7 @@ 
      */
     public function remove_column($name)
     {
-        if (   empty($name)
+        if (empty($name)
             || !array_key_exists($name, $this->_columns)) {
             throw new midcom_error('Invalid column name ' . $name);
         }

src/midcom/grid/provider.php

Spacing +3 added lines, -3 removed lines

@@ -232,7 +232,7 @@ 
 
     private function _convert_to_localdata()
     {
-        return "var " . $this->_grid->get_identifier() . '_entries = ' .  json_encode($this->get_rows()) . ";\n";
+        return "var " . $this->_grid->get_identifier() . '_entries = ' . json_encode($this->get_rows()) . ";\n";
     }
 
     private function _render_json()
@@ -266,7 +266,7 @@ 
             $this->_sort_field = $query['sidx'];
             $this->_sort_direction = strtoupper($query['sord']);
         }
-        if (   !empty($query['_search'])
+        if (!empty($query['_search'])
             && $query['_search'] === 'true') {
             foreach ($query as $field => $value) {
                 if (in_array($field, ['_search', 'nd', 'page', 'rows', 'sidx', 'sord'])) {
@@ -291,7 +291,7 @@ 
 
         $this->_total_rows = $qb->count();
 
-        if (   $this->_datatype == 'json'
+        if ($this->_datatype == 'json'
             && !empty($this->_results_per_page)) {
             $qb->set_limit($this->_results_per_page);
             if (!empty($this->_offset)) {

lib/org/openpsa/invoices/handler/invoice/items.php

Braces +4 added lines, -2 removed lines

@@ -48,7 +48,8 @@ 
                 if ($sales_url) {
                     $entry['deliverable'] = '<a href="' . $sales_url . 'deliverable/' . $deliverable->guid . '/">' . $entry['deliverable'] . '</a>';
                 }
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $entry['deliverable'] = '';
             }
             try {
@@ -57,7 +58,8 @@ 
                 if ($projects_url) {
                     $entry['task'] = '<a href="' . $projects_url . 'task/' . $task->guid . '/">' . $entry['task'] . '</a>';
                 }
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $entry['task'] = '';
             }
 

lib/org/openpsa/calendar/conflictmanager.php

Braces +4 added lines, -2 removed lines

@@ -195,7 +195,8 @@ 
             try {
                 $event = new org_openpsa_calendar_event_dba($member->event);
                 $set_as_modified = true;
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add("event_resource #{$member->id} links to bogus event #{$member->event}, skipping and removing", MIDCOM_LOG_WARN);
                 $member->delete();
                 return;
@@ -223,7 +224,8 @@ 
 
         try {
             $event = new org_openpsa_calendar_event_dba($member->eid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             debug_add("eventmember #{$member->id} links to bogus event #{$member->eid}, skipping and removing", MIDCOM_LOG_WARN);
             $member->delete();
             return;

Spacing +4 added lines, -4 removed lines

@@ -125,7 +125,7 @@ 
         }
         // TODO: Shared tasks need a separate check (different member object)
 
-        if (   !empty($this->busy_members)
+        if (!empty($this->busy_members)
             || !empty($this->busy_resources)) {
             //Unresolved conflicts (note return value is for conflicts not lack of them)
             midcom::get()->auth->drop_sudo();
@@ -188,7 +188,7 @@ 
         }
 
         if (array_key_exists($member->event, $modified_events)) {
-            $event =& $modified_events[$member->event];
+            $event = & $modified_events[$member->event];
             $set_as_modified = false;
         } else {
             try {
@@ -202,7 +202,7 @@ 
         }
         debug_add("overlap found in event {$event->title} (#{$event->id})");
 
-        if (   $event->tentative
+        if ($event->tentative
             && $rob_tentative) {
             debug_add('event is tentative, robbing resources');
             $event->resources = array_diff_key($event->resources, $this->_event->resources);
@@ -229,7 +229,7 @@ 
         }
         debug_add("overlap found in event {$event->title} (#{$event->id})");
 
-        if (   $event->tentative
+        if ($event->tentative
             && $rob_tentative) {
             debug_add('event is tentative, robbing participants');
             $event->participants = array_diff_key($event->participants, $this->_event->participants);

src/midcom/datamanager/extension/type/captchaType.php

Spacing +2 added lines, -2 removed lines

@@ -35,12 +35,12 @@
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
         $session_key = md5($builder->getForm()->getName() . '_session_key');
-        $builder->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) use ($session_key) {
+        $builder->addEventListener(FormEvents::POST_SUBMIT, function(FormEvent $event) use ($session_key) {
             $value = $event->getForm()->getData();
             $session = new midcom_services_session('midcom_datamanager_captcha');
             $l10n = midcom::get()->i18n->get_l10n('midcom.datamanager');
 
-            if (   !$session->exists($session_key)
+            if (!$session->exists($session_key)
                 || $value != $session->get($session_key)) {
                 $event->getForm()->addError(new FormError($l10n->get('captcha validation failed')));
             }