flack / openpsa

lib/midgard/admin/asgard/handler/object/manage.php

Braces +2 added lines, -1 removed lines

@@ -61,7 +61,8 @@
     {
         try {
             $this->_object = midcom::get()->dbfactory->get_object_by_guid($guid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             if (midcom_connection::get_error() == MGD_ERR_OBJECT_DELETED) {
                 $relocate = $this->router->generate('object_deleted', ['guid' => $guid]);
                 midcom::get()->relocate($relocate);

Spacing +7 added lines, -7 removed lines

@@ -123,7 +123,7 @@ 
         $this->_load_schemadb();
 
         // Hide the revision message
-        $field =& $this->schemadb->get_first()->get_field('_rcs_message');
+        $field = & $this->schemadb->get_first()->get_field('_rcs_message');
         $field['hidden'] = true;
 
         $this->datamanager = new datamanager($this->schemadb);
@@ -213,7 +213,7 @@ 
         }
         $this->_new_object = new $create_type();
 
-        if (   $handler_id == 'object_create_toplevel'
+        if ($handler_id == 'object_create_toplevel'
             || $handler_id == 'object_create_chooser') {
             midcom::get()->auth->require_user_do('midgard:create', null, $create_type);
 
@@ -269,11 +269,11 @@ 
             $type_to_link_to = midcom_helper_reflector::class_rewrite($this->_object->__mgdschema_class_name__);
             foreach ($link_properties as $child_property => $link) {
                 $linked_type = midcom_helper_reflector::class_rewrite($link['class']);
-                if (   midcom_helper_reflector::is_same_class($linked_type, $type_to_link_to)
-                    || (   $link['type'] == MGD_TYPE_GUID
+                if (midcom_helper_reflector::is_same_class($linked_type, $type_to_link_to)
+                    || ($link['type'] == MGD_TYPE_GUID
                         && $link['class'] === null)) {
                     $defaults[$child_property] = $this->_object->{$link['target']};
-                } elseif (   $child_property == $parent_property
+                } elseif ($child_property == $parent_property
                           && midcom_helper_reflector::is_same_class($new_type, $type_to_link_to)) {
                     $defaults[$child_property] = $this->_object->$parent_property;
                 }
@@ -301,7 +301,7 @@ 
     {
         if ($handler_id == 'object_create_chooser') {
             midcom_show_style('midgard_admin_asgard_popup_header');
-            if (   $this->_new_object->id
+            if ($this->_new_object->id
                 || isset($data['cancelled'])) {
                 $data['jsdata'] = $this->_object_to_jsdata($this->_new_object);
                 midcom_show_style('midgard_admin_asgard_object_create_after');
@@ -437,7 +437,7 @@ 
             $parent = midcom_helper_reflector_copy::get_parent_property($this->_object->__object);
             $this->_load_schemadb(get_class($this->_object), $parent, true);
             // Change the name for the parent field
-            $field =& $this->schemadb->get_first()->get_field($parent);
+            $field = & $this->schemadb->get_first()->get_field($parent);
             $field['title'] = $this->_l10n->get('choose the target');
         } else {
             $parent = null;

lib/org/openpsa/user/style/show-person-account.php

Indentation +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
             echo '<span class="toolbar_label">' . $data['l10n_midcom']->get('delete') . '</span></a></li>';
             if (    midcom::get()->config->get('auth_allow_trusted') === true
                  && $data['person']->can_do('org.openpsa.user:su')) {
-                 echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '" />' . $data['l10n']->get('switch to user') . "</a></li>\n";
+                    echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '" />' . $data['l10n']->get('switch to user') . "</a></li>\n";
             }
             echo "</ul>\n";
         }

Spacing +4 added lines, -4 removed lines

@@ -13,7 +13,7 @@ 
             $formatter = $data['l10n']->get_formatter();
             echo '<p>' . $data['l10n']->get('last login') . ': ' . $formatter->datetime($lastlogin) . "</p>\n";
         }
-        if (   $data['person']->id == midcom_connection::get_user()
+        if ($data['person']->id == midcom_connection::get_user()
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $workflow = new midcom\workflow\datamanager;
             echo '<ul class="area_toolbar">';
@@ -22,9 +22,9 @@ 
                 'object' => $data['person'],
                 'label' => $data['l10n']->get('account')
             ]);
-            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]). '" ' . $workflow->render_attributes() . '"  class="button">';
+            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]) . '" ' . $workflow->render_attributes() . '"  class="button">';
             echo '<span class="toolbar_label">' . $data['l10n_midcom']->get('delete') . '</span></a></li>';
-            if (    midcom::get()->config->get('auth_allow_trusted') === true
+            if (midcom::get()->config->get('auth_allow_trusted') === true
                  && $data['person']->can_do('org.openpsa.user:su')) {
                  echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '" />' . $data['l10n']->get('switch to user') . "</a></li>\n";
             }
@@ -32,7 +32,7 @@ 
         }
     } else {
         echo '<p><span class="metadata">' . $data['l10n']->get("no account") . '</span></p>';
-        if (   $data['person']->id == midcom_connection::get_user()
+        if ($data['person']->id == midcom_connection::get_user()
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $workflow = new midcom\workflow\datamanager;
             echo '<ul class="area_toolbar">';

lib/org/openpsa/user/handler/person/view.php

Spacing +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
         $this->add_breadcrumb('', $this->_person->get_label());
 
         $auth = midcom::get()->auth;
-        if (   $this->_person->id == midcom_connection::get_user()
+        if ($this->_person->id == midcom_connection::get_user()
             || $auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $buttons = [];
             $workflow = $this->get_workflow('datamanager');
@@ -49,7 +49,7 @@ 
                 $delete_workflow = $this->get_workflow('delete', ['object' => $this->_person]);
                 $buttons[] = $delete_workflow->get_button($this->router->generate('user_delete', ['guid' => $this->_person->guid]));
             }
-            if (   midcom_connection::is_user($this->_person)
+            if (midcom_connection::is_user($this->_person)
                 && $this->_person->can_do('midgard:privileges')) {
                 $buttons[] = $workflow->get_button($this->router->generate('user_privileges', ['guid' => $this->_person->guid]), [
                     MIDCOM_TOOLBAR_LABEL => $this->_l10n->get("permissions"),

lib/org/openpsa/directmarketing/viewer.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
      */
     private function _populate_node_toolbar()
     {
-        if (   $this->_topic->can_do('midgard:update')
+        if ($this->_topic->can_do('midgard:update')
             && $this->_topic->can_do('midcom:component_config')) {
             $workflow = $this->get_workflow('datamanager');
             $this->_node_toolbar->add_item($workflow->get_button($this->router->generate('config'), [

lib/org/openpsa/relatedto/style/show_entries_list.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     <?php
         //index is needed for sorting
         echo "'index_name',";
-echo "'" . midcom::get()->i18n->get_string('entry title', 'org.openpsa.relatedto') ."',";
+echo "'" . midcom::get()->i18n->get_string('entry title', 'org.openpsa.relatedto') . "',";
 echo "'" . midcom::get()->i18n->get_string('entry text', 'org.openpsa.relatedto') . "',";
 echo "'" . midcom::get()->i18n->get_string('followup', 'org.openpsa.relatedto') . "',";
 echo "'index_object',";

lib/org/openpsa/documents/style/show-search-form-simple.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 $search_config = org_openpsa_widgets_ui::get_search_providers();
-if (   array_key_exists('org.openpsa.documents', $search_config)
+if (array_key_exists('org.openpsa.documents', $search_config)
     && midcom::get()->indexer->enabled()) {
     $url = $data['router']->generate('search'); ?>
 <div class="area" id="document_search">

lib/org/openpsa/contacts/handler/frontpage.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
         }
         $this->_view_toolbar->add_items($buttons);
 
-        if (   $this->_topic->can_do('midgard:update')
+        if ($this->_topic->can_do('midgard:update')
             && $this->_topic->can_do('midcom:component_config')) {
             $this->_node_toolbar->add_item($workflow->get_button($this->router->generate('config'), [
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),

lib/org/openpsa/contacts/handler/group/view.php

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
             ];
         }
 
-        if (   midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_contacts_person_dba::class)
+        if (midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_contacts_person_dba::class)
             && $this->group->can_do('midgard:create')) {
                 $buttons[] = $workflow->get_button($this->router->generate('person_new_group', ['guid' => $this->group->guid]), [
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('create person'),
@@ -58,7 +58,7 @@ 
 
         $siteconfig = org_openpsa_core_siteconfig::get_instance();
         $user_url = $siteconfig->get_node_full_url('org.openpsa.user');
-        if (   $user_url
+        if ($user_url
             && midcom::get()->auth->can_user_do('org.openpsa.user:access', null, org_openpsa_user_interface::class)) {
             $buttons[] = [
                 MIDCOM_TOOLBAR_URL => $user_url . "group/{$this->group->guid}/",

lib/org/openpsa/invoices/handler/list.php

Spacing +1 added lines, -1 removed lines

@@ -171,7 +171,7 @@
     {
         $this->prepare_toolbar(false);
 
-        if (   $this->_topic->can_do('midgard:update')
+        if ($this->_topic->can_do('midgard:update')
             && $this->_topic->can_do('midcom:component_config')) {
             $workflow = $this->get_workflow('datamanager');
             $this->_node_toolbar->add_item($workflow->get_button($this->router->generate('config'), [

Braces +6 added lines, -3 removed lines

@@ -106,7 +106,8 @@ 
                 $customer = org_openpsa_contacts_group_dba::get_cached($invoice->customer);
                 $entry['customer'] = "<a href=\"{$this->_request_data['invoices_url']}list/customer/all/{$customer->guid}/\">" . $customer->get_label() . "</a>";
                 $entry['index_customer'] = $customer->get_label();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $entry['customer'] = '';
                 $entry['index_customer'] = '';
             }
@@ -117,7 +118,8 @@ 
                 $contact = org_openpsa_contacts_person_dba::get_cached($invoice->customerContact);
                 $entry['contact'] = "<a href=\"{$this->_request_data['invoices_url']}list/customer/all/{$contact->guid}/\">" . $contact->get_label() . "</a>";
                 $entry['index_contact'] = $contact->get_label();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $entry['contact'] = '';
                 $entry['index_contact'] = '';
             }
@@ -282,7 +284,8 @@ 
     {
         try {
             $this->_customer = new org_openpsa_contacts_group_dba($guid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $this->_customer = new org_openpsa_contacts_person_dba($guid);
         }
         $data['customer'] = $this->_customer;