flack / openpsa

lib/org/openpsa/invoices/invoice.php

Spacing +1 added lines, -1 removed lines

@@ -237,7 +237,7 @@
                 $invoice_item->pricePerUnit = $deliverable->pricePerUnit;
                 $invoice_item->deliverable = $deliverable->id;
                 //calculate price
-                if (   $deliverable->invoiceByActualUnits
+                if ($deliverable->invoiceByActualUnits
                     || $deliverable->plannedUnits == 0) {
                     $invoice_item->units = $hours;
                 } else {

Braces +6 added lines, -3 removed lines

@@ -128,7 +128,8 @@ 
             try {
                 $task = new org_openpsa_projects_task_dba($id);
                 $task->update_cache();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
             }
         }
 
@@ -293,14 +294,16 @@ 
         if (!empty($this->customer)) {
             try {
                 return org_openpsa_contacts_group_dba::get_cached($this->customer);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }
         if (!empty($this->customerContact)) {
             try {
                 return org_openpsa_contacts_person_dba::get_cached($this->customerContact);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/org/openpsa/sales/calculator/default.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
 
     private function get_units($units = false)
     {
-        if (   $this->_deliverable->invoiceByActualUnits
+        if ($this->_deliverable->invoiceByActualUnits
             || $this->_deliverable->plannedUnits == 0) {
             // In most cases we calculate the price based on the actual units entered
             return $units ?: $this->_deliverable->units;

lib/org/openpsa/directmarketing/sender/backend/email.php

Indentation +11 added lines, -11 removed lines

@@ -163,17 +163,17 @@
     }
 
     /**
-    * Inserts a link detector to the given HTML source. All outgoing
-    * HTTP links in the source HTML are replaced with the given
-    * link detector address so that the token "URL" is replaced with
-    * encoded form of the original link. It is expected that the link detector
-    * address points to a script that records the passed link and
-    * forwards the client to the real link target.
-    *
-    * @param string $html the HTML source
-    * @param string $address the link detector address
-    * @return string HTML source with the link detector
-    */
+     * Inserts a link detector to the given HTML source. All outgoing
+     * HTTP links in the source HTML are replaced with the given
+     * link detector address so that the token "URL" is replaced with
+     * encoded form of the original link. It is expected that the link detector
+     * address points to a script that records the passed link and
+     * forwards the client to the real link target.
+     *
+     * @param string $html the HTML source
+     * @param string $address the link detector address
+     * @return string HTML source with the link detector
+     */
     private function _insert_link_detector($html, $address)
     {
         $address = addslashes($address);

Spacing +2 added lines, -2 removed lines

@@ -34,7 +34,7 @@ 
         //Check for bounce detector usage
         if (!empty($config['bounce_detector_address'])) {
             //Force bouncer as backend if default specified
-            if (   empty($config['mail_send_backend'])
+            if (empty($config['mail_send_backend'])
                 || $config['mail_send_backend'] == 'try_default') {
                 $config['mail_send_backend'] = 'bouncer';
             }
@@ -179,7 +179,7 @@ 
         $address = addslashes($address);
         return preg_replace_callback(
             '/href="(http:\/\/.*?)"/i',
-            function ($match) use ($address) {
+            function($match) use ($address) {
                 return 'href="' . str_replace("URL", rawurlencode($match[1]), $address) . '"';
             },
             $html);

lib/midcom/connection.php

Braces +2 added lines, -1 removed lines

@@ -132,7 +132,8 @@
 
         try {
             $user = new midgard_user($login_tokens);
-        } catch (mgd_exception $e) {
+        }
+        catch (mgd_exception $e) {
             return false;
         }
         if (!$trusted && !self::verify_password($password, $user->password)) {

Spacing +1 added lines, -1 removed lines

@@ -261,7 +261,7 @@
             if ($part === '') {
                 continue;
             }
-            if (    midcom::get()->config->get('theme')
+            if (midcom::get()->config->get('theme')
                  && !$args_started
                  && self::check_page_exists($part)) {
                 $page_style .= '/' . $part;

lib/midcom/core/dbaobject.php

Braces +2 added lines, -1 removed lines

@@ -93,7 +93,8 @@
             try {
                 $mgdschemaclass = $this->__mgdschema_class_name__;
                 $this->__object = new $mgdschemaclass($id);
-            } catch (mgd_exception $e) {
+            }
+            catch (mgd_exception $e) {
                 debug_add('Constructing ' . $this->__mgdschema_class_name__ . ' object ' . $id . ' failed, reason: ' . $e->getMessage(), MIDCOM_LOG_WARN);
                 throw new midcom_error_midgard($e, $id);
             }

Spacing +2 added lines, -2 removed lines

@@ -106,7 +106,7 @@ 
         if (is_object($id)) {
             $this->__object = midcom::get()->dbfactory->convert_midcom_to_midgard($id);
         } else {
-            if (   is_int($id)
+            if (is_int($id)
                 && $id < 1) {
                 throw new midcom_error($id . ' is not a valid database ID');
             }
@@ -120,7 +120,7 @@ 
             }
 
             //Some useful information for performance tuning
-            if (   midcom::get()->config->get('log_level') >= MIDCOM_LOG_DEBUG
+            if (midcom::get()->config->get('log_level') >= MIDCOM_LOG_DEBUG
                 && $this->__object->guid) {
                 static $guids = [];
                 static $total = 0;

lib/midcom/helper/_dbfactory.php

Braces +8 added lines, -4 removed lines

@@ -44,7 +44,8 @@ 
     {
         try {
             $tmp = midgard_object_class::get_object_by_guid($guid);
-        } catch (mgd_exception $e) {
+        }
+        catch (mgd_exception $e) {
             debug_add('Loading object by GUID ' . $guid . ' failed, reason: ' . $e->getMessage(), MIDCOM_LOG_INFO);
 
             throw new midcom_error_midgard($e, $guid);
@@ -237,7 +238,8 @@ 
                 $parent_data = [
                     $parent->__midcom_class_name__ => $parent_guid
                 ];
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $parent_data = [
                     '' => null
                 ];
@@ -251,7 +253,8 @@ 
 
         try {
             return $this->get_cached($classname, $parent_guid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             return null;
         }
     }
@@ -310,7 +313,8 @@ 
                 if ($the_object === null) {
                     try {
                         $the_object = $this->get_object_by_guid($object_guid);
-                    } catch (midcom_error $e) {
+                    }
+                    catch (midcom_error $e) {
                         return ['' => null];
                     }
                 }

Spacing +6 added lines, -6 removed lines

@@ -48,7 +48,7 @@ 
             throw new midcom_error_midgard($e, $guid);
         }
         $person_class = midcom::get()->config->get('person_class');
-        if (   get_class($tmp) == 'midgard_person'
+        if (get_class($tmp) == 'midgard_person'
             && $person_class != 'midgard_person') {
             $tmp = new $person_class($guid);
         }
@@ -79,7 +79,7 @@ 
         }
         $object = new $classname($src);
         $cache[$classname][$object->guid] = $object;
-        $cache[$classname][$object->id] =& $cache[$classname][$object->guid];
+        $cache[$classname][$object->id] = & $cache[$classname][$object->guid];
         return $cache[$classname][$object->guid];
     }
 
@@ -182,14 +182,14 @@ 
             return true;
         }
 
-        if (   isset($object->__object)
+        if (isset($object->__object)
             && is_object($object->__object)
             && $object->__object instanceof $class) {
             // Decorator whose MgdSchema object matches
             return true;
         }
 
-        if (   isset($object->__mgdschema_class_name__)
+        if (isset($object->__mgdschema_class_name__)
             && $object->__mgdschema_class_name__ == $class) {
             // Decorator without object instantiated, check class match
             return true;
@@ -212,7 +212,7 @@ 
         $parent_data = $this->_get_parent_guid_cached($object->guid, $object);
 
         $parent_guid = current($parent_data);
-        if (   empty($parent_guid)
+        if (empty($parent_guid)
             || $parent_guid === $object->guid) {
             return null;
         }
@@ -415,7 +415,7 @@ 
                 ];
             }
 
-            if (   $parent_property
+            if ($parent_property
                 && $reflector->get_link_target($parent_property)) {
                 $target_class = $reflector->get_link_name($parent_property);
                 if ($target_class == 'midgard_person') {

lib/midcom/core/group.php

Braces +2 added lines, -1 removed lines

@@ -94,7 +94,8 @@
             }
             try {
                 $this->_storage = new midgard_group($id);
-            } catch (Exception $e) {
+            }
+            catch (Exception $e) {
                 debug_add('Tried to load a midcom_core_group, but got error ' . $e->getMessage(), MIDCOM_LOG_ERROR);
                 debug_print_r('Passed argument was:', $id);
                 throw new midcom_error($e->getMessage());

lib/org/openpsa/relatedto/exec/delete_dangling_links.php

Braces +2 added lines, -1 removed lines

@@ -27,7 +27,8 @@
     try {
         midcom::get()->dbfactory->get_object_by_guid($result->fromGuid);
         midcom::get()->dbfactory->get_object_by_guid($result->toGuid);
-    } catch (midcom_error $e) {
+    }
+    catch (midcom_error $e) {
         echo $i . "/" . $total . ": Deleting relatedto #" . $result->id . "\n";
         $result->delete();
     }

lib/midcom/helper/configuration.php

Spacing +4 added lines, -4 removed lines

@@ -144,7 +144,7 @@ 
     private function _update_cache()
     {
         $this->_merged = $this->_global;
-        if (   !empty($this->_local)
+        if (!empty($this->_local)
             && is_array($this->_local)) {
             $this->_merged = array_merge($this->_merged, $this->_local);
         }
@@ -185,7 +185,7 @@ 
      */
     public function store(array $params, $reset = true)
     {
-        if (   !$this->_object_stored
+        if (!$this->_object_stored
             && $this->_object) {
             $this->_store_from_object();
         }
@@ -269,7 +269,7 @@ 
      */
     public function get_all()
     {
-        if (   !$this->_object_stored
+        if (!$this->_object_stored
             && $this->_object) {
             $this->_store_from_object();
         }
@@ -285,7 +285,7 @@ 
      */
     public function exists($key)
     {
-        if (   !$this->_object_stored
+        if (!$this->_object_stored
             && $this->_object) {
             $this->_store_from_object();
         }