Completed
Pull Request — master (#198)
by
unknown
19:02
created
lib/org/openpsa/documents/handler/directory/create.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,6 +50,6 @@
 block discarded – undo
50 50
         $indexer = new org_openpsa_documents_midcom_indexer($this->_topic);
51 51
         $indexer->index($controller->get_datamanager());
52 52
 
53
-        return $controller->get_datamanager()->get_storage()->get_value()->name. "/";
53
+        return $controller->get_datamanager()->get_storage()->get_value()->name . "/";
54 54
     }
55 55
 }
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/handler/invoice/crud.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -130,13 +130,13 @@
 block discarded – undo
130 130
      */
131 131
     private function modify_schema(schema $schema)
132 132
     {
133
-        $vat_field =& $schema->get_field('vat');
134
-        $pdf_field =& $schema->get_field('pdf_file');
135
-        $due_field =& $schema->get_field('due');
136
-        $sent_field =& $schema->get_field('sent');
137
-        $paid_field =& $schema->get_field('paid');
138
-        $customer_field =& $schema->get_field('customer');
139
-        $contact_field =& $schema->get_field('customerContact');
133
+        $vat_field = & $schema->get_field('vat');
134
+        $pdf_field = & $schema->get_field('pdf_file');
135
+        $due_field = & $schema->get_field('due');
136
+        $sent_field = & $schema->get_field('sent');
137
+        $paid_field = & $schema->get_field('paid');
138
+        $customer_field = & $schema->get_field('customer');
139
+        $contact_field = & $schema->get_field('customerContact');
140 140
 
141 141
         // Fill VAT select
142 142
         $vat_array = explode(',', $this->_config->get('vat_percentages'));
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,8 @@  discard block
 block discarded – undo
48 48
             // We're creating invoice for chosen customer
49 49
             try {
50 50
                 $this->customer = new org_openpsa_contacts_group_dba($company);
51
-            } catch (midcom_error $e) {
51
+            }
52
+            catch (midcom_error $e) {
52 53
                 $contact = new org_openpsa_contacts_person_dba($company);
53 54
                 $this->contact_id = $contact->id;
54 55
             }
@@ -155,7 +156,8 @@  discard block
 block discarded – undo
155 156
             if (!empty($this->invoice->customer)) {
156 157
                 try {
157 158
                     $this->customer = org_openpsa_contacts_group_dba::get_cached($this->invoice->customer);
158
-                } catch (midcom_error $e) {
159
+                }
160
+                catch (midcom_error $e) {
159 161
                     $customer_field['hidden'] = true;
160 162
                     $e->log();
161 163
                 }
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/midcom/indexer.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -9,11 +9,11 @@
 block discarded – undo
9 9
 use midcom\datamanager\indexer\client;
10 10
 use midcom\datamanager\datamanager;
11 11
 
12
- /**
13
- * Indexer client class
14
- *
15
- * @package org.openpsa.invoices
16
- */
12
+    /**
13
+     * Indexer client class
14
+     *
15
+     * @package org.openpsa.invoices
16
+     */
17 17
 class org_openpsa_invoices_midcom_indexer extends client
18 18
 {
19 19
     public function prepare_document(midcom_services_indexer_document &$document, datamanager $dm)
Please login to merge, or discard this patch.
src/midcom/datamanager/storage/dbanode.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,8 @@
 block discarded – undo
30 30
         $this->config = $config;
31 31
     }
32 32
 
33
-    protected function cast($value) {
33
+    protected function cast($value)
34
+    {
34 35
         if ($this->config['type'] == 'number' && !is_numeric($value)) {
35 36
             $value = (float) $value;
36 37
         }
Please login to merge, or discard this patch.
lib/net/nemein/wiki/handler/edit.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
         foreach ($this->schemadb->all() as $schema) {
53 53
             $schema->set('operations', $operations);
54 54
             if ($schema->has_field('title')) {
55
-                $field =& $schema->get_field('title');
55
+                $field = & $schema->get_field('title');
56 56
                 $field['hidden'] = true;
57 57
             }
58 58
         }
Please login to merge, or discard this patch.
lib/org/openpsa/user/handler/group/privileges.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 
23 23
         // Get the calendar root event
24 24
         if ($root_event = org_openpsa_calendar_interface::find_root_event()) {
25
-            $field =& $schemadb->get('default')->get_field('calendar');
25
+            $field = & $schemadb->get('default')->get_field('calendar');
26 26
             $field['type_config']['privilege_object'] = $root_event;
27 27
             $field['type_config']['assignee'] = 'group:' . $group->guid;
28 28
         }
Please login to merge, or discard this patch.
lib/org/openpsa/user/handler/person/privileges.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 
23 23
         // Get the calendar root event
24 24
         if ($root_event = org_openpsa_calendar_interface::find_root_event()) {
25
-            $field =& $schemadb->get('default')->get_field('calendar');
25
+            $field = & $schemadb->get('default')->get_field('calendar');
26 26
             $field['type_config']['privilege_object'] = $root_event;
27 27
             $field['type_config']['assignee'] = 'user:' . $person->guid;
28 28
         }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/component/configuration.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -306,7 +306,7 @@
 block discarded – undo
306 306
                  * See http://trac.midgard-project.org/ticket/1442
307 307
                 $topic->set_parameter($this->_request_data['name'], var_export($value, true));
308 308
                  */
309
-                 continue;
309
+                    continue;
310 310
             }
311 311
 
312 312
             if ($value === false) {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -115,11 +115,11 @@  discard block
 block discarded – undo
115 115
                 $fields[$key] = $this->_detect_schema($key, $value);
116 116
             }
117 117
 
118
-            if (   !isset($this->_request_data['config']->_local[$key])
118
+            if (!isset($this->_request_data['config']->_local[$key])
119 119
                 || $this->_request_data['config']->_local[$key] == $this->_request_data['config']->_global[$key]) {
120 120
                 // No local configuration setting, note to user that this is the global value
121 121
                 $fields[$key]['title'] = $schema->get_l10n()->get($fields[$key]['title']);
122
-                $fields[$key]['title'] .= " <span class=\"global\">(" . $this->_l10n->get('global value') .")</span>";
122
+                $fields[$key]['title'] .= " <span class=\"global\">(" . $this->_l10n->get('global value') . ")</span>";
123 123
             }
124 124
         }
125 125
 
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
     private function _save_topic(midcom_db_topic $topic, $config)
288 288
     {
289 289
         foreach ($this->_request_data['config']->_global as $global_key => $global_value) {
290
-            if (   isset($config[$global_key])
290
+            if (isset($config[$global_key])
291 291
                 && $config[$global_key] != $global_value) {
292 292
                 continue;
293 293
                 // Skip the ones we will set next
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
         }
301 301
 
302 302
         foreach ($config as $key => $value) {
303
-            if (   is_array($value)
303
+            if (is_array($value)
304 304
                 || is_object($value)) {
305 305
                 /**
306 306
                  * See http://trac.midgard-project.org/ticket/1442
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/archive.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -409,7 +409,8 @@
 block discarded – undo
409 409
             foreach ($this->_articles as $article_counter => $article) {
410 410
                 try {
411 411
                     $data['datamanager']->set_storage($article);
412
-                } catch (midcom_error $e) {
412
+                }
413
+                catch (midcom_error $e) {
413 414
                     $e->log();
414 415
                     continue;
415 416
                 }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -134,8 +134,8 @@  discard block
 block discarded – undo
134 134
         $year_data = [];
135 135
         $first_post = $this->_compute_welcome_first_post();
136 136
         $this->_request_data['first_post'] = $first_post;
137
-        $this->_request_data['total_count'] =& $total_count;
138
-        $this->_request_data['year_data'] =& $year_data;
137
+        $this->_request_data['total_count'] = & $total_count;
138
+        $this->_request_data['year_data'] = & $year_data;
139 139
         if (!$first_post) {
140 140
             return;
141 141
         }
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
         switch ($handler_id) {
272 272
             case 'archive-year-category':
273 273
                 $data['category'] = trim(strip_tags($args[1]));
274
-                if (   $data['datamanager']->get_schema('default')->has_field('categories')
274
+                if ($data['datamanager']->get_schema('default')->has_field('categories')
275 275
                     && !$data['datamanager']->get_schema('default')->get_field('categories')['type_config']['allow_multiple']) {
276 276
                     $qb->add_constraint('extra1', '=', (string) $data['category']);
277 277
                 } else {
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
             throw new midcom_error_notfound("The year '{$year}' is not a valid year identifier.");
361 361
         }
362 362
 
363
-        if (   $month < 1
363
+        if ($month < 1
364 364
             || $month > 12) {
365 365
             throw new midcom_error_notfound("The year {$month} is not a valid year identifier.");
366 366
         }
Please login to merge, or discard this patch.