@@ -105,7 +105,7 @@ discard block |
||
105 | 105 | |
106 | 106 | $this->_add_visibility_checks(); |
107 | 107 | |
108 | - if ( empty($this->_limit) |
|
108 | + if (empty($this->_limit) |
|
109 | 109 | && empty($this->_offset)) { |
110 | 110 | // No point to do windowing |
111 | 111 | $newresult = $this->_execute_and_check_privileges(); |
@@ -150,7 +150,7 @@ discard block |
||
150 | 150 | } |
151 | 151 | $this->_query->set_limit($window_size); |
152 | 152 | |
153 | - while ( ($resultset = $this->_execute_and_check_privileges()) |
|
153 | + while (($resultset = $this->_execute_and_check_privileges()) |
|
154 | 154 | || $this->denied > $denied) { |
155 | 155 | $size = count($resultset); |
156 | 156 | $total_size = $size + ($this->denied - $denied); |
@@ -57,7 +57,8 @@ |
||
57 | 57 | $classname = $this->_real_class; |
58 | 58 | try { |
59 | 59 | $result[] = new $classname($object); |
60 | - } catch (midcom_error $e) { |
|
60 | + } |
|
61 | + catch (midcom_error $e) { |
|
61 | 62 | if ($e->getCode() == MIDCOM_ERRFORBIDDEN) { |
62 | 63 | $this->denied++; |
63 | 64 | } |
@@ -25,7 +25,8 @@ |
||
25 | 25 | { |
26 | 26 | try { |
27 | 27 | $viewer->register_plugin_namespace('__feeds', ['rss' => ['class' => __CLASS__]]); |
28 | - } catch (midcom_error $e) { |
|
28 | + } |
|
29 | + catch (midcom_error $e) { |
|
29 | 30 | $e->log(); |
30 | 31 | } |
31 | 32 | } |
@@ -41,7 +41,7 @@ discard block |
||
41 | 41 | |
42 | 42 | // Hide the articles that have the publish time in the future and if |
43 | 43 | // the user is not administrator |
44 | - if ( $this->_config->get('enable_scheduled_publishing') |
|
44 | + if ($this->_config->get('enable_scheduled_publishing') |
|
45 | 45 | && !midcom::get()->auth->admin) { |
46 | 46 | // Show the article only if the publishing time has passed or the viewer |
47 | 47 | // is the author |
@@ -83,14 +83,14 @@ discard block |
||
83 | 83 | |
84 | 84 | private function _add_pseudo_leaves(array &$leaves) |
85 | 85 | { |
86 | - if ( $this->_config->get('archive_enable') |
|
86 | + if ($this->_config->get('archive_enable') |
|
87 | 87 | && $this->_config->get('archive_in_navigation')) { |
88 | 88 | $leaves["{$this->_topic->id}_ARCHIVE"] = [ |
89 | 89 | MIDCOM_NAV_URL => "archive/", |
90 | 90 | MIDCOM_NAV_NAME => $this->_l10n->get('archive'), |
91 | 91 | ]; |
92 | 92 | } |
93 | - if ( $this->_config->get('rss_enable') |
|
93 | + if ($this->_config->get('rss_enable') |
|
94 | 94 | && $this->_config->get('feeds_in_navigation')) { |
95 | 95 | $leaves[self::LEAFID_FEEDS] = [ |
96 | 96 | MIDCOM_NAV_URL => "feeds/", |
@@ -98,7 +98,7 @@ discard block |
||
98 | 98 | ]; |
99 | 99 | } |
100 | 100 | |
101 | - if ( $this->_config->get('categories_in_navigation') |
|
101 | + if ($this->_config->get('categories_in_navigation') |
|
102 | 102 | && $this->_config->get('categories') != '') { |
103 | 103 | $categories = explode(',', $this->_config->get('categories')); |
104 | 104 | foreach ($categories as $category) { |
@@ -109,14 +109,14 @@ discard block |
||
109 | 109 | } |
110 | 110 | } |
111 | 111 | |
112 | - if ( $this->_config->get('archive_years_in_navigation') |
|
112 | + if ($this->_config->get('archive_years_in_navigation') |
|
113 | 113 | && $this->_config->get('archive_years_enable')) { |
114 | 114 | $qb = midcom_db_article::new_query_builder(); |
115 | 115 | $qb->add_constraint('topic', '=', $this->_topic->id); |
116 | 116 | |
117 | 117 | // Hide the articles that have the publish time in the future and if |
118 | 118 | // the user is not administrator |
119 | - if ( $this->_config->get('enable_scheduled_publishing') |
|
119 | + if ($this->_config->get('enable_scheduled_publishing') |
|
120 | 120 | && !midcom::get()->auth->admin) { |
121 | 121 | // Show the article only if the publishing time has passed or the viewer |
122 | 122 | // is the author |
@@ -73,7 +73,7 @@ |
||
73 | 73 | } |
74 | 74 | } |
75 | 75 | |
76 | - if ( $this->_topic->can_do('midgard:update') |
|
76 | + if ($this->_topic->can_do('midgard:update') |
|
77 | 77 | && $this->_topic->can_do('midcom:component_config')) { |
78 | 78 | $buttons[] = $workflow->get_button('config/', [ |
79 | 79 | MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'), |
@@ -94,7 +94,7 @@ |
||
94 | 94 | 'midcom' => [ |
95 | 95 | 'style-init' => '', |
96 | 96 | 'style-finish' => '', |
97 | - ] |
|
97 | + ] |
|
98 | 98 | ], |
99 | 99 | 'nodes' => [], |
100 | 100 | ]; |
@@ -22,7 +22,7 @@ discard block |
||
22 | 22 | |
23 | 23 | public function __construct(array &$data) |
24 | 24 | { |
25 | - $this->_data =& $data; |
|
25 | + $this->_data = & $data; |
|
26 | 26 | midcom::get()->head->enable_jquery_ui(['accordion']); |
27 | 27 | } |
28 | 28 | |
@@ -33,11 +33,11 @@ discard block |
||
33 | 33 | return; |
34 | 34 | } |
35 | 35 | |
36 | - if ( midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_style') |
|
37 | - && ( $this->_data['handler_id'] !== 'object_create' |
|
36 | + if (midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_style') |
|
37 | + && ($this->_data['handler_id'] !== 'object_create' |
|
38 | 38 | || $this->_data['current_type'] == 'midgard_element')) { |
39 | 39 | $help_element = $this->_get_help_style_elementnames($this->_data['object']); |
40 | - } elseif ( midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_element') |
|
40 | + } elseif (midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_element') |
|
41 | 41 | && $this->_data['handler_id'] !== 'object_create') { |
42 | 42 | $help_element = $this->_get_help_element(); |
43 | 43 | } |
@@ -49,7 +49,7 @@ discard block |
||
49 | 49 | |
50 | 50 | private function _get_help_element() |
51 | 51 | { |
52 | - if ( empty($this->_data['object']->name) |
|
52 | + if (empty($this->_data['object']->name) |
|
53 | 53 | || empty($this->_data['object']->style)) { |
54 | 54 | // We cannot help with empty elements |
55 | 55 | return; |
@@ -62,7 +62,8 @@ |
||
62 | 62 | try { |
63 | 63 | $this->__object = call_user_func([$this->__midcom_class_name__, 'get_cached'], $this->__identifier); |
64 | 64 | return true; |
65 | - } catch (midcom_error $e) { |
|
65 | + } |
|
66 | + catch (midcom_error $e) { |
|
66 | 67 | $e->log(); |
67 | 68 | } |
68 | 69 | return false; |
@@ -158,7 +158,7 @@ discard block |
||
158 | 158 | private static function _check_permissions($deleted) |
159 | 159 | { |
160 | 160 | // PONDER: Check for some generic user privilege instead ?? |
161 | - if ( $deleted |
|
161 | + if ($deleted |
|
162 | 162 | && !midcom_connection::is_admin() |
163 | 163 | && !midcom::get()->auth->is_component_sudo()) { |
164 | 164 | debug_add('Non-admins are not allowed to list deleted objects', MIDCOM_LOG_ERROR); |
@@ -248,7 +248,7 @@ discard block |
||
248 | 248 | 'target' => $ref->get_link_target($field) |
249 | 249 | ]; |
250 | 250 | $linked_class = $ref->get_link_name($field); |
251 | - if ( empty($linked_class) |
|
251 | + if (empty($linked_class) |
|
252 | 252 | && $info['type'] === MGD_TYPE_GUID) { |
253 | 253 | // Guid link without class specification, valid for all classes |
254 | 254 | if (empty($info['target'])) { |
@@ -298,7 +298,7 @@ discard block |
||
298 | 298 | $field_type = $field_data['type']; |
299 | 299 | $field = $field_data['name']; |
300 | 300 | |
301 | - if ( !$field_target |
|
301 | + if (!$field_target |
|
302 | 302 | || !isset($for_object->$field_target)) { |
303 | 303 | // Why return false ??? |
304 | 304 | return false; |
@@ -414,7 +414,7 @@ discard block |
||
414 | 414 | $parent_property = midgard_object_class::get_property_parent($schema_type); |
415 | 415 | $up_property = midgard_object_class::get_property_up($schema_type); |
416 | 416 | |
417 | - if ( !$this->_resolve_child_classes_links_back($parent_property, $schema_type, $this->mgdschema_class) |
|
417 | + if (!$this->_resolve_child_classes_links_back($parent_property, $schema_type, $this->mgdschema_class) |
|
418 | 418 | && !$this->_resolve_child_classes_links_back($up_property, $schema_type, $this->mgdschema_class)) { |
419 | 419 | continue; |
420 | 420 | } |
@@ -439,7 +439,7 @@ discard block |
||
439 | 439 | |
440 | 440 | $ref = new midgard_reflection_property($prospect_type); |
441 | 441 | $link_class = $ref->get_link_name($property); |
442 | - if ( empty($link_class) |
|
442 | + if (empty($link_class) |
|
443 | 443 | && $ref->get_midgard_type($property) === MGD_TYPE_GUID) { |
444 | 444 | return true; |
445 | 445 | } |
@@ -553,7 +553,8 @@ |
||
553 | 553 | $tree = []; |
554 | 554 | try { |
555 | 555 | $children = self::get_child_objects($parent); |
556 | - } catch (midcom_error $e) { |
|
556 | + } |
|
557 | + catch (midcom_error $e) { |
|
557 | 558 | return $tree; |
558 | 559 | } |
559 | 560 |
@@ -54,7 +54,7 @@ discard block |
||
54 | 54 | ]); |
55 | 55 | } |
56 | 56 | |
57 | - if ( midcom::get()->config->get('midcom_services_rcs_enable') |
|
57 | + if (midcom::get()->config->get('midcom_services_rcs_enable') |
|
58 | 58 | && $object->can_do('midgard:update') |
59 | 59 | && $object->_use_rcs) { |
60 | 60 | $buttons[] = [ |
@@ -84,7 +84,7 @@ discard block |
||
84 | 84 | } |
85 | 85 | |
86 | 86 | $icon = 'stock-icons/16x16/page-' . $icontype . '.png'; |
87 | - if ( !midcom::get()->config->get('show_hidden_objects') |
|
87 | + if (!midcom::get()->config->get('show_hidden_objects') |
|
88 | 88 | && !$object->metadata->is_visible()) { |
89 | 89 | // Take scheduling into account |
90 | 90 | $icon = 'stock-icons/16x16/page-' . $icontype . '-notpublished.png'; |
@@ -338,8 +338,8 @@ discard block |
||
338 | 338 | $classes = []; |
339 | 339 | |
340 | 340 | if ($child[MIDCOM_NAV_TYPE] === 'node') { |
341 | - if ( $item[MIDCOM_NAV_ID] === $this->_nap->get_current_node() |
|
342 | - && ( !$this->_nap->get_current_leaf() |
|
341 | + if ($item[MIDCOM_NAV_ID] === $this->_nap->get_current_node() |
|
342 | + && (!$this->_nap->get_current_leaf() |
|
343 | 343 | || !$this->_nap->get_leaf($this->_nap->get_current_leaf()))) { |
344 | 344 | $classes[] = $this->css_active; |
345 | 345 | } |
@@ -386,7 +386,7 @@ discard block |
||
386 | 386 | } |
387 | 387 | |
388 | 388 | // Add information about the object's status |
389 | - if ( $this->object_status_to_class |
|
389 | + if ($this->object_status_to_class |
|
390 | 390 | && isset($item[MIDCOM_NAV_OBJECT]) |
391 | 391 | && $css_status_class = midcom::get()->metadata->get_object_classes($item[MIDCOM_NAV_OBJECT])) { |
392 | 392 | $classes[] = $css_status_class; |
@@ -405,12 +405,12 @@ discard block |
||
405 | 405 | echo "<a href=\"{$item[MIDCOM_NAV_ABSOLUTEURL]}\"{$link_class}>{$item[MIDCOM_NAV_NAME]}</a>"; |
406 | 406 | // If either of the follow nodes switches is on, follow all the nodes |
407 | 407 | |
408 | - if ( $item[MIDCOM_NAV_TYPE] === 'node' |
|
408 | + if ($item[MIDCOM_NAV_TYPE] === 'node' |
|
409 | 409 | && !$this->show_only_current |
410 | - && ( $this->list_levels === 0 |
|
410 | + && ($this->list_levels === 0 |
|
411 | 411 | || $this->_level < $this->list_levels)) { |
412 | - if ( $this->follow_all |
|
413 | - || ( $this->follow_selected |
|
412 | + if ($this->follow_all |
|
413 | + || ($this->follow_selected |
|
414 | 414 | && in_array($item[MIDCOM_NAV_ID], $this->node_path, true))) { |
415 | 415 | $this->_level++; |
416 | 416 | $this->_list_child_elements($item[MIDCOM_NAV_ID]); |