flack / midgard-portable

src/xmlreader.php

Doc Comments +3 added lines

@@ -95,6 +95,9 @@
         $type->add_property($property);
     }
 
+    /**
+     * @param string $name
+     */
     private function add_mixin($name, type $type)
     {
         if (empty($this->mixins[$name])) {

api/midgard/collector.php

Spacing +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
         $parsed = $this->parse_constraint_name($property);
 
         // for properties like up.name
-        if (   strpos($property, ".") !== false
+        if (strpos($property, ".") !== false
             && !(strpos($property, "metadata") === 0)) {
             return $parsed['name'] . " as " . str_replace(".", "_", $property);
         }
@@ -134,7 +134,7 @@ 
      */
     public function get($key)
     {
-        if (   !$this->_has_results()
+        if (!$this->_has_results()
             || !isset($this->_results[$key])) {
             return false;
         }

Doc Comments +7 added lines

@@ -25,6 +25,10 @@ 
 
     private $value_properties = [];
 
+    /**
+     * @param string $class
+     * @param string $field
+     */
     public function __construct($class, $field = null, $value = null)
     {
         parent::__construct($class);
@@ -68,6 +72,9 @@ 
         return true;
     }
 
+    /**
+     * @param string $property
+     */
     protected function build_property_select($property)
     {
         $parsed = $this->parse_constraint_name($property);

src/classgenerator.php

Indentation +1 added lines, -1 removed lines

@@ -174,7 +174,7 @@
                     break;
             }
             if (   $default !== null
-                   // we need to skip working links because in this case, Doctrine expects objects as values
+                    // we need to skip working links because in this case, Doctrine expects objects as values
                 && (   !$property->link
                     || $this->manager->resolve_targetclass($property) === false)) {
                 $line .= ' = ' . $default;

Spacing +7 added lines, -7 removed lines

@@ -62,8 +62,8 @@ 
         }
 
         $types = $this->manager->get_types();
-        uasort($types, function ($a, $b) {
-            if (   !empty($a->extends)
+        uasort($types, function($a, $b) {
+            if (!empty($a->extends)
                 && !empty($b->extends)) {
                 return strnatcmp($a->extends, $b->extends);
             } elseif (!empty($a->extends)) {
@@ -104,7 +104,7 @@ 
         $prefix = $this->get_class_prefix($namespace);
 
         foreach ($this->manager->get_types() as $type) {
-            if (   $prefix !== ''
+            if ($prefix !== ''
                 && !class_exists($type->name)) {
                 $this->add_line('class_alias( "' . $prefix . $type->name . '", "' . $type->name . '");');
             }
@@ -112,7 +112,7 @@ 
 
         foreach ($this->manager->get_inherited_mapping() as $child => $parent) {
             $this->add_line('class_alias( "' . $prefix . $parent . '", "' . $prefix . $child . '");');
-            if (   $prefix !== ''
+            if ($prefix !== ''
                 && !class_exists($child)) {
                 $this->add_line('class_alias( "' . $prefix . $parent . '", "' . $child . '");');
             }
@@ -173,9 +173,9 @@ 
                     $objects[$name] = 'new midgard_datetime("0001-01-01 00:00:00")';
                     break;
             }
-            if (   $default !== null
+            if ($default !== null
                    // we need to skip working links because in this case, Doctrine expects objects as values
-                && (   !$property->link
+                && (!$property->link
                     || $this->manager->resolve_targetclass($property) === false)) {
                 $line .= ' = ' . $default;
             }
@@ -235,7 +235,7 @@ 
         $this->write_annotations($type);
         $this->add_line('class ' . $type->name . ' extends ' . $type->extends);
         $mixins = $type->get_mixins();
-        $interfaces = array_filter(array_map(function ($name) {
+        $interfaces = array_filter(array_map(function($name) {
             if (interface_exists('\\midgard\\portable\\storage\\interfaces\\' . $name)) {
                 return '\\midgard\\portable\\storage\\interfaces\\' . $name;
             }

src/mgdschema/type.php

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
         } else {
             if ($property->parentfield) {
                 $this->parentfield = $property->name;
-                if (   empty($this->parent)
+                if (empty($this->parent)
                     && $property->link) {
                     $this->parent = $property->link['target'];
                 }

src/driver.php

Spacing +1 added lines, -1 removed lines

@@ -156,7 +156,7 @@
 
         foreach ($type->get_properties() as $name => $property) {
             // doctrine can handle id links only
-            if (   $property->link
+            if ($property->link
                 && $target_class = $this->manager->resolve_targetclass($property)) {
                 $link_mapping = [
                     'fieldName' => $property->name,

src/mgdschema/translator.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
         if (!array_key_exists($typeattribute, self::$typemap)) {
             throw new \Exception('unknown type ' . $typeattribute);
         }
-        $search = ['unsigned ', 'guid',   'datetime', 'text', 'longtext'];
+        $search = ['unsigned ', 'guid', 'datetime', 'text', 'longtext'];
         $replace = ['', 'string', 'midgard_datetime', 'string', 'string'];
 
         return str_replace($search, $replace, $typeattribute);

src/api/dbobject.php

Spacing +8 added lines, -8 removed lines

@@ -63,7 +63,7 @@ 
     {
         $this->initialize();
         $properties = array_merge($this->cm->getFieldNames(), $this->cm->getAssociationNames(), array_keys($this->cm->midgard['field_aliases']));
-        $properties = array_filter($properties, function ($input) {
+        $properties = array_filter($properties, function($input) {
             return (strpos($input, 'metadata_') === false);
         });
         $ret = [];
@@ -78,7 +78,7 @@ 
     {
         $this->initialize();
 
-        if (   !$this->cm->hasField($field)
+        if (!$this->cm->hasField($field)
             && array_key_exists($field, $this->cm->midgard['field_aliases'])) {
             $field = $this->cm->midgard['field_aliases'][$field];
         }
@@ -88,7 +88,7 @@ 
             if (empty($value)) {
                 $value = null;
             } else {
-                if (   !is_object($this->$field)
+                if (!is_object($this->$field)
                     || $this->$field->id != $value) {
                     $this->changed_associations[$field] = true;
                 }
@@ -98,7 +98,7 @@ 
         } elseif ($this->cm->hasField($field)) {
             $mapping = $this->cm->getFieldMapping($field);
 
-            if (   $mapping['type'] === 'string'
+            if ($mapping['type'] === 'string'
                 || $mapping['type'] == 'text') {
                 $value = (string) $value;
             } elseif ($mapping['type'] === 'integer') {
@@ -108,7 +108,7 @@ 
             } elseif ($mapping['type'] === 'float') {
                 $value = (float) $value;
             } elseif ($mapping['type'] === 'midgard_datetime') {
-                if (   is_string($value)
+                if (is_string($value)
                     && $value !== '0000-00-00 00:00:00') {
                     $value = new midgard_datetime($value);
                 } elseif (!($value instanceof midgard_datetime)) {
@@ -124,7 +124,7 @@ 
     {
         $this->initialize();
 
-        if (   !$this->cm->hasField($field)
+        if (!$this->cm->hasField($field)
             && array_key_exists($field, $this->cm->midgard['field_aliases'])) {
             $field = $this->cm->midgard['field_aliases'][$field];
         }
@@ -137,11 +137,11 @@ 
             }
             return 0;
         }
-        if (   $this->$field === null
+        if ($this->$field === null
             && $this->cm->isIdentifier($field)) {
             return 0;
         }
-        if (   $this->$field instanceof midgard_datetime
+        if ($this->$field instanceof midgard_datetime
             && $this->$field->format('U') == -62169984000) {
             //This is mainly needed for working with converted Legacy databases. Midgard2 somehow handles this internally
             //@todo Find a nicer solution and research how QB handles this

src/api/user.php

Spacing +4 added lines, -4 removed lines

@@ -61,7 +61,7 @@ 
 
     private function load_by_properties(array $properties)
     {
-        if (   !array_key_exists('authtype', $properties)
+        if (!array_key_exists('authtype', $properties)
             || !array_key_exists('login', $properties)) {
             throw exception::invalid_property_value();
         }
@@ -109,7 +109,7 @@ 
 
     public function &get_person()
     {
-        if (   $this->person_object === null
+        if ($this->person_object === null
             && $this->person !== null) {
             $this->person_object = connection::get_em()->getRepository('midgard:midgard_person')->findOneBy(['guid' => $this->person]);
         }
@@ -118,7 +118,7 @@ 
 
     public function create()
     {
-        if (   empty($this->authtype)
+        if (empty($this->authtype)
             || !empty($this->id)) {
             exception::invalid_property_value();
             return false;
@@ -182,7 +182,7 @@ 
 
     protected function is_unique()
     {
-        if (   empty($this->login)
+        if (empty($this->login)
             || empty($this->authtype)) {
             return true;
         }

src/storage/subscriber.php

Spacing +5 added lines, -5 removed lines

@@ -99,7 +99,7 @@ 
         if (!($entity instanceof repligard)) {
             $repligard_entry = $em->getRepository('midgard:midgard_repligard')->findOneBy(['guid' => $entity->guid]);
 
-            if (   $entity instanceof metadata
+            if ($entity instanceof metadata
                 && $entity->{metadata::DELETED_FIELD}) {
                 $repligard_entry->object_action = self::ACTION_DELETE;
             } else {
@@ -140,7 +140,7 @@ 
 
         foreach ($columns as $name => &$config) {
             if ($platform->getName() === 'sqlite') {
-                if (   !empty($config['primary'])
+                if (!empty($config['primary'])
                     && !empty($config['autoincrement'])) {
                     /*
                      * This is essentially a workaround for http://www.doctrine-project.org/jira/browse/DBAL-642
@@ -149,7 +149,7 @@ 
                     $modified = true;
                     $config['columnDefinition'] = 'INTEGER PRIMARY KEY AUTOINCREMENT';
                 }
-                if (   !empty($config['comment'])
+                if (!empty($config['comment'])
                     && $config['comment'] == 'BINARY') {
                     $modified = true;
                     $config['columnDefinition'] = $config['type']->getSQLDeclaration($config, $platform) . ' COLLATE BINARY' . $platform->getDefaultValueDeclarationSQL($config);
@@ -166,7 +166,7 @@ 
                         $config['columnDefinition'] = $config['comment'] . $platform->getDefaultValueDeclarationSQL($config);
                     }
                     if (!empty($config['columnDefinition']) && $platform->supportsInlineColumnComments()) {
-                        $config['columnDefinition'] .=  " COMMENT " . $platform->quoteStringLiteral($config['comment']);
+                        $config['columnDefinition'] .= " COMMENT " . $platform->quoteStringLiteral($config['comment']);
                     }
                 }
             }
@@ -260,7 +260,7 @@ 
     public function postGenerateSchemaTable(GenerateSchemaTableEventArgs $args)
     {
         $table = $args->getClassTable();
-        if (   !$table->hasOption('engine')
+        if (!$table->hasOption('engine')
             || $table->getOption('engine') !== 'MyISAM') {
             return;
         }