flack / midgard-portable

src/api/mgdobject.php

Spacing +10 added lines, -10 removed lines

@@ -78,7 +78,7 @@ 
 
     public function __get($field)
     {
-        if (   $field === 'metadata'
+        if ($field === 'metadata'
             && $this->metadata === null
             && $this instanceof metadata_interface) {
             $this->metadata = new metadata($this);
@@ -98,13 +98,13 @@ 
     protected function load_parent(array $candidates) : ?dbobject
     {
         foreach ($candidates as $candidate) {
-            if (   is_string($this->$candidate)
+            if (is_string($this->$candidate)
                 && mgd_is_guid($this->$candidate)) {
                 return \midgard_object_class::get_object_by_guid($this->$candidate);
             }
             if ($this->$candidate !== null) {
                 //Proxies become stale if the object itself is detached, so we have to re-fetch
-                if (   $this->$candidate instanceof Proxy
+                if ($this->$candidate instanceof Proxy
                     && $this->$candidate->__isInitialized()) {
                     try {
                         $this->$candidate->get_by_id($this->$candidate->id);
@@ -171,7 +171,7 @@ 
             exception::duplicate();
             return false;
         }
-        if (   !$this->is_unique()
+        if (!$this->is_unique()
             || !$this->check_parent()) {
             return false;
         }
@@ -219,7 +219,7 @@ 
             exception::invalid_property_value();
             return false;
         }
-        if (   $check_dependencies
+        if ($check_dependencies
             && $this->has_dependents()) {
             exception::has_dependants();
             return false;
@@ -304,7 +304,7 @@ 
     {
         $this->initialize();
 
-        if (   empty($this->cm->midgard['parentfield'])
+        if (empty($this->cm->midgard['parentfield'])
             || empty($this->cm->midgard['parent'])) {
             return true;
         }
@@ -321,7 +321,7 @@ 
         $this->initialize();
 
         foreach ($this->cm->fieldMappings as $name => $field) {
-            if (   $field['midgard:midgard_type'] == translator::TYPE_GUID
+            if ($field['midgard:midgard_type'] == translator::TYPE_GUID
                 && !empty($this->$name)
                 && !mgd_is_guid($this->$name)) {
                 exception::invalid_property_value("'" . $name . "' property's value is not a guid.");
@@ -333,7 +333,7 @@ 
 
     private function check_upfield() : bool
     {
-        if (   !empty($this->id)
+        if (!empty($this->id)
             && !empty($this->cm->midgard['upfield'])
             && $this->__get($this->cm->midgard['upfield']) === $this->id
             && $this->cm->getAssociationMapping($this->cm->midgard['upfield'])['targetEntity'] === $this->cm->getName()) {
@@ -370,7 +370,7 @@ 
             $stat = $results > 0;
         }
 
-        if (   !$stat
+        if (!$stat
             && !empty($this->cm->midgard['childtypes'])) {
             foreach ($this->cm->midgard['childtypes'] as $typename => $parentfield) {
                 $qb = connection::get_em()->createQueryBuilder();
@@ -679,7 +679,7 @@ 
             exception::not_exists();
             return false;
         }
-        if (   $check_dependencies
+        if ($check_dependencies
             && $this->has_dependents()) {
             exception::has_dependants();
             return false;

src/query.php

Spacing +3 added lines, -3 removed lines

@@ -252,7 +252,7 @@ 
                 } else {
                     $mrp = new \midgard_reflection_property($targetclass);
 
-                    if (   !$mrp->is_link($part)
+                    if (!$mrp->is_link($part)
                         && !$mrp->is_special_link($part)) {
                         throw exception::invalid_property($part);
                     }
@@ -269,7 +269,7 @@ 
             $column = $cm->midgard['field_aliases'][$column];
         }
 
-        if (   !$cm->hasField($column)
+        if (!$cm->hasField($column)
             && !$cm->hasAssociation($column)) {
             throw exception::invalid_property($column);
         }
@@ -290,7 +290,7 @@ 
             $expression = $operator . '( ?' . $this->parameters . ')';
         }
 
-        if (   $value === 0
+        if ($value === 0
             || $value === null
             || is_array($value)) {
             $cm = connection::get_em()->getClassMetadata($parsed['targetclass']);

src/api/dbobject.php

Spacing +8 added lines, -8 removed lines

@@ -56,7 +56,7 @@ 
     {
         $this->initialize();
         $properties = array_merge($this->cm->getFieldNames(), $this->cm->getAssociationNames(), array_keys($this->cm->midgard['field_aliases']));
-        $properties = array_filter($properties, function ($input) {
+        $properties = array_filter($properties, function($input) {
             return !str_contains($input, 'metadata_');
         });
         $ret = [];
@@ -71,7 +71,7 @@ 
     {
         $this->initialize();
 
-        if (   !$this->cm->hasField($field)
+        if (!$this->cm->hasField($field)
             && isset($this->cm->midgard['field_aliases'][$field])) {
             $field = $this->cm->midgard['field_aliases'][$field];
         }
@@ -81,7 +81,7 @@ 
             if (empty($value)) {
                 $value = null;
             } else {
-                if (   !\is_object($this->$field)
+                if (!\is_object($this->$field)
                     || $this->$field->id != $value) {
                     $this->changed_associations[$field] = true;
                 }
@@ -91,7 +91,7 @@ 
         } elseif ($this->cm->hasField($field)) {
             $mapping = $this->cm->getFieldMapping($field);
 
-            if (   $mapping['type'] === 'string'
+            if ($mapping['type'] === 'string'
                 || $mapping['type'] == 'text') {
                 $value = (string) $value;
             } elseif ($mapping['type'] === 'integer') {
@@ -101,7 +101,7 @@ 
             } elseif ($mapping['type'] === 'float') {
                 $value = (float) $value;
             } elseif (in_array($mapping['type'], ['datetime', 'date'])) {
-                if (   \is_string($value)
+                if (\is_string($value)
                     && $value !== '0000-00-00 00:00:00') {
                     $value = new midgard_datetime($value);
                 } elseif (!($value instanceof midgard_datetime)) {
@@ -117,7 +117,7 @@ 
     {
         $this->initialize();
 
-        if (   !$this->cm->hasField($field)
+        if (!$this->cm->hasField($field)
             && isset($this->cm->midgard['field_aliases'][$field])) {
             $field = $this->cm->midgard['field_aliases'][$field];
         }
@@ -130,11 +130,11 @@ 
             }
             return 0;
         }
-        if (   $this->$field === null
+        if ($this->$field === null
             && $this->cm->isIdentifier($field)) {
             return 0;
         }
-        if (   $this->$field instanceof midgard_datetime
+        if ($this->$field instanceof midgard_datetime
             && $this->$field->format('U') == -62169984000) {
             //This is mainly needed for working with converted Legacy databases. Midgard2 somehow handles this internally
             //@todo Find a nicer solution and research how QB handles this

api/midgard/collector.php

Spacing +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
         $parsed = $this->parse_constraint_name($property);
 
         // for properties like up.name
-        if (   str_contains($property, ".")
+        if (str_contains($property, ".")
             && !(str_starts_with($property, "metadata"))) {
             return $parsed['name'] . " as " . str_replace(".", "_", $property);
         }