Passed
Push — master ( 24644b...f0a5ce )
by Andreas
04:06 queued 22s
created
src/mgdschema/type.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
         } else {
66 66
             if ($property->parentfield) {
67 67
                 $this->parentfield = $property->name;
68
-                if (   empty($this->parent)
68
+                if (empty($this->parent)
69 69
                     && $property->link) {
70 70
                     $this->parent = $property->link['target'];
71 71
                 }
Please login to merge, or discard this patch.
src/mgdschema/manager.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
             $fqcn = $this->namespace . '\\' . $fqcn;
79 79
         }
80 80
 
81
-        if (   array_key_exists($fqcn, $this->types)
81
+        if (array_key_exists($fqcn, $this->types)
82 82
             || $property->link['target'] === $property->get_parent()->name) {
83 83
             $target_class = $property->link['target'];
84 84
         } else {
Please login to merge, or discard this patch.
src/api/object.php 2 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 
81 81
     public function __get($field)
82 82
     {
83
-        if (   $field === 'metadata'
83
+        if ($field === 'metadata'
84 84
             && $this->metadata === null
85 85
             && $this instanceof metadata_interface) {
86 86
             $this->metadata = new metadata($this);
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
         foreach ($candidates as $candidate) {
103 103
             if ($this->$candidate !== null) {
104 104
                 //Proxies become stale if the object itself is detached, so we have to re-fetch
105
-                if (   $this->$candidate instanceof \Doctrine\ORM\Proxy\Proxy
105
+                if ($this->$candidate instanceof \Doctrine\ORM\Proxy\Proxy
106 106
                     && $this->$candidate->__isInitialized()) {
107 107
                     try {
108 108
                         $this->$candidate->get_by_id($this->$candidate->id);
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
         }
127 127
         // According to Doctrine documentation, proxies should be transparent, but in practice,
128 128
         // there will be problems if we don't force-load
129
-        if (   $entity instanceof \Doctrine\ORM\Proxy\Proxy
129
+        if ($entity instanceof \Doctrine\ORM\Proxy\Proxy
130 130
             && !$entity->__isInitialized()) {
131 131
             try {
132 132
                 $entity->__load();
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
             exception::duplicate();
176 176
             return false;
177 177
         }
178
-        if (   !$this->is_unique()
178
+        if (!$this->is_unique()
179 179
             || !$this->check_parent()) {
180 180
             return false;
181 181
         }
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
             midgard_connection::get_instance()->set_error(MGD_ERR_INVALID_PROPERTY_VALUE);
232 232
             return false;
233 233
         }
234
-        if (   $check_dependencies
234
+        if ($check_dependencies
235 235
             && $this->has_dependents()) {
236 236
             exception::has_dependants();
237 237
             return false;
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
     {
323 323
         $this->initialize();
324 324
 
325
-        if (   empty($this->cm->midgard['parentfield'])
325
+        if (empty($this->cm->midgard['parentfield'])
326 326
             || empty($this->cm->midgard['parent'])) {
327 327
             return true;
328 328
         }
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
         $this->initialize();
340 340
 
341 341
         foreach ($this->cm->fieldMappings as $name => $field) {
342
-            if (   $field['midgard:midgard_type'] == translator::TYPE_GUID
342
+            if ($field['midgard:midgard_type'] == translator::TYPE_GUID
343 343
                 && !empty($this->$name)
344 344
                 && !mgd_is_guid($this->$name)) {
345 345
                 exception::invalid_property_value("'" . $name . "' property's value is not a guid.");
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
             $stat = ($results > 0);
376 376
         }
377 377
 
378
-        if (   !$stat
378
+        if (!$stat
379 379
             && !empty($this->cm->midgard['childtypes'])) {
380 380
             foreach ($this->cm->midgard['childtypes'] as $typename => $parentfield) {
381 381
                 $qb = connection::get_em()->createQueryBuilder();
@@ -740,7 +740,7 @@  discard block
 block discarded – undo
740 740
             exception::not_exists();
741 741
             return false;
742 742
         }
743
-        if (   $check_dependencies
743
+        if ($check_dependencies
744 744
             && $this->has_dependents()) {
745 745
             exception::has_dependants();
746 746
             return false;
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -509,6 +509,7 @@  discard block
 block discarded – undo
509 509
     }
510 510
 
511 511
     /**
512
+     * @param integer $up
512 513
      * @return QueryBuilder
513 514
      */
514 515
     protected function get_uniquefield_query($classname, $field, $part, $upfield, $up)
@@ -610,7 +611,7 @@  discard block
 block discarded – undo
610 611
     /**
611 612
      * @param string $domain
612 613
      * @param string $name
613
-     * @param mixed $value
614
+     * @param string $value
614 615
      * @return boolean
615 616
      */
616 617
     public function set_parameter($domain, $name, $value)
@@ -816,6 +817,9 @@  discard block
 block discarded – undo
816 817
         return new \midgard_reflection_property(get_called_class());
817 818
     }
818 819
 
820
+    /**
821
+     * @param string $guid
822
+     */
819 823
     public function set_guid($guid)
820 824
     {
821 825
         parent::__set('guid', $guid);
Please login to merge, or discard this patch.