schema::generate_proxyfiles() - Code Metrics - Inspection of "Add workaround for doctrine/dbal#5369" - flack/midgard-portable - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( c365d8...1a7141 )

by Andreas
created 2022-08-11 15:56 UTC
schema::generate_proxyfiles() A

↳ Parent: schema
Complexity

Conditions	3
Paths	3
Size

Total Lines	12
Code Lines	8
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	12
Importance

Changes	2
Bugs	0	Features	1
Metric	Value
cc	3
eloc	8
c	2
b	0
f	1
nc	3
nop	1
dl	0
loc	12
ccs	0
cts	9
cp	0
crap	12
rs	10
<?php
/**
 * @author CONTENT CONTROL http://www.contentcontrol-berlin.de/
 * @copyright CONTENT CONTROL http://www.contentcontrol-berlin.de/
 * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
 */

namespace midgard\portable\command;

use midgard\portable\storage\connection;
use midgard\portable\classgenerator;
use Symfony\Component\Console\Command\Command;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Helper\ProgressBar;
use Symfony\Component\Console\Question\Question;
filter:
    dependency_paths: ["lib/*"]
use midgard_storage;
use midgard_connection;
use Doctrine\ORM\Tools\SchemaTool;
use Doctrine\DBAL\Schema\Comparator;
use Symfony\Component\Console\Input\InputOption;
use Doctrine\Common\Proxy\ProxyGenerator;
use Doctrine\DBAL\Schema\Column;
use Doctrine\DBAL\Schema\SchemaDiff;
use Doctrine\DBAL\Schema\Schema as dbal_schema;

/**
 * (Re)generate mapping information from MgdSchema XMLs
 */
class schema extends Command
{
    public $connected = false;

    protected function configure()
    {
        $this->setName('schema')
            ->setDescription('(Re)generate mapping information from MgdSchema XMLs')
            ->addArgument('config', InputArgument::OPTIONAL, 'Full path to midgard-portable config file')
            ->addOption('force', null, InputOption::VALUE_NONE, 'Ignore errors from DB')
            ->addOption('delete', null, InputOption::VALUE_NONE, 'Delete columns/tables that are not defined in mgdschema');
    }

    protected function execute(InputInterface $input, OutputInterface $output) : int
    {
        if (!$this->connected) {
            $path = $input->getArgument('config');
            if (empty($path)) {
                if (file_exists(OPENPSA_PROJECT_BASEDIR . 'config/midgard-portable.inc.php')) {

                    $path = OPENPSA_PROJECT_BASEDIR . 'config/midgard-portable.inc.php';
                } else {
                    $dialog = $this->getHelper('question');
                    $path = $dialog->ask($input, $output, new Question('<question>Enter path to config file</question>'));
                }
            }
            if (!file_exists($path)) {
                throw new \RuntimeException('Config file ' . $path . ' not found');
            }
            //we have to delay startup so that we can delete the entity class file before it gets included
            connection::set_autostart(false);
            require $path;
        }

        $mgd_config = midgard_connection::get_instance()->config;
        $mgdschema_file = $mgd_config->vardir . '/mgdschema_classes.php';
        if (   file_exists($mgdschema_file)
            && !unlink($mgdschema_file)) {
            throw new \RuntimeException('Could not unlink ' . $mgdschema_file);
        }
        if (connection::get_parameter('dev_mode') !== true) {
            $driver = connection::get_parameter('driver');
            $classgenerator = new classgenerator($driver->get_manager(), $mgdschema_file);
            $classgenerator->write($driver->get_namespace());
        }
        if (!file_exists($mgd_config->blobdir . '/0/0')) {
            $mgd_config->create_blobdir();
        }
        connection::startup();
        $em = connection::get_em();
        connection::invalidate_cache();
        $cms = $em->getMetadataFactory()->getAllMetadata();

        // create storage
        if (    !midgard_storage::create_base_storage()
             && midgard_connection::get_instance()->get_error_string() != 'MGD_ERR_OK') {
            throw new \Exception("Failed to create base database structures" . midgard_connection::get_instance()->get_error_string());
        }
        $force = $input->getOption('force');
        $to_update = [];
        $to_create = [];

        $sm = $em->getConnection()->createSchemaManager();
        foreach ($cms as $cm) {
            if ($sm->tablesExist([$cm->getTableName()])) {
                $to_update[] = $cm;
            } else {
                $to_create[] = $cm;
            }
        }

        if (!empty($to_create)) {
            $output->writeln('Creating <info>' . count($to_create) . '</info> new tables');
            $tool = new SchemaTool($em);
            try {
                $tool->createSchema($to_create);
            } catch (\Exception $e) {
                if (!$force) {
                    throw $e;
                }
                $output->writeln('<error>' . $e->getMessage() . '</error>');
            }
        }
        if (!empty($to_update)) {
            $delete = $input->getOption('delete');
            $this->process_updates($to_update, $output, $force, $delete);
        }
        $output->writeln('Generating proxies');
        $this->generate_proxyfiles($cms);

        $output->writeln('Done');
        return 0;
    }

    private function generate_proxyfiles(array $cms)
    {
        $em = connection::get_em();
        $generator = new ProxyGenerator($em->getConfiguration()->getProxyDir(), $em->getConfiguration()->getProxyNamespace());
        $generator->setPlaceholder('baseProxyInterface', 'Doctrine\ORM\Proxy\Proxy');

        foreach ($cms as $cm) {
            $filename = $generator->getProxyFileName($cm->getName());
            if (file_exists($filename)) {
                unlink($filename);
            }
            $generator->generateProxyClass($cm, $filename);
        }
    }

    /**
     * Since we normally don't delete old columns, we have to disable DBAL's renaming
     * detection, because otherwise a new column might just reuse an outdated one (keeping the values)
     */
    public static function diff(dbal_schema $from, dbal_schema $to, bool $delete = false) : SchemaDiff
    {
        $platform = connection::get_em()->getConnection()->getDatabasePlatform();
        $comparator = new Comparator($platform);
        $diff = $comparator->compareSchemas($from, $to);

        foreach ($diff->changedTables as $changed_table) {
            if (!empty($changed_table->renamedColumns)) {
                if (empty($changed_table->addedColumns)) {
                    $changed_table->addedColumns = [];
                }

                foreach ($changed_table->renamedColumns as $name => $column) {
                    $changed_table->addedColumns[$column->getName()] = $column;
                    $changed_table->removedColumns[$name] = new Column($name, $column->getType());
                }
                $changed_table->renamedColumns = [];
            }
            if (!$delete) {
                $changed_table->removedColumns = [];
            }
            // workaround for https://github.com/doctrine/dbal/issues/5369
            foreach ($changed_table->changedColumns as $name => $col_diff) {
                if (!$comparator->diffColumn($col_diff->column, $col_diff->fromColumn)) {
                if (!$comparator->diffColumn($col_diff->column, /** @scrutinizer ignore-type */ $col_diff->fromColumn)) {
                    unset($changed_table->changedColumns[$name]);
                }
            }
        }
        return $diff;
    }

    private function process_updates(array $to_update, OutputInterface $output, $force, $delete)
    {
        $em = connection::get_em();
        $conn = $em->getConnection();
        $tool = new SchemaTool($em);
        $from = $conn->createSchemaManager()->createSchema();
        $to = $tool->getSchemaFromMetadata($to_update);

        $diff = self::diff($from, $to, $delete);

        if ($delete) {
            $sql = $diff->toSql($conn->getDatabasePlatform());
        } else {
            $sql = $diff->toSaveSql($conn->getDatabasePlatform());
        }

        if (empty($sql)) {
            return;
        }

        $output->writeln('Executing <info>' . count($sql) . '</info> updates');
        $progress = new ProgressBar($output);
        $progress->start(count($sql));

        foreach ($sql as $sql_line) {
            if ($output->getVerbosity() >= OutputInterface::VERBOSITY_VERBOSE) {
                $output->writeln(' Executing <info>' . $sql_line . '</info>');
            }
            try {
                $conn->executeQuery($sql_line);
            } catch (\Exception $e) {
                if (!$force) {
                    throw $e;
                }
                $output->writeln('<error>' . $e->getMessage() . '</error>');
            }

            $progress->advance();
        }
        $progress->finish();
        $output->writeln('');
    }
}

flack / midgard-portable

Push — master ( c365d8...1a7141 )

schema::generate_proxyfiles() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
