flack / midgard-portable

src/storage/connection.php

Spacing +1 added lines, -1 removed lines

@@ -213,7 +213,7 @@
             $midgard = midgard_connection::get_instance();
             if ($midgard->config->logfilename) {
                 $logdir = dirname($midgard->config->logfilename);
-                if (   !is_dir($logdir)
+                if (!is_dir($logdir)
                     && !mkdir($logdir, 0777, true)) {
                     throw exception::user_data('Log directory could not be created');
                 }

src/command/schema.php

Spacing +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
 
         $mgd_config = midgard_connection::get_instance()->config;
         $mgdschema_file = $mgd_config->vardir . '/mgdschema_classes.php';
-        if (   file_exists($mgdschema_file)
+        if (file_exists($mgdschema_file)
             && !unlink($mgdschema_file)) {
             throw new \RuntimeException('Could not unlink ' . $mgdschema_file);
         }
@@ -72,7 +72,7 @@ 
         $cms = $em->getMetadataFactory()->getAllMetadata();
 
         // create storage
-        if (    !midgard_storage::create_base_storage()
+        if (!midgard_storage::create_base_storage()
              && midgard_connection::get_instance()->get_error_string() != 'MGD_ERR_OK') {
             throw new \Exception("Failed to create base database structures" . midgard_connection::get_instance()->get_error_string());
         }

api/midgard/collector.php

Spacing +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
         $parsed = $this->parse_constraint_name($property);
 
         // for properties like up.name
-        if (   strpos($property, ".") !== false
+        if (strpos($property, ".") !== false
             && !(strpos($property, "metadata") === 0)) {
             return $parsed['name'] . " as " . str_replace(".", "_", $property);
         }
@@ -134,7 +134,7 @@ 
      */
     public function get($key)
     {
-        if (   !$this->_has_results()
+        if (!$this->_has_results()
             || !isset($this->_results[$key])) {
             return false;
         }

src/mgdschema/type.php

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
         } else {
             if ($property->parentfield) {
                 $this->parentfield = $property->name;
-                if (   empty($this->parent)
+                if (empty($this->parent)
                     && $property->link) {
                     $this->parent = $property->link['target'];
                 }

src/driver.php

Spacing +1 added lines, -1 removed lines

@@ -156,7 +156,7 @@
 
         foreach ($type->get_properties() as $name => $property) {
             // doctrine can handle id links only
-            if (   $property->link
+            if ($property->link
                 && $target_class = $this->manager->resolve_targetclass($property)) {
                 $link_mapping = [
                     'fieldName' => $property->name,

src/api/config.php

Spacing +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
 
     public function read_file_at_path($path)
     {
-        if (   !file_exists($path)
+        if (!file_exists($path)
             || !is_readable($path)) {
             return false;
         }
@@ -145,7 +145,7 @@ 
         $subdirs = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 'A', 'B', 'C', 'D', 'E', 'F'];
         foreach ($subdirs as $dir) {
             foreach ($subdirs as $subdir) {
-                if (   !is_dir($this->blobdir . '/' . $dir . '/' . $subdir)
+                if (!is_dir($this->blobdir . '/' . $dir . '/' . $subdir)
                     && !mkdir($this->blobdir . '/' . $dir . '/' . $subdir, 0777, true)) {
                     return false;
                 }

src/api/user.php

Spacing +4 added lines, -4 removed lines

@@ -61,7 +61,7 @@ 
 
     private function load_by_properties(array $properties)
     {
-        if (   !array_key_exists('authtype', $properties)
+        if (!array_key_exists('authtype', $properties)
             || !array_key_exists('login', $properties)) {
             throw exception::invalid_property_value();
         }
@@ -109,7 +109,7 @@ 
 
     public function &get_person()
     {
-        if (   $this->person_object === null
+        if ($this->person_object === null
             && $this->person !== null) {
             $this->person_object = connection::get_em()->getRepository('midgard:midgard_person')->findOneBy(['guid' => $this->person]);
         }
@@ -118,7 +118,7 @@ 
 
     public function create()
     {
-        if (   empty($this->authtype)
+        if (empty($this->authtype)
             || !empty($this->id)) {
             exception::invalid_property_value();
             return false;
@@ -182,7 +182,7 @@ 
 
     protected function is_unique()
     {
-        if (   empty($this->login)
+        if (empty($this->login)
             || empty($this->authtype)) {
             return true;
         }

api/midgard/replicator.php

Spacing +3 added lines, -3 removed lines

@@ -201,19 +201,19 @@
                 break;
         }
 
-        if (   $dbobject->id > 0
+        if ($dbobject->id > 0
             && $dbobject->metadata->revised->format('U') >= $object->metadata->revised->format('U')) {
             midgard_connection::get_instance()->set_error(exception::OBJECT_IMPORTED);
             return false;
         }
 
-        if (   $dbobject->metadata->deleted
+        if ($dbobject->metadata->deleted
             && !$object->metadata->deleted) {
             if (!midgard_object_class::undelete($dbobject->guid)) {
                 return false;
             }
             $dbobject->metadata_deleted = false;
-        } elseif (   !$dbobject->metadata->deleted
+        } elseif (!$dbobject->metadata->deleted
                  && $object->metadata->deleted) {
             return $dbobject->delete();
         }

src/api/mgdobject.php

Spacing +10 added lines, -10 removed lines

@@ -80,7 +80,7 @@ 
 
     public function __get($field)
     {
-        if (   $field === 'metadata'
+        if ($field === 'metadata'
             && $this->metadata === null
             && $this instanceof metadata_interface) {
             $this->metadata = new metadata($this);
@@ -102,7 +102,7 @@ 
         foreach ($candidates as $candidate) {
             if ($this->$candidate !== null) {
                 //Proxies become stale if the object itself is detached, so we have to re-fetch
-                if (   $this->$candidate instanceof Proxy
+                if ($this->$candidate instanceof Proxy
                     && $this->$candidate->__isInitialized()) {
                     try {
                         $this->$candidate->get_by_id($this->$candidate->id);
@@ -130,7 +130,7 @@ 
         }
         // According to Doctrine documentation, proxies should be transparent, but in practice,
         // there will be problems if we don't force-load
-        if (   $entity instanceof Proxy
+        if ($entity instanceof Proxy
             && !$entity->__isInitialized()) {
             try {
                 $entity->__load();
@@ -183,7 +183,7 @@ 
             exception::duplicate();
             return false;
         }
-        if (   !$this->is_unique()
+        if (!$this->is_unique()
             || !$this->check_parent()) {
             return false;
         }
@@ -239,7 +239,7 @@ 
             midgard_connection::get_instance()->set_error(MGD_ERR_INVALID_PROPERTY_VALUE);
             return false;
         }
-        if (   $check_dependencies
+        if ($check_dependencies
             && $this->has_dependents()) {
             exception::has_dependants();
             return false;
@@ -330,7 +330,7 @@ 
     {
         $this->initialize();
 
-        if (   empty($this->cm->midgard['parentfield'])
+        if (empty($this->cm->midgard['parentfield'])
             || empty($this->cm->midgard['parent'])) {
             return true;
         }
@@ -347,7 +347,7 @@ 
         $this->initialize();
 
         foreach ($this->cm->fieldMappings as $name => $field) {
-            if (   $field['midgard:midgard_type'] == translator::TYPE_GUID
+            if ($field['midgard:midgard_type'] == translator::TYPE_GUID
                 && !empty($this->$name)
                 && !mgd_is_guid($this->$name)) {
                 exception::invalid_property_value("'" . $name . "' property's value is not a guid.");
@@ -359,7 +359,7 @@ 
 
     private function check_upfield()
     {
-        if (   !empty($this->id)
+        if (!empty($this->id)
             && !empty($this->cm->midgard['upfield'])
             && $this->__get($this->cm->midgard['upfield']) === $this->id
             && $this->cm->getAssociationMapping($this->cm->midgard['upfield'])['targetEntity'] === $this->cm->getName()) {
@@ -396,7 +396,7 @@ 
             $stat = $results > 0;
         }
 
-        if (   !$stat
+        if (!$stat
             && !empty($this->cm->midgard['childtypes'])) {
             foreach ($this->cm->midgard['childtypes'] as $typename => $parentfield) {
                 $qb = connection::get_em()->createQueryBuilder();
@@ -755,7 +755,7 @@ 
             exception::not_exists();
             return false;
         }
-        if (   $check_dependencies
+        if ($check_dependencies
             && $this->has_dependents()) {
             exception::has_dependants();
             return false;