midgard_reflector_object::has_metadata_class() - Code Metrics - Inspection of "Partial implementation of midgard_reflector_object" - flack/midgard-portable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aac2ef...a9cdaa )

by Andreas

created 2016-11-29 19:32 UTC

midgard_reflector_object::has_metadata_class() A

↳ Parent: midgard_reflector_object

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php
/**
 * @author CONTENT CONTROL http://www.contentcontrol-berlin.de/
 * @copyright CONTENT CONTROL http://www.contentcontrol-berlin.de/
 * @license http://www.gnu.org/licenses/gpl.html GNU General Public License
 */

use midgard\portable\storage\connection;

class midgard_reflector_object
{
    public static function get_property_primary($classname)

    {
        return 'id';
    }

    public static function get_property_up($classname)
    {
        return midgard_object_class::get_property_up($classname);
    }

    public static function get_property_parent($classname)
    {
        return midgard_object_class::get_property_parent($classname);
    }

    public static function get_property_unique($classname)

    {
        $cm = connection::get_em()->getClassMetadata($classname);
        if (empty($cm->midgard['unique_fields'])) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return null;
        }
        return $cm->midgard['unique_fields'][0];
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public static function list_children($classname)

    {
        $cm = connection::get_em()->getClassMetadata($classname);
        if (empty($cm->midgard['childtypes'])) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return array();
        }
        // @todo We filter out useful information (parent field name) in the name of mgd2 compat.
        return array_fill_keys(array_keys($cm->midgard['childtypes']), '');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public static function has_metadata_class($classname)
    {
        return midgard_object_class::has_metadata($classname);
    }

    public static function get_metadata_class($classname)
    {
        if (!self::has_metadata_class($classname)) {
            return null;
        }
        return 'midgard_metadata';
    }

    public static function get_schema_value($classname, $node_name)

    {
        throw new Exception('Not implemented yet');
    }

    public static function is_mixin($classname)

    {
        return false;
    }

    public static function is_interface($classname)

    {
        return false;
    }

    public static function is_abstract($classname)

    {
        return false;
    }

    public static function list_defined_properties($classname)

    {
        throw new Exception('Not implemented yet');
    }
}

1			<?php
2			/**
3			* @author CONTENT CONTROL http://www.contentcontrol-berlin.de/
4			* @copyright CONTENT CONTROL http://www.contentcontrol-berlin.de/
5			* @license http://www.gnu.org/licenses/gpl.html GNU General Public License
6			*/
7
8			use midgard\portable\storage\connection;
9
10			class midgard_reflector_object
11			{
12	1		public static function get_property_primary($classname)
			0 ignored issues – show Unused Code introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report The parameter `$classname` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
13			{
14	1		return 'id';
15			}
16
17	1		public static function get_property_up($classname)
18			{
19	1		return midgard_object_class::get_property_up($classname);
20			}
21
22	1		public static function get_property_parent($classname)
23			{
24	1		return midgard_object_class::get_property_parent($classname);
25			}
26
27	1	View Code Duplication	public static function get_property_unique($classname)
			0 ignored issues – show Duplication introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28			{
29	1		$cm = connection::get_em()->getClassMetadata($classname);
30	1		if (empty($cm->midgard['unique_fields'])) {
			0 ignored issues – show Bug introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report Accessing `midgard` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
31	1		return null;
32			}
33	1		return $cm->midgard['unique_fields'][0];
			0 ignored issues – show Bug introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report Accessing `midgard` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
34			}
35
36	1	View Code Duplication	public static function list_children($classname)
			0 ignored issues – show Duplication introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37			{
38	1		$cm = connection::get_em()->getClassMetadata($classname);
39	1		if (empty($cm->midgard['childtypes'])) {
			0 ignored issues – show Bug introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report Accessing `midgard` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
40	1		return array();
41			}
42			// @todo We filter out useful information (parent field name) in the name of mgd2 compat.
43	1		return array_fill_keys(array_keys($cm->midgard['childtypes']), '');
			0 ignored issues – show Bug introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report Accessing `midgard` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
44			}
45
46	2		public static function has_metadata_class($classname)
47			{
48	2		return midgard_object_class::has_metadata($classname);
49			}
50
51	1		public static function get_metadata_class($classname)
52			{
53	1		if (!self::has_metadata_class($classname)) {
54	1		return null;
55			}
56	1		return 'midgard_metadata';
57			}
58
59			public static function get_schema_value($classname, $node_name)
			0 ignored issues – show Unused Code introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report The parameter `$classname` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report The parameter `$node_name` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
60			{
61			throw new Exception('Not implemented yet');
62			}
63
64			public static function is_mixin($classname)
			0 ignored issues – show Unused Code introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report The parameter `$classname` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
65			{
66			return false;
67			}
68
69			public static function is_interface($classname)
			0 ignored issues – show Unused Code introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report The parameter `$classname` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
70			{
71			return false;
72			}
73
74			public static function is_abstract($classname)
			0 ignored issues – show Unused Code introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report The parameter `$classname` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
75			{
76			return false;
77			}
78
79			public static function list_defined_properties($classname)
			0 ignored issues – show Unused Code introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report The parameter `$classname` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
80			{
81			throw new Exception('Not implemented yet');
82			}
83			}

flack / midgard-portable

Push — master ( aac2ef...a9cdaa )

midgard_reflector_object::has_metadata_class() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like