Completed
Push — master ( e8b763...5d6f2d )
by Andreas
09:56 queued 03:03
created
src/api/dbobject.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
     {
64 64
         $this->initialize();
65 65
         $properties = array_merge($this->cm->getFieldNames(), $this->cm->getAssociationNames(), array_keys($this->cm->midgard['field_aliases']));
66
-        $properties = array_filter($properties, function ($input) {
66
+        $properties = array_filter($properties, function($input) {
67 67
             return (strpos($input, 'metadata_') === false);
68 68
         });
69 69
         $ret = [];
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
     {
79 79
         $this->initialize();
80 80
 
81
-        if (   !$this->cm->hasField($field)
81
+        if (!$this->cm->hasField($field)
82 82
             && array_key_exists($field, $this->cm->midgard['field_aliases'])) {
83 83
             $field = $this->cm->midgard['field_aliases'][$field];
84 84
         }
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
             if (empty($value)) {
89 89
                 $value = null;
90 90
             } else {
91
-                if (   !is_object($this->$field)
91
+                if (!is_object($this->$field)
92 92
                     || $this->$field->id != $value) {
93 93
                     $this->changed_associations[$field] = true;
94 94
                 }
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
         } elseif ($this->cm->hasField($field)) {
99 99
             $mapping = $this->cm->getFieldMapping($field);
100 100
 
101
-            if (   $mapping['type'] === 'string'
101
+            if ($mapping['type'] === 'string'
102 102
                 || $mapping['type'] == 'text') {
103 103
                 $value = (string) $value;
104 104
             } elseif ($mapping['type'] === 'integer') {
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
             } elseif ($mapping['type'] === 'float') {
109 109
                 $value = (float) $value;
110 110
             } elseif ($mapping['type'] === 'midgard_datetime') {
111
-                if (   is_string($value)
111
+                if (is_string($value)
112 112
                     && $value !== '0000-00-00 00:00:00') {
113 113
                     $value = new midgard_datetime($value);
114 114
                 } elseif (!($value instanceof midgard_datetime)) {
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
     {
125 125
         $this->initialize();
126 126
 
127
-        if (   !$this->cm->hasField($field)
127
+        if (!$this->cm->hasField($field)
128 128
             && array_key_exists($field, $this->cm->midgard['field_aliases'])) {
129 129
             $field = $this->cm->midgard['field_aliases'][$field];
130 130
         }
@@ -137,11 +137,11 @@  discard block
 block discarded – undo
137 137
             }
138 138
             return 0;
139 139
         }
140
-        if (   $this->$field === null
140
+        if ($this->$field === null
141 141
             && $this->cm->isIdentifier($field)) {
142 142
             return 0;
143 143
         }
144
-        if (   $this->$field instanceof midgard_datetime
144
+        if ($this->$field instanceof midgard_datetime
145 145
             && $this->$field->format('U') == -62169984000) {
146 146
             //This is mainly needed for working with converted Legacy databases. Midgard2 somehow handles this internally
147 147
             //@todo Find a nicer solution and research how QB handles this
Please login to merge, or discard this patch.
src/api/user.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 
62 62
     private function load_by_properties(array $properties)
63 63
     {
64
-        if (   !array_key_exists('authtype', $properties)
64
+        if (!array_key_exists('authtype', $properties)
65 65
             || !array_key_exists('login', $properties)) {
66 66
             throw exception::invalid_property_value();
67 67
         }
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 
110 110
     public function &get_person()
111 111
     {
112
-        if (   $this->person_object === null
112
+        if ($this->person_object === null
113 113
             && $this->person !== null) {
114 114
             $this->person_object = connection::get_em()->getRepository('midgard:midgard_person')->findOneBy(['guid' => $this->person]);
115 115
         }
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 
119 119
     public function create()
120 120
     {
121
-        if (   empty($this->authtype)
121
+        if (empty($this->authtype)
122 122
             || !empty($this->id)) {
123 123
             exception::invalid_property_value();
124 124
             return false;
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 
183 183
     protected function is_unique()
184 184
     {
185
-        if (   empty($this->login)
185
+        if (empty($this->login)
186 186
             || empty($this->authtype)) {
187 187
             return true;
188 188
         }
Please login to merge, or discard this patch.
src/storage/subscriber.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
         if (!($entity instanceof repligard)) {
100 100
             $repligard_entry = $em->getRepository('midgard:midgard_repligard')->findOneBy(['guid' => $entity->guid]);
101 101
 
102
-            if (   $entity instanceof metadata
102
+            if ($entity instanceof metadata
103 103
                 && $entity->{metadata::DELETED_FIELD}) {
104 104
                 $repligard_entry->object_action = self::ACTION_DELETE;
105 105
             } else {
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 
141 141
         foreach ($columns as $name => &$config) {
142 142
             if ($platform->getName() === 'sqlite') {
143
-                if (   !empty($config['primary'])
143
+                if (!empty($config['primary'])
144 144
                     && !empty($config['autoincrement'])) {
145 145
                     /*
146 146
                      * This is essentially a workaround for http://www.doctrine-project.org/jira/browse/DBAL-642
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
                     $modified = true;
150 150
                     $config['columnDefinition'] = 'INTEGER PRIMARY KEY AUTOINCREMENT';
151 151
                 }
152
-                if (   !empty($config['comment'])
152
+                if (!empty($config['comment'])
153 153
                     && $config['comment'] == 'BINARY') {
154 154
                     $modified = true;
155 155
                     $config['columnDefinition'] = $config['type']->getSQLDeclaration($config, $platform) . ' COLLATE BINARY' . $platform->getDefaultValueDeclarationSQL($config);
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
                         $config['columnDefinition'] = $config['comment'] . $platform->getDefaultValueDeclarationSQL($config);
167 167
                     }
168 168
                     if (!empty($config['columnDefinition']) && $platform->supportsInlineColumnComments()) {
169
-                        $config['columnDefinition'] .=  " COMMENT " . $platform->quoteStringLiteral($config['comment']);
169
+                        $config['columnDefinition'] .= " COMMENT " . $platform->quoteStringLiteral($config['comment']);
170 170
                     }
171 171
                 }
172 172
             }
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
     public function postGenerateSchemaTable(GenerateSchemaTableEventArgs $args)
261 261
     {
262 262
         $table = $args->getClassTable();
263
-        if (   !$table->hasOption('engine')
263
+        if (!$table->hasOption('engine')
264 264
             || $table->getOption('engine') !== 'MyISAM') {
265 265
             return;
266 266
         }
Please login to merge, or discard this patch.