flack / midgard-portable

src/storage/objectmanager.php

Doc Comments +4 added lines

@@ -65,6 +65,7 @@ 
      * This is basically a workaround for some quirks when merging detached entities with changed associations
      *
      * @todo: This may or may not be a bug in Doctrine
+     * @param dbobject $source
      */
     private function copy_associations($source, $target)
     {
@@ -222,6 +223,9 @@ 
         return $entity;
     }
 
+    /**
+     * @param dbobject $target
+     */
     private function copy_metadata($source, $target, $action = 'update')
     {
         if (!$source instanceof metadata) {

src/xmlreader.php

Doc Comments +3 added lines

@@ -95,6 +95,9 @@
         $type->add_property($property);
     }
 
+    /**
+     * @param string $name
+     */
     private function add_mixin($name, type $type)
     {
         if (empty($this->mixins[$name])) {

api/midgard/collector.php

Spacing +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
         $parsed = $this->parse_constraint_name($property);
 
         // for properties like up.name
-        if (   strpos($property, ".") !== false
+        if (strpos($property, ".") !== false
             && !(strpos($property, "metadata") === 0)) {
             return $parsed['name'] . " as " . str_replace(".", "_", $property);
         }
@@ -134,7 +134,7 @@ 
      */
     public function get($key)
     {
-        if (   !$this->_has_results()
+        if (!$this->_has_results()
             || !isset($this->_results[$key])) {
             return false;
         }

Doc Comments +7 added lines

@@ -25,6 +25,10 @@ 
 
     private $value_properties = [];
 
+    /**
+     * @param string $class
+     * @param string $field
+     */
     public function __construct($class, $field = null, $value = null)
     {
         parent::__construct($class);
@@ -68,6 +72,9 @@ 
         return true;
     }
 
+    /**
+     * @param string $property
+     */
     protected function build_property_select($property)
     {
         $parsed = $this->parse_constraint_name($property);

api/bootstrap.php

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
 use midgard\portable\mgdschema\translator;
 use midgard\portable\api\error\exception;
 
-if (   extension_loaded('midgard')
+if (extension_loaded('midgard')
     || extension_loaded('midgard2')) {
     //TODO: Print some error?
     return;

src/classgenerator.php

Indentation +1 added lines, -1 removed lines

@@ -174,7 +174,7 @@
                     break;
             }
             if (   $default !== null
-                   // we need to skip working links because in this case, Doctrine expects objects as values
+                    // we need to skip working links because in this case, Doctrine expects objects as values
                 && (   !$property->link
                     || $this->manager->resolve_targetclass($property) === false)) {
                 $line .= ' = ' . $default;

Spacing +7 added lines, -7 removed lines

@@ -62,8 +62,8 @@ 
         }
 
         $types = $this->manager->get_types();
-        uasort($types, function ($a, $b) {
-            if (   !empty($a->extends)
+        uasort($types, function($a, $b) {
+            if (!empty($a->extends)
                 && !empty($b->extends)) {
                 return strnatcmp($a->extends, $b->extends);
             } elseif (!empty($a->extends)) {
@@ -104,7 +104,7 @@ 
         $prefix = $this->get_class_prefix($namespace);
 
         foreach ($this->manager->get_types() as $type) {
-            if (   $prefix !== ''
+            if ($prefix !== ''
                 && !class_exists($type->name)) {
                 $this->add_line('class_alias( "' . $prefix . $type->name . '", "' . $type->name . '");');
             }
@@ -112,7 +112,7 @@ 
 
         foreach ($this->manager->get_inherited_mapping() as $child => $parent) {
             $this->add_line('class_alias( "' . $prefix . $parent . '", "' . $prefix . $child . '");');
-            if (   $prefix !== ''
+            if ($prefix !== ''
                 && !class_exists($child)) {
                 $this->add_line('class_alias( "' . $prefix . $parent . '", "' . $child . '");');
             }
@@ -173,9 +173,9 @@ 
                     $objects[$name] = 'new midgard_datetime("0001-01-01 00:00:00")';
                     break;
             }
-            if (   $default !== null
+            if ($default !== null
                    // we need to skip working links because in this case, Doctrine expects objects as values
-                && (   !$property->link
+                && (!$property->link
                     || $this->manager->resolve_targetclass($property) === false)) {
                 $line .= ' = ' . $default;
             }
@@ -235,7 +235,7 @@ 
         $this->write_annotations($type);
         $this->add_line('class ' . $type->name . ' extends ' . $type->extends);
         $mixins = $type->get_mixins();
-        $interfaces = array_filter(array_map(function ($name) {
+        $interfaces = array_filter(array_map(function($name) {
             if (interface_exists('\\midgard\\portable\\storage\\interfaces\\' . $name)) {
                 return '\\midgard\\portable\\storage\\interfaces\\' . $name;
             }

src/mgdschema/type.php

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
         } else {
             if ($property->parentfield) {
                 $this->parentfield = $property->name;
-                if (   empty($this->parent)
+                if (empty($this->parent)
                     && $property->link) {
                     $this->parent = $property->link['target'];
                 }

src/mgdschema/manager.php

Spacing +1 added lines, -1 removed lines

@@ -78,7 +78,7 @@
             $fqcn = $this->namespace . '\\' . $fqcn;
         }
 
-        if (   array_key_exists($fqcn, $this->types)
+        if (array_key_exists($fqcn, $this->types)
             || $property->link['target'] === $property->get_parent()->name) {
             $target_class = $property->link['target'];
         } else {

src/api/object.php

Spacing +9 added lines, -9 removed lines

@@ -80,7 +80,7 @@ 
 
     public function __get($field)
     {
-        if (   $field === 'metadata'
+        if ($field === 'metadata'
             && $this->metadata === null
             && $this instanceof metadata_interface) {
             $this->metadata = new metadata($this);
@@ -102,7 +102,7 @@ 
         foreach ($candidates as $candidate) {
             if ($this->$candidate !== null) {
                 //Proxies become stale if the object itself is detached, so we have to re-fetch
-                if (   $this->$candidate instanceof \Doctrine\ORM\Proxy\Proxy
+                if ($this->$candidate instanceof \Doctrine\ORM\Proxy\Proxy
                     && $this->$candidate->__isInitialized()) {
                     try {
                         $this->$candidate->get_by_id($this->$candidate->id);
@@ -126,7 +126,7 @@ 
         }
         // According to Doctrine documentation, proxies should be transparent, but in practice,
         // there will be problems if we don't force-load
-        if (   $entity instanceof \Doctrine\ORM\Proxy\Proxy
+        if ($entity instanceof \Doctrine\ORM\Proxy\Proxy
             && !$entity->__isInitialized()) {
             try {
                 $entity->__load();
@@ -175,7 +175,7 @@ 
             exception::duplicate();
             return false;
         }
-        if (   !$this->is_unique()
+        if (!$this->is_unique()
             || !$this->check_parent()) {
             return false;
         }
@@ -231,7 +231,7 @@ 
             midgard_connection::get_instance()->set_error(MGD_ERR_INVALID_PROPERTY_VALUE);
             return false;
         }
-        if (   $check_dependencies
+        if ($check_dependencies
             && $this->has_dependents()) {
             exception::has_dependants();
             return false;
@@ -322,7 +322,7 @@ 
     {
         $this->initialize();
 
-        if (   empty($this->cm->midgard['parentfield'])
+        if (empty($this->cm->midgard['parentfield'])
             || empty($this->cm->midgard['parent'])) {
             return true;
         }
@@ -339,7 +339,7 @@ 
         $this->initialize();
 
         foreach ($this->cm->fieldMappings as $name => $field) {
-            if (   $field['midgard:midgard_type'] == translator::TYPE_GUID
+            if ($field['midgard:midgard_type'] == translator::TYPE_GUID
                 && !empty($this->$name)
                 && !mgd_is_guid($this->$name)) {
                 exception::invalid_property_value("'" . $name . "' property's value is not a guid.");
@@ -375,7 +375,7 @@ 
             $stat = ($results > 0);
         }
 
-        if (   !$stat
+        if (!$stat
             && !empty($this->cm->midgard['childtypes'])) {
             foreach ($this->cm->midgard['childtypes'] as $typename => $parentfield) {
                 $qb = connection::get_em()->createQueryBuilder();
@@ -740,7 +740,7 @@ 
             exception::not_exists();
             return false;
         }
-        if (   $check_dependencies
+        if ($check_dependencies
             && $this->has_dependents()) {
             exception::has_dependants();
             return false;

Doc Comments +5 added lines, -1 removed lines

@@ -509,6 +509,7 @@ 
     }
 
     /**
+     * @param integer $up
      * @return QueryBuilder
      */
     protected function get_uniquefield_query($classname, $field, $part, $upfield, $up)
@@ -610,7 +611,7 @@ 
     /**
      * @param string $domain
      * @param string $name
-     * @param mixed $value
+     * @param string $value
      * @return boolean
      */
     public function set_parameter($domain, $name, $value)
@@ -816,6 +817,9 @@ 
         return new \midgard_reflection_property(get_called_class());
     }
 
+    /**
+     * @param string $guid
+     */
     public function set_guid($guid)
     {
         parent::__set('guid', $guid);

src/driver.php

Spacing +1 added lines, -1 removed lines

@@ -156,7 +156,7 @@
 
         foreach ($type->get_properties() as $name => $property) {
             // doctrine can handle id links only
-            if (   $property->link
+            if ($property->link
                 && $target_class = $this->manager->resolve_targetclass($property)) {
                 $link_mapping = [
                     'fieldName' => $property->name,