| @@ -213,7 +213,7 @@ | ||
| 213 | 213 | $midgard = midgard_connection::get_instance(); | 
| 214 | 214 |              if ($midgard->config->logfilename) { | 
| 215 | 215 | $logdir = dirname($midgard->config->logfilename); | 
| 216 | - if ( !is_dir($logdir) | |
| 216 | + if (!is_dir($logdir) | |
| 217 | 217 |                      && !mkdir($logdir, 0777, true)) { | 
| 218 | 218 |                      throw exception::user_data('Log directory could not be created'); | 
| 219 | 219 | } | 
| @@ -55,7 +55,7 @@ discard block | ||
| 55 | 55 | |
| 56 | 56 | $mgd_config = midgard_connection::get_instance()->config; | 
| 57 | 57 | $mgdschema_file = $mgd_config->vardir . '/mgdschema_classes.php'; | 
| 58 | - if ( file_exists($mgdschema_file) | |
| 58 | + if (file_exists($mgdschema_file) | |
| 59 | 59 |              && !unlink($mgdschema_file)) { | 
| 60 | 60 |              throw new \RuntimeException('Could not unlink ' . $mgdschema_file); | 
| 61 | 61 | } | 
| @@ -72,7 +72,7 @@ discard block | ||
| 72 | 72 | $cms = $em->getMetadataFactory()->getAllMetadata(); | 
| 73 | 73 | |
| 74 | 74 | // create storage | 
| 75 | - if ( !midgard_storage::create_base_storage() | |
| 75 | + if (!midgard_storage::create_base_storage() | |
| 76 | 76 |               && midgard_connection::get_instance()->get_error_string() != 'MGD_ERR_OK') { | 
| 77 | 77 |              throw new \Exception("Failed to create base database structures" . midgard_connection::get_instance()->get_error_string()); | 
| 78 | 78 | } | 
| @@ -65,7 +65,7 @@ | ||
| 65 | 65 |          } else { | 
| 66 | 66 |              if ($property->parentfield) { | 
| 67 | 67 | $this->parentfield = $property->name; | 
| 68 | - if ( empty($this->parent) | |
| 68 | + if (empty($this->parent) | |
| 69 | 69 |                      && $property->link) { | 
| 70 | 70 | $this->parent = $property->link['target']; | 
| 71 | 71 | } | 
| @@ -201,19 +201,19 @@ | ||
| 201 | 201 | break; | 
| 202 | 202 | } | 
| 203 | 203 | |
| 204 | - if ( $dbobject->id > 0 | |
| 204 | + if ($dbobject->id > 0 | |
| 205 | 205 |              && $dbobject->metadata->revised->format('U') >= $object->metadata->revised->format('U')) { | 
| 206 | 206 | midgard_connection::get_instance()->set_error(exception::OBJECT_IMPORTED); | 
| 207 | 207 | return false; | 
| 208 | 208 | } | 
| 209 | 209 | |
| 210 | - if ( $dbobject->metadata->deleted | |
| 210 | + if ($dbobject->metadata->deleted | |
| 211 | 211 |              && !$object->metadata->deleted) { | 
| 212 | 212 |              if (!midgard_object_class::undelete($dbobject->guid)) { | 
| 213 | 213 | return false; | 
| 214 | 214 | } | 
| 215 | 215 | $dbobject->metadata_deleted = false; | 
| 216 | - } elseif ( !$dbobject->metadata->deleted | |
| 216 | + } elseif (!$dbobject->metadata->deleted | |
| 217 | 217 |                   && $object->metadata->deleted) { | 
| 218 | 218 | return $dbobject->delete(); | 
| 219 | 219 | } | 
| @@ -68,8 +68,8 @@ discard block | ||
| 68 | 68 | } | 
| 69 | 69 | |
| 70 | 70 | $types = $this->manager->get_types(); | 
| 71 | -        uasort($types, function ($a, $b) { | |
| 72 | - if ( !empty($a->extends) | |
| 71 | +        uasort($types, function($a, $b) { | |
| 72 | + if (!empty($a->extends) | |
| 73 | 73 |                  && !empty($b->extends)) { | 
| 74 | 74 | return strnatcmp($a->extends, $b->extends); | 
| 75 | 75 | } | 
| @@ -112,7 +112,7 @@ discard block | ||
| 112 | 112 | $prefix = $this->get_class_prefix($namespace); | 
| 113 | 113 | |
| 114 | 114 |          foreach ($this->manager->get_types() as $type) { | 
| 115 | - if ( $prefix !== '' | |
| 115 | + if ($prefix !== '' | |
| 116 | 116 |                  && !class_exists($type->name)) { | 
| 117 | 117 |                  $this->add_line('class_alias( "' . $prefix . $type->name . '", "' . $type->name . '");'); | 
| 118 | 118 | } | 
| @@ -120,7 +120,7 @@ discard block | ||
| 120 | 120 | |
| 121 | 121 |          foreach ($this->manager->get_inherited_mapping() as $child => $parent) { | 
| 122 | 122 |              $this->add_line('class_alias( "' . $prefix . $parent . '", "' . $prefix . $child . '");'); | 
| 123 | - if ( $prefix !== '' | |
| 123 | + if ($prefix !== '' | |
| 124 | 124 |                  && !class_exists($child)) { | 
| 125 | 125 |                  $this->add_line('class_alias( "' . $prefix . $parent . '", "' . $child . '");'); | 
| 126 | 126 | } | 
| @@ -181,9 +181,9 @@ discard block | ||
| 181 | 181 |                      $objects[$name] = 'new midgard_datetime("0001-01-01 00:00:00")'; | 
| 182 | 182 | break; | 
| 183 | 183 | } | 
| 184 | - if ( $default !== null | |
| 184 | + if ($default !== null | |
| 185 | 185 | // we need to skip working links because in this case, Doctrine expects objects as values | 
| 186 | - && ( !$property->link | |
| 186 | + && (!$property->link | |
| 187 | 187 |                      || $this->manager->resolve_targetclass($property) === false)) { | 
| 188 | 188 | $line .= ' = ' . $default; | 
| 189 | 189 | } | 
| @@ -243,7 +243,7 @@ discard block | ||
| 243 | 243 | $this->write_annotations($type); | 
| 244 | 244 |          $this->add_line('class ' . $type->name . ' extends ' . $type->extends); | 
| 245 | 245 | $mixins = $type->get_mixins(); | 
| 246 | -        $interfaces = array_filter(array_map(function ($name) { | |
| 246 | +        $interfaces = array_filter(array_map(function($name) { | |
| 247 | 247 |              if (interface_exists('\\midgard\\portable\\storage\\interfaces\\' . $name)) { | 
| 248 | 248 | return '\\midgard\\portable\\storage\\interfaces\\' . $name; | 
| 249 | 249 | } | 
| @@ -260,7 +260,7 @@ discard block | ||
| 260 | 260 |                  } else { | 
| 261 | 261 | $mrp = new \midgard_reflection_property($targetclass); | 
| 262 | 262 | |
| 263 | - if ( !$mrp->is_link($part) | |
| 263 | + if (!$mrp->is_link($part) | |
| 264 | 264 |                          && !$mrp->is_special_link($part)) { | 
| 265 | 265 | throw exception::ok(); | 
| 266 | 266 | } | 
| @@ -277,7 +277,7 @@ discard block | ||
| 277 | 277 | $column = $cm->midgard['field_aliases'][$column]; | 
| 278 | 278 | } | 
| 279 | 279 | |
| 280 | - if ( !$cm->hasField($column) | |
| 280 | + if (!$cm->hasField($column) | |
| 281 | 281 |              && !$cm->hasAssociation($column)) { | 
| 282 | 282 | throw exception::ok(); | 
| 283 | 283 | } | 
| @@ -298,7 +298,7 @@ discard block | ||
| 298 | 298 | $expression = $operator . '( ?' . $this->parameters . ')'; | 
| 299 | 299 | } | 
| 300 | 300 | |
| 301 | - if ( $value === 0 | |
| 301 | + if ($value === 0 | |
| 302 | 302 | || $value === null | 
| 303 | 303 |              || is_array($value)) { | 
| 304 | 304 | $cm = connection::get_em()->getClassMetadata($parsed['targetclass']); | 
| @@ -38,7 +38,7 @@ | ||
| 38 | 38 |          if (!isset(self::$typemap[$typeattribute])) { | 
| 39 | 39 |              throw new \Exception('unknown type ' . $typeattribute); | 
| 40 | 40 | } | 
| 41 | - $search = ['unsigned ', 'guid', 'datetime', 'longtext', 'text']; | |
| 41 | + $search = ['unsigned ', 'guid', 'datetime', 'longtext', 'text']; | |
| 42 | 42 | $replace = ['', 'string', 'midgard_datetime', 'string', 'string']; | 
| 43 | 43 | |
| 44 | 44 | return str_replace($search, $replace, $typeattribute); | 
| @@ -75,7 +75,7 @@ | ||
| 75 | 75 | |
| 76 | 76 | $fqcn = $this->get_fcqn($property->link['target']); | 
| 77 | 77 | |
| 78 | - if ( isset($this->types[$fqcn]) | |
| 78 | + if (isset($this->types[$fqcn]) | |
| 79 | 79 |              || $property->link['target'] === $property->get_parent()->name) { | 
| 80 | 80 | return $property->link['target']; | 
| 81 | 81 | } | 
| @@ -95,8 +95,8 @@ discard block | ||
| 95 | 95 | $cs = $em->getUnitOfWork()->getEntityChangeSet($entity); | 
| 96 | 96 | // We only need to update repligard if we're coming from create (revision 0) | 
| 97 | 97 | // or if we delete/undelete | 
| 98 | -            if (   !array_key_exists('metadata_deleted', $cs) | |
| 99 | -                && $entity->metadata_revision > 0)  { | |
| 98 | +            if (!array_key_exists('metadata_deleted', $cs) | |
| 99 | +                && $entity->metadata_revision > 0) { | |
| 100 | 100 | $check_repligard = false; | 
| 101 | 101 | } | 
| 102 | 102 | |
| @@ -157,7 +157,7 @@ discard block | ||
| 157 | 157 | |
| 158 | 158 |          foreach ($columns as $name => &$config) { | 
| 159 | 159 |              if ($platform->getName() === 'sqlite') { | 
| 160 | - if ( !empty($config['primary']) | |
| 160 | + if (!empty($config['primary']) | |
| 161 | 161 |                      && !empty($config['autoincrement'])) { | 
| 162 | 162 | /* | 
| 163 | 163 | * This is essentially a workaround for http://www.doctrine-project.org/jira/browse/DBAL-642 | 
| @@ -166,7 +166,7 @@ discard block | ||
| 166 | 166 | $modified = true; | 
| 167 | 167 | $config['columnDefinition'] = 'INTEGER PRIMARY KEY AUTOINCREMENT'; | 
| 168 | 168 | } | 
| 169 | - if ( !empty($config['comment']) | |
| 169 | + if (!empty($config['comment']) | |
| 170 | 170 |                      && $config['comment'] == 'BINARY') { | 
| 171 | 171 | $modified = true; | 
| 172 | 172 | $config['columnDefinition'] = $config['type']->getSQLDeclaration($config, $platform) . ' COLLATE BINARY' . $platform->getDefaultValueDeclarationSQL($config); | 
| @@ -183,7 +183,7 @@ discard block | ||
| 183 | 183 | $config['columnDefinition'] = $config['comment'] . $platform->getDefaultValueDeclarationSQL($config); | 
| 184 | 184 | } | 
| 185 | 185 |                      if (!empty($config['columnDefinition']) && $platform->supportsInlineColumnComments()) { | 
| 186 | - $config['columnDefinition'] .= " COMMENT " . $platform->quoteStringLiteral($config['comment']); | |
| 186 | + $config['columnDefinition'] .= " COMMENT " . $platform->quoteStringLiteral($config['comment']); | |
| 187 | 187 | } | 
| 188 | 188 | } | 
| 189 | 189 | } | 
| @@ -276,7 +276,7 @@ discard block | ||
| 276 | 276 | public function postGenerateSchemaTable(GenerateSchemaTableEventArgs $args) | 
| 277 | 277 |      { | 
| 278 | 278 | $table = $args->getClassTable(); | 
| 279 | -        if (   !$table->hasOption('engine') | |
| 279 | +        if (!$table->hasOption('engine') | |
| 280 | 280 |              || $table->getOption('engine') !== 'MyISAM') { | 
| 281 | 281 | return; | 
| 282 | 282 | } |