flack / midgard-portable

src/command/schema.php

Spacing +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
 
         $mgd_config = midgard_connection::get_instance()->config;
         $mgdschema_file = $mgd_config->vardir . '/mgdschema_classes.php';
-        if (   file_exists($mgdschema_file)
+        if (file_exists($mgdschema_file)
             && !unlink($mgdschema_file)) {
             throw new \RuntimeException('Could not unlink ' . $mgdschema_file);
         }
@@ -72,7 +72,7 @@ 
         $cms = $em->getMetadataFactory()->getAllMetadata();
 
         // create storage
-        if (    !midgard_storage::create_base_storage()
+        if (!midgard_storage::create_base_storage()
              && midgard_connection::get_instance()->get_error_string() != 'MGD_ERR_OK') {
             throw new \Exception("Failed to create base database structures" . midgard_connection::get_instance()->get_error_string());
         }

src/api/object.php

Doc Comments +11 added lines, -1 removed lines

@@ -117,6 +117,9 @@ 
         return null;
     }
 
+    /**
+     * @param integer $id
+     */
     public function get_by_id($id)
     {
         $entity = connection::get_em()->find(get_class($this), $id);
@@ -150,6 +153,9 @@ 
         return true;
     }
 
+    /**
+     * @param string $guid
+     */
     public function get_by_guid($guid)
     {
         if (!mgd_is_guid($guid)) {
@@ -492,6 +498,7 @@ 
     }
 
     /**
+     * @param integer $up
      * @return QueryBuilder
      */
     protected function get_uniquefield_query($classname, $field, $part, $upfield, $up)
@@ -593,7 +600,7 @@ 
     /**
      * @param string $domain
      * @param string $name
-     * @param mixed $value
+     * @param string $value
      * @return boolean
      */
     public function set_parameter($domain, $name, $value)
@@ -799,6 +806,9 @@ 
         return new \midgard_reflection_property(get_called_class());
     }
 
+    /**
+     * @param string $guid
+     */
     public function set_guid($guid)
     {
         parent::__set('guid', $guid);

Spacing +9 added lines, -9 removed lines

@@ -80,7 +80,7 @@ 
 
     public function __get($field)
     {
-        if (   $field === 'metadata'
+        if ($field === 'metadata'
             && $this->metadata === null
             && $this instanceof metadata_interface) {
             $this->metadata = new metadata($this);
@@ -102,7 +102,7 @@ 
         foreach ($candidates as $candidate) {
             if ($this->$candidate !== null) {
                 //Proxies become stale if the object itself is detached, so we have to re-fetch
-                if (   $this->$candidate instanceof \Doctrine\ORM\Proxy\Proxy
+                if ($this->$candidate instanceof \Doctrine\ORM\Proxy\Proxy
                     && $this->$candidate->__isInitialized()) {
                     try {
                         $this->$candidate->get_by_id($this->$candidate->id);
@@ -126,7 +126,7 @@ 
         }
         // According to Doctrine documentation, proxies should be transparent, but in practice,
         // there will be problems if we don't force-load
-        if (   $entity instanceof \Doctrine\ORM\Proxy\Proxy
+        if ($entity instanceof \Doctrine\ORM\Proxy\Proxy
             && !$entity->__isInitialized()) {
             try {
                 $entity->__load();
@@ -175,7 +175,7 @@ 
             exception::duplicate();
             return false;
         }
-        if (   !$this->is_unique()
+        if (!$this->is_unique()
             || !$this->check_parent()) {
             return false;
         }
@@ -231,7 +231,7 @@ 
             midgard_connection::get_instance()->set_error(MGD_ERR_INVALID_PROPERTY_VALUE);
             return false;
         }
-        if (   $check_dependencies
+        if ($check_dependencies
             && $this->has_dependents()) {
             exception::has_dependants();
             return false;
@@ -322,7 +322,7 @@ 
     {
         $this->initialize();
 
-        if (   empty($this->cm->midgard['parentfield'])
+        if (empty($this->cm->midgard['parentfield'])
             || empty($this->cm->midgard['parent'])) {
             return true;
         }
@@ -339,7 +339,7 @@ 
         $this->initialize();
 
         foreach ($this->cm->fieldMappings as $name => $field) {
-            if (   $field['midgard:midgard_type'] == translator::TYPE_GUID
+            if ($field['midgard:midgard_type'] == translator::TYPE_GUID
                 && !empty($this->$name)
                 && !mgd_is_guid($this->$name)) {
                 exception::invalid_property_value("'" . $name . "' property's value is not a guid.");
@@ -375,7 +375,7 @@ 
             $stat = ($results > 0);
         }
 
-        if (   !$stat
+        if (!$stat
             && !empty($this->cm->midgard['childtypes'])) {
             foreach ($this->cm->midgard['childtypes'] as $typename => $parentfield) {
                 $qb = connection::get_em()->createQueryBuilder();
@@ -740,7 +740,7 @@ 
             exception::not_exists();
             return false;
         }
-        if (   $check_dependencies
+        if ($check_dependencies
             && $this->has_dependents()) {
             exception::has_dependants();
             return false;

api/midgard/storage.php

Doc Comments +8 added lines

@@ -56,6 +56,9 @@ 
         return true;
     }
 
+    /**
+     * @param string $classname
+     */
     public static function create_class_storage($classname)
     {
         $em = connection::get_em();
@@ -87,6 +90,11 @@ 
         $generator->generateProxyClass($cm, $filename);
     }
 
+    /**
+     * @param Doctrine\ORM\EntityManager $em
+     *
+     * @return ClassMetadata
+     */
     private static function get_cm($em, $classname)
     {
         if (!class_exists($classname)) {

api/midgard/connection.php

Doc Comments +3 added lines

@@ -29,6 +29,9 @@
 
     private $replication_enabled = true;
 
+    /**
+     * @return integer
+     */
     public static function get_instance()
     {
         if (self::$instance === null) {

api/midgard/object/class.php

Doc Comments +3 added lines

@@ -96,6 +96,9 @@
         return true;
     }
 
+    /**
+     * @param string $guid
+     */
     public static function get_object_by_guid($guid)
     {
         if (!mgd_is_guid($guid)) {

api/midgard/query/builder.php

Doc Comments +3 added lines

@@ -19,6 +19,9 @@
         }
     }
 
+    /**
+     * @param string $operator
+     */
     public function add_constraint($name, $operator, $value)
     {
         try {

src/storage/objectmanager.php

Doc Comments +4 added lines

@@ -65,6 +65,7 @@ 
      * This is basically a workaround for some quirks when merging detached entities with changed associations
      *
      * @todo: This may or may not be a bug in Doctrine
+     * @param dbobject $source
      */
     private function copy_associations($source, $target)
     {
@@ -222,6 +223,9 @@ 
         return $entity;
     }
 
+    /**
+     * @param dbobject $target
+     */
     private function copy_metadata($source, $target, $action = 'update')
     {
         if (!$source instanceof metadata) {

src/xmlreader.php

Doc Comments +3 added lines

@@ -95,6 +95,9 @@
         $type->add_property($property);
     }
 
+    /**
+     * @param string $name
+     */
     private function add_mixin($name, type $type)
     {
         if (empty($this->mixins[$name])) {

api/midgard/collector.php

Spacing +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
         $parsed = $this->parse_constraint_name($property);
 
         // for properties like up.name
-        if (   strpos($property, ".") !== false
+        if (strpos($property, ".") !== false
             && !(strpos($property, "metadata") === 0)) {
             return $parsed['name'] . " as " . str_replace(".", "_", $property);
         }
@@ -134,7 +134,7 @@ 
      */
     public function get($key)
     {
-        if (   !$this->_has_results()
+        if (!$this->_has_results()
             || !isset($this->_results[$key])) {
             return false;
         }

Doc Comments +4 added lines

@@ -25,6 +25,10 @@
 
     private $value_properties = array();
 
+    /**
+     * @param string $class
+     * @param string $field
+     */
     public function __construct($class, $field = null, $value = null)
     {
         parent::__construct($class);