flack / midgard-portable

api/midgard/collector.php

Spacing +2 added lines, -2 removed lines

@@ -70,7 +70,7 @@ 
         $parsed = $this->parse_constraint_name($property);
 
         // for properties like up.name
-        if (   strpos($property, ".") !== false
+        if (strpos($property, ".") !== false
             && !(strpos($property, "metadata") === 0))
         {
             return $parsed['name'] . " as " . str_replace(".", "_", $property);
@@ -154,7 +154,7 @@ 
      */
     public function get($key)
     {
-        if (   !$this->_has_results()
+        if (!$this->_has_results()
             || !isset($this->_results[$key]))
         {
             return false;

Doc Comments +4 added lines

@@ -25,6 +25,10 @@
 
     private $value_properties = array();
 
+    /**
+     * @param string $class
+     * @param string $field
+     */
     public function __construct($class, $field, $value)
     {
         parent::__construct($class);

api/bootstrap.php

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
 use midgard\portable\mgdschema\translator;
 use midgard\portable\api\error\exception;
 
-if (   extension_loaded('midgard')
+if (extension_loaded('midgard')
     || extension_loaded('midgard2'))
 {
     //TODO: Print some error?

src/mgdschema/manager.php

Spacing +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
             $fqcn = $this->namespace . '\\' . $fqcn;
         }
 
-        if (   array_key_exists($fqcn, $this->types)
+        if (array_key_exists($fqcn, $this->types)
             || $property->link['target'] === $property->get_parent()->name)
         {
             $target_class = $property->link['target'];

src/mgdschema/type.php

Spacing +1 added lines, -1 removed lines

@@ -76,7 +76,7 @@
             if ($property->parentfield)
             {
                 $this->parentfield = $property->name;
-                if (   empty($this->parent)
+                if (empty($this->parent)
                     && $property->link)
                 {
                     $this->parent = $property->link['target'];

src/classgenerator.php

Indentation +1 added lines, -1 removed lines

@@ -200,7 +200,7 @@
                     break;
             }
             if (   $default !== null
-                   // we need to skip working links because in this case, Doctrine expects objects as values
+                    // we need to skip working links because in this case, Doctrine expects objects as values
                 && (   !$property->link
                     || $this->manager->resolve_targetclass($property) === false))
             {

Spacing +7 added lines, -7 removed lines

@@ -63,8 +63,8 @@ 
         }
 
         $types = $this->manager->get_types();
-        uasort($types, function ($a, $b) {
-            if (   !empty($a->extends)
+        uasort($types, function($a, $b) {
+            if (!empty($a->extends)
                 && !empty($b->extends)) {
                 return strnatcmp($a->extends, $b->extends);
             } elseif (!empty($a->extends)) {
@@ -105,7 +105,7 @@ 
         $prefix = $this->get_class_prefix($namespace);
 
         foreach ($this->manager->get_types() as $type) {
-            if (   $prefix !== ''
+            if ($prefix !== ''
                 && !class_exists($type->name)) {
                 $this->add_line('class_alias( "' . $prefix . $type->name . '", "' . $type->name . '");');
             }
@@ -113,7 +113,7 @@ 
 
         foreach ($this->manager->get_inherited_mapping() as $child => $parent) {
             $this->add_line('class_alias( "' . $prefix . $parent . '", "' . $prefix . $child . '");');
-            if (   $prefix !== ''
+            if ($prefix !== ''
                 && !class_exists($child)) {
                 $this->add_line('class_alias( "' . $prefix . $parent . '", "' . $child . '");');
             }
@@ -177,9 +177,9 @@ 
                     $objects[$name] = 'new midgard_datetime("0001-01-01 00:00:00")';
                     break;
             }
-            if (   $default !== null
+            if ($default !== null
                    // we need to skip working links because in this case, Doctrine expects objects as values
-                && (   !$property->link
+                && (!$property->link
                     || $this->manager->resolve_targetclass($property) === false)) {
                 $line .= ' = ' . $default;
             }
@@ -223,7 +223,7 @@ 
     {
         $this->add_line('class ' . $type->name . ' extends ' . $type->extends);
         $mixins = $type->get_mixins();
-        $interfaces = array_filter(array_map(function ($name) {
+        $interfaces = array_filter(array_map(function($name) {
             if (interface_exists('\\midgard\\portable\\storage\\' . $name . '\\entity')) {
                 return '\\midgard\\portable\\storage\\' . $name . '\\entity';
             }

src/api/user.php

Spacing +4 added lines, -4 removed lines

@@ -61,7 +61,7 @@ 
 
     private function load_by_properties(array $properties)
     {
-        if (   !array_key_exists('authtype', $properties)
+        if (!array_key_exists('authtype', $properties)
             || !array_key_exists('login', $properties)) {
             throw exception::invalid_property_value();
         }
@@ -109,7 +109,7 @@ 
 
     public function &get_person()
     {
-        if (   $this->person_object === null
+        if ($this->person_object === null
             && $this->person !== null) {
             $this->person_object = connection::get_em()->getRepository('midgard:midgard_person')->findOneBy(array('guid' => $this->person));
         }
@@ -118,7 +118,7 @@ 
 
     public function create()
     {
-        if (   empty($this->authtype)
+        if (empty($this->authtype)
             || !empty($this->id)) {
             exception::invalid_property_value();
             return false;
@@ -182,7 +182,7 @@ 
 
     protected function is_unique()
     {
-        if (   empty($this->login)
+        if (empty($this->login)
             || empty($this->authtype)) {
             return true;
         }

src/api/dbobject.php

Spacing +8 added lines, -8 removed lines

@@ -63,7 +63,7 @@ 
     {
         $this->initialize();
         $properties = array_merge($this->cm->getFieldNames(), $this->cm->getAssociationNames(), array_keys($this->cm->midgard['field_aliases']));
-        $properties = array_filter($properties, function ($input) {
+        $properties = array_filter($properties, function($input) {
             return (strpos($input, 'metadata_') === false);
         });
         $ret = array();
@@ -78,7 +78,7 @@ 
     {
         $this->initialize();
 
-        if (   !$this->cm->hasField($field)
+        if (!$this->cm->hasField($field)
             && array_key_exists($field, $this->cm->midgard['field_aliases'])) {
             $field = $this->cm->midgard['field_aliases'][$field];
         }
@@ -88,7 +88,7 @@ 
             if (empty($value)) {
                 $value = null;
             } else {
-                if (   !is_object($this->$field)
+                if (!is_object($this->$field)
                     || $this->$field->id != $value) {
                     $this->changed_associations[$field] = true;
                 }
@@ -98,7 +98,7 @@ 
         } elseif ($this->cm->hasField($field)) {
             $mapping = $this->cm->getFieldMapping($field);
 
-            if (   $mapping['type'] === 'string'
+            if ($mapping['type'] === 'string'
                 || $mapping['type'] == 'text') {
                 $value = (string) $value;
             } elseif ($mapping['type'] === 'integer') {
@@ -108,7 +108,7 @@ 
             } elseif ($mapping['type'] === 'float') {
                 $value = (float) $value;
             } elseif ($mapping['type'] === 'midgard_datetime') {
-                if (   is_string($value)
+                if (is_string($value)
                     && $value !== '0000-00-00 00:00:00') {
                     $value = new midgard_datetime($value);
                 } elseif (!($value instanceof midgard_datetime)) {
@@ -124,7 +124,7 @@ 
     {
         $this->initialize();
 
-        if (   !$this->cm->hasField($field)
+        if (!$this->cm->hasField($field)
             && array_key_exists($field, $this->cm->midgard['field_aliases'])) {
             $field = $this->cm->midgard['field_aliases'][$field];
         }
@@ -137,11 +137,11 @@ 
             }
             return 0;
         }
-        if (   $this->$field === null
+        if ($this->$field === null
             && $this->cm->isIdentifier($field)) {
             return 0;
         }
-        if (   $this->$field instanceof midgard_datetime
+        if ($this->$field instanceof midgard_datetime
             && $this->$field->format('U') == -62169984000) {
             //This is mainly needed for working with converted Legacy databases. Midgard2 somehow handles this internally
             //@todo Find a nicer solution and research how QB handles this

src/api/object.php

Spacing +9 added lines, -9 removed lines

@@ -77,7 +77,7 @@ 
 
     public function __get($field)
     {
-        if (   $field === 'metadata'
+        if ($field === 'metadata'
             && property_exists($this, 'metadata')
             && $this->metadata === null) {
             $this->metadata = new metadata($this);
@@ -99,7 +99,7 @@ 
         foreach ($candidates as $candidate) {
             if ($this->$candidate !== null) {
                 //Proxies become stale if the object itself is detached, so we have to re-fetch
-                if (   $this->$candidate instanceof \Doctrine\ORM\Proxy\Proxy
+                if ($this->$candidate instanceof \Doctrine\ORM\Proxy\Proxy
                     && $this->$candidate->__isInitialized()) {
                     try {
                         $this->$candidate->get_by_id($this->$candidate->id);
@@ -123,7 +123,7 @@ 
         }
         // According to Doctrine documentation, proxies should be transparent, but in practice,
         // there will be problems if we don't force-load
-        if (   $entity instanceof \Doctrine\ORM\Proxy\Proxy
+        if ($entity instanceof \Doctrine\ORM\Proxy\Proxy
             && !$entity->__isInitialized()) {
             try {
                 $entity->__load();
@@ -169,7 +169,7 @@ 
             exception::duplicate();
             return false;
         }
-        if (   !$this->is_unique()
+        if (!$this->is_unique()
             || !$this->check_parent()) {
             return false;
         }
@@ -220,7 +220,7 @@ 
             midgard_connection::get_instance()->set_error(MGD_ERR_INVALID_PROPERTY_VALUE);
             return false;
         }
-        if (   $check_dependencies
+        if ($check_dependencies
             && $this->has_dependents()) {
             exception::has_dependants();
             return false;
@@ -302,7 +302,7 @@ 
     {
         $this->initialize();
 
-        if (   empty($this->cm->midgard['parentfield'])
+        if (empty($this->cm->midgard['parentfield'])
             || empty($this->cm->midgard['parent'])) {
             return true;
         }
@@ -319,7 +319,7 @@ 
         $this->initialize();
 
         foreach ($this->cm->fieldMappings as $name => $field) {
-            if (   $field['midgard:midgard_type'] == translator::TYPE_GUID
+            if ($field['midgard:midgard_type'] == translator::TYPE_GUID
                 && !empty($this->$name)
                 && !mgd_is_guid($this->$name)) {
                 exception::invalid_property_value("'" . $name . "' property's value is not a guid.");
@@ -355,7 +355,7 @@ 
             $stat = ($results > 0);
         }
 
-        if (   !$stat
+        if (!$stat
             && !empty($this->cm->midgard['childtypes'])) {
             foreach ($this->cm->midgard['childtypes'] as $typename => $parentfield) {
                 $qb = connection::get_em()->createQueryBuilder();
@@ -684,7 +684,7 @@ 
             exception::not_exists();
             return false;
         }
-        if (   $check_dependencies
+        if ($check_dependencies
             && $this->has_dependents()) {
             exception::has_dependants();
             return false;

Doc Comments +11 added lines, -1 removed lines

@@ -117,6 +117,9 @@ 
         return null;
     }
 
+    /**
+     * @param integer $id
+     */
     public function get_by_id($id)
     {
         $entity = connection::get_em()->find(get_class($this), $id);
@@ -150,6 +153,9 @@ 
         return true;
     }
 
+    /**
+     * @param string $guid
+     */
     public function get_by_guid($guid)
     {
         if (!mgd_is_guid($guid)) {
@@ -492,6 +498,7 @@ 
     }
 
     /**
+     * @param integer $up
      * @return QueryBuilder
      */
     protected function get_uniquefield_query($classname, $field, $part, $upfield, $up)
@@ -593,7 +600,7 @@ 
     /**
      * @param string $domain
      * @param string $name
-     * @param mixed $value
+     * @param string $value
      * @return boolean
      */
     public function set_parameter($domain, $name, $value)
@@ -799,6 +806,9 @@ 
         return new \midgard_reflection_property(get_called_class());
     }
 
+    /**
+     * @param string $guid
+     */
     public function set_guid($guid)
     {
         parent::__set('guid', $guid);

src/storage/connection.php

Spacing +1 added lines, -1 removed lines

@@ -213,7 +213,7 @@
             $midgard = midgard_connection::get_instance();
             if ($midgard->config->logfilename) {
                 $logdir = dirname($midgard->config->logfilename);
-                if (   !is_dir($logdir)
+                if (!is_dir($logdir)
                     && !mkdir($logdir, 0777, true)) {
                     throw exception::user_data('Log directory could not be created');
                 }