flack /
midgard-portable
| Conditions | 17 |
| Paths | 359 |
| Total Lines | 78 |
| Code Lines | 55 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 39 |
| CRAP Score | 22.3296 |
| Changes | 12 | ||
| Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 43 | 1 | protected function execute(InputInterface $input, OutputInterface $output) : int |
|
| 44 | { |
||
| 45 | 1 | if (!$this->connected) { |
|
| 46 | 1 | $path = $input->getArgument('config'); |
|
| 47 | 1 | if (empty($path)) { |
|
| 48 | if (file_exists(OPENPSA_PROJECT_BASEDIR . 'config/midgard-portable.inc.php')) { |
||
|
Bug
introduced
by
|
|||
| 49 | $path = OPENPSA_PROJECT_BASEDIR . 'config/midgard-portable.inc.php'; |
||
| 50 | } else { |
||
| 51 | $dialog = $this->getHelper('question'); |
||
| 52 | $path = $dialog->ask($input, $output, new Question('<question>Enter path to config file</question>')); |
||
| 53 | } |
||
| 54 | } |
||
| 55 | 1 | if (!file_exists($path)) { |
|
| 56 | throw new \RuntimeException('Config file ' . $path . ' not found'); |
||
| 57 | } |
||
| 58 | //we have to delay startup so that we can delete the entity class file before it gets included |
||
| 59 | 1 | connection::set_autostart(false); |
|
| 60 | 1 | require $path; |
|
| 61 | } |
||
| 62 | |||
| 63 | 1 | $mgd_config = midgard_connection::get_instance()->config; |
|
| 64 | 1 | $mgdschema_file = $mgd_config->vardir . '/mgdschema_classes.php'; |
|
| 65 | 1 | if ( file_exists($mgdschema_file) |
|
| 66 | 1 | && !unlink($mgdschema_file)) { |
|
| 67 | throw new \RuntimeException('Could not unlink ' . $mgdschema_file); |
||
| 68 | } |
||
| 69 | 1 | if (connection::get_parameter('dev_mode') !== true) { |
|
| 70 | $driver = connection::get_parameter('driver'); |
||
| 71 | $classgenerator = new classgenerator($driver->get_manager(), $mgdschema_file); |
||
| 72 | $classgenerator->write($driver->get_namespace()); |
||
| 73 | } |
||
| 74 | 1 | if (!file_exists($mgd_config->blobdir . '/0/0')) { |
|
| 75 | 1 | $mgd_config->create_blobdir(); |
|
| 76 | } |
||
| 77 | 1 | connection::startup(); |
|
| 78 | 1 | $em = connection::get_em(); |
|
| 79 | 1 | connection::invalidate_cache(); |
|
| 80 | 1 | $cms = $em->getMetadataFactory()->getAllMetadata(); |
|
| 81 | |||
| 82 | // create storage |
||
| 83 | 1 | if ( !midgard_storage::create_base_storage() |
|
| 84 | 1 | && midgard_connection::get_instance()->get_error_string() != 'MGD_ERR_OK') { |
|
| 85 | throw new \Exception("Failed to create base database structures" . midgard_connection::get_instance()->get_error_string()); |
||
| 86 | } |
||
| 87 | 1 | $force = $input->getOption('force'); |
|
| 88 | 1 | $to_update = []; |
|
| 89 | 1 | $to_create = []; |
|
| 90 | |||
| 91 | 1 | $sm = $em->getConnection()->createSchemaManager(); |
|
| 92 | 1 | foreach ($cms as $cm) { |
|
| 93 | 1 | if ($sm->tablesExist([$cm->getTableName()])) { |
|
| 94 | 1 | $to_update[] = $cm; |
|
| 95 | } else { |
||
| 96 | 1 | $to_create[] = $cm; |
|
| 97 | } |
||
| 98 | } |
||
| 99 | |||
| 100 | 1 | if (!empty($to_create)) { |
|
| 101 | 1 | $output->writeln('Creating <info>' . count($to_create) . '</info> new tables'); |
|
| 102 | 1 | $tool = new SchemaTool($em); |
|
| 103 | try { |
||
| 104 | 1 | $tool->createSchema($to_create); |
|
| 105 | } catch (\Exception $e) { |
||
| 106 | if (!$force) { |
||
| 107 | throw $e; |
||
| 108 | } |
||
| 109 | $output->writeln('<error>' . $e->getMessage() . '</error>'); |
||
| 110 | } |
||
| 111 | } |
||
| 112 | 1 | if (!empty($to_update)) { |
|
| 113 | 1 | $delete = $input->getOption('delete'); |
|
| 114 | 1 | $this->process_updates($to_update, $output, $force, $delete); |
|
| 115 | } |
||
| 116 | 1 | $output->writeln('Generating proxies'); |
|
| 117 | 1 | $this->generate_proxyfiles($cms); |
|
| 118 | |||
| 119 | 1 | $output->writeln('Done'); |
|
| 120 | 1 | return Command::SUCCESS; |
|
| 121 | } |
||
| 208 |
Loading history...