midgard_reflector_object

Complexity

Total Complexity

9

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	get_property_up()	0	3	1
A	get_property_primary()	0	3	1
A	get_property_parent()	0	3	1
A	get_property_unique()	0	4	1
A	list_children()	0	8	2
A	get_metadata_class()	0	6	2
A	has_metadata_class()	0	3	1

<?php
/**
 * @author CONTENT CONTROL http://www.contentcontrol-berlin.de/
 * @copyright CONTENT CONTROL http://www.contentcontrol-berlin.de/
 * @license http://www.gnu.org/licenses/gpl.html GNU General Public License
 */

use midgard\portable\storage\connection;

class midgard_reflector_object
{
    public static function get_property_primary(string $classname) : string

The parameter $classname is not used and could be removed.

    {
        return 'id';
    }

    public static function get_property_up(string $classname) : ?string
    {
        return midgard_object_class::get_property_up($classname);
    }

    public static function get_property_parent(string $classname) : ?string
    {
        return midgard_object_class::get_property_parent($classname);
    }

    public static function get_property_unique(string $classname) : ?string
    {
        $cm = connection::get_em()->getClassMetadata($classname);
        return $cm->midgard['unique_fields'][0] ?? null;

Accessing midgard on the interface Doctrine\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public static function list_children(string $classname) : array
    {
        $cm = connection::get_em()->getClassMetadata($classname);
        if (empty($cm->midgard['childtypes'])) {

Accessing midgard on the interface Doctrine\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

            return [];
        }
        // @todo We filter out useful information (parent field name) in the name of mgd2 compat.
        return array_fill_keys(array_keys($cm->midgard['childtypes']), '');
    }

    public static function has_metadata_class($classname) : bool
    {
        return midgard_object_class::has_metadata($classname);
    }

    public static function get_metadata_class($classname) : ?string
    {
        if (!self::has_metadata_class($classname)) {
            return null;
        }
        return 'midgard_metadata';
    }
}