fkosmala / superhive

src/Controllers/PagesController.php

<?php

/**
 *  * Pages controller
 *  *
 * The file contains all the functions used for off-chain pages.
 * Display / Save / update / ...
 *
 *  * @category   Controllers
 *  * @package    SuperHive
 *  * @author     Florent Kosmala <kosflorent@gmail.com>
 *  * @license    https://www.gnu.org/licenses/gpl-3.0.txt GPL-3.0
 *  */

declare(strict_types=1);

namespace App\Controllers;

use Psr\Container\ContainerInterface;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;

final class PagesController
{
    private ContainerInterface $app;

    public function __construct(ContainerInterface $app)
    {
        $this->app = $app;

        $session = $this->app->get('session');

        $this->app->get('view')->getEnvironment()->addGlobal("user", [
            'author' => $session['sh_author'],
            'signature' => $session['sh_sign'],
        ]);
    }

    /**
     *  * Admin pages function
     *  *
     * This function display the already written pages and a button to create one.
     *
     * @param Response $response
     */
    public function adminPages(Response $response): Response
    {
        $pagesDir = $this->app->get('pagesdir');
        $settings = $this->app->get('settings');
        $pages = [];

        $allPages = preg_grep('~\.(html)$~', scandir($pagesDir));
        foreach ($allPages as $page) {
            $pages[] = substr($page, 0, strrpos($page, '.'));
        }

        return $this->app->get('view')->render($response, '/admin/admin-pages.html', [
            'settings' => $settings,
            'pages' => $pages,
        ]);
    }

    /**
     *  * Administration new page function
     *  *
     * This function just display editor to write new page.
     *
     * @param Response $response
     */
    public function adminNewPage(Response $response): Response
    {
        $settings = $this->app->get('settings');

        return $this->app->get('view')->render($response, '/admin/admin-newpage.html', [
            'settings' => $settings,
        ]);
    }

    /**
     *  * Administration edit page function
     *  *
     * Same as adminNewPage but with already written content from already written page.
     *
     * @param string $file
     * @param Response $response
     */
    public function adminEditPage(string $file, Response $response): Response
    {
        $pageTitle = [];

The assignment to $pageTitle is dead and can be removed.

        $pagesDir = $this->app->get('pagesdir');
        $settings = $this->app->get('settings');

        $content = file_get_contents($pagesDir . $file . '.html');

        $pageTitle = preg_match('/\{% block title %\}(.*?)\{% endblock %\}/s', $content, $match);
        $pageTitle = $match[1];
        $pageContent = strstr($content, '{% block page %}');
        $pageContent = preg_replace("/\{%(.*?)%\}/", '', $pageContent);

        return $this->app->get('view')->render($response, '/admin/admin-newpage.html', [
            'pageTitle' => $pageTitle,
            'pageFile' => $file,
            'pageContent' => $pageContent,
            'settings' => $settings,
        ]);
    }

    /**
     *  * Administration delete page function
     *  *
     * called to delete fpage and return to administration Pages section
     *
     * @param string $file
     * @param Response $response
     * @param array<string, string> $args
     */
    public function adminDelPage(string $file, Response $response): Response
    {
        $name = $file;
        $pagesDir = $this->app->get('pagesdir');
        $filePath = $pagesDir . $name . '.html';

        if (unlink($filePath)) {
            $response->getBody()->write('OK');
        } else {
            $response->getBody()->write('Error');
        }

        return $response;
    }

    /**
     *  * Administration save page function
     *  *
     * Used to generate slug, html code and save page in file.
     *
     * @param Request $request
     * @param Response $response
     */
    public function adminSavePage(Request $request, Response $response): Response
    {
        $data = $request->getParsedBody();
        $pagesDir = $this->app->get('pagesdir');

        if (!empty($data['title'])) {
            $pageTitle = $data['title'];
        } else {
            $pageTitle = "No Title";
        }

        if (!empty($data['mde'])) {
            $pageContent = $data['mde'];
        } else {
            $pageContent = 'No content in this page';
        }

        // Some functions to slugify title to create very cool URL
        $acc = 'àáâãäçèéêëìíîïñòóôõöùúûüýÿÀÁÂÃÄÇÈÉÊËÌÍÎÏÑÒÓÔÕÖÙÚÛÜÝ';
        $noAcc = 'aaaaaceeeeiiiinooooouuuuyyAAAAACEEEEIIIINOOOOOUUUUY';
        $title = mb_convert_encoding($pageTitle, 'UTF-8', mb_list_encodings());
        $acc = mb_convert_encoding($acc, 'UTF-8', mb_list_encodings());
        $slug = mb_strtolower(strtr($title, $acc, $noAcc));

It seems like $title can also be of type array; however, parameter $str of strtr() does only seem to accept string, maybe add an additional type check?

It seems like $acc can also be of type array; however, parameter $from of strtr() does only seem to accept string, maybe add an additional type check?

        $slug = preg_replace('~[^\pL\d]+~u', '-', $slug);
        $slug = preg_replace('~[^-\w]+~', '', $slug);
        $slug = strtolower($slug);
        $slug = preg_replace('~-+~', '-', $slug);

        // apply Twig to the page to display with selected theme
        $page = '{% extends settings.theme ~ "/page.html" %}';
        $page .= "\n{% block title %}" . $title . "{% endblock %}\n";

Are you sure $title of type array|string can be used in concatenation?

        $page .= "\n{% block page %}\n" . $pageContent . "\n{% endblock %}\n";

        $file = $pagesDir . $slug . '.html';

        if (file_put_contents($file, $page)) {
            if (isset($_SERVER['HTTPS'])) {
                $isSecure = $_SERVER['HTTPS'];
            }
            if (isset($isSecure) && $isSecure === 'on') {
                $scheme = 'https';
            } else {
                $scheme = 'http';
            }

            if (isset($_SERVER['HTTP_HOST'])) {
                $host = $_SERVER['HTTP_HOST'];
            } else {
                $host = "unknown_host.com";
            }


            $pageUrl = $scheme . '://' . $host . '/pages/' . $slug;
            $response->getBody()->write($pageUrl);
        } else {
            $response->getBody()->write('Error');
        }
        return $response;
    }
}