CommonController::genPostsFile() - Code Metrics - Inspection of "Add Popular Posts (sorted by upvotes)" - fkosmala/superhive - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2c5565...ba7598 )

by Florent

created 2023-09-17 14:42 UTC

CommonController::genPostsFile() B

↳ Parent: CommonController

Complexity

Conditions	9
Paths	6

Size

Total Lines	65
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	9
eloc	44
c	2
b	0
f	0
nc	6
nop	0
dl	0
loc	65
rs	7.6604

How to fix Long Method

<?php

/**
 *  * Common controller
 *  *
 * The file contains every function needed in many other controllers.
 *
 *  * @category   Controllers
 *  * @package    SuperHive
 *  * @author     Florent Kosmala <[email protected]>
 *  * @license    https://www.gnu.org/licenses/gpl-3.0.txt GPL-3.0
 *  */

declare(strict_types=1);

namespace App\Controllers;

use Hive\PhpLib\Hive\Condenser as HiveCondenser;
use Psr\Container\ContainerInterface;

final class CommonController
{
    private ContainerInterface $app;

    public function __construct(ContainerInterface $app)
    {
        $this->app = $app;
    }

    /**
     *  * genPostsFile function
     *  *
     * This function will query the blockchain to have posts
     * It will generate a JSON file stored in /resources/blog/ folder
     *  */
    public function genPostsFile(): void
    {
        $settings = $this->app->get('settings');
        $result = '';

        // Hive API communication init
        $apiConfig = [
            'hiveNode' => $settings['api'],
            'debug' => false,
        ];
        $api = new HiveCondenser($apiConfig);

        // The file with the latest posts.
        $file = $this->app->get('blogfile');

        // if the JSON file doesn't exist or if it's old, take it from API
        if (!file_exists($file) || (time() - filemtime($file) > $settings['delay'])) {
            // Prepare API call according to displayed posts type
            $displayType = $settings['displayType']['type'];
            if ($displayType === 'author') {
                if (preg_match('/(hive-\d{6})/i', $settings['author']) == 1) {
                    $result = json_encode(
                        $api->getDiscussionsByCreated(
                            $settings['author']
                        ),
                        JSON_PRETTY_PRINT
                    );
                } else {
                    $dateNow = (new \DateTime())->format('Y-m-d\TH:i:s');
                    $result = json_encode(
                        $api->getDiscussionsByAuthorBeforeDate(
                            $settings['author'],
                            '',
                            $dateNow,
                            100
                        ),
                        JSON_PRETTY_PRINT
                    );
                }
            } elseif (($displayType === 'tag')) {
                $displayTag = $settings['displayType']['tag'];
                $taggedPosts = [];
                $allPosts = json_encode(
                    $api->getDiscussionsByAuthorBeforeDate(
                        $settings['author'],
                        '',
                        '',
                        100
                    )
                );
                $allPosts = json_decode($allPosts, true);
                foreach ($allPosts as &$post) {
                    $postMeta = json_decode($post['json_metadata'], true);
                    $postTags = $postMeta['tags'];
                    if (in_array($displayTag, $postTags)) {
                        $taggedPosts[] = $post;
                    }
                }

                $result = json_encode($taggedPosts, JSON_PRETTY_PRINT);
                unset($taggedPosts);
            } elseif ($displayType === 'reblog') {
                $result = json_encode($api->getDiscussionsByBlog($settings['author']), JSON_PRETTY_PRINT);
            }
            file_put_contents($file, $result);
        }
    }

    /**
     *  * getMostUsedTags function
     *  *
     * This function will get tags from each post and sort them
     * by occurence.
     *
     * @return array<string, int> $mostUsedTags
     *  */
    public function getMostUsedTags(): array
    {
        $file = $this->app->get('blogfile');
        $tags = '';

        $data = json_decode(file_get_contents($file), true);

        /* For each post, get metadata, to extract tags only */
        foreach ($data as &$post) {
            $meta = json_decode($post['json_metadata'], true);
            $tags .= implode(',', $meta['tags']) . ',';
        }

        $tagsArray = explode(',', $tags);
        $mostUsedTags = array_count_values($tagsArray); //get all occurrences of each values
        arsort($mostUsedTags);
        $mostUsedTags = array_slice($mostUsedTags, 0, 10, true);

        return $mostUsedTags;
    }

    /**
     *  * getPopularPosts function
     *  *
     * This function will get 5 posts with most upvotes
     *
     * @return array<string, int> $popularPosts
     *  */
    public function getPopularPosts(): array
    {
        $file = $this->app->get('blogfile');
        $data = json_decode(file_get_contents($file), true);

        uasort($data, function ($a, $b) {
            if(strpos($a['body'],'cross post') === false) {
                $a = count($a['active_votes']);
                $b = count($b['active_votes']);
                return ($a == $b) ? 0 : (($a > $b) ? -1 : 1);
            }
        });

        $mostPopular = array_slice($data, 0, 5, true);

        return $mostPopular;
    }
}


1			<?php
2
3			/**
4			* * Common controller
5			* *
6			* The file contains every function needed in many other controllers.
7			*
8			* * @category Controllers
9			* * @package SuperHive
10			* * @author Florent Kosmala <[email protected]>
11			* * @license https://www.gnu.org/licenses/gpl-3.0.txt GPL-3.0
12			* */
13
14			declare(strict_types=1);
15
16			namespace App\Controllers;
17
18			use Hive\PhpLib\Hive\Condenser as HiveCondenser;
19			use Psr\Container\ContainerInterface;
20
21			final class CommonController
22			{
23			private ContainerInterface $app;
24
25			public function __construct(ContainerInterface $app)
26			{
27			$this->app = $app;
28			}
29
30			/**
31			* * genPostsFile function
32			* *
33			* This function will query the blockchain to have posts
34			* It will generate a JSON file stored in /resources/blog/ folder
35			* */
36			public function genPostsFile(): void
37			{
38			$settings = $this->app->get('settings');
39			$result = '';
40
41			// Hive API communication init
42			$apiConfig = [
43			'hiveNode' => $settings['api'],
44			'debug' => false,
45			];
46			$api = new HiveCondenser($apiConfig);
47
48			// The file with the latest posts.
49			$file = $this->app->get('blogfile');
50
51			// if the JSON file doesn't exist or if it's old, take it from API
52			if (!file_exists($file) \|\| (time() - filemtime($file) > $settings['delay'])) {
53			// Prepare API call according to displayed posts type
54			$displayType = $settings['displayType']['type'];
55			if ($displayType === 'author') {
56			if (preg_match('/(hive-\d{6})/i', $settings['author']) == 1) {
57			$result = json_encode(
58			$api->getDiscussionsByCreated(
59			$settings['author']
60			),
61			JSON_PRETTY_PRINT
62			);
63			} else {
64			$dateNow = (new \DateTime())->format('Y-m-d\TH:i:s');
65			$result = json_encode(
66			$api->getDiscussionsByAuthorBeforeDate(
67			$settings['author'],
68			'',
69			$dateNow,
70			100
71			),
72			JSON_PRETTY_PRINT
73			);
74			}
75			} elseif (($displayType === 'tag')) {
76			$displayTag = $settings['displayType']['tag'];
77			$taggedPosts = [];
78			$allPosts = json_encode(
79			$api->getDiscussionsByAuthorBeforeDate(
80			$settings['author'],
81			'',
82			'',
83			100
84			)
85			);
86			$allPosts = json_decode($allPosts, true);
87			foreach ($allPosts as &$post) {
88			$postMeta = json_decode($post['json_metadata'], true);
89			$postTags = $postMeta['tags'];
90			if (in_array($displayTag, $postTags)) {
91			$taggedPosts[] = $post;
92			}
93			}
94
95			$result = json_encode($taggedPosts, JSON_PRETTY_PRINT);
96			unset($taggedPosts);
97			} elseif ($displayType === 'reblog') {
98			$result = json_encode($api->getDiscussionsByBlog($settings['author']), JSON_PRETTY_PRINT);
99			}
100			file_put_contents($file, $result);
101			}
102			}
103
104			/**
105			* * getMostUsedTags function
106			* *
107			* This function will get tags from each post and sort them
108			* by occurence.
109			*
110			* @return array<string, int> $mostUsedTags
111			* */
112			public function getMostUsedTags(): array
113			{
114			$file = $this->app->get('blogfile');
115			$tags = '';
116
117			$data = json_decode(file_get_contents($file), true);
118
119			/* For each post, get metadata, to extract tags only */
120			foreach ($data as &$post) {
121			$meta = json_decode($post['json_metadata'], true);
122			$tags .= implode(',', $meta['tags']) . ',';
123			}
124
125			$tagsArray = explode(',', $tags);
126			$mostUsedTags = array_count_values($tagsArray); //get all occurrences of each values
127			arsort($mostUsedTags);
128			$mostUsedTags = array_slice($mostUsedTags, 0, 10, true);
129
130			return $mostUsedTags;
131			}
132
133			/**
134			* * getPopularPosts function
135			* *
136			* This function will get 5 posts with most upvotes
137			*
138			* @return array<string, int> $popularPosts
139			* */
140			public function getPopularPosts(): array
141			{
142			$file = $this->app->get('blogfile');
143			$data = json_decode(file_get_contents($file), true);
144
145			uasort($data, function ($a, $b) {
146			if(strpos($a['body'],'cross post') === false) {
147			$a = count($a['active_votes']);
148			$b = count($b['active_votes']);
149			return ($a == $b) ? 0 : (($a > $b) ? -1 : 1);
150			}
151			});
152
153			$mostPopular = array_slice($data, 0, 5, true);
154
155			return $mostPopular;
156			}
157			}
158

fkosmala / superhive

Push — master ( 2c5565...ba7598 )

CommonController::genPostsFile() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like