OAuth2Client::getAccessToken() - Code Metrics - Inspection of "some refactoring" - fkooman/php-oauth2-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ef6996...428169 )

by François

created 2016-05-30 07:10 UTC

OAuth2Client::getAccessToken() C

↳ Parent: OAuth2Client

Complexity

Conditions	9
Paths	10

Size

Total Lines	59
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	59
rs	6.9133
cc	9
eloc	33
nc	10
nop	3

How to fix Long Method

<?php
/**
 * Copyright 2016 François Kooman <[email protected]>.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace fkooman\OAuth\Client;

use fkooman\OAuth\Client\Exception\OAuthException;

class OAuth2Client
{
    /** @var Provider */
    private $provider;

    /** @var HttpClientInterface */
    private $httpClient;

    /** @var RandomInterface */
    private $random;

    public function __construct(Provider $provider, HttpClientInterface $httpClient, RandomInterface $random = null)
    {
        $this->provider = $provider;
        $this->httpClient = $httpClient;
        if (is_null($random)) {
            $random = new Random();
        }
        $this->random = $random;
    }

    public function getAuthorizationRequestUri($scope, $redirectUri)
    {
        $state = $this->random->get();

        $queryParams = http_build_query(
            [
                'client_id' => $this->provider->getId(),
                'redirect_uri' => $redirectUri,
                'scope' => $scope,
                'state' => $state,
                'response_type' => 'code',
            ],
            '&'
        );

        return sprintf(
            '%s%s%s',
            $this->provider->getAuthorizationEndpoint(),
            false === strpos($this->provider->getAuthorizationEndpoint(), '?') ? '?' : '&',
            $queryParams
        );
    }

    public function getAccessToken($authorizationRequestUri, $authorizationResponseCode, $authorizationResponseState)
    {
        // parse our authorizationRequestUri to extract the state
        if (false === strpos($authorizationRequestUri, '?')) {
            throw new OAuthException('invalid authorizationRequestUri');
        }

        parse_str(explode('?', $authorizationRequestUri)[1], $queryParams);

        if (!isset($queryParams['state'])) {
            throw new OAuthException('state missing from authorizationRequestUri');
        }

        if (!isset($queryParams['redirect_uri'])) {
            throw new OAuthException('redirect_uri missing from authorizationRequestUri');
        }

        if ($authorizationResponseState !== $queryParams['state']) {
            throw new OAuthException('state from authorizationRequestUri MUST match authorizationResponseState');
        }

        // prepare access_token request
        $tokenRequestData = [
            'client_id' => $this->provider->getId(),
            'grant_type' => 'authorization_code',
            'code' => $authorizationResponseCode,
            'redirect_uri' => $queryParams['redirect_uri'],
        ];

        $responseData = $this->httpClient->post(
            $this->provider,
            $tokenRequestData
        );

        if (!isset($responseData['access_token'])) {
            throw new OAuthException('no access_token received from token endpoint');
        }

        if (!isset($responseData['token_type'])) {
            throw new OAuthException('no token_type received from token endpoint');
        }

        $scope = null;
        if (isset($responseData['scope'])) {
            $scope = $responseData['scope'];
        }

        $expiresIn = null;
        if (isset($responseData['expires_in'])) {
            $expiresIn = $responseData['expires_in'];
        }

        return new AccessToken(
            $responseData['access_token'],
            $responseData['token_type'],
            $scope,
            $expiresIn
        );
    }
}


1			<?php
2			/**
3			* Copyright 2016 François Kooman <[email protected]>.
4			*
5			* Licensed under the Apache License, Version 2.0 (the "License");
6			* you may not use this file except in compliance with the License.
7			* You may obtain a copy of the License at
8			*
9			* http://www.apache.org/licenses/LICENSE-2.0
10			*
11			* Unless required by applicable law or agreed to in writing, software
12			* distributed under the License is distributed on an "AS IS" BASIS,
13			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14			* See the License for the specific language governing permissions and
15			* limitations under the License.
16			*/
17
18			namespace fkooman\OAuth\Client;
19
20			use fkooman\OAuth\Client\Exception\OAuthException;
21
22			class OAuth2Client
23			{
24			/** @var Provider */
25			private $provider;
26
27			/** @var HttpClientInterface */
28			private $httpClient;
29
30			/** @var RandomInterface */
31			private $random;
32
33			public function __construct(Provider $provider, HttpClientInterface $httpClient, RandomInterface $random = null)
34			{
35			$this->provider = $provider;
36			$this->httpClient = $httpClient;
37			if (is_null($random)) {
38			$random = new Random();
39			}
40			$this->random = $random;
41			}
42
43			public function getAuthorizationRequestUri($scope, $redirectUri)
44			{
45			$state = $this->random->get();
46
47			$queryParams = http_build_query(
48			[
49			'client_id' => $this->provider->getId(),
50			'redirect_uri' => $redirectUri,
51			'scope' => $scope,
52			'state' => $state,
53			'response_type' => 'code',
54			],
55			'&'
56			);
57
58			return sprintf(
59			'%s%s%s',
60			$this->provider->getAuthorizationEndpoint(),
61			false === strpos($this->provider->getAuthorizationEndpoint(), '?') ? '?' : '&',
62			$queryParams
63			);
64			}
65
66			public function getAccessToken($authorizationRequestUri, $authorizationResponseCode, $authorizationResponseState)
67			{
68			// parse our authorizationRequestUri to extract the state
69			if (false === strpos($authorizationRequestUri, '?')) {
70			throw new OAuthException('invalid authorizationRequestUri');
71			}
72
73			parse_str(explode('?', $authorizationRequestUri)[1], $queryParams);
74
75			if (!isset($queryParams['state'])) {
76			throw new OAuthException('state missing from authorizationRequestUri');
77			}
78
79			if (!isset($queryParams['redirect_uri'])) {
80			throw new OAuthException('redirect_uri missing from authorizationRequestUri');
81			}
82
83			if ($authorizationResponseState !== $queryParams['state']) {
84			throw new OAuthException('state from authorizationRequestUri MUST match authorizationResponseState');
85			}
86
87			// prepare access_token request
88			$tokenRequestData = [
89			'client_id' => $this->provider->getId(),
90			'grant_type' => 'authorization_code',
91			'code' => $authorizationResponseCode,
92			'redirect_uri' => $queryParams['redirect_uri'],
93			];
94
95			$responseData = $this->httpClient->post(
96			$this->provider,
97			$tokenRequestData
98			);
99
100			if (!isset($responseData['access_token'])) {
101			throw new OAuthException('no access_token received from token endpoint');
102			}
103
104			if (!isset($responseData['token_type'])) {
105			throw new OAuthException('no token_type received from token endpoint');
106			}
107
108			$scope = null;
109			if (isset($responseData['scope'])) {
110			$scope = $responseData['scope'];
111			}
112
113			$expiresIn = null;
114			if (isset($responseData['expires_in'])) {
115			$expiresIn = $responseData['expires_in'];
116			}
117
118			return new AccessToken(
119			$responseData['access_token'],
120			$responseData['token_type'],
121			$scope,
122			$expiresIn
123			);
124			}
125			}
126

fkooman / php-oauth2-client

GitHub Access Token became invalid

Push — master ( ef6996...428169 )

OAuth2Client::getAccessToken() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like