SessionTokenStorage::__construct() - Code Metrics - Inspection of "also consider userId in SessionTokenStorage" - fkooman/php-oauth2-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6a7af2...297acc )

by François

created 2017-05-05 20:22 UTC

SessionTokenStorage::__construct() A

↳ Parent: SessionTokenStorage

Complexity

Conditions	3
Paths	4

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	10
rs	9.4285
c	1
b	0
f	0
cc	3
eloc	5
nc	4
nop	0

<?php

/**
 * Copyright (c) 2016, 2017 François Kooman <[email protected]>.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace fkooman\OAuth\Client;

class SessionTokenStorage implements TokenStorageInterface
{
    /**
     * @param string $userId
     * @param string $requestScope
     *
     * @return AccessToken|false
     */
    public function getAccessToken($userId, $requestScope)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->startSession($userId);
        foreach ($_SESSION['_oauth2_client'][$userId] as $accessToken) {
            if ($requestScope === $accessToken->getScope()) {
                return $accessToken;
            }
        }

        return false;
    }

    /**
     * @param string      $userId
     * @param AccessToken $accessToken
     */
    public function setAccessToken($userId, AccessToken $accessToken)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->startSession($userId);
        $_SESSION['_oauth2_client'][$userId][] = $accessToken;
    }

    /**
     * @param string      $userId
     * @param AccessToken $accessToken
     */
    public function deleteAccessToken($userId, AccessToken $accessToken)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->startSession($userId);
        foreach ($_SESSION['_oauth2_client'][$userId] as $i => $sessionAccessToken) {
            if ($accessToken->getScope() === $sessionAccessToken->getScope()) {
                unset($_SESSION['_oauth2_client'][$userId][$i]);
            }
        }
    }

    private function startSession($userId)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ('' === session_id()) {
            session_start();
        }

        if (!isset($_SESSION['_oauth2_client'][$userId])) {
            $_SESSION['_oauth2_client'][$userId] = [];
        }
    }
}


1			<?php
2
3			/**
4			* Copyright (c) 2016, 2017 François Kooman <[email protected]>.
5			*
6			* Permission is hereby granted, free of charge, to any person obtaining a copy
7			* of this software and associated documentation files (the "Software"), to deal
8			* in the Software without restriction, including without limitation the rights
9			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10			* copies of the Software, and to permit persons to whom the Software is
11			* furnished to do so, subject to the following conditions:
12			*
13			* The above copyright notice and this permission notice shall be included in all
14			* copies or substantial portions of the Software.
15			*
16			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22			* SOFTWARE.
23			*/
24
25			namespace fkooman\OAuth\Client;
26
27			class SessionTokenStorage implements TokenStorageInterface
28			{
29			/**
30			* @param string $userId
31			* @param string $requestScope
32			*
33			* @return AccessToken\|false
34			*/
35			public function getAccessToken($userId, $requestScope)
			0 ignored issues – show Coding Style introduced 2017-04-23 10:39 UTC by Report Bug Copy Issue Report `getAccessToken` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
36			{
37			$this->startSession($userId);
38			foreach ($_SESSION['_oauth2_client'][$userId] as $accessToken) {
39			if ($requestScope === $accessToken->getScope()) {
40			return $accessToken;
41			}
42			}
43
44			return false;
45			}
46
47			/**
48			* @param string $userId
49			* @param AccessToken $accessToken
50			*/
51			public function setAccessToken($userId, AccessToken $accessToken)
			0 ignored issues – show Coding Style introduced 2017-03-21 20:17 UTC by Report Bug Copy Issue Report `setAccessToken` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
52			{
53			$this->startSession($userId);
54			$_SESSION['_oauth2_client'][$userId][] = $accessToken;
55			}
56
57			/**
58			* @param string $userId
59			* @param AccessToken $accessToken
60			*/
61			public function deleteAccessToken($userId, AccessToken $accessToken)
			0 ignored issues – show Coding Style introduced 2017-03-21 19:44 UTC by Report Bug Copy Issue Report `deleteAccessToken` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
62			{
63			$this->startSession($userId);
64			foreach ($_SESSION['_oauth2_client'][$userId] as $i => $sessionAccessToken) {
65			if ($accessToken->getScope() === $sessionAccessToken->getScope()) {
66			unset($_SESSION['_oauth2_client'][$userId][$i]);
67			}
68			}
69			}
70
71			private function startSession($userId)
			0 ignored issues – show Coding Style introduced 2017-05-05 20:24 UTC by Report Bug Copy Issue Report `startSession` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
72			{
73			if ('' === session_id()) {
74			session_start();
75			}
76
77			if (!isset($_SESSION['_oauth2_client'][$userId])) {
78			$_SESSION['_oauth2_client'][$userId] = [];
79			}
80			}
81			}
82

fkooman / php-oauth2-client

GitHub Access Token became invalid

Push — master ( 6a7af2...297acc )

SessionTokenStorage::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like