Issues in AddPaypalExpressButtonTest.php (master) - Issues in master - fjbender/magento-2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (547)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Test/Unit/Observer/AddPaypalExpressButtonTest.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
 *
 * PHP version 5
 *
 * @category  Payone
 * @package   Payone_Magento2_Plugin
 * @author    FATCHIP GmbH <[email protected]>
 * @copyright 2003 - 2017 Payone GmbH
 * @license   <http://www.gnu.org/licenses/> GNU Lesser General Public License
 * @link      http://www.payone.de
 */

namespace Payone\Core\Test\Unit\Observer;

use Magento\Catalog\Block\ShortcutButtons;
use Magento\Framework\Event;
use Magento\Framework\Event\Observer;
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
use Magento\Framework\View\LayoutInterface;
use Magento\Paypal\Block\Express\Shortcut;
use Payone\Core\Helper\Payment;
use Payone\Core\Observer\AddPaypalExpressButtons as ClassToTest;
use Payone\Core\Test\Unit\BaseTestCase;
use Payone\Core\Model\Test\PayoneObjectManager;

class AddPaypalExpressButtonTest extends BaseTestCase
{
    /**
     * @var ClassToTest
     */
    private $classToTest;

    /**
     * @var ObjectManager|PayoneObjectManager
     */
    private $objectManager;

    /**
     * @var Payment|\PHPUnit_Framework_MockObject_MockObject
     */
    private $paymentHelper;

    protected function setUp()

    {
        $this->objectManager = $this->getObjectManager();

        $this->paymentHelper = $this->getMockBuilder(Payment::class)->disableOriginalConstructor()->getMock();

        $this->classToTest = $this->objectManager->getObject(ClassToTest::class, [
            'paymentHelper' => $this->paymentHelper
        ]);
    }

    public function testExecutePaypalInactive()

    {
        $this->paymentHelper->method('isPayPalExpressActive')->willReturn(false);
        $observer = $this->getMockBuilder(Observer::class)->disableOriginalConstructor()->getMock();

        $result = $this->classToTest->execute($observer);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertNull($result);
    }

    public function testExecutePaypalActive()

    {
        $this->paymentHelper->method('isPayPalExpressActive')->willReturn(true);

        $shortcut = $this->getMockBuilder(Shortcut::class)->disableOriginalConstructor()->getMock();

        $layout = $this->getMockBuilder(LayoutInterface::class)->disableOriginalConstructor()->getMock();
        $layout->method('createBlock')->willReturn($shortcut);

        $shortcutButtons = $this->getMockBuilder(ShortcutButtons::class)->disableOriginalConstructor()->getMock();
        $shortcutButtons->method('getLayout')->willReturn($layout);

        $event = $this->getMockBuilder(Event::class)
            ->disableOriginalConstructor()
            ->setMethods(['getContainer'])
            ->getMock();
        $event->method('getContainer')->willReturn($shortcutButtons);

        $observer = $this->getMockBuilder(Observer::class)->disableOriginalConstructor()->getMock();
        $observer->method('getEvent')->willReturn($event);

        $executed = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        /** @var Observer $observer */
        $this->classToTest->execute($observer);
        $executed = true;
        $this->assertTrue($executed);
    }

    public function testExecutePaypalActiveAddToCart()

    {
        $this->paymentHelper->method('isPayPalExpressActive')->willReturn(true);

        $shortcut = $this->getMockBuilder(Shortcut::class)->disableOriginalConstructor()->getMock();

        $layout = $this->getMockBuilder(LayoutInterface::class)->disableOriginalConstructor()->getMock();
        $layout->method('createBlock')->willReturn($shortcut);

        $shortcutButtons = $this->getMockBuilder(ShortcutButtons::class)->disableOriginalConstructor()->getMock();
        $shortcutButtons->method('getNameInLayout')->willReturn('addtocart.shortcut.buttons');
        $shortcutButtons->method('getLayout')->willReturn($layout);

        $event = $this->getMockBuilder(Event::class)
            ->disableOriginalConstructor()
            ->setMethods(['getContainer'])
            ->getMock();
        $event->method('getContainer')->willReturn($shortcutButtons);

        $observer = $this->getMockBuilder(Observer::class)->disableOriginalConstructor()->getMock();
        $observer->method('getEvent')->willReturn($event);

        $executed = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        /** @var Observer $observer */
        $this->classToTest->execute($observer);
        $executed = true;
        $this->assertTrue($executed);
    }
}


1		<?php
2
3		/**
4		* PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
5		* it under the terms of the GNU Lesser General Public License as published by
6		* the Free Software Foundation, either version 3 of the License, or
7		* (at your option) any later version.
8		*
9		* PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
10		* but WITHOUT ANY WARRANTY; without even the implied warranty of
11		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12		* GNU Lesser General Public License for more details.
13		*
14		* You should have received a copy of the GNU Lesser General Public License
15		* along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
16		*
17		* PHP version 5
18		*
19		* @category Payone
20		* @package Payone_Magento2_Plugin
21		* @author FATCHIP GmbH <[email protected]>
22		* @copyright 2003 - 2017 Payone GmbH
23		* @license <http://www.gnu.org/licenses/> GNU Lesser General Public License
24		* @link http://www.payone.de
25		*/
26
27		namespace Payone\Core\Test\Unit\Observer;
28
29		use Magento\Catalog\Block\ShortcutButtons;
30		use Magento\Framework\Event;
31		use Magento\Framework\Event\Observer;
32		use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
33		use Magento\Framework\View\LayoutInterface;
34		use Magento\Paypal\Block\Express\Shortcut;
35		use Payone\Core\Helper\Payment;
36		use Payone\Core\Observer\AddPaypalExpressButtons as ClassToTest;
37		use Payone\Core\Test\Unit\BaseTestCase;
38		use Payone\Core\Model\Test\PayoneObjectManager;
39
40		class AddPaypalExpressButtonTest extends BaseTestCase
41		{
42		/**
43		* @var ClassToTest
44		*/
45		private $classToTest;
46
47		/**
48		* @var ObjectManager\|PayoneObjectManager
49		*/
50		private $objectManager;
51
52		/**
53		* @var Payment\|\PHPUnit_Framework_MockObject_MockObject
54		*/
55		private $paymentHelper;
56
57	View Code Duplication	protected function setUp()
		0 ignored issues – show Duplication introduced 2017-08-22 11:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		{
59		$this->objectManager = $this->getObjectManager();
60
61		$this->paymentHelper = $this->getMockBuilder(Payment::class)->disableOriginalConstructor()->getMock();
62
63		$this->classToTest = $this->objectManager->getObject(ClassToTest::class, [
64		'paymentHelper' => $this->paymentHelper
65		]);
66		}
67
68	View Code Duplication	public function testExecutePaypalInactive()
		0 ignored issues – show Duplication introduced 2017-08-22 11:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69		{
70		$this->paymentHelper->method('isPayPalExpressActive')->willReturn(false);
71		$observer = $this->getMockBuilder(Observer::class)->disableOriginalConstructor()->getMock();
72
73		$result = $this->classToTest->execute($observer);
		0 ignored issues – show Bug introduced 2017-04-21 17:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$result` is correct as `$this->classToTest->execute($observer)` (which targets `Payone\Core\Observer\Add...pressButtons::execute()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
74		$this->assertNull($result);
75		}
76
77	View Code Duplication	public function testExecutePaypalActive()
		0 ignored issues – show Duplication introduced 2017-08-22 11:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		{
79		$this->paymentHelper->method('isPayPalExpressActive')->willReturn(true);
80
81		$shortcut = $this->getMockBuilder(Shortcut::class)->disableOriginalConstructor()->getMock();
82
83		$layout = $this->getMockBuilder(LayoutInterface::class)->disableOriginalConstructor()->getMock();
84		$layout->method('createBlock')->willReturn($shortcut);
85
86		$shortcutButtons = $this->getMockBuilder(ShortcutButtons::class)->disableOriginalConstructor()->getMock();
87		$shortcutButtons->method('getLayout')->willReturn($layout);
88
89		$event = $this->getMockBuilder(Event::class)
90		->disableOriginalConstructor()
91		->setMethods(['getContainer'])
92		->getMock();
93		$event->method('getContainer')->willReturn($shortcutButtons);
94
95		$observer = $this->getMockBuilder(Observer::class)->disableOriginalConstructor()->getMock();
96		$observer->method('getEvent')->willReturn($event);
97
98		$executed = false;
		0 ignored issues – show Unused Code introduced 2017-10-23 09:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$executed` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
99
100		/** @var Observer $observer */
101		$this->classToTest->execute($observer);
102		$executed = true;
103		$this->assertTrue($executed);
104		}
105
106	View Code Duplication	public function testExecutePaypalActiveAddToCart()
		0 ignored issues – show Duplication introduced 2017-08-22 11:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
107		{
108		$this->paymentHelper->method('isPayPalExpressActive')->willReturn(true);
109
110		$shortcut = $this->getMockBuilder(Shortcut::class)->disableOriginalConstructor()->getMock();
111
112		$layout = $this->getMockBuilder(LayoutInterface::class)->disableOriginalConstructor()->getMock();
113		$layout->method('createBlock')->willReturn($shortcut);
114
115		$shortcutButtons = $this->getMockBuilder(ShortcutButtons::class)->disableOriginalConstructor()->getMock();
116		$shortcutButtons->method('getNameInLayout')->willReturn('addtocart.shortcut.buttons');
117		$shortcutButtons->method('getLayout')->willReturn($layout);
118
119		$event = $this->getMockBuilder(Event::class)
120		->disableOriginalConstructor()
121		->setMethods(['getContainer'])
122		->getMock();
123		$event->method('getContainer')->willReturn($shortcutButtons);
124
125		$observer = $this->getMockBuilder(Observer::class)->disableOriginalConstructor()->getMock();
126		$observer->method('getEvent')->willReturn($event);
127
128		$executed = false;
		0 ignored issues – show Unused Code introduced 2017-10-23 09:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$executed` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
129
130		/** @var Observer $observer */
131		$this->classToTest->execute($observer);
132		$executed = true;
133		$this->assertTrue($executed);
134		}
135		}
136

fjbender / magento-2

Issues (547)

Security Analysis not enabled

Test/Unit/Observer/AddPaypalExpressButtonTest.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like