Issues (547)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Model/Api/Request/Addresscheck.php (1 issue)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
/**
4
 * PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
5
 * it under the terms of the GNU Lesser General Public License as published by
6
 * the Free Software Foundation, either version 3 of the License, or
7
 * (at your option) any later version.
8
 *
9
 * PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
10
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
 * GNU Lesser General Public License for more details.
13
 *
14
 * You should have received a copy of the GNU Lesser General Public License
15
 * along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
16
 *
17
 * PHP version 5
18
 *
19
 * @category  Payone
20
 * @package   Payone_Magento2_Plugin
21
 * @author    FATCHIP GmbH <[email protected]>
22
 * @copyright 2003 - 2016 Payone GmbH
23
 * @license   <http://www.gnu.org/licenses/> GNU Lesser General Public License
24
 * @link      http://www.payone.de
25
 */
26
27
namespace Payone\Core\Model\Api\Request;
28
29
/**
30
 * Class for the PAYONE Server API request "addresscheck"
31
 */
32
class Addresscheck extends AddressRequest
33
{
34
    /*
35
     * Array of valid countries for addresscheck basic
36
     *
37
     * @var array
38
     */
39
    protected $aValidCountrys = [
40
        'BE',
41
        'DK',
42
        'DE',
43
        'FI',
44
        'FR',
45
        'IT',
46
        'CA',
47
        'LU',
48
        'NL',
49
        'NO',
50
        'AT',
51
        'PL',
52
        'PT',
53
        'SE',
54
        'CH',
55
        'SK',
56
        'ES',
57
        'CZ',
58
        'HU',
59
        'US',
60
    ];
61
    
62
    /**
63
     * Checked addresses resource model
64
     * 
65
     * @var \Payone\Core\Model\ResourceModel\CheckedAddresses 
66
     */
67
    protected $addressesChecked;
68
69
    /**
70
     * Constructor
71
     *
72
     * @param \Payone\Core\Helper\Shop                          $shopHelper
73
     * @param \Payone\Core\Helper\Environment                   $environmentHelper
74
     * @param \Payone\Core\Helper\Api                           $apiHelper
75
     * @param \Payone\Core\Model\ResourceModel\ApiLog           $apiLog
76
     * @param \Payone\Core\Helper\Customer                      $customerHelper
77
     * @param \Payone\Core\Model\ResourceModel\CheckedAddresses $addressesChecked
78
     */
79 View Code Duplication
    public function __construct(
0 ignored issues
show
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
80
        \Payone\Core\Helper\Shop $shopHelper,
81
        \Payone\Core\Helper\Environment $environmentHelper,
82
        \Payone\Core\Helper\Api $apiHelper,
83
        \Payone\Core\Model\ResourceModel\ApiLog $apiLog,
84
        \Payone\Core\Helper\Customer $customerHelper,
85
        \Payone\Core\Model\ResourceModel\CheckedAddresses $addressesChecked
86
    ) {
87
        parent::__construct($shopHelper, $environmentHelper, $apiHelper, $apiLog, $customerHelper);
88
        $this->addressesChecked = $addressesChecked;
89
    }
90
91
    /**
92
     * Get addresscheck type
93
     *
94
     * @param  bool $blIsBillingAddress
95
     * @return string
96
     */
97
    protected function getAddresscheckType($blIsBillingAddress)
98
    {
99
        $sConfigField = 'check_billing';
100
        if ($blIsBillingAddress === false) {
101
            $sConfigField = 'check_shipping';
102
        }
103
        return $this->shopHelper->getConfigParam($sConfigField, 'address_check', 'payone_protect');
104
    }
105
106
    /**
107
     * Check if the addresscheck is available for the given check-type and address-country
108
     *
109
     * @param  string                                   $sAddresscheckType
110
     * @param  \Magento\Quote\Api\Data\AddressInterface $oAddress
111
     * @return bool
112
     */
113
    protected function validateTypeToCountry($sAddresscheckType, \Magento\Quote\Api\Data\AddressInterface $oAddress)
114
    {
115
        if ($sAddresscheckType == 'PE' && $oAddress->getCountryId() != 'DE') {
116
            //AddressCheck Person only available for germany
117
            return false;
118
        }
119
        if ($sAddresscheckType == 'BA' && array_search($oAddress->getCountryId(), $this->aValidCountrys) === false) {
120
            //AddressCheck Basic only available for certain countries
121
            return false;
122
        }
123
        return true;
124
    }
125
126
    /**
127
     * Check enabled status
128
     *
129
     * @param  bool $blIsBillingAddress
130
     * @return bool
131
     */
132
    protected function isCheckEnabled($blIsBillingAddress)
133
    {
134
        if (!$this->shopHelper->getConfigParam('enabled', 'address_check', 'payone_protect')) {
135
            return false; // address check was disabled
136
        }
137
        if ($blIsBillingAddress && $this->shopHelper->getConfigParam('check_billing', 'address_check', 'payone_protect') == 'NO') {
138
            return false; // address check was disabled for the billing address
139
        }
140
        if (!$blIsBillingAddress && $this->shopHelper->getConfigParam('check_shipping', 'address_check', 'payone_protect') == 'NO') {
141
            return false; // address check was disabled for the shipping address
142
        }
143
        return true;
144
    }
145
146
    /**
147
     * Send request "addresscheck" to PAYONE server API
148
     *
149
     * @param  \Magento\Quote\Api\Data\AddressInterface $oAddress
150
     * @param  bool                                     $blIsBillingAddress
151
     * @return array|bool
152
     */
153
    public function sendRequest(\Magento\Quote\Api\Data\AddressInterface $oAddress, $blIsBillingAddress = false)
154
    {
155
        if (!$this->isCheckEnabled($blIsBillingAddress)) { // check not needed because of configuration
156
            return true;
157
        }
158
159
        $sType = $this->getAddresscheckType($blIsBillingAddress);
160
        if (!$this->validateTypeToCountry($sType, $oAddress)) {
161
            return ['wrongCountry' => true]; //Simulate successful check
162
        }
163
164
        $this->addParameter('request', 'addresscheck');
165
        $this->addParameter('mode', $this->shopHelper->getConfigParam('mode', 'address_check', 'payone_protect')); //Operationmode live or test
166
        $this->addParameter('aid', $this->shopHelper->getConfigParam('aid')); //ID of PayOne Sub-Account
167
        $this->addParameter('addresschecktype', $sType);
168
        $this->addParameter('language', $this->shopHelper->getLocale());
169
        $this->addAddress($oAddress);
170
171
        if ($this->addressesChecked->wasAddressCheckedBefore($oAddress) === false) {
172
            $aResponse = $this->send();
173
            if ($aResponse['status'] == 'VALID') {
174
                $this->addressesChecked->addCheckedAddress($oAddress, $aResponse);
175
            }
176
            return $aResponse;
177
        }
178
        return true;
179
    }
180
}
181