Issues in Review.php (master) - Issues in master - fjbender/magento-2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (547)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Block/Onepage/Review.php (6 issues)

Labels

Severity

Minor 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
 *
 * PHP version 5
 *
 * @category  Payone
 * @package   Payone_Magento2_Plugin
 * @author    FATCHIP GmbH <[email protected]>
 * @copyright 2003 - 2017 Payone GmbH
 * @license   <http://www.gnu.org/licenses/> GNU Lesser General Public License
 * @link      http://www.payone.de
 */

namespace Payone\Core\Block\Onepage;

use Magento\Checkout\Model\Session;
use Magento\Framework\Pricing\PriceCurrencyInterface;
use Magento\Quote\Model\Quote\Address\Rate;
use Magento\Quote\Model\Quote\Address;
use Magento\Framework\DataObject;

/**
 * Paypal Express Onepage checkout block
 *
 * @author      Magento Core Team <[email protected]>
 */
class Review extends \Magento\Framework\View\Element\Template
{
    /**
     * @var \Magento\Quote\Model\Quote
     */
    protected $_quote;

    /**
     * @var \Magento\Quote\Model\Quote\Address
     */
    protected $_address;

    /**
     * @var \Magento\Customer\Model\Address\Config
     */
    protected $_addressConfig;

    /**
     * Currently selected shipping rate
     *
     * @var Rate
     */
    protected $_currentShippingRate = null;

    /**
     * Paypal controller path
     *
     * @var string
     */
    protected $_controllerPath = 'payone/onepage';

    /**
     * @var \Magento\Tax\Helper\Data
     */
    protected $_taxHelper;

    /**
     * @var PriceCurrencyInterface
     */
    protected $priceCurrency;

    /**
     * Checkout session object
     *
     * @var Session
     */
    protected $checkoutSession;

    /**
     * @param \Magento\Framework\View\Element\Template\Context $context
     * @param \Magento\Tax\Helper\Data $taxHelper
     * @param \Magento\Customer\Model\Address\Config $addressConfig
     * @param PriceCurrencyInterface $priceCurrency
     * @param Session $checkoutSession
     * @param array $data
     */
    public function __construct(
        \Magento\Framework\View\Element\Template\Context $context,
        \Magento\Tax\Helper\Data $taxHelper,
        \Magento\Customer\Model\Address\Config $addressConfig,
        PriceCurrencyInterface $priceCurrency,
        Session $checkoutSession,
        array $data = []
    ) {
        parent::__construct($context, $data);
        $this->priceCurrency = $priceCurrency;
        $this->_taxHelper = $taxHelper;
        $this->_addressConfig = $addressConfig;
        $this->checkoutSession = $checkoutSession;
        $this->getQuote(); // fill quote property
    }

    /**
     * Return checkout quote object
     *
     * @return \Magento\Quote\Model\Quote
     */
    protected function getQuote()
    {
        if (!$this->_quote) {
            $this->_quote = $this->checkoutSession->getQuote();
        }
        return $this->_quote;
    }

    /**
     * Return quote billing address
     *
     * @return Address
     */
    public function getBillingAddress()
    {
        return $this->_quote->getBillingAddress();
    }

    /**
     * Return quote shipping address
     *
     * @return false|Address
     */
    public function getShippingAddress()
    {
        if ($this->_quote->getIsVirtual()) {
            return false;
        }
        return $this->_quote->getShippingAddress();
    }

    /**
     * Get HTML output for specified address
     *
     * @param Address $address
     * @return string
     */
    public function renderAddress(Address $address)
    {
        /** @var \Magento\Customer\Block\Address\Renderer\RendererInterface $renderer */
        $renderer = $this->_addressConfig->getFormatByCode('html')->getRenderer();
        $addressData = \Magento\Framework\Convert\ConvertArray::toFlatArray($address->getData());
        return $renderer->renderArray($addressData);
    }

    /**
     * Return carrier name from config, base on carrier code
     *
     * @param string $carrierCode
     * @return string
     */
    public function getCarrierName($carrierCode)
    {
        if ($name = $this->_scopeConfig->getValue("carriers/{$carrierCode}/title", \Magento\Store\Model\ScopeInterface::SCOPE_STORE)) {
            return $name;
        }
        return $carrierCode;
    }

    /**
     * Get either shipping rate code or empty value on error
     *
     * @param DataObject $rate
     * @return string
     */
    public function renderShippingRateValue(DataObject $rate)
    {
        if ($rate->getErrorMessage()) {
            return '';
        }
        return $rate->getCode();
    }

    /**
     * Get shipping rate code title and its price or error message
     *
     * @param DataObject $rate
     * @param string $format
     * @param string $inclTaxFormat
     * @return string
     */
    public function renderShippingRateOption(DataObject $rate, $format = '%s - %s%s', $inclTaxFormat = ' (%s %s)')
    {
        $renderedInclTax = '';
        if ($rate->getErrorMessage()) {
            $price = $rate->getErrorMessage();
        } else {
            $price = $this->_getShippingPrice(
                $rate->getPrice(),
                $this->_taxHelper->displayShippingPriceIncludingTax()
            );

            $incl = $this->_getShippingPrice($rate->getPrice(), true);
            if ($incl != $price && $this->_taxHelper->displayShippingBothPrices()) {
                $renderedInclTax = sprintf($inclTaxFormat, $this->escapeHtml(__('Incl. Tax')), $incl);
            }
        }
        return sprintf($format, $this->escapeHtml($rate->getMethodTitle()), $price, $renderedInclTax);
    }

    /**
     * Getter for current shipping rate
     *
     * @return Rate
     */
    public function getCurrentShippingRate()
    {
        return $this->_currentShippingRate;
    }

    /**
     * Get quote email
     *
     * @return string
     */
    public function getEmail()
    {
        $billingAddress = $this->getBillingAddress();
        return $billingAddress ? $billingAddress->getEmail() : '';
    }

    /**
     * Return formatted shipping price
     *
     * @param float $price
     * @param bool $isInclTax
     * @return string
     */
    protected function _getShippingPrice($price, $isInclTax)
    {
        return $this->_formatPrice($this->_taxHelper->getShippingPrice($price, $isInclTax, $this->_address));
    }

    /**
     * Format price base on store convert price method
     *
     * @param float $price
     * @return string
     */
    protected function _formatPrice($price)
    {
        return $this->priceCurrency->convertAndFormat(
            $price,
            true,
            PriceCurrencyInterface::DEFAULT_PRECISION,
            $this->_quote->getStore()
        );
    }

    /**
     * Retrieve payment method and assign additional template values
     *
     * @return $this
     */
    protected function _beforeToHtml()
    {
        $methodInstance = $this->_quote->getPayment()->getMethodInstance();
        $this->setPaymentMethodTitle($methodInstance->getTitle());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $this->setShippingRateRequired(true);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($this->_quote->getIsVirtual()) {
            $this->setShippingRateRequired(false);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        } else {
            // prepare shipping rates
            $this->_address = $this->_quote->getShippingAddress();
            $groups = $this->_address->getGroupedAllShippingRates();
            if ($groups && $this->_address) {
                $this->setShippingRateGroups($groups);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                // determine current selected code & name
                foreach ($groups as $code => $rates) {
                    foreach ($rates as $rate) {
                        if ($this->_address->getShippingMethod() == $rate->getCode()) {
                            $this->_currentShippingRate = $rate;
                            break 2;
                        }
                    }
                }
            }

            // misc shipping parameters
            $this->setShippingMethodSubmitUrl(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                $this->getUrl("{$this->_controllerPath}/review", ['_secure' => true])
            );
        }

        $this->setEditUrl(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $this->getUrl("{$this->_controllerPath}/edit")
        )->setPlaceOrderUrl(
            $this->getUrl("{$this->_controllerPath}/placeOrder", ['_secure' => true])
        );

        return parent::_beforeToHtml();
    }
}


1			<?php
2
3			/**
4			* PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
5			* it under the terms of the GNU Lesser General Public License as published by
6			* the Free Software Foundation, either version 3 of the License, or
7			* (at your option) any later version.
8			*
9			* PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
10			* but WITHOUT ANY WARRANTY; without even the implied warranty of
11			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12			* GNU Lesser General Public License for more details.
13			*
14			* You should have received a copy of the GNU Lesser General Public License
15			* along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
16			*
17			* PHP version 5
18			*
19			* @category Payone
20			* @package Payone_Magento2_Plugin
21			* @author FATCHIP GmbH <[email protected]>
22			* @copyright 2003 - 2017 Payone GmbH
23			* @license <http://www.gnu.org/licenses/> GNU Lesser General Public License
24			* @link http://www.payone.de
25			*/
26
27			namespace Payone\Core\Block\Onepage;
28
29			use Magento\Checkout\Model\Session;
30			use Magento\Framework\Pricing\PriceCurrencyInterface;
31			use Magento\Quote\Model\Quote\Address\Rate;
32			use Magento\Quote\Model\Quote\Address;
33			use Magento\Framework\DataObject;
34
35			/**
36			* Paypal Express Onepage checkout block
37			*
38			* @author Magento Core Team <[email protected]>
39			*/
40			class Review extends \Magento\Framework\View\Element\Template
41			{
42			/**
43			* @var \Magento\Quote\Model\Quote
44			*/
45			protected $_quote;
46
47			/**
48			* @var \Magento\Quote\Model\Quote\Address
49			*/
50			protected $_address;
51
52			/**
53			* @var \Magento\Customer\Model\Address\Config
54			*/
55			protected $_addressConfig;
56
57			/**
58			* Currently selected shipping rate
59			*
60			* @var Rate
61			*/
62			protected $_currentShippingRate = null;
63
64			/**
65			* Paypal controller path
66			*
67			* @var string
68			*/
69			protected $_controllerPath = 'payone/onepage';
70
71			/**
72			* @var \Magento\Tax\Helper\Data
73			*/
74			protected $_taxHelper;
75
76			/**
77			* @var PriceCurrencyInterface
78			*/
79			protected $priceCurrency;
80
81			/**
82			* Checkout session object
83			*
84			* @var Session
85			*/
86			protected $checkoutSession;
87
88			/**
89			* @param \Magento\Framework\View\Element\Template\Context $context
90			* @param \Magento\Tax\Helper\Data $taxHelper
91			* @param \Magento\Customer\Model\Address\Config $addressConfig
92			* @param PriceCurrencyInterface $priceCurrency
93			* @param Session $checkoutSession
94			* @param array $data
95			*/
96			public function __construct(
97			\Magento\Framework\View\Element\Template\Context $context,
98			\Magento\Tax\Helper\Data $taxHelper,
99			\Magento\Customer\Model\Address\Config $addressConfig,
100			PriceCurrencyInterface $priceCurrency,
101			Session $checkoutSession,
102			array $data = []
103			) {
104			parent::__construct($context, $data);
105			$this->priceCurrency = $priceCurrency;
106			$this->_taxHelper = $taxHelper;
107			$this->_addressConfig = $addressConfig;
108			$this->checkoutSession = $checkoutSession;
109			$this->getQuote(); // fill quote property
110			}
111
112			/**
113			* Return checkout quote object
114			*
115			* @return \Magento\Quote\Model\Quote
116			*/
117			protected function getQuote()
118			{
119			if (!$this->_quote) {
120			$this->_quote = $this->checkoutSession->getQuote();
121			}
122			return $this->_quote;
123			}
124
125			/**
126			* Return quote billing address
127			*
128			* @return Address
129			*/
130			public function getBillingAddress()
131			{
132			return $this->_quote->getBillingAddress();
133			}
134
135			/**
136			* Return quote shipping address
137			*
138			* @return false\|Address
139			*/
140			public function getShippingAddress()
141			{
142			if ($this->_quote->getIsVirtual()) {
143			return false;
144			}
145			return $this->_quote->getShippingAddress();
146			}
147
148			/**
149			* Get HTML output for specified address
150			*
151			* @param Address $address
152			* @return string
153			*/
154			public function renderAddress(Address $address)
155			{
156			/** @var \Magento\Customer\Block\Address\Renderer\RendererInterface $renderer */
157			$renderer = $this->_addressConfig->getFormatByCode('html')->getRenderer();
158			$addressData = \Magento\Framework\Convert\ConvertArray::toFlatArray($address->getData());
159			return $renderer->renderArray($addressData);
160			}
161
162			/**
163			* Return carrier name from config, base on carrier code
164			*
165			* @param string $carrierCode
166			* @return string
167			*/
168			public function getCarrierName($carrierCode)
169			{
170			if ($name = $this->_scopeConfig->getValue("carriers/{$carrierCode}/title", \Magento\Store\Model\ScopeInterface::SCOPE_STORE)) {
171			return $name;
172			}
173			return $carrierCode;
174			}
175
176			/**
177			* Get either shipping rate code or empty value on error
178			*
179			* @param DataObject $rate
180			* @return string
181			*/
182			public function renderShippingRateValue(DataObject $rate)
183			{
184			if ($rate->getErrorMessage()) {
185			return '';
186			}
187			return $rate->getCode();
188			}
189
190			/**
191			* Get shipping rate code title and its price or error message
192			*
193			* @param DataObject $rate
194			* @param string $format
195			* @param string $inclTaxFormat
196			* @return string
197			*/
198			public function renderShippingRateOption(DataObject $rate, $format = '%s - %s%s', $inclTaxFormat = ' (%s %s)')
199			{
200			$renderedInclTax = '';
201			if ($rate->getErrorMessage()) {
202			$price = $rate->getErrorMessage();
203			} else {
204			$price = $this->_getShippingPrice(
205			$rate->getPrice(),
206			$this->_taxHelper->displayShippingPriceIncludingTax()
207			);
208
209			$incl = $this->_getShippingPrice($rate->getPrice(), true);
210			if ($incl != $price && $this->_taxHelper->displayShippingBothPrices()) {
211			$renderedInclTax = sprintf($inclTaxFormat, $this->escapeHtml(__('Incl. Tax')), $incl);
212			}
213			}
214			return sprintf($format, $this->escapeHtml($rate->getMethodTitle()), $price, $renderedInclTax);
215			}
216
217			/**
218			* Getter for current shipping rate
219			*
220			* @return Rate
221			*/
222			public function getCurrentShippingRate()
223			{
224			return $this->_currentShippingRate;
225			}
226
227			/**
228			* Get quote email
229			*
230			* @return string
231			*/
232			public function getEmail()
233			{
234			$billingAddress = $this->getBillingAddress();
235			return $billingAddress ? $billingAddress->getEmail() : '';
236			}
237
238			/**
239			* Return formatted shipping price
240			*
241			* @param float $price
242			* @param bool $isInclTax
243			* @return string
244			*/
245			protected function _getShippingPrice($price, $isInclTax)
246			{
247			return $this->_formatPrice($this->_taxHelper->getShippingPrice($price, $isInclTax, $this->_address));
248			}
249
250			/**
251			* Format price base on store convert price method
252			*
253			* @param float $price
254			* @return string
255			*/
256			protected function _formatPrice($price)
257			{
258			return $this->priceCurrency->convertAndFormat(
259			$price,
260			true,
261			PriceCurrencyInterface::DEFAULT_PRECISION,
262			$this->_quote->getStore()
263			);
264			}
265
266			/**
267			* Retrieve payment method and assign additional template values
268			*
269			* @return $this
270			*/
271			protected function _beforeToHtml()
272			{
273			$methodInstance = $this->_quote->getPayment()->getMethodInstance();
274			$this->setPaymentMethodTitle($methodInstance->getTitle());
			0 ignored issues – show Documentation Bug introduced 2017-06-15 07:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setPaymentMethodTitle` does not exist on `object<Payone\Core\Block\Onepage\Review>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
275
276			$this->setShippingRateRequired(true);
			0 ignored issues – show Documentation Bug introduced 2017-06-15 07:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setShippingRateRequired` does not exist on `object<Payone\Core\Block\Onepage\Review>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
277			if ($this->_quote->getIsVirtual()) {
278			$this->setShippingRateRequired(false);
			0 ignored issues – show Documentation Bug introduced 2017-06-15 07:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setShippingRateRequired` does not exist on `object<Payone\Core\Block\Onepage\Review>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
279			} else {
280			// prepare shipping rates
281			$this->_address = $this->_quote->getShippingAddress();
282			$groups = $this->_address->getGroupedAllShippingRates();
283			if ($groups && $this->_address) {
284			$this->setShippingRateGroups($groups);
			0 ignored issues – show Documentation Bug introduced 2017-06-15 07:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setShippingRateGroups` does not exist on `object<Payone\Core\Block\Onepage\Review>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
285			// determine current selected code & name
286			foreach ($groups as $code => $rates) {
287			foreach ($rates as $rate) {
288			if ($this->_address->getShippingMethod() == $rate->getCode()) {
289			$this->_currentShippingRate = $rate;
290			break 2;
291			}
292			}
293			}
294			}
295
296			// misc shipping parameters
297			$this->setShippingMethodSubmitUrl(
			0 ignored issues – show Documentation Bug introduced 2017-06-15 07:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setShippingMethodSubmitUrl` does not exist on `object<Payone\Core\Block\Onepage\Review>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
298			$this->getUrl("{$this->_controllerPath}/review", ['_secure' => true])
299			);
300			}
301
302			$this->setEditUrl(
			0 ignored issues – show Documentation Bug introduced 2017-06-15 07:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setEditUrl` does not exist on `object<Payone\Core\Block\Onepage\Review>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
303			$this->getUrl("{$this->_controllerPath}/edit")
304			)->setPlaceOrderUrl(
305			$this->getUrl("{$this->_controllerPath}/placeOrder", ['_secure' => true])
306			);
307
308			return parent::_beforeToHtml();
309			}
310			}
311

fjbender / magento-2

Issues (547)

Security Analysis not enabled

Block/Onepage/Review.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like