fjbender / magento-2

Helper/ConfigExport.php

Spacing +1 added lines, -1 removed lines

@@ -177,6 +177,6 @@
         if ($this->getPaymentConfig('allowspecific', $sPaymentCode, $sStoreCode, true) == '1') {
             return $this->getPaymentConfig('specificcountry', $sPaymentCode, $sStoreCode, true);
         }
-        return '';// empty return value if all countries are available
+        return ''; // empty return value if all countries are available
     }
 }

Helper/Database.php

Spacing +1 added lines, -1 removed lines

@@ -188,6 +188,6 @@
         if ($iCount === null) {
             return 0;
         }
-        return $iCount+1;
+        return $iCount + 1;
     }
 }

Setup/Tables/Transactionstatus.php

Spacing +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
             'cardpan' => ['type' => Table::TYPE_TEXT, 'length' => 32, 'option' => []],
             'clearing_bankaccountholder' => ['type' => Table::TYPE_TEXT, 'length' => 255, 'option' => []],
             'clearing_bankaccount' => ['type' => Table::TYPE_TEXT, 'length' => 32, 'option' => []],
-            'clearing_bankcode' => ['type' => Table::TYPE_TEXT, 'length' => 32, 'option' => [],],
+            'clearing_bankcode' => ['type' => Table::TYPE_TEXT, 'length' => 32, 'option' => [], ],
             'clearing_bankname' => ['type' => Table::TYPE_TEXT, 'length' => 255, 'option' => []],
             'clearing_bankbic' => ['type' => Table::TYPE_TEXT, 'length' => 32, 'option' => []],
             'clearing_bankiban' => ['type' => Table::TYPE_TEXT, 'length' => 32, 'option' => []],

Model/Entities/TransactionStatus.php

Spacing +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
         $sRequest = $this->getData($sKey);
         if ($sRequest) {
             if (Toolkit::isUTF8($sRequest)) {
-                $sRequest = utf8_decode($sRequest);// needed for unserializing the array
+                $sRequest = utf8_decode($sRequest); // needed for unserializing the array
             }
             $aRequest = unserialize($sRequest);
             if (is_array($aRequest)) {

Model/ResourceModel/TransactionStatus.php

Spacing +1 added lines, -1 removed lines

@@ -108,7 +108,7 @@
         $aRequest = $oContext->getRequest()->getPostValue();
         $sRawStatus = serialize($aRequest);
         if (!Toolkit::isUTF8($sRawStatus)) {
-            $sRawStatus = utf8_encode($sRawStatus);// needed for serializing the array
+            $sRawStatus = utf8_encode($sRawStatus); // needed for serializing the array
         }
         $sOrderId = $oOrder !== null ? $oOrder->getIncrementId() : '';
         $this->getConnection()->insert(

Model/PayoneConfig.php

Spacing +2 added lines, -2 removed lines

@@ -58,8 +58,8 @@
     const TRANSACTIONSTATUS_REMINDER = 'reminder';
     const TRANSACTIONSTATUS_VAUTHORIZATION = 'vauthorization';
     const TRANSACTIONSTATUS_VSETTLEMENT = 'vsettlement';
-    const TRANSACTIONSTATUS_TRANSFER= 'transfer';
-    const TRANSACTIONSTATUS_INVOICE= 'invoice';
+    const TRANSACTIONSTATUS_TRANSFER = 'transfer';
+    const TRANSACTIONSTATUS_INVOICE = 'invoice';
 
     /* Payment method codes */
     const METHOD_CREDITCARD = 'payone_creditcard';

Model/Api/Request/Debit.php

Spacing +4 added lines, -4 removed lines

@@ -86,19 +86,19 @@
         $oOrder = $oPaymentInfo->getOrder();
         $iTxid = $oPaymentInfo->getParentTransactionId();
         if (strpos($iTxid, '-') !== false) {
-            $iTxid = substr($iTxid, 0, strpos($iTxid, '-'));// clean the txid from the magento-suffixes
+            $iTxid = substr($iTxid, 0, strpos($iTxid, '-')); // clean the txid from the magento-suffixes
         }
 
         $this->setOrderId($oOrder->getRealOrderId());
 
         $this->addParameter('request', 'debit'); // Request method
-        $this->addParameter('mode', $oPayment->getOperationMode());// PayOne Portal Operation Mode (live or test)
+        $this->addParameter('mode', $oPayment->getOperationMode()); // PayOne Portal Operation Mode (live or test)
         $this->addParameter('txid', $iTxid); // PayOne Transaction ID
         $this->addParameter('sequencenumber', $this->databaseHelper->getSequenceNumber($iTxid));
 
         // Total order sum in smallest currency unit
-        $this->addParameter('amount', number_format((-1 * $dAmount), 2, '.', '')*100);
-        $this->addParameter('currency', $oOrder->getOrderCurrencyCode());// Currency
+        $this->addParameter('amount', number_format((-1 * $dAmount), 2, '.', '') * 100);
+        $this->addParameter('currency', $oOrder->getOrderCurrencyCode()); // Currency
         $this->addParameter('transactiontype', 'GT');
 
         $sRefundAppendix = $this->getRefundAppendix($oOrder, $oPayment);

Model/Api/Request/Getfile.php

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
                 'content' => http_build_query($this->aParameters),
             ],
         ];
-        $oContext  = stream_context_create($aOptions);
+        $oContext = stream_context_create($aOptions);
         $sMandate = file_get_contents($this->sApiUrl, false, $oContext);
         if ($sMandate !== false) {
             $sReturn = $sMandate;

Model/Api/Request/Authorization.php

Spacing +30 added lines, -30 removed lines

@@ -116,20 +116,20 @@ 
      */
     public function sendRequest(PayoneMethod $oPayment, Order $oOrder, $dAmount)
     {
-        $this->setOrderId($oOrder->getRealOrderId());// save order id to object for later use
+        $this->setOrderId($oOrder->getRealOrderId()); // save order id to object for later use
 
-        $this->addParameter('request', $oPayment->getAuthorizationMode());// add request type
-        $this->addParameter('mode', $oPayment->getOperationMode());// add mode ( live or test )
-        $this->addParameter('customerid', $oOrder->getCustomerId());// add customer id
-        $this->addParameter('aid', $this->shopHelper->getConfigParam('aid'));// add sub account id
-        $this->setAuthorizationParameters($oPayment, $oOrder, $dAmount);// set authorization params
+        $this->addParameter('request', $oPayment->getAuthorizationMode()); // add request type
+        $this->addParameter('mode', $oPayment->getOperationMode()); // add mode ( live or test )
+        $this->addParameter('customerid', $oOrder->getCustomerId()); // add customer id
+        $this->addParameter('aid', $this->shopHelper->getConfigParam('aid')); // add sub account id
+        $this->setAuthorizationParameters($oPayment, $oOrder, $dAmount); // set authorization params
         if ($oPayment->hasCustomConfig()) {// if payment type doesnt use the global settings
-            $this->addCustomParameters($oPayment);// add custom connection settings
+            $this->addCustomParameters($oPayment); // add custom connection settings
         }
 
-        $aResponse = $this->send();// send request to PAYONE Server API
+        $aResponse = $this->send(); // send request to PAYONE Server API
 
-        $this->apiHelper->addPayoneOrderData($oOrder, $this->getParameters(), $aResponse);// add payone data to order
+        $this->apiHelper->addPayoneOrderData($oOrder, $this->getParameters(), $aResponse); // add payone data to order
 
         return $aResponse;
     }
@@ -143,15 +143,15 @@ 
      */
     protected function setUserParameters(PayoneMethod $oPayment, Order $oOrder)
     {
-        $oQuote = $this->checkoutSession->getQuote();// get quote from session
-        $oCustomer = $oQuote->getCustomer();// get customer object from quote
+        $oQuote = $this->checkoutSession->getQuote(); // get quote from session
+        $oCustomer = $oQuote->getCustomer(); // get customer object from quote
         $this->addUserDataParameters($oOrder->getBillingAddress(), $oPayment, $oCustomer->getGender(), $oOrder->getCustomerEmail(), $oCustomer->getDob());
 
         $oShipping = $oOrder->getShippingAddress(); // get shipping address from order
         if ($oShipping) {// shipping address existing?
-            $this->addAddress($oShipping, true);// add regular shipping address
+            $this->addAddress($oShipping, true); // add regular shipping address
         } elseif ($oPayment->getCode() == PayoneConfig::METHOD_PAYPAL && $this->shopHelper->getConfigParam('bill_as_del_address', PayoneConfig::METHOD_PAYPAL, 'payone_payment')) {
-            $this->addAddress($oOrder->getBillingAddress(), true);// add billing address as shipping address
+            $this->addAddress($oOrder->getBillingAddress(), true); // add billing address as shipping address
         }
     }
 
@@ -165,22 +165,22 @@ 
      */
     protected function setAuthorizationParameters(PayoneMethod $oPayment, Order $oOrder, $dAmount)
     {
-        $sRefNr = $this->shopHelper->getConfigParam('ref_prefix').$oOrder->getIncrementId();// ref_prefix to prevent duplicate refnumbers in testing environments
-        $sRefNr = $oPayment->formatReferenceNumber($sRefNr);// some payment methods have refnr regulations
-        $this->addParameter('reference', $sRefNr);// add ref-nr to request
-        $this->addParameter('amount', number_format($dAmount, 2, '.', '')*100);// add price to request
-        $this->addParameter('currency', $oOrder->getOrderCurrencyCode());// add currency to request
+        $sRefNr = $this->shopHelper->getConfigParam('ref_prefix').$oOrder->getIncrementId(); // ref_prefix to prevent duplicate refnumbers in testing environments
+        $sRefNr = $oPayment->formatReferenceNumber($sRefNr); // some payment methods have refnr regulations
+        $this->addParameter('reference', $sRefNr); // add ref-nr to request
+        $this->addParameter('amount', number_format($dAmount, 2, '.', '') * 100); // add price to request
+        $this->addParameter('currency', $oOrder->getOrderCurrencyCode()); // add currency to request
         if ($this->shopHelper->getConfigParam('transmit_ip') == '1') {// is IP transmission needed?
-            $sIp = $this->environmentHelper->getRemoteIp();// get remote IP
+            $sIp = $this->environmentHelper->getRemoteIp(); // get remote IP
             if ($sIp != '') {// is IP not empty
-                $this->addParameter('ip', $sIp);// add IP address to the request
+                $this->addParameter('ip', $sIp); // add IP address to the request
             }
         }
-        $this->setUserParameters($oPayment, $oOrder);// add user data - addresses etc.
-        $this->setPaymentParameters($oPayment, $oOrder);// add payment specific parameters
+        $this->setUserParameters($oPayment, $oOrder); // add user data - addresses etc.
+        $this->setPaymentParameters($oPayment, $oOrder); // add payment specific parameters
 
         if ($this->apiHelper->isInvoiceDataNeeded($oPayment)) {//
-            $this->invoiceGenerator->addProductInfo($this, $oOrder);// add invoice parameters
+            $this->invoiceGenerator->addProductInfo($this, $oOrder); // add invoice parameters
         }
     }
 
@@ -193,15 +193,15 @@ 
      */
     protected function setPaymentParameters(PayoneMethod $oPayment, Order $oOrder)
     {
-        $this->addParameter('clearingtype', $oPayment->getClearingtype());// add payment type to request
+        $this->addParameter('clearingtype', $oPayment->getClearingtype()); // add payment type to request
         $sNarrativeText = $this->toolkitHelper->getNarrativeText($oOrder, $oPayment);
         if (!empty($sNarrativeText)) {// narrative text existing?
-            $this->addParameter('narrative_text', $sNarrativeText);// add narrative text parameter
+            $this->addParameter('narrative_text', $sNarrativeText); // add narrative text parameter
         }
-        $aPaymentParams = $oPayment->getPaymentSpecificParameters($oOrder);// get payment params specific to the payment type
-        $this->aParameters = array_merge($this->aParameters, $aPaymentParams);// merge payment params with other params
+        $aPaymentParams = $oPayment->getPaymentSpecificParameters($oOrder); // get payment params specific to the payment type
+        $this->aParameters = array_merge($this->aParameters, $aPaymentParams); // merge payment params with other params
         if ($oPayment->needsRedirectUrls() === true) {// does the used payment type need redirect urls?
-            $this->addRedirectUrls($oPayment);// add needed redirect urls
+            $this->addRedirectUrls($oPayment); // add needed redirect urls
         }
     }
 
@@ -214,9 +214,9 @@ 
     protected function addCustomParameters(PayoneMethod $oPayment)
     {
         foreach ($this->aCustomParamMap as $sParamName => $sConfigName) {// add all custom parameters
-            $sCustomConfig = $oPayment->getCustomConfigParam($sConfigName);// get custom config param
+            $sCustomConfig = $oPayment->getCustomConfigParam($sConfigName); // get custom config param
             if (!empty($sCustomConfig)) {// only add if the param is configured
-                $this->addParameter($sParamName, $sCustomConfig);// add custom param to request
+                $this->addParameter($sParamName, $sCustomConfig); // add custom param to request
             }
         }
     }