fjbender / magento-2

Model/Api/Request/Base.php

Spacing +11 added lines, -11 removed lines

@@ -120,14 +120,14 @@ 
      */
     protected function initRequest()
     {
-        $this->addParameter('mid', $this->shopHelper->getConfigParam('mid'));// PayOne Merchant ID
-        $this->addParameter('portalid', $this->shopHelper->getConfigParam('portalid'));// PayOne Portal ID
-        $this->addParameter('key', md5($this->shopHelper->getConfigParam('key')));// PayOne Portal Key
-        $this->addParameter('encoding', $this->environmentHelper->getEncoding());// Encoding
-        $this->addParameter('integrator_name', 'Magento2');// Shop-system
-        $this->addParameter('integrator_version', $this->shopHelper->getMagentoVersion());// Shop version
-        $this->addParameter('solution_name', 'fatchip');// Company developing the module
-        $this->addParameter('solution_version', PayoneConfig::MODULE_VERSION);// Module version
+        $this->addParameter('mid', $this->shopHelper->getConfigParam('mid')); // PayOne Merchant ID
+        $this->addParameter('portalid', $this->shopHelper->getConfigParam('portalid')); // PayOne Portal ID
+        $this->addParameter('key', md5($this->shopHelper->getConfigParam('key'))); // PayOne Portal Key
+        $this->addParameter('encoding', $this->environmentHelper->getEncoding()); // Encoding
+        $this->addParameter('integrator_name', 'Magento2'); // Shop-system
+        $this->addParameter('integrator_version', $this->shopHelper->getMagentoVersion()); // Shop version
+        $this->addParameter('solution_name', 'fatchip'); // Company developing the module
+        $this->addParameter('solution_version', PayoneConfig::MODULE_VERSION); // Module version
     }
 
     /**
@@ -141,7 +141,7 @@ 
     public function addParameter($sKey, $sValue, $blAddAsNullIfEmpty = false)
     {
         if ($blAddAsNullIfEmpty === true && empty($sValue)) {
-            $sValue = 'NULL';// add value as string NULL - needed in certain situations
+            $sValue = 'NULL'; // add value as string NULL - needed in certain situations
         }
         $this->aParameters[$sKey] = $sValue;
     }
@@ -251,8 +251,8 @@ 
             return $sRequestUrl;
         }
 
-        $aResponse = $this->apiHelper->sendApiRequest($sRequestUrl);// send request to PAYONE
-        $this->apiLog->addApiLogEntry($this, $aResponse, $aResponse['status']);// log request to db
+        $aResponse = $this->apiHelper->sendApiRequest($sRequestUrl); // send request to PAYONE
+        $this->apiLog->addApiLogEntry($this, $aResponse, $aResponse['status']); // log request to db
         return $aResponse;
     }
 }

Model/Api/Request/Genericpayment/PayPalExpress.php

Spacing +2 added lines, -2 removed lines

@@ -48,10 +48,10 @@
     {
         $this->addParameter('request', 'genericpayment');
         $this->addParameter('mode', $oPayment->getOperationMode());
-        $this->addParameter('aid', $this->shopHelper->getConfigParam('aid'));// ID of PayOne Sub-Account
+        $this->addParameter('aid', $this->shopHelper->getConfigParam('aid')); // ID of PayOne Sub-Account
         $this->addParameter('clearingtype', 'wlt');
         $this->addParameter('wallettype', 'PPE');
-        $this->addParameter('amount', number_format($oQuote->getGrandTotal(), 2, '.', '')*100);
+        $this->addParameter('amount', number_format($oQuote->getGrandTotal(), 2, '.', '') * 100);
         $this->addParameter('currency', $oQuote->getQuoteCurrencyCode());
         $this->addParameter('narrative_text', 'Test');
 

Model/Api/Request/AddressRequest.php

Spacing +2 added lines, -2 removed lines

@@ -77,7 +77,7 @@ 
     {
         $sPre = '';
         if ($blIsShipping === true) {
-            $sPre = 'shipping_';// add shipping prefix for shipping addresses
+            $sPre = 'shipping_'; // add shipping prefix for shipping addresses
         }
         $this->addParameter($sPre.'firstname', $oAddress->getFirstname());
         $this->addParameter($sPre.'lastname', $oAddress->getLastname());
@@ -86,7 +86,7 @@ 
         }
 
         $aStreet = $oAddress->getStreet();
-        $sStreet = is_array($aStreet) ? implode(' ', $aStreet) : $aStreet;// street may be an array
+        $sStreet = is_array($aStreet) ? implode(' ', $aStreet) : $aStreet; // street may be an array
         $this->addParameter($sPre.'street', trim($sStreet));
         $this->addParameter($sPre.'zip', $oAddress->getPostcode());
         $this->addParameter($sPre.'city', $oAddress->getCity());

Model/Api/Request/Managemandate.php

Spacing +2 added lines, -2 removed lines

@@ -77,8 +77,8 @@
         $oCustomer = $oQuote->getCustomer();
 
         $this->addParameter('request', 'managemandate'); // Request method
-        $this->addParameter('mode', $oPayment->getOperationMode());// PayOne Portal Operation Mode (live or test)
-        $this->addParameter('aid', $this->shopHelper->getConfigParam('aid'));// ID of PayOne Sub-Account
+        $this->addParameter('mode', $oPayment->getOperationMode()); // PayOne Portal Operation Mode (live or test)
+        $this->addParameter('aid', $this->shopHelper->getConfigParam('aid')); // ID of PayOne Sub-Account
         $this->addParameter('clearingtype', 'elv');
 
         $this->addParameter('customerid', $oCustomer->getId());

Model/UiComponent/DataProvider.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
         array $meta = [],
         array $data = []
     ) {
-        $this->databaseHelper = $databaseHelper;// needs to be in front of constructor, doesnt work otherwise for no apparent reason
+        $this->databaseHelper = $databaseHelper; // needs to be in front of constructor, doesnt work otherwise for no apparent reason
         parent::__construct($name, $primaryFieldName, $requestFieldName, $reporting, $searchCritBuilder, $request, $filterBuilder, $meta, $data);
     }
 

Model/Methods/BaseMethod.php

Spacing +17 added lines, -17 removed lines

@@ -235,7 +235,7 @@ 
      */
     public function getInstructions()
     {
-        return trim($this->getConfigData('instructions'));// return description text
+        return trim($this->getConfigData('instructions')); // return description text
     }
 
     /**
@@ -247,9 +247,9 @@ 
     {
         $sRequestType = $this->getAuthorizationMode();
         if ($sRequestType == PayoneConfig::REQUEST_TYPE_PREAUTHORIZATION) {
-            return AbstractMethod::ACTION_AUTHORIZE;// only create order
+            return AbstractMethod::ACTION_AUTHORIZE; // only create order
         } elseif ($sRequestType == PayoneConfig::REQUEST_TYPE_AUTHORIZATION) {
-            return AbstractMethod::ACTION_AUTHORIZE_CAPTURE;// create order and capture
+            return AbstractMethod::ACTION_AUTHORIZE_CAPTURE; // create order and capture
         }
     }
 
@@ -262,9 +262,9 @@ 
      */
     public function authorize(InfoInterface $payment, $amount)
     {
-        $oReturn = parent::authorize($payment, $amount);// execute Magento parent authorization
-        $this->sendPayoneAuthorization($payment, $amount);// send auth request to PAYONE
-        return $oReturn;// return magento parent auth value
+        $oReturn = parent::authorize($payment, $amount); // execute Magento parent authorization
+        $this->sendPayoneAuthorization($payment, $amount); // send auth request to PAYONE
+        return $oReturn; // return magento parent auth value
     }
 
     /**
@@ -276,9 +276,9 @@ 
      */
     public function refund(InfoInterface $payment, $amount)
     {
-        $oReturn = parent::refund($payment, $amount);// execute Magento parent refund
-        $this->sendPayoneDebit($payment, $amount);// send debit request to PAYONE
-        return $oReturn;// return magento parent refund value
+        $oReturn = parent::refund($payment, $amount); // execute Magento parent refund
+        $this->sendPayoneDebit($payment, $amount); // send debit request to PAYONE
+        return $oReturn; // return magento parent refund value
     }
 
     /**
@@ -290,13 +290,13 @@ 
      */
     public function capture(InfoInterface $payment, $amount)
     {
-        $oReturn = parent::capture($payment, $amount);// execute Magento parent capture
+        $oReturn = parent::capture($payment, $amount); // execute Magento parent capture
         if ($payment->getParentTransactionId()) {// does the order already have a transaction?
-            $this->sendPayoneCapture($payment, $amount);// is probably admin invoice capture
+            $this->sendPayoneCapture($payment, $amount); // is probably admin invoice capture
         } else {
-            $this->sendPayoneAuthorization($payment, $amount);// is probably frontend checkout capture
+            $this->sendPayoneAuthorization($payment, $amount); // is probably frontend checkout capture
         }
-        return $oReturn;// return magento parent capture value
+        return $oReturn; // return magento parent capture value
     }
 
     /**
@@ -311,12 +311,12 @@ 
         $iAllowSpecific = $this->shopHelper->getConfigParam('allowspecific');
         $aAvailableCountries = explode(',', $this->shopHelper->getConfigParam('specificcountry'));
         if ($this->hasCustomConfig()) {// check for non-global configuration
-            $iAllowSpecific = $this->getCustomConfigParam('allowspecific');// only specific countries allowed?
-            $aAvailableCountries = explode(',', $this->getCustomConfigParam('specificcountry'));// get allowed countries
+            $iAllowSpecific = $this->getCustomConfigParam('allowspecific'); // only specific countries allowed?
+            $aAvailableCountries = explode(',', $this->getCustomConfigParam('specificcountry')); // get allowed countries
         }
         if ($iAllowSpecific == 1 && !in_array($country, $aAvailableCountries)) {// only specific but not included
-            return false;// cant use for given country
+            return false; // cant use for given country
         }
-        return true;// can use for given country
+        return true; // can use for given country
     }
 }

Model/Methods/PayoneMethod.php

Spacing +3 added lines, -3 removed lines

@@ -111,7 +111,7 @@ 
     protected function sendPayoneAuthorization(InfoInterface $payment, $amount)
     {
         $oOrder = $payment->getOrder();
-        $this->checkoutSession->unsPayoneRedirectUrl();// remove redirect url from session
+        $this->checkoutSession->unsPayoneRedirectUrl(); // remove redirect url from session
         $aResponse = $this->authorizationRequest->sendRequest($this, $oOrder, $amount);
         $this->handleResponse($aResponse);
         if ($aResponse['status'] == 'ERROR') {// request returned an error
@@ -154,7 +154,7 @@ 
      */
     public function getPaymentSpecificParameters(Order $oOrder)
     {
-        return [];// filled in child classes
+        return []; // filled in child classes
     }
 
     /**
@@ -272,7 +272,7 @@ 
      */
     public function getSubTypeSpecificParameters(Order $oOrder)
     {
-        return [];// filled in child classes
+        return []; // filled in child classes
     }
 
     /**

Block/Onepage/Debit.php

Doc Comments +1 added lines, -1 removed lines

@@ -116,7 +116,7 @@
      * Returns formatted birthday if possible
      *
      * @param  DataObject $data
-     * @return string|bool
+     * @return string|false
      */
     protected function getFormattedBirthday(DataObject $data)
     {

Helper/Country.php

Doc Comments +1 added lines, -1 removed lines

@@ -116,7 +116,7 @@
      * Returns formatted birthday if possible
      *
      * @param  DataObject $data
-     * @return string|bool
+     * @return string|false
      */
     protected function getFormattedBirthday(DataObject $data)
     {