fjbender /
magento-2
| Conditions | 10 |
| Paths | 288 |
| Total Lines | 61 |
| Code Lines | 37 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 47 | public function sendRequest(PayoneMethod $oPayment, Quote $oQuote, $dAmount, $sBirthday = false, $sEmail = false) |
||
| 48 | { |
||
| 49 | $this->addParameter('request', 'genericpayment'); |
||
| 50 | $this->addParameter('add_paydata[action]', 'pre_check'); |
||
| 51 | |||
| 52 | $this->addParameter('mode', $oPayment->getOperationMode()); |
||
| 53 | $this->addParameter('aid', $this->shopHelper->getConfigParam('aid')); // ID of PayOne Sub-Account |
||
| 54 | $this->addParameter('api_version', '3.10'); |
||
| 55 | |||
| 56 | $this->addParameter('clearingtype', $oPayment->getClearingtype()); |
||
|
|
|||
| 57 | $this->addParameter('financingtype', $oPayment->getSubType()); |
||
| 58 | $this->addParameter('add_paydata[payment_type]', $oPayment->getLongSubType()); |
||
| 59 | |||
| 60 | $this->addParameter('amount', number_format($dAmount, 2, '.', '') * 100); |
||
| 61 | $this->addParameter('currency', $oQuote->getQuoteCurrencyCode()); |
||
| 62 | |||
| 63 | if ($sEmail === false) { |
||
| 64 | $sEmail = $oQuote->getCustomerEmail(); |
||
| 65 | } |
||
| 66 | $this->addParameter('email', $sEmail); |
||
| 67 | |||
| 68 | #if ($sBirthday === false && $oPayment->getData('info_instance')) { |
||
| 69 | if ($oPayment->getData('info_instance')) { |
||
| 70 | $sBirthday = $oPayment->getInfoInstance()->getAdditionalInformation('dateofbirth'); |
||
| 71 | } |
||
| 72 | if ($sBirthday) { |
||
| 73 | $this->addParameter('birthday', $sBirthday); |
||
| 74 | } |
||
| 75 | |||
| 76 | $oBilling = $oQuote->getBillingAddress(); |
||
| 77 | $this->addAddress($oBilling); |
||
| 78 | |||
| 79 | if ($oBilling->getCountryId() == 'NL') { |
||
| 80 | $sTelephone = $oBilling->getTelephone(); |
||
| 81 | if (empty($sTelephone)) { |
||
| 82 | $sTelephone = $oPayment->getInfoInstance()->getAdditionalInformation('telephone'); |
||
| 83 | } |
||
| 84 | $this->addParameter('telephone', $sTelephone); |
||
| 85 | } |
||
| 86 | |||
| 87 | $this->addParameter('language', $this->shopHelper->getLocale()); |
||
| 88 | |||
| 89 | $sIp = $this->environmentHelper->getRemoteIp(); // get remote IP |
||
| 90 | if ($sIp != '') {// is IP not empty |
||
| 91 | $this->addParameter('ip', $sIp); // add IP address to the request |
||
| 92 | } |
||
| 93 | |||
| 94 | if ($oPayment->getData('info_instance')) { |
||
| 95 | $sTradeRegistryNumber = $oPayment->getInfoInstance()->getAdditionalInformation('trade_registry_number'); |
||
| 96 | if ($sTradeRegistryNumber) { |
||
| 97 | $this->addParameter('add_paydata[b2b]', 'yes'); |
||
| 98 | $this->addParameter('add_paydata[company_trade_registry_number]', $sTradeRegistryNumber); |
||
| 99 | } |
||
| 100 | } |
||
| 101 | |||
| 102 | if ($oPayment->hasCustomConfig()) {// if payment type doesnt use the global settings |
||
| 103 | $this->addCustomParameters($oPayment); // add custom connection settings |
||
| 104 | } |
||
| 105 | |||
| 106 | return $this->send(); |
||
| 107 | } |
||
| 108 | } |
||
| 109 |
Loading history...
This check looks at variables that are passed out again to other methods.
If the outgoing method call has stricter type requirements than the method itself, an issue is raised.
An additional type check may prevent trouble.