fjbender / magento-2

Helper/ConfigExport.php

Spacing +1 added lines, -1 removed lines

@@ -177,6 +177,6 @@
         if ($this->getPaymentConfig('allowspecific', $sPaymentCode, $sStoreCode, true) == '1') {
             return $this->getPaymentConfig('specificcountry', $sPaymentCode, $sStoreCode, true);
         }
-        return '';// empty return value if all countries are available
+        return ''; // empty return value if all countries are available
     }
 }

Helper/Database.php

Spacing +1 added lines, -1 removed lines

@@ -188,6 +188,6 @@
         if ($iCount === null) {
             return 0;
         }
-        return $iCount+1;
+        return $iCount + 1;
     }
 }

Helper/Api.php

Spacing +10 added lines, -10 removed lines

@@ -129,9 +129,9 @@ 
             foreach ($aResponse as $iLinenum => $sLine) {// go through line by line
                 $iPos = strpos($sLine, "=");
                 if ($iPos > 0) {// is a "=" as delimiter existing?
-                    $aOutput[substr($sLine, 0, $iPos)] = trim(substr($sLine, $iPos+1));
+                    $aOutput[substr($sLine, 0, $iPos)] = trim(substr($sLine, $iPos + 1));
                 } elseif (!empty($sLine)) {// is line not empty?
-                    $aOutput[$iLinenum] = $sLine;// add the line unedited
+                    $aOutput[$iLinenum] = $sLine; // add the line unedited
                 }
             }
         }
@@ -171,11 +171,11 @@ 
     public function addPayoneOrderData(SalesOrder $oOrder, $aRequest, $aResponse)
     {
         if (isset($aResponse['txid'])) {// txid existing?
-            $oOrder->setPayoneTxid($aResponse['txid']);// add txid to order entity
+            $oOrder->setPayoneTxid($aResponse['txid']); // add txid to order entity
         }
-        $oOrder->setPayoneRefnr($aRequest['reference']);// add refnr to order entity
-        $oOrder->setPayoneAuthmode($aRequest['request']);// add authmode to order entity
-        $oOrder->setPayoneMode($aRequest['mode']);// add payone mode to order entity
+        $oOrder->setPayoneRefnr($aRequest['reference']); // add refnr to order entity
+        $oOrder->setPayoneAuthmode($aRequest['request']); // add authmode to order entity
+        $oOrder->setPayoneMode($aRequest['mode']); // add payone mode to order entity
         if (isset($aRequest['mandate_identification'])) {// mandate id existing in request?
             $oOrder->setPayoneMandateId($aRequest['mandate_identification']);
         } elseif (isset($aResponse['mandate_identification'])) {// mandate id existing in response?
@@ -191,11 +191,11 @@ 
      */
     public function isInvoiceDataNeeded(PayoneMethod $oPayment)
     {
-        $sType = $this->getConfigParam('request_type');// auth or preauth?
-        $blInvoiceEnabled = (bool)$this->getConfigParam('transmit_enabled', 'invoicing');// invoicing enabled?
+        $sType = $this->getConfigParam('request_type'); // auth or preauth?
+        $blInvoiceEnabled = (bool)$this->getConfigParam('transmit_enabled', 'invoicing'); // invoicing enabled?
         if ($oPayment->needsProductInfo() || ($sType == PayoneConfig::REQUEST_TYPE_AUTHORIZATION && $blInvoiceEnabled)) {
-            return true;// invoice data needed
+            return true; // invoice data needed
         }
-        return false;// invoice data not needed
+        return false; // invoice data not needed
     }
 }

Helper/Order.php

Spacing +2 added lines, -2 removed lines

@@ -129,8 +129,8 @@
         }
 
         if (!empty($aRates)) {// more than one shipping method existing?
-            ksort($aRates);// sort by price ascending
-            return array_shift($aRates);// return the cheapest shipping-method
+            ksort($aRates); // sort by price ascending
+            return array_shift($aRates); // return the cheapest shipping-method
         }
         return false;
     }

Helper/HostedIframe.php

Spacing +4 added lines, -4 removed lines

@@ -156,15 +156,15 @@
      */
     public function getHostedFieldConfig()
     {
-        $aHostedParams = $this->getHostedParams();// get hosted params from config
+        $aHostedParams = $this->getHostedParams(); // get hosted params from config
 
         $aFieldConfig = [];
         if (!empty($aHostedParams)) {
-            $aFieldConfig['fields'] = $this->getFieldConfig();// generate config for all field types
+            $aFieldConfig['fields'] = $this->getFieldConfig(); // generate config for all field types
             $aFieldConfig['defaultStyle'] = $this->getDefaultStyles($aHostedParams);
             if ($aHostedParams['Errors_active'] == "true") {
-                $aFieldConfig['error'] = 'errorOutput';// area to display error-messages (optional)
-                $aFieldConfig['language'] = $aHostedParams['Errors_lang'];// has to be defined in javascript
+                $aFieldConfig['error'] = 'errorOutput'; // area to display error-messages (optional)
+                $aFieldConfig['language'] = $aHostedParams['Errors_lang']; // has to be defined in javascript
             }
         }
         return $aFieldConfig;

Helper/Toolkit.php

Spacing +3 added lines, -3 removed lines

@@ -135,7 +135,7 @@ 
         if (!empty($sText)) {
             $sText = str_replace(array_keys($aSubstitutionArray), array_values($aSubstitutionArray), $sText);
             if ($iMaxLength !== false && strlen($sText) > $iMaxLength) {
-                $sText = substr($sText, 0, $iMaxLength);// shorten text if too long
+                $sText = substr($sText, 0, $iMaxLength); // shorten text if too long
             }
             return $sText;
         }
@@ -150,7 +150,7 @@ 
      */
     public function getInvoiceAppendix(SalesOrder $oOrder)
     {
-        $sText = $this->getConfigParam('invoice_appendix', 'invoicing');// get invoice appendix from config
+        $sText = $this->getConfigParam('invoice_appendix', 'invoicing'); // get invoice appendix from config
         $aSubstitutionArray = [
             '{{order_increment_id}}' => $oOrder->getIncrementId(),
             '{{customer_id}}' => $oOrder->getCustomerId(),
@@ -168,7 +168,7 @@ 
      */
     public function getNarrativeText(SalesOrder $oOrder, PayoneMethod $oPayment)
     {
-        $sText = $this->getConfigParam($oPayment->getCode(), 'text');// get narrative text for payment from config
+        $sText = $this->getConfigParam($oPayment->getCode(), 'text'); // get narrative text for payment from config
         $aSubstitutionArray = [
             '{{order_increment_id}}' => $oOrder->getIncrementId(),
         ];

Model/Methods/BaseMethod.php

Spacing +17 added lines, -17 removed lines

@@ -235,7 +235,7 @@ 
      */
     public function getInstructions()
     {
-        return trim($this->getConfigData('instructions'));// return description text
+        return trim($this->getConfigData('instructions')); // return description text
     }
 
     /**
@@ -247,9 +247,9 @@ 
     {
         $sRequestType = $this->getAuthorizationMode();
         if ($sRequestType == PayoneConfig::REQUEST_TYPE_PREAUTHORIZATION) {
-            return AbstractMethod::ACTION_AUTHORIZE;// only create order
+            return AbstractMethod::ACTION_AUTHORIZE; // only create order
         } elseif ($sRequestType == PayoneConfig::REQUEST_TYPE_AUTHORIZATION) {
-            return AbstractMethod::ACTION_AUTHORIZE_CAPTURE;// create order and capture
+            return AbstractMethod::ACTION_AUTHORIZE_CAPTURE; // create order and capture
         }
     }
 
@@ -262,9 +262,9 @@ 
      */
     public function authorize(InfoInterface $payment, $amount)
     {
-        $oReturn = parent::authorize($payment, $amount);// execute Magento parent authorization
-        $this->sendPayoneAuthorization($payment, $amount);// send auth request to PAYONE
-        return $oReturn;// return magento parent auth value
+        $oReturn = parent::authorize($payment, $amount); // execute Magento parent authorization
+        $this->sendPayoneAuthorization($payment, $amount); // send auth request to PAYONE
+        return $oReturn; // return magento parent auth value
     }
 
     /**
@@ -276,9 +276,9 @@ 
      */
     public function refund(InfoInterface $payment, $amount)
     {
-        $oReturn = parent::refund($payment, $amount);// execute Magento parent refund
-        $this->sendPayoneDebit($payment, $amount);// send debit request to PAYONE
-        return $oReturn;// return magento parent refund value
+        $oReturn = parent::refund($payment, $amount); // execute Magento parent refund
+        $this->sendPayoneDebit($payment, $amount); // send debit request to PAYONE
+        return $oReturn; // return magento parent refund value
     }
 
     /**
@@ -290,13 +290,13 @@ 
      */
     public function capture(InfoInterface $payment, $amount)
     {
-        $oReturn = parent::capture($payment, $amount);// execute Magento parent capture
+        $oReturn = parent::capture($payment, $amount); // execute Magento parent capture
         if ($payment->getParentTransactionId()) {// does the order already have a transaction?
-            $this->sendPayoneCapture($payment, $amount);// is probably admin invoice capture
+            $this->sendPayoneCapture($payment, $amount); // is probably admin invoice capture
         } else {
-            $this->sendPayoneAuthorization($payment, $amount);// is probably frontend checkout capture
+            $this->sendPayoneAuthorization($payment, $amount); // is probably frontend checkout capture
         }
-        return $oReturn;// return magento parent capture value
+        return $oReturn; // return magento parent capture value
     }
 
     /**
@@ -311,12 +311,12 @@ 
         $iAllowSpecific = $this->shopHelper->getConfigParam('allowspecific');
         $aAvailableCountries = explode(',', $this->shopHelper->getConfigParam('specificcountry'));
         if ($this->hasCustomConfig()) {// check for non-global configuration
-            $iAllowSpecific = $this->getCustomConfigParam('allowspecific');// only specific countries allowed?
-            $aAvailableCountries = explode(',', $this->getCustomConfigParam('specificcountry'));// get allowed countries
+            $iAllowSpecific = $this->getCustomConfigParam('allowspecific'); // only specific countries allowed?
+            $aAvailableCountries = explode(',', $this->getCustomConfigParam('specificcountry')); // get allowed countries
         }
         if ($iAllowSpecific == 1 && !in_array($country, $aAvailableCountries)) {// only specific but not included
-            return false;// cant use for given country
+            return false; // cant use for given country
         }
-        return true;// can use for given country
+        return true; // can use for given country
     }
 }

Model/Methods/PayoneMethod.php

Spacing +3 added lines, -3 removed lines

@@ -111,7 +111,7 @@ 
     protected function sendPayoneAuthorization(InfoInterface $payment, $amount)
     {
         $oOrder = $payment->getOrder();
-        $this->checkoutSession->unsPayoneRedirectUrl();// remove redirect url from session
+        $this->checkoutSession->unsPayoneRedirectUrl(); // remove redirect url from session
         $aResponse = $this->authorizationRequest->sendRequest($this, $oOrder, $amount);
         $this->handleResponse($aResponse);
         if ($aResponse['status'] == 'ERROR') {// request returned an error
@@ -154,7 +154,7 @@ 
      */
     public function getPaymentSpecificParameters(Order $oOrder)
     {
-        return [];// filled in child classes
+        return []; // filled in child classes
     }
 
     /**
@@ -272,7 +272,7 @@ 
      */
     public function getSubTypeSpecificParameters(Order $oOrder)
     {
-        return [];// filled in child classes
+        return []; // filled in child classes
     }
 
     /**

Model/ChecksumCheck.php

Spacing +2 added lines, -2 removed lines

@@ -113,9 +113,9 @@
         }
         if ($this->blGotModuleInfo === true) {// was composer.json readable?
             $sRequestUrl = $this->sVersionCheckUrl.'?module='.$this->sModuleId.'&version='.$this->sModuleVersion;
-            $sResponse = file_get_contents($sRequestUrl);// request info from fatchip checksum server
+            $sResponse = file_get_contents($sRequestUrl); // request info from fatchip checksum server
             if (!empty($sResponse)) {// Did the server answer?
-                $aFiles = json_decode($sResponse);// Decode the json encoded answer from the server
+                $aFiles = json_decode($sResponse); // Decode the json encoded answer from the server
             }
         }
         return $aFiles;