Payone\Core\Test\Unit\Model\Methods\PayoneMethodTest

Complexity

Total Complexity

10

Size/Duplication

Total Lines	97
Duplicated Lines	17.53 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	2
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	10	10	1
A	testGetClearingtype()	0	6	1
A	testGetAuthorizationMode()	0	15	1
A	testGetOperationMode()	7	7	1
A	testNeedsRedirectUrls()	0	5	1
A	testNeedsProductInfo()	0	5	1
A	testHasCustomConfig()	0	6	1
A	testIsGroupMethod()	0	5	1
A	testGetGroupName()	0	5	1
A	testGetNarrativeTextMaxLength()	0	6	1

<?php

/**
 * PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
 *
 * PHP version 5
 *
 * @category  Payone
 * @package   Payone_Magento2_Plugin
 * @author    FATCHIP GmbH <support@fatchip.de>
 * @copyright 2003 - 2017 Payone GmbH
 * @license   <http://www.gnu.org/licenses/> GNU Lesser General Public License
 * @link      http://www.payone.de
 */

namespace Payone\Core\Test\Unit\Model\Methods;

use Payone\Core\Model\Methods\Paydirekt as ClassToTest;
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
use Payone\Core\Helper\Shop;
use Payone\Core\Model\PayoneConfig;
use Payone\Core\Test\Unit\BaseTestCase;
use Payone\Core\Model\Test\PayoneObjectManager;

class PayoneMethodTest extends BaseTestCase
{
    /**
     * @var ClassToTest
     */
    private $classToTest;

    /**
     * @var ObjectManager|PayoneObjectManager
     */
    private $objectManager;

    /**
     * @var Shop|\PHPUnit_Framework_MockObject_MockObject
     */
    private $shopHelper;

    protected function setUp()

This method seems to be duplicated in your project.

    {
        $this->objectManager = $this->getObjectManager();

        $this->shopHelper = $this->getMockBuilder(Shop::class)->disableOriginalConstructor()->getMock();

        $this->classToTest = $this->objectManager->getObject(ClassToTest::class, [
            'shopHelper' => $this->shopHelper
        ]);
    }

    public function testGetClearingtype()
    {
        $result = $this->classToTest->getClearingtype();
        $expected = 'wlt';
        $this->assertEquals($expected, $result);
    }

    public function testGetAuthorizationMode()
    {
        $expected = 'custom_request_type';
        $this->shopHelper->expects($this->any())

The method expects does only exist in PHPUnit_Framework_MockObject_MockObject, but not in Payone\Core\Helper\Shop.

            ->method('getConfigParam')
            ->willReturnMap(
                [
                    ['request_type', 'global', 'payone_general', null, 'global_request_type'],
                    ['use_global', PayoneConfig::METHOD_PAYDIREKT, 'payone_payment', null, '0'],
                    ['request_type', PayoneConfig::METHOD_PAYDIREKT, 'payone_payment', null, $expected]
                ]
            );
        $result = $this->classToTest->getAuthorizationMode();
        $this->assertEquals($expected, $result);
    }

    public function testGetOperationMode()

This method seems to be duplicated in your project.

    {
        $expected = 'operation_mode';
        $this->shopHelper->method('getConfigParam')->willReturn($expected);
        $result = $this->classToTest->getOperationMode();
        $this->assertEquals($expected, $result);
    }

    public function testNeedsRedirectUrls()
    {
        $result = $this->classToTest->needsRedirectUrls();
        $this->assertTrue($result);
    }

    public function testNeedsProductInfo()
    {
        $result = $this->classToTest->needsProductInfo();
        $this->assertFalse($result);
    }

    public function testHasCustomConfig()
    {
        $this->shopHelper->method('getConfigParam')->willReturn('1');
        $result = $this->classToTest->hasCustomConfig();
        $this->assertFalse($result);
    }

    public function testIsGroupMethod()
    {
        $result = $this->classToTest->isGroupMethod();
        $this->assertFalse($result);
    }

    public function testGetGroupName()
    {
        $result = $this->classToTest->getGroupName();
        $this->assertFalse($result);

It seems like $result defined by $this->classToTest->getGroupName() on line 122 can also be of type string; however, PHPUnit\Framework\Assert::assertFalse() does only seem to accept boolean, maybe add an additional type check?

    }

    public function testGetNarrativeTextMaxLength()
    {
        $result = $this->classToTest->getNarrativeTextMaxLength();
        $expected = 37;
        $this->assertEquals($expected, $result);
    }
}