SofortUeberweisung   A
last analyzed

Complexity

Total Complexity 4

Size/Duplication

Total Lines 54
Duplicated Lines 18.52 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 0
Metric Value
dl 10
loc 54
c 0
b 0
f 0
wmc 4
lcom 1
cbo 2
rs 10

2 Methods

Rating   Name   Duplication   Size   Complexity  
A getSubTypeSpecificParameters() 0 14 3
A assignData() 10 10 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
/**
4
 * PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
5
 * it under the terms of the GNU Lesser General Public License as published by
6
 * the Free Software Foundation, either version 3 of the License, or
7
 * (at your option) any later version.
8
 *
9
 * PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
10
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
 * GNU Lesser General Public License for more details.
13
 *
14
 * You should have received a copy of the GNU Lesser General Public License
15
 * along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
16
 *
17
 * PHP version 5
18
 *
19
 * @category  Payone
20
 * @package   Payone_Magento2_Plugin
21
 * @author    FATCHIP GmbH <[email protected]>
22
 * @copyright 2003 - 2016 Payone GmbH
23
 * @license   <http://www.gnu.org/licenses/> GNU Lesser General Public License
24
 * @link      http://www.payone.de
25
 */
26
27
namespace Payone\Core\Model\Methods\OnlineBankTransfer;
28
29
use Payone\Core\Model\PayoneConfig;
30
use Magento\Framework\DataObject;
31
use Magento\Sales\Model\Order;
32
33
/**
34
 * Model for Sofort-Überweisung payment method
35
 */
36
class SofortUeberweisung extends OnlineBankTransferBase
37
{
38
    /**
39
     * Payment method code
40
     *
41
     * @var string
42
     */
43
    protected $_code = PayoneConfig::METHOD_OBT_SOFORTUEBERWEISUNG;
44
45
    /**
46
     * Payment method sub type
47
     *
48
     * @var string
49
     */
50
    protected $sSubType = self::METHOD_OBT_SUBTYPE_SOFORTUEBERWEISUNG;
51
52
    /**
53
     * Return parameters specific to this payment sub type
54
     *
55
     * @param  Order $oOrder
56
     * @return array
57
     */
58
    public function getSubTypeSpecificParameters(Order $oOrder)
59
    {
60
        $oInfoInstance = $this->getInfoInstance();
61
62
        $aParams = ['bankcountry' => $oOrder->getBillingAddress()->getCountryId()];
63
        if ($oInfoInstance->getAdditionalInformation('iban')) {
64
            $aParams['iban'] = $oInfoInstance->getAdditionalInformation('iban');
65
        }
66
        if ($oInfoInstance->getAdditionalInformation('bic')) {
67
            $aParams['bic'] = $oInfoInstance->getAdditionalInformation('bic');
68
        }
69
70
        return $aParams;
71
    }
72
73
    /**
74
     * Add the checkout-form-data to the checkout session
75
     *
76
     * @param  DataObject $data
77
     * @return $this
78
     */
79 View Code Duplication
    public function assignData(DataObject $data)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
80
    {
81
        parent::assignData($data);
82
83
        $oInfoInstance = $this->getInfoInstance();
84
        $oInfoInstance->setAdditionalInformation('iban', $this->toolkitHelper->getAdditionalDataEntry($data, 'iban'));
85
        $oInfoInstance->setAdditionalInformation('bic', $this->toolkitHelper->getAdditionalDataEntry($data, 'bic'));
86
87
        return $this;
88
    }
89
}
90