Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 36 | class Eps extends OnlineBankTransferBase |
||
| 37 | { |
||
| 38 | /** |
||
| 39 | * Payment method code |
||
| 40 | * |
||
| 41 | * @var string |
||
| 42 | */ |
||
| 43 | protected $_code = PayoneConfig::METHOD_OBT_EPS; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * Payment method sub type |
||
| 47 | * |
||
| 48 | * @var string |
||
| 49 | */ |
||
| 50 | protected $sSubType = self::METHOD_OBT_SUBTYPE_EPS; |
||
| 51 | |||
| 52 | /** |
||
| 53 | * Array of all available bank groups |
||
| 54 | * |
||
| 55 | * @var array |
||
| 56 | */ |
||
| 57 | protected static $aBankGroups = [ |
||
| 58 | 'ARZ_OVB' => 'Volksbanken', |
||
| 59 | 'ARZ_BAF' => 'Bank f�r �rzte und Freie Berufe', |
||
| 60 | 'ARZ_NLH' => 'Nieder�sterreichische Landes-Hypo', |
||
| 61 | 'ARZ_VLH' => 'Vorarlberger Landes-Hypo', |
||
| 62 | 'ARZ_BCS' => 'Bankhaus Carl Sp�ngler & Co. AG', |
||
| 63 | 'ARZ_HTB' => 'Hypo Tirol', |
||
| 64 | 'ARZ_HAA' => 'Hypo Alpe Adria', |
||
| 65 | 'ARZ_IKB' => 'Investkreditbank', |
||
| 66 | 'ARZ_OAB' => '�sterreichische Apothekerbank', |
||
| 67 | 'ARZ_IMB' => 'Immobank', |
||
| 68 | 'ARZ_GRB' => 'G�rtnerbank', |
||
| 69 | 'ARZ_HIB' => 'HYPO Investment', |
||
| 70 | 'BA_AUS' => 'Bank Austria', |
||
| 71 | 'BAWAG_BWG' => 'BAWAG', |
||
| 72 | 'BAWAG_PSK' => 'PSK Bank', |
||
| 73 | 'BAWAG_ESY' => 'easybank', |
||
| 74 | 'BAWAG_SPD' => 'Sparda Bank', |
||
| 75 | 'SPARDAT_EBS' => 'Erste Bank', |
||
| 76 | 'SPARDAT_BBL' => 'Bank Burgenland', |
||
| 77 | 'RAC_RAC' => 'Raiffeisen', |
||
| 78 | 'HRAC_OOS' => 'Hypo Ober�sterreich', |
||
| 79 | 'HRAC_SLB' => 'Hypo Salzburg', |
||
| 80 | 'HRAC_STM' => 'Hypo Steiermark', |
||
| 81 | ]; |
||
| 82 | |||
| 83 | /** |
||
| 84 | * Return parameters specific to this payment sub type |
||
| 85 | * |
||
| 86 | * @param Order $oOrder |
||
| 87 | * @return array |
||
| 88 | */ |
||
| 89 | View Code Duplication | public function getSubTypeSpecificParameters(Order $oOrder) |
|
| 100 | |||
| 101 | /** |
||
| 102 | * Add the checkout-form-data to the checkout session |
||
| 103 | * |
||
| 104 | * @param DataObject $data |
||
| 105 | * @return $this |
||
| 106 | */ |
||
| 107 | View Code Duplication | public function assignData(DataObject $data) |
|
| 116 | |||
| 117 | /** |
||
| 118 | * Return available bank groups |
||
| 119 | * |
||
| 120 | * @return array |
||
| 121 | */ |
||
| 122 | View Code Duplication | public static function getBankGroups() |
|
| 135 | } |
||
| 136 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.