fjbender / magento-1

lib/Payone/Api/Request/Parameter/ManageMandate/PersonalData.php

Doc Comments +1 added lines, -1 removed lines

@@ -181,7 +181,7 @@
     }
 
     /**
-     * @return string
+     * @return integer
      */
     public function getUserid()
     {

lib/Payone/Api/Request/Parameter/Vauthorization/PersonalData.php

Doc Comments +2 added lines, -2 removed lines

@@ -95,7 +95,7 @@ 
     }
 
     /**
-     * @return string
+     * @return integer
      */
     public function getBirthday()
     {
@@ -259,7 +259,7 @@ 
     }
 
     /**
-     * @return string
+     * @return integer
      */
     public function getUserid()
     {

lib/Payone/Api/Response/Abstract.php

Doc Comments +3 added lines, -3 removed lines

@@ -224,7 +224,7 @@ 
     }
 
     /**
-     * @param $name
+     * @param string $name
      * @return null|mixed
      */
     protected function get($name)
@@ -237,7 +237,7 @@ 
 
     /**
      * @param string $name
-     * @param mixed $value
+     * @param string $value
      * @return boolean|null
      */
     protected function set($name, $value)
@@ -257,7 +257,7 @@ 
         $this->rawResponse = $rawResponse;
     }
     /**
-     * @return null
+     * @return string
      */
     public function getRawResponse()
     {

Spacing +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
     
     protected function _toString($aValue)
     {
-        if($this->applyFilters) {
+        if ($this->applyFilters) {
             $result = $this->applyFilters->apply($aValue);
         } else {
             $protocolFactory     = new Payone_Protocol_Factory();

lib/Payone/Api/Response/Parameter/Paydata/DataItem.php

Doc Comments -1 removed lines

@@ -30,7 +30,6 @@
     protected $data = NULL;
 
     /**
-     * @param int $key
      * @return array
      */
     public function toArray()

lib/Payone/Builder.php

Doc Comments +10 added lines, -10 removed lines

@@ -65,7 +65,7 @@ 
     /**
      * @api
      *
-     * @return Payone_ClientApi_Service_GenerateHash
+     * @return Payone_Api_Service_Payment_Abstract
      */
     public function buildServiceClientApiGenerateHash() {
         return $this->buildService(self::KEY_CLIENTAPI . '/generateHash');
@@ -119,7 +119,7 @@ 
     /**
      * @api
      *
-     * @return Payone_Api_Service_Verification_3dsCheck
+     * @return Payone_Api_Service_Payment_Abstract
      */
     public function buildServiceVerification3dsCheck() {
         return $this->buildService(self::KEY_API . '/verification/3dscheck');
@@ -128,7 +128,7 @@ 
     /**
      * @api
      *
-     * @return Payone_Api_Service_Management_GetInvoice
+     * @return Payone_Api_Service_Payment_Abstract
      */
     public function buildServiceManagementGetInvoice() {
         return $this->buildService(self::KEY_API . '/management/getInvoice');
@@ -137,7 +137,7 @@ 
     /**
      * @api
      *
-     * @return Payone_Api_Service_Management_GetFile
+     * @return Payone_Api_Service_Payment_Abstract
      */
     public function buildServiceManagementGetFile() {
         return $this->buildService(self::KEY_API . '/management/getFile');
@@ -146,7 +146,7 @@ 
     /**
      * @api
      *
-     * @return Payone_Api_Service_Management_ManageMandate
+     * @return Payone_Api_Service_Payment_Abstract
      */
     public function buildServiceManagementManageMandate() {
         return $this->buildService(self::KEY_API . '/management/manageMandate');
@@ -155,7 +155,7 @@ 
     /**
      * @api
      *
-     * @return Payone_Api_Service_Verification_AddressCheck
+     * @return Payone_Api_Service_Payment_Abstract
      */
     public function buildServiceVerificationAddressCheck() {
         return $this->buildService(self::KEY_API . '/verification/addressCheck');
@@ -164,7 +164,7 @@ 
     /**
      * @api
      *
-     * @return Payone_Api_Service_Verification_CreditCardCheck
+     * @return Payone_Api_Service_Payment_Abstract
      */
     public function buildServiceVerificationCreditCardCheck() {
         return $this->buildService(self::KEY_API . '/verification/creditCardCheck');
@@ -173,7 +173,7 @@ 
     /**
      * @api
      *
-     * @return Payone_Api_Service_Verification_BankAccountCheck
+     * @return Payone_Api_Service_Payment_Abstract
      */
     public function buildServiceVerificationBankAccountCheck() {
         return $this->buildService(self::KEY_API . '/verification/bankAccountCheck');
@@ -182,7 +182,7 @@ 
     /**
      * @api
      *
-     * @return Payone_Api_Service_Verification_Consumerscore
+     * @return Payone_Api_Service_Payment_Abstract
      */
     public function buildServiceVerificationConsumerscore() {
         return $this->buildService(self::KEY_API . '/verification/consumerscore');
@@ -191,7 +191,7 @@ 
     /**
      * @api
      *
-     * @return Payone_Settings_Service_XmlGenerate
+     * @return Payone_Api_Service_Payment_Abstract
      */
     public function buildServiceSettingsXmlGenerate() {
         return $this->buildService(self::KEY_SETTINGS . '/xmlgenerate');

Spacing +2 added lines, -2 removed lines

@@ -389,7 +389,7 @@ 
         if (is_array($validatorConfig)) {
             $validator = array();
             foreach ($validatorConfig as $config) {
-                if ($config === 'default' or ! class_exists($config)) {
+                if ($config === 'default' or !class_exists($config)) {
                     return null;
                 } else {
                     $validator[] = new $config();
@@ -399,7 +399,7 @@ 
             return $validator;
         } else {
             // Load validator by config (if non-default):
-            if ($validatorConfig === 'default' or ! class_exists($validatorConfig)) {
+            if ($validatorConfig === 'default' or !class_exists($validatorConfig)) {
                 return null;
             } else {
                 $validator = new $validatorConfig();

lib/Payone/ClientApi/Factory.php

Doc Comments +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 
     /**
      * @param string $key Service Key, e.g. 'payment/refund'
-     * @return Payone_Api_Service_Payment_Authorize|Payone_Api_Service_Payment_Debit|Payone_Api_Service_Payment_Preauthorize|Payone_Api_Service_Payment_Refund
+     * @return Payone_ClientApi_Service_GenerateHash|null
      * @throws Exception
      */
     public function buildService($key)

lib/Payone/Log4php/Logger.php

Doc Comments +3 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
 
 	/**
 	 * Returns the parent Logger. Can be null if this is the root logger.
-	 * @return Logger
+	 * @return Payone_Log4php_Logger
 	 */
 	public function getParent() {
 		return $this->parent;
@@ -395,7 +395,7 @@ 
 
 	/**
 	 * Sets the parent logger.
-	 * @param Logger $logger
+	 * @param Payone_Log4php_Logger $logger
 	 */
 	public function setParent(Payone_Log4php_Logger $logger) {
 		$this->parent = $logger;
@@ -453,7 +453,7 @@ 
 	
 	/**
 	 * Clears all Logger definitions from the logger hierarchy.
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public static function clear() {
 		return self::getHierarchy()->clear();

Spacing +11 added lines, -11 removed lines

@@ -169,7 +169,7 @@ 
 	 *   in the logging event.
 	 */
 	public function log(Payone_Log4php_LoggerLevel $level, $message, $throwable = null) {
-		if($this->isEnabledFor($level)) {
+		if ($this->isEnabledFor($level)) {
 			$this->forcedLog($this->fqcn, $throwable, $level, $message);
 		}
 	}
@@ -182,7 +182,7 @@ 
 	 * @param string $msg message to log
 	 */
 	public function assertLog($assertion = true, $msg = '') {
-		if($assertion == false) {
+		if ($assertion == false) {
 			$this->error($msg);
 		}
 	}
@@ -285,7 +285,7 @@ 
 	
 	/** Removes all appenders from the Logger. */
 	public function removeAllAppenders() {
-		foreach($this->appenders as $name => $appender) {
+		foreach ($this->appenders as $name => $appender) {
 			$this->removeAppender($name);
 		}
 	} 
@@ -295,7 +295,7 @@ 
 	 * @param mixed $appender an appender name or a {@link Payone_Log4php_LoggerAppender} instance.
 	 */
 	public function removeAppender($appender) {
-		if($appender instanceof Payone_Log4php_LoggerAppender) {
+		if ($appender instanceof Payone_Log4php_LoggerAppender) {
 			$appender->close();
 			unset($this->appenders[$appender->getName()]);
 		} else if (is_string($appender) and isset($this->appenders[$appender])) {
@@ -310,12 +310,12 @@ 
 	 */
 	public function callAppenders($event) {
 		// Forward the event to each linked appender
-		foreach($this->appenders as $appender) {
+		foreach ($this->appenders as $appender) {
 			$appender->doAppend($event);
 		}
 		
 		// Forward the event upstream if additivity is turned on
-		if(isset($this->parent) && $this->getAdditivity()) {
+		if (isset($this->parent) && $this->getAdditivity()) {
 			$this->parent->callAppenders($event);
 		}
 	}
@@ -358,8 +358,8 @@ 
 	 * @return Payone_Log4php_LoggerLevel or null
 	 */
 	public function getEffectiveLevel() {
-		for($logger = $this; $logger !== null; $logger = $logger->getParent()) {
-			if($logger->getLevel() !== null) {
+		for ($logger = $this; $logger !== null; $logger = $logger->getParent()) {
+			if ($logger->getLevel() !== null) {
 				return $logger->getLevel();
 			}
 		}
@@ -421,7 +421,7 @@ 
 	 * @return Payone_Log4php_LoggerHierarchy
 	 */
 	public static function getHierarchy() {
-		if(!isset(self::$hierarchy)) {
+		if (!isset(self::$hierarchy)) {
 			self::$hierarchy = new Payone_Log4php_LoggerHierarchy(new Payone_Log4php_LoggerRoot());
 		}
 		return self::$hierarchy;
@@ -434,7 +434,7 @@ 
 	 * @return Logger
 	 */
 	public static function getLogger($name) {
-		if(!self::isInitialized()) {
+		if (!self::isInitialized()) {
 			self::configure();
 		}
 		return self::getHierarchy()->getLogger($name);
@@ -445,7 +445,7 @@ 
 	 * @return Payone_Log4php_LoggerRoot
 	 */
 	public static function getRootLogger() {
-		if(!self::isInitialized()) {
+		if (!self::isInitialized()) {
 			self::configure();
 		}
 		return self::getHierarchy()->getRootLogger();

lib/Payone/Log4php/LoggerConfigurationAdapterXML.php

Doc Comments +5 added lines

@@ -69,6 +69,7 @@ 
 	/**
 	 * Loads and validates the XML.
 	 * @param string $url Input XML.
+	 * @return SimpleXMLElement
 	 */
 	private function loadXML($url) {
 		if (!file_exists($url)) {
@@ -213,6 +214,7 @@ 
 	
 	/** 
 	 * Parses a <logger> node for appender references and returns them in an array.
+	 * @param string $name
 	 */
 	private function parseAppenderReferences(SimpleXMLElement $node, $name) {
 		$refs = array();
@@ -247,6 +249,9 @@ 
 	// ** Helper methods                       **
 	// ******************************************
 	
+	/**
+	 * @param string $name
+	 */
 	private function getAttributeValue(SimpleXMLElement $node, $name) {
 		return isset($node[$name]) ? (string) $node[$name] : null;
 	}

Spacing +11 added lines, -11 removed lines

@@ -50,17 +50,17 @@ 
 		}
 		
 		// Process <logger> nodes
-		foreach($xml->logger as $logger) {
+		foreach ($xml->logger as $logger) {
 			$this->parseLogger($logger);
 		} 
 		
 		// Process <appender> nodes
-		foreach($xml->appender as $appender) {
+		foreach ($xml->appender as $appender) {
 			$this->parseAppender($appender);
 		}
 		
 		// Process <renderer> nodes
-		foreach($xml->renderer as $rendererNode) {
+		foreach ($xml->renderer as $rendererNode) {
 			$this->parseRenderer($rendererNode);
 		}
 		return $this->config;
@@ -83,7 +83,7 @@ 
 		if ($xml === false) {
 			
 			$errorStr = "";
-			foreach(libxml_get_errors() as $error) {
+			foreach (libxml_get_errors() as $error) {
 				$errorStr .= $error->message;
 			}
 			
@@ -102,7 +102,7 @@ 
 	private function parseConfiguration(SimpleXMLElement $xml) {
 		$attributes = $xml->attributes();
 		if (isset($attributes['threshold'])) {
-			$this->config['threshold'] = (string) $attributes['threshold'];
+			$this->config['threshold'] = (string)$attributes['threshold'];
 		}
 	}
 	
@@ -122,14 +122,14 @@ 
 		}
 		
 		if (isset($node->layout)) {
-			$appender['layout']= $this->parseLayout($node->layout, $name);
+			$appender['layout'] = $this->parseLayout($node->layout, $name);
 		}
 		
 		if (count($node->param) > 0) {
 			$appender['params'] = $this->parseParameters($node);
 		}
 		
-		foreach($node->filter as $filterNode) {
+		foreach ($node->filter as $filterNode) {
 			$appender['filters'][] = $this->parseFilter($filterNode);
 		}
 		
@@ -152,7 +152,7 @@ 
 	private function parseParameters($paramsNode) {
 		$params = array();
 
-		foreach($paramsNode->param as $paramNode) {
+		foreach ($paramsNode->param as $paramNode) {
 			if (empty($paramNode['name'])) {
 				$this->warn("A <param> node is missing the required 'name' attribute. Skipping parameter.");
 				continue;
@@ -176,7 +176,7 @@ 
 		}
 		
 		$logger['appenders'] = array();
-		foreach($node->appender_ref as $appender) {
+		foreach ($node->appender_ref as $appender) {
 			$logger['appenders'][] = $this->getAttributeValue($appender, 'ref');
 		}
 		
@@ -216,7 +216,7 @@ 
 	 */
 	private function parseAppenderReferences(SimpleXMLElement $node, $name) {
 		$refs = array();
-		foreach($node->appender_ref as $ref) {
+		foreach ($node->appender_ref as $ref) {
 			$refs[] = $this->getAttributeValue($ref, 'ref');
 		}
 		
@@ -248,7 +248,7 @@ 
 	// ******************************************
 	
 	private function getAttributeValue(SimpleXMLElement $node, $name) {
-		return isset($node[$name]) ? (string) $node[$name] : null;
+		return isset($node[$name]) ? (string)$node[$name] : null;
 	}
 	
 	private function warn($message) {

lib/Payone/Log4php/LoggerConfiguratorDefault.php

Doc Comments +1 added lines, -1 removed lines

@@ -404,7 +404,7 @@
 	/**
 	 * Configures a logger. 
 	 * 
-	 * @param Logger $logger The logger to configure
+	 * @param Payone_Log4php_Logger $logger The logger to configure
 	 * @param array $config Logger configuration options.
 	 */
 	private function configureLogger(Payone_Log4php_Logger $logger, $config) {

Spacing +7 added lines, -7 removed lines

@@ -167,7 +167,7 @@ 
 		$info = pathinfo($url);
 		$ext = strtolower($info['extension']);
 		
-		switch($ext) {
+		switch ($ext) {
 			case 'xml':
 				return self::FORMAT_XML;
 			
@@ -201,7 +201,7 @@ 
 		
 		// Configure appenders and add them to the appender pool
 		if (isset($config['appenders']) && is_array($config['appenders'])) {
-			foreach($config['appenders'] as $name => $appenderConfig) {
+			foreach ($config['appenders'] as $name => $appenderConfig) {
 				$this->configureAppender($name, $appenderConfig);
 			}
 		}
@@ -213,14 +213,14 @@ 
 		
 		// Configure loggers
 		if (isset($config['loggers']) && is_array($config['loggers'])) {
-			foreach($config['loggers'] as $loggerName => $loggerConfig) {
+			foreach ($config['loggers'] as $loggerName => $loggerConfig) {
 				$this->configureOtherLogger($hierarchy, $loggerName, $loggerConfig);
 			}
 		}
 
 		// Configure renderers
 		if (isset($config['renderers']) && is_array($config['renderers'])) {
-			foreach($config['renderers'] as $rendererConfig) {
+			foreach ($config['renderers'] as $rendererConfig) {
 				$this->configureRenderer($hierarchy, $rendererConfig);
 			}
 		}
@@ -308,7 +308,7 @@ 
 		
 		// Parse filters
 		if (isset($config['filters']) && is_array($config['filters'])) {
-			foreach($config['filters'] as $filterConfig) {
+			foreach ($config['filters'] as $filterConfig) {
 				$this->createAppenderFilter($appender, $filterConfig);
 			}
 		}
@@ -423,7 +423,7 @@ 
 		
 		// Link appenders to logger
 		if (isset($config['appenders'])) {
-			foreach($config['appenders'] as $appenderName) {
+			foreach ($config['appenders'] as $appenderName) {
 				if (isset($this->appenders[$appenderName])) {
 					$logger->addAppender($this->appenders[$appenderName]);
 				} else {
@@ -467,7 +467,7 @@ 
 	 * @param unknown_type $options
 	 */
 	private function setOptions($object, $options) {
-		foreach($options as $name => $value) {
+		foreach ($options as $name => $value) {
 			$setter = "set$name";
 			if (method_exists($object, $setter)) {
 				$object->$setter($value);