fjbender / magento-1

lib/Payone/Log4php/LoggerRoot.php

Doc Comments +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
 	/**
 	 * Always returns false.
 	 * Because LoggerRoot has no parents, it returns false.
-	 * @param Logger $parent
+	 * @param Payone_Log4php_Logger $parent
 	 * @return boolean
 	 */
 	public function setParent(Payone_Log4php_Logger $parent) {

Indentation +36 added lines, -36 removed lines

@@ -26,45 +26,45 @@
  * @see Logger
  */
 class Payone_Log4php_LoggerRoot extends Payone_Log4php_Logger {
-	/**
-	 * Constructor
-	 *
-	 * @param integer $level initial log level
-	 */
-	public function __construct($level = null) {
-		parent::__construct('root');
+    /**
+     * Constructor
+     *
+     * @param integer $level initial log level
+     */
+    public function __construct($level = null) {
+        parent::__construct('root');
 
-		if($level == null) {
-			$level = Payone_Log4php_LoggerLevel::getLevelAll();
-		}
-		$this->setLevel($level);
-	} 
+        if($level == null) {
+            $level = Payone_Log4php_LoggerLevel::getLevelAll();
+        }
+        $this->setLevel($level);
+    } 
 	
-	/**
-	 * @return Payone_Log4php_LoggerLevel the level
-	 */
-	public function getChainedLevel() {
-		return parent::getLevel();
-	} 
+    /**
+     * @return Payone_Log4php_LoggerLevel the level
+     */
+    public function getChainedLevel() {
+        return parent::getLevel();
+    } 
 	
-	/**
-	 * Setting a null value to the level of the root category may have catastrophic results.
-	 * @param Payone_Log4php_LoggerLevel $level
-	 */
-	public function setLevel($level) {
-		if($level != null) {
-			parent::setLevel($level);
-		}	 
-	}
+    /**
+     * Setting a null value to the level of the root category may have catastrophic results.
+     * @param Payone_Log4php_LoggerLevel $level
+     */
+    public function setLevel($level) {
+        if($level != null) {
+            parent::setLevel($level);
+        }	 
+    }
 	
-	/**
-	 * Always returns false.
-	 * Because LoggerRoot has no parents, it returns false.
-	 * @param Logger $parent
-	 * @return boolean
-	 */
-	public function setParent(Payone_Log4php_Logger $parent) {
-		return false;
-	}
+    /**
+     * Always returns false.
+     * Because LoggerRoot has no parents, it returns false.
+     * @param Logger $parent
+     * @return boolean
+     */
+    public function setParent(Payone_Log4php_Logger $parent) {
+        return false;
+    }
 
 }

Spacing +2 added lines, -2 removed lines

@@ -34,7 +34,7 @@ 
 	public function __construct($level = null) {
 		parent::__construct('root');
 
-		if($level == null) {
+		if ($level == null) {
 			$level = Payone_Log4php_LoggerLevel::getLevelAll();
 		}
 		$this->setLevel($level);
@@ -52,7 +52,7 @@ 
 	 * @param Payone_Log4php_LoggerLevel $level
 	 */
 	public function setLevel($level) {
-		if($level != null) {
+		if ($level != null) {
 			parent::setLevel($level);
 		}	 
 	}

lib/Payone/Settings/Service/XmlGenerate.php

Doc Comments +8 added lines, -4 removed lines

@@ -49,7 +49,7 @@ 
      * @api
      *
      * @param Payone_Settings_Data_ConfigFile_Root $config
-     * @return mixed @see SimpleXMLElement::asXml()
+     * @return string @see SimpleXMLElement::asXml()
      */
     public function generate(Payone_Settings_Data_ConfigFile_Root $config)
     {
@@ -74,7 +74,7 @@ 
      * @api
      *
      * @param Payone_Settings_Data_ConfigFile_Root $config
-     * @return mixed @see SimpleXMLElement::asXml()
+     * @return string|false @see SimpleXMLElement::asXml()
      */
     public function execute(Payone_Settings_Data_ConfigFile_Root $config)
     {
@@ -125,7 +125,7 @@ 
     /**
      * @param Payone_Settings_Data_ConfigFile_Shop $shopConfig
      * @param DOMElement $configXml
-     * @return string
+     * @return DOMElement
      */
     protected function mapShop(Payone_Settings_Data_ConfigFile_Shop $shopConfig, DOMElement $configXml)
     {
@@ -366,6 +366,10 @@ 
         $this->addGlobal($cleatringTypeNode, $valueClearingType);
     }
 
+    /**
+     * @param DOMElement $parent
+     * @param Payone_Settings_Data_ConfigFile_PaymentMethod_Abstract $type
+     */
     public function addGlobal($parent, $type)
     {
 
@@ -401,7 +405,7 @@ 
     /**
      * @param DOMElement $parent
      * @param $object
-     * @param $property
+     * @param string $property
      * @param bool $withCdata
      * @return DOMElement
      */

Spacing +11 added lines, -11 removed lines

@@ -173,9 +173,9 @@ 
         $this->addChild($globalXml, $globalConfig, 'aid');
         $this->addChild($globalXml, $globalConfig, 'portalid');
         $this->addChild($globalXml, $globalConfig, 'request_type');
-        $this->mapParameterInvoice($globalConfig,$globalXml);
+        $this->mapParameterInvoice($globalConfig, $globalXml);
         $this->addStatusMapping($globalConfig, $globalXml);
-        $this->mapPaymentCreditcard($globalConfig,$globalXml);
+        $this->mapPaymentCreditcard($globalConfig, $globalXml);
         return $shopXml;
     }
 
@@ -214,7 +214,7 @@ 
      */
     protected function mapProtect(Payone_Settings_Data_ConfigFile_Shop_Protect $protectConfig, DOMElement $shopXml)
     {
-        $protectXml = $this->appendElement($shopXml,$protectConfig->getKey());
+        $protectXml = $this->appendElement($shopXml, $protectConfig->getKey());
 
         $protectXml = $this->mapConsumerscore($protectConfig->getConsumerscore(), $protectXml);
         $protectXml = $this->mapAddresscheck($protectConfig->getAddresscheck(), $protectXml);
@@ -321,7 +321,7 @@ 
         $tasXml = $this->appendElement($miscXml, $tasForwarding->getKey());
 
         foreach ($tasForwarding->getTransactionstatusForwarding() as $keyTas => $config) {
-            $configNode = $this->appendElement($tasXml,'config');
+            $configNode = $this->appendElement($tasXml, 'config');
 
             foreach ($config as $key => $value) {
                 $configNode->setAttribute($key, $value);
@@ -336,10 +336,10 @@ 
     public function addStatusMapping(Payone_Settings_Data_ConfigFile_Shop_Global $globalConfig, DOMElement $globalXml)
     {
         $statusMapping = $globalConfig->getStatusMapping();
-        $tasXml = $this->appendElement($globalXml,$statusMapping->getKey());
+        $tasXml = $this->appendElement($globalXml, $statusMapping->getKey());
 
         foreach ($statusMapping->getStatusMapping() as $keyStatusMapping => $valueStatusMapping) {
-            $parent = $this->appendElement($tasXml,$keyStatusMapping);
+            $parent = $this->appendElement($tasXml, $keyStatusMapping);
 
             foreach ($valueStatusMapping as $key => $value) {
                 $mapNode = $this->appendElement($parent, 'map');
@@ -385,7 +385,7 @@ 
     {
         $feeConfig = $valueClearingType->getFeeConfig();
         if (!empty($feeConfig)) {
-            $feeConfigNode = $this->appendElement($cleatringTypeNode,'fee_config');
+            $feeConfigNode = $this->appendElement($cleatringTypeNode, 'fee_config');
 
             foreach ($feeConfig as $keyFeeConfig => $valueFeeConfig) {
                 if (array_key_exists('value', $valueFeeConfig) && array_key_exists('attribute', $valueFeeConfig)) {
@@ -411,7 +411,7 @@ 
         $data = $object->$getter();
         $child = $parent;
         if (is_array($data)) {
-            $parentNode = $this->appendElement($parent,$property);
+            $parentNode = $this->appendElement($parent, $property);
             foreach ($data as $key => $value) {
                 $child = $this->appendElement($parentNode, $key, $value, $withCdata);
             }
@@ -452,9 +452,9 @@ 
      * @param bool $asCdata
      * @return DOMElement
      */
-    protected function appendElement( $parent, $key, $value = null, $asCdata = false)
+    protected function appendElement($parent, $key, $value = null, $asCdata = false)
     {
-        if($asCdata === true)
+        if ($asCdata === true)
         {
             $cdata = $this->dom->createCDATASection($value);
             $child = $this->dom->createElement($key);
@@ -463,7 +463,7 @@ 
         else
         {
             $child = $this->dom->createElement($key);
-            if($value !== null)
+            if ($value !== null)
             {
                 $domValue = $this->dom->createTextNode($value);
                 $child->appendChild($domValue);

Braces +5 added lines, -10 removed lines

@@ -109,12 +109,10 @@ 
                     foreach ($value['attribute'] as $attributKey => $attributData) {
                         $node->addAttribute($attributKey, $attributData);
                     }
-                }
-                else {
+                } else {
                     $this->simpleXmlFromNestedArray($key, $value, $parent);
                 }
-            }
-            else {
+            } else {
                 $parent->addChild($key, $value);
             }
 
@@ -415,8 +413,7 @@ 
             foreach ($data as $key => $value) {
                 $child = $this->appendElement($parentNode, $key, $value, $withCdata);
             }
-        }
-        else {
+        } else {
             if (isset($data)) {
                 $child = $this->appendElement($parent, $property, $data, $withCdata);
             }
@@ -436,8 +433,7 @@ 
             foreach ($value as $key => $data) {
                 $mapNode->setAttribute($key, $data);
             }
-        }
-        else {
+        } else {
             if (!empty($data)) {
                 $mapNode->setAttribute($name, $value);
             }
@@ -459,8 +455,7 @@ 
             $cdata = $this->dom->createCDATASection($value);
             $child = $this->dom->createElement($key);
             $child->appendChild($cdata);
-        }
-        else
+        } else
         {
             $child = $this->dom->createElement($key);
             if($value !== null)

lib/Payone/TransactionStatus/Factory.php

Doc Comments +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
     }
 
     /**
-     * @param $key
+     * @param string $key
      * @return Payone_TransactionStatus_Service_HandleRequest
      * @throws Exception
      */

lib/Payone/Config/Abstract.php

Braces +5 added lines, -10 removed lines

@@ -77,8 +77,7 @@ 
     {
         if (empty($data)) {
             $this->config = $this->getDefaultConfigData();
-        }
-        else {
+        } else {
             $this->config = $data;
         }
     }
@@ -127,8 +126,7 @@ 
             // Start recursion:
             return $this->set($newKey, $value, $tree[$currentKey]);
 
-        }
-        else {
+        } else {
             // Set value (can overwrite an existing value)
             $tree[$key] = $value;
             // Exit recursion, Success!
@@ -166,16 +164,13 @@ 
                 // Reassemble key, start recursion:
                 $newKey = implode(self::KEY_SEPARATOR, $explodedKey);
                 return $this->get($newKey, $newTree);
-            }
-            else {
+            } else {
                 return NULL; // Exit recursion, unsuccessful
             }
 
-        }
-        elseif (is_array($tree) and array_key_exists($key, $tree)) {
+        } elseif (is_array($tree) and array_key_exists($key, $tree)) {
             return $tree[$key]; // Exit recursion, Success!
-        }
-        else {
+        } else {
             return NULL; // Exit recursion, unsuccessful
         }
     }

lib/Payone/Settings/Data/ConfigFile/Shop/Global.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
     protected $parameter_invoice = array();
 
     /** @var Payone_Settings_Data_ConfigFile_Global_StatusMapping */
-    protected $status_mapping = null ;
+    protected $status_mapping = null;
 
     /** @var array */
     protected $payment_creditcard = array();

lib/Payone/Settings/Data/ConfigFile/Shop/ClearingTypes.php

Braces +1 added lines, -2 removed lines

@@ -58,8 +58,7 @@
             if ($value instanceof Payone_Settings_Data_ConfigFile_Interface) {
                 /** @var Payone_Api_Request_Parameter_Interface $value */
                 $array[$value->getKey()] = $value->toArray();
-            }
-            else {
+            } else {
                 $array[$key] = $value;
             }
         }

lib/Payone/Settings/Data/ConfigFile/Root.php

Spacing +1 added lines, -1 removed lines

@@ -68,6 +68,6 @@
 
     public function addShop($shop)
     {
-        return $this->shop[]=$shop;
+        return $this->shop[] = $shop;
     }
 }

lib/Payone/Settings/Data/ConfigFile/Abstract.php

Braces +3 added lines, -6 removed lines

@@ -50,21 +50,18 @@
             if ($data instanceof Payone_Settings_Data_ConfigFile_Interface) {
                 /** @var Payone_Api_Request_Parameter_Interface $data */
                 $array[$key] = $data->toArray();
-            }
-            elseif (is_array($data))
+            } elseif (is_array($data))
             {
                 foreach ($data as $innerKey => $innerValue)
                 {
                     if ($innerValue instanceof Payone_Settings_Data_ConfigFile_Interface) {
                         /** @var Payone_Api_Request_Parameter_Interface $innerValue */
                         $array[$key][$innerValue->getKey()] = $innerValue->toArray();
-                    }
-                    else {
+                    } else {
                         $array[$key][$innerKey] = $innerValue;
                     }
                 }
-            }
-            else {
+            } else {
                 $array[$key] = $data;
             }
         }

lib/Payone/Settings/Data/ConfigFile/PaymentMethod/Abstract.php

Spacing +3 added lines, -3 removed lines

@@ -41,11 +41,11 @@ 
     protected $title = '';
 
     protected $mid = null;
-    protected $aid =null;
+    protected $aid = null;
     protected $portalid = null;
     protected $fee_config = array();
     protected $min_order_total = null;
-    protected $max_order_total =null;
+    protected $max_order_total = null;
     /** @var string */
     protected $types = null;
     /** @var string */
@@ -113,7 +113,7 @@ 
 
     public function addFeeConfig($value)
     {
-        return $this->fee_config[]=$value;
+        return $this->fee_config[] = $value;
     }
 
     public function setMaxOrderTotal($max_order_total)