fjbender / magento-1

lib/Payone/Config/Abstract.php

Braces +5 added lines, -10 removed lines

@@ -77,8 +77,7 @@ 
     {
         if (empty($data)) {
             $this->config = $this->getDefaultConfigData();
-        }
-        else {
+        } else {
             $this->config = $data;
         }
     }
@@ -127,8 +126,7 @@ 
             // Start recursion:
             return $this->set($newKey, $value, $tree[$currentKey]);
 
-        }
-        else {
+        } else {
             // Set value (can overwrite an existing value)
             $tree[$key] = $value;
             // Exit recursion, Success!
@@ -166,16 +164,13 @@ 
                 // Reassemble key, start recursion:
                 $newKey = implode(self::KEY_SEPARATOR, $explodedKey);
                 return $this->get($newKey, $newTree);
-            }
-            else {
+            } else {
                 return NULL; // Exit recursion, unsuccessful
             }
 
-        }
-        elseif (is_array($tree) and array_key_exists($key, $tree)) {
+        } elseif (is_array($tree) and array_key_exists($key, $tree)) {
             return $tree[$key]; // Exit recursion, Success!
-        }
-        else {
+        } else {
             return NULL; // Exit recursion, unsuccessful
         }
     }

lib/Payone/Settings/Data/ConfigFile/Shop/ClearingTypes.php

Braces +1 added lines, -2 removed lines

@@ -58,8 +58,7 @@
             if ($value instanceof Payone_Settings_Data_ConfigFile_Interface) {
                 /** @var Payone_Api_Request_Parameter_Interface $value */
                 $array[$value->getKey()] = $value->toArray();
-            }
-            else {
+            } else {
                 $array[$key] = $value;
             }
         }

lib/Payone/Settings/Data/ConfigFile/Abstract.php

Braces +3 added lines, -6 removed lines

@@ -50,21 +50,18 @@
             if ($data instanceof Payone_Settings_Data_ConfigFile_Interface) {
                 /** @var Payone_Api_Request_Parameter_Interface $data */
                 $array[$key] = $data->toArray();
-            }
-            elseif (is_array($data))
+            } elseif (is_array($data))
             {
                 foreach ($data as $innerKey => $innerValue)
                 {
                     if ($innerValue instanceof Payone_Settings_Data_ConfigFile_Interface) {
                         /** @var Payone_Api_Request_Parameter_Interface $innerValue */
                         $array[$key][$innerValue->getKey()] = $innerValue->toArray();
-                    }
-                    else {
+                    } else {
                         $array[$key][$innerKey] = $innerValue;
                     }
                 }
-            }
-            else {
+            } else {
                 $array[$key] = $data;
             }
         }

lib/Payone/Settings/Service/XmlGenerate.php

Braces +5 added lines, -10 removed lines

@@ -109,12 +109,10 @@ 
                     foreach ($value['attribute'] as $attributKey => $attributData) {
                         $node->addAttribute($attributKey, $attributData);
                     }
-                }
-                else {
+                } else {
                     $this->simpleXmlFromNestedArray($key, $value, $parent);
                 }
-            }
-            else {
+            } else {
                 $parent->addChild($key, $value);
             }
 
@@ -415,8 +413,7 @@ 
             foreach ($data as $key => $value) {
                 $child = $this->appendElement($parentNode, $key, $value, $withCdata);
             }
-        }
-        else {
+        } else {
             if (isset($data)) {
                 $child = $this->appendElement($parent, $property, $data, $withCdata);
             }
@@ -436,8 +433,7 @@ 
             foreach ($value as $key => $data) {
                 $mapNode->setAttribute($key, $data);
             }
-        }
-        else {
+        } else {
             if (!empty($data)) {
                 $mapNode->setAttribute($name, $value);
             }
@@ -459,8 +455,7 @@ 
             $cdata = $this->dom->createCDATASection($value);
             $child = $this->dom->createElement($key);
             $child->appendChild($cdata);
-        }
-        else
+        } else
         {
             $child = $this->dom->createElement($key);
             if($value !== null)

lib/Payone/ClientApi/Request/Abstract.php

Braces +1 added lines, -2 removed lines

@@ -187,8 +187,7 @@
 
                 return $object->get($propertyName);
             }
-        }
-        elseif (property_exists($this, $name)) {
+        } elseif (property_exists($this, $name)) {
             return $this->$name;
         }
         return null;

lib/Payone/Log4php/LoggerAppenderRollingFile.php

Braces +6 added lines, -3 removed lines

@@ -119,8 +119,9 @@ 
 
 			// Delete the oldest file, to keep Windows happy.
 			$file = $fileName . '.' . $this->maxBackupIndex;
-			if(is_writable($file))
-				unlink($file);
+			if(is_writable($file)) {
+							unlink($file);
+			}
 
 			// Map {(maxBackupIndex - 1), ..., 2, 1} to {maxBackupIndex, ..., 3, 2}
 			for($i = $this->maxBackupIndex - 1; $i >= 1; $i--) {
@@ -145,7 +146,9 @@ 
 		// As Payone_Log4php_LoggerAppenderFile does not create the directory, it has to exist.
 		// realpath() fails if the argument does not exist so the filename is separated.
 		$this->expandedFileName = realpath(dirname($fileName));
-		if ($this->expandedFileName === false) throw new Exception("Directory of $fileName does not exist!");
+		if ($this->expandedFileName === false) {
+		    throw new Exception("Directory of $fileName does not exist!");
+		}
 		$this->expandedFileName .= DIRECTORY_SEPARATOR . basename($fileName);
 	}
 

lib/Payone/Config.php

Braces +13 added lines, -14 removed lines

@@ -104,14 +104,16 @@ 
                 $this->sessionStatusConfig = new Payone_SessionStatus_Config();
             }
             $this->config = $this->getDefaultConfigData();
-        }
-        else {
-            if(array_key_exists('api', $data))
-                $this->setApiConfig($data['api']);
-            if(array_key_exists('transaction_status',$data))
-                $this->setTransactionStatusConfig($data['transaction_status']);
-            if(array_key_exists('session_status',$data))
-                $this->setSessionStatusConfig($data['session_status']);
+        } else {
+            if(array_key_exists('api', $data)) {
+                            $this->setApiConfig($data['api']);
+            }
+            if(array_key_exists('transaction_status',$data)) {
+                            $this->setTransactionStatusConfig($data['transaction_status']);
+            }
+            if(array_key_exists('session_status',$data)) {
+                            $this->setSessionStatusConfig($data['session_status']);
+            }
             $this->config = $data;
         }
     }
@@ -170,8 +172,7 @@ 
             $object = $tree[$currentKey];
             $object->setValue($newKey,$value);
             return TRUE;
-        }
-        else {
+        } else {
             // Set value (can overwrite an existing value)
             $tree[$key] = $value;
             // Exit recursion, Success!
@@ -205,11 +206,9 @@ 
             /** @var $object Payone_Config_Abstract */
             $object = $tree[$currentKey];
             return $object->getValue($newKey);
-        }
-        elseif (is_array($tree) and array_key_exists($key, $tree)) {
+        } elseif (is_array($tree) and array_key_exists($key, $tree)) {
             return $tree[$key]; // Exit recursion, Success!
-        }
-        else {
+        } else {
             return NULL; // Exit recursion, unsuccessful
         }
     }

lib/Payone/Api/Mapper/Response/3dsCheck.php

Braces +4 added lines, -8 removed lines

@@ -45,17 +45,13 @@
 
         if ($this->isValid()) {
             $response = new Payone_Api_Response_3dsCheck_Valid($params);
-        }
-        elseif ($this->isEnrolled()) {
+        } elseif ($this->isEnrolled()) {
             $response = new Payone_Api_Response_3dsCheck_Enrolled($params);
-        }
-        elseif ($this->isInvalid()) {
+        } elseif ($this->isInvalid()) {
             $response = new Payone_Api_Response_3dsCheck_Invalid($params);
-        }
-        elseif ($this->isError()) {
+        } elseif ($this->isError()) {
             $response = new Payone_Api_Response_Error($params);
-        }
-        else {
+        } else {
             throw new Payone_Api_Exception_UnknownStatus();
         }
 

lib/Payone/Api/Mapper/Response/BankAccountCheck.php

Braces +4 added lines, -8 removed lines

@@ -46,17 +46,13 @@
 
         if ($this->isValid()) {
             $response = new Payone_Api_Response_BankAccountCheck_Valid($params);
-        }
-        elseif ($this->isInvalid()) {
+        } elseif ($this->isInvalid()) {
             $response = new Payone_Api_Response_BankAccountCheck_Invalid($params);
-        }
-        elseif ($this->isBlocked()) {
+        } elseif ($this->isBlocked()) {
             $response = new Payone_Api_Response_BankAccountCheck_Blocked($params);
-        }
-        elseif ($this->isError()) {
+        } elseif ($this->isError()) {
             $response = new Payone_Api_Response_Error($params);
-        }
-        else {
+        } else {
             throw new Payone_Api_Exception_UnknownStatus();
         }