fjbender / magento-1

lib/Payone/Builder.php

Spacing +2 added lines, -2 removed lines

@@ -389,7 +389,7 @@ 
         if (is_array($validatorConfig)) {
             $validator = array();
             foreach ($validatorConfig as $config) {
-                if ($config === 'default' or ! class_exists($config)) {
+                if ($config === 'default' or !class_exists($config)) {
                     return null;
                 } else {
                     $validator[] = new $config();
@@ -399,7 +399,7 @@ 
             return $validator;
         } else {
             // Load validator by config (if non-default):
-            if ($validatorConfig === 'default' or ! class_exists($validatorConfig)) {
+            if ($validatorConfig === 'default' or !class_exists($validatorConfig)) {
                 return null;
             } else {
                 $validator = new $validatorConfig();

lib/Payone/Settings/Data/ConfigFile/Shop/Global.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
     protected $parameter_invoice = array();
 
     /** @var Payone_Settings_Data_ConfigFile_Global_StatusMapping */
-    protected $status_mapping = null ;
+    protected $status_mapping = null;
 
     /** @var array */
     protected $payment_creditcard = array();

lib/Payone/Settings/Data/ConfigFile/Root.php

Spacing +1 added lines, -1 removed lines

@@ -68,6 +68,6 @@
 
     public function addShop($shop)
     {
-        return $this->shop[]=$shop;
+        return $this->shop[] = $shop;
     }
 }

lib/Payone/Settings/Data/ConfigFile/PaymentMethod/Abstract.php

Spacing +3 added lines, -3 removed lines

@@ -41,11 +41,11 @@ 
     protected $title = '';
 
     protected $mid = null;
-    protected $aid =null;
+    protected $aid = null;
     protected $portalid = null;
     protected $fee_config = array();
     protected $min_order_total = null;
-    protected $max_order_total =null;
+    protected $max_order_total = null;
     /** @var string */
     protected $types = null;
     /** @var string */
@@ -113,7 +113,7 @@ 
 
     public function addFeeConfig($value)
     {
-        return $this->fee_config[]=$value;
+        return $this->fee_config[] = $value;
     }
 
     public function setMaxOrderTotal($max_order_total)

lib/Payone/Settings/Data/ConfigFile/PaymentMethod/CashOnDelivery.php

Indentation +2 added lines, -2 removed lines

@@ -143,8 +143,8 @@
     }
 
     /**
-         * @return string
-         */
+     * @return string
+     */
         public function getKey()
         {
             return $this->key;

Spacing +5 added lines, -5 removed lines

@@ -56,7 +56,7 @@ 
     /**
      * @param string $active
      */
-    public function setActive( $active)
+    public function setActive($active)
     {
         $this->active = $active;
     }
@@ -72,7 +72,7 @@ 
     /**
      * @param string $authorization
      */
-    public function setAuthorization( $authorization)
+    public function setAuthorization($authorization)
     {
         $this->authorization = $authorization;
     }
@@ -88,7 +88,7 @@ 
     /**
      * @param string $countries
      */
-    public function setCountries( $countries)
+    public function setCountries($countries)
     {
         $this->countries = $countries;
     }
@@ -105,7 +105,7 @@ 
     /**
      * @param string $mode
      */
-    public function setMode( $mode)
+    public function setMode($mode)
     {
         $this->mode = $mode;
     }
@@ -121,7 +121,7 @@ 
     /**
      * @param string $newOrderStatus
      */
-    public function setNewOrderStatus( $newOrderStatus)
+    public function setNewOrderStatus($newOrderStatus)
     {
         $this->newOrderStatus = $newOrderStatus;
     }

lib/Payone/Settings/Data/ConfigFile/Misc/TransactionstatusForwarding.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
     /**
      * @param $value
      */
-    public function addTransactionstatusForwarding($value){
+    public function addTransactionstatusForwarding($value) {
         $this->transactionstatus_forwarding[] = $value;
     }
 

lib/Payone/Settings/Service/XmlGenerate.php

Spacing +11 added lines, -11 removed lines

@@ -173,9 +173,9 @@ 
         $this->addChild($globalXml, $globalConfig, 'aid');
         $this->addChild($globalXml, $globalConfig, 'portalid');
         $this->addChild($globalXml, $globalConfig, 'request_type');
-        $this->mapParameterInvoice($globalConfig,$globalXml);
+        $this->mapParameterInvoice($globalConfig, $globalXml);
         $this->addStatusMapping($globalConfig, $globalXml);
-        $this->mapPaymentCreditcard($globalConfig,$globalXml);
+        $this->mapPaymentCreditcard($globalConfig, $globalXml);
         return $shopXml;
     }
 
@@ -214,7 +214,7 @@ 
      */
     protected function mapProtect(Payone_Settings_Data_ConfigFile_Shop_Protect $protectConfig, DOMElement $shopXml)
     {
-        $protectXml = $this->appendElement($shopXml,$protectConfig->getKey());
+        $protectXml = $this->appendElement($shopXml, $protectConfig->getKey());
 
         $protectXml = $this->mapConsumerscore($protectConfig->getConsumerscore(), $protectXml);
         $protectXml = $this->mapAddresscheck($protectConfig->getAddresscheck(), $protectXml);
@@ -321,7 +321,7 @@ 
         $tasXml = $this->appendElement($miscXml, $tasForwarding->getKey());
 
         foreach ($tasForwarding->getTransactionstatusForwarding() as $keyTas => $config) {
-            $configNode = $this->appendElement($tasXml,'config');
+            $configNode = $this->appendElement($tasXml, 'config');
 
             foreach ($config as $key => $value) {
                 $configNode->setAttribute($key, $value);
@@ -336,10 +336,10 @@ 
     public function addStatusMapping(Payone_Settings_Data_ConfigFile_Shop_Global $globalConfig, DOMElement $globalXml)
     {
         $statusMapping = $globalConfig->getStatusMapping();
-        $tasXml = $this->appendElement($globalXml,$statusMapping->getKey());
+        $tasXml = $this->appendElement($globalXml, $statusMapping->getKey());
 
         foreach ($statusMapping->getStatusMapping() as $keyStatusMapping => $valueStatusMapping) {
-            $parent = $this->appendElement($tasXml,$keyStatusMapping);
+            $parent = $this->appendElement($tasXml, $keyStatusMapping);
 
             foreach ($valueStatusMapping as $key => $value) {
                 $mapNode = $this->appendElement($parent, 'map');
@@ -385,7 +385,7 @@ 
     {
         $feeConfig = $valueClearingType->getFeeConfig();
         if (!empty($feeConfig)) {
-            $feeConfigNode = $this->appendElement($cleatringTypeNode,'fee_config');
+            $feeConfigNode = $this->appendElement($cleatringTypeNode, 'fee_config');
 
             foreach ($feeConfig as $keyFeeConfig => $valueFeeConfig) {
                 if (array_key_exists('value', $valueFeeConfig) && array_key_exists('attribute', $valueFeeConfig)) {
@@ -411,7 +411,7 @@ 
         $data = $object->$getter();
         $child = $parent;
         if (is_array($data)) {
-            $parentNode = $this->appendElement($parent,$property);
+            $parentNode = $this->appendElement($parent, $property);
             foreach ($data as $key => $value) {
                 $child = $this->appendElement($parentNode, $key, $value, $withCdata);
             }
@@ -452,9 +452,9 @@ 
      * @param bool $asCdata
      * @return DOMElement
      */
-    protected function appendElement( $parent, $key, $value = null, $asCdata = false)
+    protected function appendElement($parent, $key, $value = null, $asCdata = false)
     {
-        if($asCdata === true)
+        if ($asCdata === true)
         {
             $cdata = $this->dom->createCDATASection($value);
             $child = $this->dom->createElement($key);
@@ -463,7 +463,7 @@ 
         else
         {
             $child = $this->dom->createElement($key);
-            if($value !== null)
+            if ($value !== null)
             {
                 $domValue = $this->dom->createTextNode($value);
                 $child->appendChild($domValue);

lib/Payone/Log4php/LoggerHierarchy.php

Indentation +164 added lines, -164 removed lines

@@ -49,192 +49,192 @@
  */
 class Payone_Log4php_LoggerHierarchy {
 	
-	/** Array holding all Logger instances. */
-	protected $loggers = array();
+    /** Array holding all Logger instances. */
+    protected $loggers = array();
 	
-	/** 
-	 * The root logger.
-	 * @var RootLogger 
-	 */
-	protected $root = null;
+    /** 
+     * The root logger.
+     * @var RootLogger 
+     */
+    protected $root = null;
 	
-	/** 
-	 * The logger renderer map.
-	 * @var Payone_Log4php_LoggerRendererMap
-	 */
-	protected $rendererMap;
+    /** 
+     * The logger renderer map.
+     * @var Payone_Log4php_LoggerRendererMap
+     */
+    protected $rendererMap;
 
-	/** 
-	 * Main level threshold. Events with lower level will not be logged by any 
-	 * logger, regardless of it's configuration.
-	 * @var Payone_Log4php_LoggerLevel
-	 */
-	protected $threshold;
+    /** 
+     * Main level threshold. Events with lower level will not be logged by any 
+     * logger, regardless of it's configuration.
+     * @var Payone_Log4php_LoggerLevel
+     */
+    protected $threshold;
 	
-	/**
-	 * Creates a new logger hierarchy.
-	 * @param Payone_Log4php_LoggerRoot $root The root logger.
-	 */
-	public function __construct(Payone_Log4php_LoggerRoot $root) {
-		$this->root = $root;
-		$this->setThreshold(Payone_Log4php_LoggerLevel::getLevelAll());
-		$this->rendererMap = new Payone_Log4php_LoggerRendererMap();
-	}
+    /**
+     * Creates a new logger hierarchy.
+     * @param Payone_Log4php_LoggerRoot $root The root logger.
+     */
+    public function __construct(Payone_Log4php_LoggerRoot $root) {
+        $this->root = $root;
+        $this->setThreshold(Payone_Log4php_LoggerLevel::getLevelAll());
+        $this->rendererMap = new Payone_Log4php_LoggerRendererMap();
+    }
 	 
-	/**
-	 * Clears all loggers.
-	 */
-	public function clear() {
-		$this->loggers = array();
-	}
+    /**
+     * Clears all loggers.
+     */
+    public function clear() {
+        $this->loggers = array();
+    }
 	
-	/**
-	 * Check if the named logger exists in the hierarchy.
-	 * @param string $name
-	 * @return boolean
-	 */
-	public function exists($name) {
-		return isset($this->loggers[$name]);
-	}
+    /**
+     * Check if the named logger exists in the hierarchy.
+     * @param string $name
+     * @return boolean
+     */
+    public function exists($name) {
+        return isset($this->loggers[$name]);
+    }
 
-	/**
-	 * Returns all the currently defined loggers in this hierarchy as an array.
-	 * @return array
-	 */	 
-	public function getCurrentLoggers() {
-		return array_values($this->loggers);
-	}
+    /**
+     * Returns all the currently defined loggers in this hierarchy as an array.
+     * @return array
+     */	 
+    public function getCurrentLoggers() {
+        return array_values($this->loggers);
+    }
 	
-	/**
-	 * Returns a named logger instance logger. If it doesn't exist, one is created.
-	 * 
-	 * @param string $name Logger name
-	 * @return Logger Logger instance.
-	 */
-	public function getLogger($name) {
-		if(!isset($this->loggers[$name])) {
-			$logger = new Payone_Log4php_Logger($name);
+    /**
+     * Returns a named logger instance logger. If it doesn't exist, one is created.
+     * 
+     * @param string $name Logger name
+     * @return Logger Logger instance.
+     */
+    public function getLogger($name) {
+        if(!isset($this->loggers[$name])) {
+            $logger = new Payone_Log4php_Logger($name);
 
-			$nodes = explode('.', $name);
-			$firstNode = array_shift($nodes);
+            $nodes = explode('.', $name);
+            $firstNode = array_shift($nodes);
 			
-			// if name is not a first node but another first node is their
-			if($firstNode != $name and isset($this->loggers[$firstNode])) {
-				$logger->setParent($this->loggers[$firstNode]);
-			} else {
-				// if there is no father, set root logger as father
-				$logger->setParent($this->root);
-			} 
+            // if name is not a first node but another first node is their
+            if($firstNode != $name and isset($this->loggers[$firstNode])) {
+                $logger->setParent($this->loggers[$firstNode]);
+            } else {
+                // if there is no father, set root logger as father
+                $logger->setParent($this->root);
+            } 
 		
-			// if there are more nodes than one
-			if(count($nodes) > 0) {
-				// find parent node
-				foreach($nodes as $node) {
-					$parentNode = "$firstNode.$node";
-					if(isset($this->loggers[$parentNode]) and $parentNode != $name) {
-						$logger->setParent($this->loggers[$parentNode]);
-					}
-					$firstNode .= ".$node";
-				}
-			}
+            // if there are more nodes than one
+            if(count($nodes) > 0) {
+                // find parent node
+                foreach($nodes as $node) {
+                    $parentNode = "$firstNode.$node";
+                    if(isset($this->loggers[$parentNode]) and $parentNode != $name) {
+                        $logger->setParent($this->loggers[$parentNode]);
+                    }
+                    $firstNode .= ".$node";
+                }
+            }
 			
-			$this->loggers[$name] = $logger;
-		}		
+            $this->loggers[$name] = $logger;
+        }		
 		
-		return $this->loggers[$name];
-	} 
+        return $this->loggers[$name];
+    } 
 	
-	/**
-	 * Returns the logger renderer map.
-	 * @return Payone_Log4php_LoggerRendererMap
-	 */
-	public function getRendererMap() {
-		return $this->rendererMap;
-	}
+    /**
+     * Returns the logger renderer map.
+     * @return Payone_Log4php_LoggerRendererMap
+     */
+    public function getRendererMap() {
+        return $this->rendererMap;
+    }
 	
-	/**
-	 * Returns the root logger.
-	 * @return Payone_Log4php_LoggerRoot
-	 */ 
-	public function getRootLogger() {
-		if(!isset($this->root) or $this->root == null) {
-			$this->root = new Payone_Log4php_LoggerRoot();
-		}
-		return $this->root;
-	}
+    /**
+     * Returns the root logger.
+     * @return Payone_Log4php_LoggerRoot
+     */ 
+    public function getRootLogger() {
+        if(!isset($this->root) or $this->root == null) {
+            $this->root = new Payone_Log4php_LoggerRoot();
+        }
+        return $this->root;
+    }
 	 
-	/**
-	 * Returns the main threshold level.
-	 * @return Payone_Log4php_LoggerLevel
-	 */
-	public function getThreshold() {
-		return $this->threshold;
-	} 
+    /**
+     * Returns the main threshold level.
+     * @return Payone_Log4php_LoggerLevel
+     */
+    public function getThreshold() {
+        return $this->threshold;
+    } 
 
-	/**
-	 * Returns true if the hierarchy is disabled for given log level and false
-	 * otherwise.
-	 * @return boolean
-	 */
-	public function isDisabled(Payone_Log4php_LoggerLevel $level) {
-		return ($this->threshold->toInt() > $level->toInt());
-	}
+    /**
+     * Returns true if the hierarchy is disabled for given log level and false
+     * otherwise.
+     * @return boolean
+     */
+    public function isDisabled(Payone_Log4php_LoggerLevel $level) {
+        return ($this->threshold->toInt() > $level->toInt());
+    }
 	
-	/**
-	 * Reset all values contained in this hierarchy instance to their
-	 * default. 
-	 *
-	 * This removes all appenders from all loggers, sets
-	 * the level of all non-root loggers to <i>null</i>,
-	 * sets their additivity flag to <i>true</i> and sets the level
-	 * of the root logger to {@link LOGGER_LEVEL_DEBUG}.
-	 * 
-	 * <p>Existing loggers are not removed. They are just reset.
-	 *
-	 * <p>This method should be used sparingly and with care as it will
-	 * block all logging until it is completed.</p>
-	 */
-	public function resetConfiguration() {
-		$root = $this->getRootLogger();
+    /**
+     * Reset all values contained in this hierarchy instance to their
+     * default. 
+     *
+     * This removes all appenders from all loggers, sets
+     * the level of all non-root loggers to <i>null</i>,
+     * sets their additivity flag to <i>true</i> and sets the level
+     * of the root logger to {@link LOGGER_LEVEL_DEBUG}.
+     * 
+     * <p>Existing loggers are not removed. They are just reset.
+     *
+     * <p>This method should be used sparingly and with care as it will
+     * block all logging until it is completed.</p>
+     */
+    public function resetConfiguration() {
+        $root = $this->getRootLogger();
 		
-		$root->setLevel(Payone_Log4php_LoggerLevel::getLevelDebug());
-		$this->setThreshold(Payone_Log4php_LoggerLevel::getLevelAll());
-		$this->shutDown();
+        $root->setLevel(Payone_Log4php_LoggerLevel::getLevelDebug());
+        $this->setThreshold(Payone_Log4php_LoggerLevel::getLevelAll());
+        $this->shutDown();
 		
-		foreach($this->loggers as $logger) {
-			$logger->setLevel(null);
-			$logger->setAdditivity(true);
-			$logger->removeAllAppenders();
-		}
+        foreach($this->loggers as $logger) {
+            $logger->setLevel(null);
+            $logger->setAdditivity(true);
+            $logger->removeAllAppenders();
+        }
 		
-		$this->rendererMap->clear();
-		Payone_Log4php_LoggerAppenderPool::clear();
-	}
+        $this->rendererMap->clear();
+        Payone_Log4php_LoggerAppenderPool::clear();
+    }
 	
-	/**
-	 * Sets the main threshold level.
-	 * @param Payone_Log4php_LoggerLevel $l
-	 */
-	public function setThreshold(Payone_Log4php_LoggerLevel $threshold) {
-		$this->threshold = $threshold;
-	}
+    /**
+     * Sets the main threshold level.
+     * @param Payone_Log4php_LoggerLevel $l
+     */
+    public function setThreshold(Payone_Log4php_LoggerLevel $threshold) {
+        $this->threshold = $threshold;
+    }
 	
-	/**
-	 * Shutting down a hierarchy will <i>safely</i> close and remove
-	 * all appenders in all loggers including the root logger.
-	 * 
-	 * The shutdown method is careful to close nested
-	 * appenders before closing regular appenders. This is allows
-	 * configurations where a regular appender is attached to a logger
-	 * and again to a nested appender.
-	 * 
-	 * @todo Check if the last paragraph is correct.
-	 */
-	public function shutdown() {
-		$this->root->removeAllAppenders();
+    /**
+     * Shutting down a hierarchy will <i>safely</i> close and remove
+     * all appenders in all loggers including the root logger.
+     * 
+     * The shutdown method is careful to close nested
+     * appenders before closing regular appenders. This is allows
+     * configurations where a regular appender is attached to a logger
+     * and again to a nested appender.
+     * 
+     * @todo Check if the last paragraph is correct.
+     */
+    public function shutdown() {
+        $this->root->removeAllAppenders();
 		
-		foreach($this->loggers as $logger) {
-			$logger->removeAllAppenders();
-		}
-	}
+        foreach($this->loggers as $logger) {
+            $logger->removeAllAppenders();
+        }
+    }
 } 

Spacing +8 added lines, -8 removed lines

@@ -112,14 +112,14 @@ 
 	 * @return Logger Logger instance.
 	 */
 	public function getLogger($name) {
-		if(!isset($this->loggers[$name])) {
+		if (!isset($this->loggers[$name])) {
 			$logger = new Payone_Log4php_Logger($name);
 
 			$nodes = explode('.', $name);
 			$firstNode = array_shift($nodes);
 			
 			// if name is not a first node but another first node is their
-			if($firstNode != $name and isset($this->loggers[$firstNode])) {
+			if ($firstNode != $name and isset($this->loggers[$firstNode])) {
 				$logger->setParent($this->loggers[$firstNode]);
 			} else {
 				// if there is no father, set root logger as father
@@ -127,11 +127,11 @@ 
 			} 
 		
 			// if there are more nodes than one
-			if(count($nodes) > 0) {
+			if (count($nodes) > 0) {
 				// find parent node
-				foreach($nodes as $node) {
+				foreach ($nodes as $node) {
 					$parentNode = "$firstNode.$node";
-					if(isset($this->loggers[$parentNode]) and $parentNode != $name) {
+					if (isset($this->loggers[$parentNode]) and $parentNode != $name) {
 						$logger->setParent($this->loggers[$parentNode]);
 					}
 					$firstNode .= ".$node";
@@ -157,7 +157,7 @@ 
 	 * @return Payone_Log4php_LoggerRoot
 	 */ 
 	public function getRootLogger() {
-		if(!isset($this->root) or $this->root == null) {
+		if (!isset($this->root) or $this->root == null) {
 			$this->root = new Payone_Log4php_LoggerRoot();
 		}
 		return $this->root;
@@ -201,7 +201,7 @@ 
 		$this->setThreshold(Payone_Log4php_LoggerLevel::getLevelAll());
 		$this->shutDown();
 		
-		foreach($this->loggers as $logger) {
+		foreach ($this->loggers as $logger) {
 			$logger->setLevel(null);
 			$logger->setAdditivity(true);
 			$logger->removeAllAppenders();
@@ -233,7 +233,7 @@ 
 	public function shutdown() {
 		$this->root->removeAllAppenders();
 		
-		foreach($this->loggers as $logger) {
+		foreach ($this->loggers as $logger) {
 			$logger->removeAllAppenders();
 		}
 	}

lib/Payone/Log4php/LoggerAppenderPhp.php

Indentation +12 added lines, -12 removed lines

@@ -41,16 +41,16 @@
  */ 
 class Payone_Log4php_LoggerAppenderPhp extends Payone_Log4php_LoggerAppender {
 
-	public function append(Payone_Log4php_LoggerLoggingEvent $event) {
-		if($this->layout !== null) {
-			$level = $event->getLevel();
-			if($level->isGreaterOrEqual(Payone_Log4php_LoggerLevel::getLevelError())) {
-				trigger_error($this->layout->format($event), E_USER_ERROR);
-			} else if ($level->isGreaterOrEqual(Payone_Log4php_LoggerLevel::getLevelWarn())) {
-				trigger_error($this->layout->format($event), E_USER_WARNING);
-			} else {
-				trigger_error($this->layout->format($event), E_USER_NOTICE);
-			}
-		}
-	}
+    public function append(Payone_Log4php_LoggerLoggingEvent $event) {
+        if($this->layout !== null) {
+            $level = $event->getLevel();
+            if($level->isGreaterOrEqual(Payone_Log4php_LoggerLevel::getLevelError())) {
+                trigger_error($this->layout->format($event), E_USER_ERROR);
+            } else if ($level->isGreaterOrEqual(Payone_Log4php_LoggerLevel::getLevelWarn())) {
+                trigger_error($this->layout->format($event), E_USER_WARNING);
+            } else {
+                trigger_error($this->layout->format($event), E_USER_NOTICE);
+            }
+        }
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -42,9 +42,9 @@
 class Payone_Log4php_LoggerAppenderPhp extends Payone_Log4php_LoggerAppender {
 
 	public function append(Payone_Log4php_LoggerLoggingEvent $event) {
-		if($this->layout !== null) {
+		if ($this->layout !== null) {
 			$level = $event->getLevel();
-			if($level->isGreaterOrEqual(Payone_Log4php_LoggerLevel::getLevelError())) {
+			if ($level->isGreaterOrEqual(Payone_Log4php_LoggerLevel::getLevelError())) {
 				trigger_error($this->layout->format($event), E_USER_ERROR);
 			} else if ($level->isGreaterOrEqual(Payone_Log4php_LoggerLevel::getLevelWarn())) {
 				trigger_error($this->layout->format($event), E_USER_WARNING);