fjbender / magento-1

lib/Payone/Log4php/LoggerNDC.php

Doc Comments +1 added lines, -1 removed lines

@@ -112,7 +112,7 @@
 
 	/**
 	 * Never use this method directly, use the {@link LoggerLoggingEvent::getNDC()} method instead.
-	 * @return array
+	 * @return string
 	 */
 	public static function get() {
 		return implode(' ', self::$stack);

lib/Payone/Log4php/LoggerPatternConverter.php

Doc Comments +1 added lines

@@ -73,6 +73,7 @@
 	 * converters must implement this method.
 	 *
 	 * @param Payone_Log4php_LoggerLoggingEvent $event
+	 * @return string
 	 */
 	abstract public function convert(Payone_Log4php_LoggerLoggingEvent $event);
 

lib/Payone/Log4php/LoggerPatternConverterLogger.php

Doc Comments +2 added lines

@@ -64,6 +64,8 @@
 	/** 
 	 * Attempts to shorten the given name to the desired length by trimming 
 	 * name fragments. See docs for examples.
+	 * @param string $name
+	 * @param integer $length
 	 */
 	private function shorten($name, $length) {
 	

lib/Payone/Log4php/LoggerPatternParser.php

Doc Comments +1 added lines, -1 removed lines

@@ -199,7 +199,7 @@
 	 * Parses the formatting modifiers and produces the corresponding 
 	 * LoggerFormattingInfo object.
 	 * 
-	 * @param string $modifier
+	 * @param string $modifiers
 	 * @return Payone_Log4php_LoggerFormattingInfo
 	 * @throws LoggerException
 	 */

lib/Payone/Log4php/LoggerReflectionUtils.php

Doc Comments +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
 	/**
 	 * Creates an instances from the given class name.
 	 *
-	 * @param string $classname
+	 * @param string $class
 	 * @return an object from the class with the given classname
 	 */
 	public static function createObject($class) {

lib/Payone/Log4php/LoggerRendererMap.php

Doc Comments +1 added lines, -2 removed lines

@@ -58,7 +58,6 @@ 
 	 * Add a renderer to a hierarchy passed as parameter.
 	 * Note that hierarchy must implement getRendererMap() and setRenderer() methods.
 	 *
-	 * @param Payone_Log4php_LoggerHierarchy $repository a logger repository.
 	 * @param string $renderedClassName
 	 * @param string $renderingClassName
 	 */
@@ -107,7 +106,7 @@ 
 	 * class of the object parameter.
 	 * 
 	 * @param mixed $o
-	 * @return string
+	 * @return Payone_Log4php_LoggerRendererObject
 	 */
 	public function getByObject($o) {
 		return ($o == null) ? null : $this->getByClassName(get_class($o));

lib/Payone/Log4php/LoggerRoot.php

Doc Comments +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
 	/**
 	 * Always returns false.
 	 * Because LoggerRoot has no parents, it returns false.
-	 * @param Logger $parent
+	 * @param Payone_Log4php_Logger $parent
 	 * @return boolean
 	 */
 	public function setParent(Payone_Log4php_Logger $parent) {

lib/Payone/Settings/Factory.php

Doc Comments +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
     }
 
     /**
-     * @param $key
+     * @param string $key
      * @return Payone_Settings_Service_XmlGenerate
      *
      * @throws Exception

lib/Payone/Settings/Service/XmlGenerate.php

Doc Comments +8 added lines, -4 removed lines

@@ -49,7 +49,7 @@ 
      * @api
      *
      * @param Payone_Settings_Data_ConfigFile_Root $config
-     * @return mixed @see SimpleXMLElement::asXml()
+     * @return string @see SimpleXMLElement::asXml()
      */
     public function generate(Payone_Settings_Data_ConfigFile_Root $config)
     {
@@ -74,7 +74,7 @@ 
      * @api
      *
      * @param Payone_Settings_Data_ConfigFile_Root $config
-     * @return mixed @see SimpleXMLElement::asXml()
+     * @return string|false @see SimpleXMLElement::asXml()
      */
     public function execute(Payone_Settings_Data_ConfigFile_Root $config)
     {
@@ -125,7 +125,7 @@ 
     /**
      * @param Payone_Settings_Data_ConfigFile_Shop $shopConfig
      * @param DOMElement $configXml
-     * @return string
+     * @return DOMElement
      */
     protected function mapShop(Payone_Settings_Data_ConfigFile_Shop $shopConfig, DOMElement $configXml)
     {
@@ -366,6 +366,10 @@ 
         $this->addGlobal($cleatringTypeNode, $valueClearingType);
     }
 
+    /**
+     * @param DOMElement $parent
+     * @param Payone_Settings_Data_ConfigFile_PaymentMethod_Abstract $type
+     */
     public function addGlobal($parent, $type)
     {
 
@@ -401,7 +405,7 @@ 
     /**
      * @param DOMElement $parent
      * @param $object
-     * @param $property
+     * @param string $property
      * @param bool $withCdata
      * @return DOMElement
      */