fjbender /
magento-1
| Total Complexity | 6 |
| Complexity/F | 6 |
| Lines of Code | 21 |
| Function Count | 1 |
| Duplicated Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
| 1 | /** |
||
| 23 | function payoneKlarnaCustomerDobInput(output_element) |
||
| 24 | { |
||
| 25 | var daySelect = $('payone_klarna_additional_fields_customer_dob_day'); |
||
| 26 | var monthSelect = $('payone_klarna_additional_fields_customer_dob_month'); |
||
| 27 | var yearSelect = $('payone_klarna_additional_fields_customer_dob_year'); |
||
| 28 | if(output_element == 'payone_financing_klarna_additional_fields_customer_dob_full') { |
||
| 29 | var daySelect = $('payone_financing_klarna_additional_fields_customer_dob_day'); |
||
|
|
|||
| 30 | var monthSelect = $('payone_financing_klarna_additional_fields_customer_dob_month'); |
||
| 31 | var yearSelect = $('payone_financing_klarna_additional_fields_customer_dob_year'); |
||
| 32 | } |
||
| 33 | |||
| 34 | var hiddenDobFull = $(output_element); |
||
| 35 | |||
| 36 | if (daySelect == undefined || monthSelect == undefined || yearSelect == undefined |
||
| 37 | || hiddenDobFull == undefined) { |
||
| 38 | return; |
||
| 39 | } |
||
| 40 | |||
| 41 | hiddenDobFull.value = yearSelect.value + "-" + monthSelect.value + "-" + daySelect.value |
||
| 42 | + " 00:00:00"; |
||
| 43 | } |
Loading history...
This check looks for variables that are declared in multiple lines. There may be several reasons for this.
In the simplest case the variable name was reused by mistake. This may lead to very hard to locate bugs.
If you want to reuse a variable for another purpose, consider declaring it at or near the top of your function and just assigning to it subsequently so it is always declared.