Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 33 | View Code Duplication | class Payone_Api_Mapper_Response_GetInvoice |
|
|
|
|||
| 34 | extends Payone_Api_Mapper_Response_Abstract |
||
| 35 | implements Payone_Api_Mapper_Response_Interface |
||
| 36 | { |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @param array $params |
||
| 40 | * |
||
| 41 | * @return Payone_Api_Response_Capture_Approved|Payone_Api_Response_Error |
||
| 42 | * @throws Payone_Api_Exception_UnknownStatus |
||
| 43 | */ |
||
| 44 | public function map(array $params) |
||
| 64 | } |
||
| 65 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.