Issues (2560)

app/Schema/Migration37.php (4 issues)

1
<?php
2
3
/**
4
 * webtrees: online genealogy
5
 * Copyright (C) 2025 webtrees development team
6
 * This program is free software: you can redistribute it and/or modify
7
 * it under the terms of the GNU General Public License as published by
8
 * the Free Software Foundation, either version 3 of the License, or
9
 * (at your option) any later version.
10
 * This program is distributed in the hope that it will be useful,
11
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13
 * GNU General Public License for more details.
14
 * You should have received a copy of the GNU General Public License
15
 * along with this program. If not, see <https://www.gnu.org/licenses/>.
16
 */
17
18
declare(strict_types=1);
19
20
namespace Fisharebest\Webtrees\Schema;
21
22
use Fisharebest\Webtrees\DB;
0 ignored issues
show
The type Fisharebest\Webtrees\DB was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
23
use Illuminate\Database\Query\Builder;
24
use Illuminate\Database\Query\Expression;
25
use Illuminate\Database\Schema\Blueprint;
26
27
/**
28
 * Upgrade the database schema from version 37 to version 38.
29
 */
30
class Migration37 implements MigrationInterface
31
{
32
    public function upgrade(): void
33
    {
34
        // These tables were created by webtrees 1.x, and may not exist if we first installed webtrees 2.x
35
        DB::schema()->dropIfExists('site_access_rule');
36
        DB::schema()->dropIfExists('next_id');
37
38
        // Split the media table into media/media_file so that we can store multiple media
39
        // files in each media object.
40
        if (!DB::schema()->hasTable('media_file')) {
41
            DB::schema()->create('media_file', static function (Blueprint $table): void {
42
                $table->integer('id', true);
43
                $table->string('m_id', 20);
44
                $table->integer('m_file');
45
                $table->string('multimedia_file_refn', 248); // GEDCOM only allows 30 characters
46
                $table->string('multimedia_format', 4);
47
                $table->string('source_media_type', 15);
48
                $table->string('descriptive_title', 248);
49
50
                $table->index(['m_id', 'm_file']);
51
                $table->index(['m_file', 'm_id']);
52
                $table->index(['m_file', 'multimedia_file_refn']);
53
                $table->index(['m_file', 'multimedia_format']);
54
                $table->index(['m_file', 'source_media_type']);
55
                $table->index(['m_file', 'descriptive_title']);
56
            });
57
        }
58
59
        if (DB::table('media_file')->count() === 0 && DB::schema()->hasColumn('media', 'm_filename')) {
60
            (new Builder(DB::connection()))->from('media_file')->insertUsing([
0 ignored issues
show
'media_file' of type string is incompatible with the type Closure|Illuminate\Datab...\Database\Query\Builder expected by parameter $table of Illuminate\Database\Query\Builder::from(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

60
            (new Builder(DB::connection()))->from(/** @scrutinizer ignore-type */ 'media_file')->insertUsing([
Loading history...
61
                'm_id',
62
                'm_file',
63
                'multimedia_file_refn',
64
                'multimedia_format',
65
                'source_media_type',
66
                'descriptive_title',
67
            ], function (Builder $query): void {
68
                // SQLite also supports SUBSTRING() from 3.34.0 (2020-12-01)
69
                $substring_function = DB::driverName() === DB::SQLITE ? 'SUBSTR' : 'SUBSTRING';
70
71
                $query->select([
72
                    'm_id',
73
                    'm_file',
74
                    new Expression($substring_function . '(m_filename, 1, 248)'),
0 ignored issues
show
$substring_function . '(m_filename, 1, 248)' of type string is incompatible with the type Illuminate\Database\Query\TValue expected by parameter $value of Illuminate\Database\Quer...pression::__construct(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

74
                    new Expression(/** @scrutinizer ignore-type */ $substring_function . '(m_filename, 1, 248)'),
Loading history...
75
                    new Expression($substring_function . '(m_ext, 1, 4)'),
76
                    new Expression($substring_function . '(m_type, 1, 15)'),
77
                    new Expression($substring_function . '(m_titl, 1, 248)'),
78
                ])->from('media');
0 ignored issues
show
'media' of type string is incompatible with the type Closure|Illuminate\Datab...\Database\Query\Builder expected by parameter $table of Illuminate\Database\Query\Builder::from(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

78
                ])->from(/** @scrutinizer ignore-type */ 'media');
Loading history...
79
            });
80
81
            // The Laravel database library for SQLite can only drop one column at a time.
82
            DB::schema()->table('media', static function (Blueprint $table): void {
83
                $table->dropColumn('m_filename');
84
            });
85
            DB::schema()->table('media', static function (Blueprint $table): void {
86
                $table->dropColumn('m_ext');
87
            });
88
            DB::schema()->table('media', static function (Blueprint $table): void {
89
                $table->dropColumn('m_type');
90
            });
91
            DB::schema()->table('media', static function (Blueprint $table): void {
92
                $table->dropColumn('m_titl');
93
            });
94
        }
95
    }
96
}
97